All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH 5/6] btrfs-progs: inspect: increase logical-resolve default buffer size to 64K
Date: Tue, 26 Nov 2019 22:55:08 -0500	[thread overview]
Message-ID: <20191127035509.15011-6-ce3g8jdj@umail.furryterror.org> (raw)
In-Reply-To: <20191127035509.15011-1-ce3g8jdj@umail.furryterror.org>

Filesystems with nontrivial snapshots or dedupe will easily overflow
a 4K buffer.  Bump the size up to the largest size supported by the
V1 ioctl.

Signed-off-by: Zygo Blaxell <ce3g8jdj@umail.furryterror.org>
---
 cmds/inspect.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/cmds/inspect.c b/cmds/inspect.c
index 81eb8125..c3c41905 100644
--- a/cmds/inspect.c
+++ b/cmds/inspect.c
@@ -151,7 +151,7 @@ static int cmd_inspect_logical_resolve(const struct cmd_struct *cmd,
 	int bytes_left;
 	struct btrfs_ioctl_logical_ino_args loi;
 	struct btrfs_data_container *inodes;
-	u64 size = 4096;
+	u64 size = SZ_64K;
 	char full_path[PATH_MAX];
 	char *path_ptr;
 	DIR *dirstream = NULL;
-- 
2.20.1


  parent reply	other threads:[~2019-11-27  4:45 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27  3:55 [PATCH 0/6] btrfs-progs: add support for LOGICAL_INO_V2 features in logical-resolve Zygo Blaxell
2019-11-27  3:55 ` [PATCH 1/6] btrfs-progs: ioctl-test: add LOGICAL_INO_V2 Zygo Blaxell
2019-11-27  3:55 ` [PATCH 2/6] btrfs-progs: libbtrfsutil: " Zygo Blaxell
2019-11-27  3:55 ` [PATCH 3/6] btrfs-progs: add LOGICAL_INO_V2 to ioctl.h Zygo Blaxell
2019-11-27  3:55 ` [PATCH 4/6] btrfs-progs: inspect: add support for LOGICAL_INO_V2 ioctl Zygo Blaxell
2019-11-27  3:55 ` Zygo Blaxell [this message]
2019-11-27  3:55 ` [PATCH 6/6] btrfs-progs: inspect-internal: document new logical-resolve options and kernel requirements Zygo Blaxell
2019-12-02 11:02 ` [PATCH 0/6] btrfs-progs: add support for LOGICAL_INO_V2 features in logical-resolve Anand Jain
2019-12-02 18:42   ` Zygo Blaxell
2019-12-03  1:08     ` Anand Jain
2020-01-02 19:00 ` David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127035509.15011-6-ce3g8jdj@umail.furryterror.org \
    --to=ce3g8jdj@umail.furryterror.org \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.