From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36A5DC432C0 for ; Wed, 27 Nov 2019 21:04:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 050C321739 for ; Wed, 27 Nov 2019 21:04:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888669; bh=soeUHr+11ttwbqIpHKGJFhQFwzuNjuqD2hkS2VnUn/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dUBTeK74G1s69Mi4j0KDlPF/apPnwr0AJxydBxXC8WfR1rdgpLEIC6GszlzR4x1DS wUGBfwWwIaEs552bfAXh8Ikeer6Ho62RvXLNA1yXaQW4I9kcQnMyVX8IKOEIyOyUIA 0MeUdKI7K8DhbOoJBGAIay5OyIHvuwOOd6aianO8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732149AbfK0VE1 (ORCPT ); Wed, 27 Nov 2019 16:04:27 -0500 Received: from mail.kernel.org ([198.145.29.99]:57884 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732141AbfK0VEX (ORCPT ); Wed, 27 Nov 2019 16:04:23 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 83DBE20637; Wed, 27 Nov 2019 21:04:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1574888663; bh=soeUHr+11ttwbqIpHKGJFhQFwzuNjuqD2hkS2VnUn/E=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mZL3F/QaTKNCkWhL3uxZSWnkyrkDb8br2h+H+AIsET97mxx4DErLS518wD9Y+XNl8 5ro7e3ARKX6ElGqSIX6MFJwze7FK+5cVT+MXqO/ZfQgKMJXH79y3wCq05acv5HDHrX KJcYgkur43ez4XJv4EsGk2KrycQy1jSmS8TCBVGQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Ali MJ Al-Nasrawy , Kalle Valo , Sasha Levin Subject: [PATCH 4.19 220/306] brcmsmac: never log "tid x is not aggable" by default Date: Wed, 27 Nov 2019 21:31:10 +0100 Message-Id: <20191127203131.122529619@linuxfoundation.org> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20191127203114.766709977@linuxfoundation.org> References: <20191127203114.766709977@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Ali MJ Al-Nasrawy [ Upstream commit 96fca788e5788b7ea3b0050eb35a343637e0a465 ] This message greatly spams the log under heavy Tx of frames with BK access class which is especially true when operating as AP. It is also not informative as the "agg'ablity" of TIDs are set once and never change. Fix this by logging only in debug mode. Signed-off-by: Ali MJ Al-Nasrawy Signed-off-by: Kalle Valo Signed-off-by: Sasha Levin --- .../net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c index 81ff558046a8f..6188275b17e5a 100644 --- a/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmsmac/mac80211_if.c @@ -846,8 +846,8 @@ brcms_ops_ampdu_action(struct ieee80211_hw *hw, status = brcms_c_aggregatable(wl->wlc, tid); spin_unlock_bh(&wl->lock); if (!status) { - brcms_err(wl->wlc->hw->d11core, - "START: tid %d is not agg\'able\n", tid); + brcms_dbg_ht(wl->wlc->hw->d11core, + "START: tid %d is not agg\'able\n", tid); return -EINVAL; } ieee80211_start_tx_ba_cb_irqsafe(vif, sta->addr, tid); -- 2.20.1