From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MIME_BASE64_TEXT,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 97527C432C3 for ; Thu, 28 Nov 2019 02:42:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6F3B42166E for ; Thu, 28 Nov 2019 02:42:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iGsRTk0h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728452AbfK1Cmt (ORCPT ); Wed, 27 Nov 2019 21:42:49 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:50447 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727861AbfK1Cms (ORCPT ); Wed, 27 Nov 2019 21:42:48 -0500 X-UUID: 76abfeb4e35846eaac3301e9b8d6294c-20191128 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=0vCTXwJv2GLquxlzgk2gQwFIoM5oJce1MlX2/bKkJNM=; b=iGsRTk0hlXIKkYRJHKjnT3BEismMYbiqiECs+a4wrWvhd6JsMftn4hdzeZirt/aTDnnffNgkza/cWiNLGPeyy7rxcsXosCYW0tMwn7q6cNJ17BGUs/86giuAEB8LfTJq/mjFXbomI9+II2zeubL7/eaQpGXjqkW7GsaMAQU9/CY=; X-UUID: 76abfeb4e35846eaac3301e9b8d6294c-20191128 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 189081807; Thu, 28 Nov 2019 10:42:44 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Nov 2019 10:42:13 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 28 Nov 2019 10:42:46 +0800 From: Bibby Hsieh To: David Airlie , Matthias Brugger , Daniel Vetter , , CC: Philipp Zabel , YT Shen , Thierry Reding , CK Hu , , , , , , Bibby Hsieh Subject: [PATCH v1 1/6] drm/mediatek: put "event" in critical section Date: Thu, 28 Nov 2019 10:42:33 +0800 Message-ID: <20191128024238.9399-2-bibby.hsieh@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20191128024238.9399-1-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-TM-SNTS-SMTP: C415EC28D10D4D98CA7C3A32C93B685D07027E2639E1945941113FD2332F427D2000:8 X-MTK: N Content-Transfer-Encoding: base64 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org VGhlIHN0YXRlLT5iYXNlLmV2ZW50IHZhcmlhYmxlIHdvdWxkIGJlIGFjY2VzcyBieSB0aHJlYWQg Y29udGV4dA0KaW4gbXRrX2RybV9jcnRjX2F0b21pY19iZWdpbigpIG9yIGJ5IGludGVycnVwdCBj b250ZXh0IGluDQptdGtfZHJtX2NydGNfZmluaXNoX3BhZ2VfZmxpcCgpLCBzbyBlYWNoIHBhcnQg c2hvdWxkIGJlIGEgY3JpdGljYWwNCnNlY3Rpb24uIEZpeCBpdC4NCg0KRml4ZXM6IDExOWY1MTcz NjI4YSAoImRybS9tZWRpYXRlazogQWRkIERSTSBEcml2ZXIgZm9yIE1lZGlhdGVrIFNvQyBNVDgx NzMuIikNCg0KU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVr LmNvbT4NCi0tLQ0KIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyB8IDMg KysrDQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fY3J0Yy5jDQppbmRleCAyOWQwNTgyZTkwZTkuLjcxZjQwODlhODExNyAx MDA2NDQNCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQpAQCAtNDgzLDEyICs0 ODMsMTUgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2F0b21pY19iZWdpbihzdHJ1Y3QgZHJt X2NydGMgKmNydGMsDQogCWlmIChtdGtfY3J0Yy0+ZXZlbnQgJiYgc3RhdGUtPmJhc2UuZXZlbnQp DQogCQlEUk1fRVJST1IoIm5ldyBldmVudCB3aGlsZSB0aGVyZSBpcyBzdGlsbCBhIHBlbmRpbmcg ZXZlbnRcbiIpOw0KIA0KKwlzcGluX2xvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOw0K IAlpZiAoc3RhdGUtPmJhc2UuZXZlbnQpIHsNCiAJCXN0YXRlLT5iYXNlLmV2ZW50LT5waXBlID0g ZHJtX2NydGNfaW5kZXgoY3J0Yyk7DQogCQlXQVJOX09OKGRybV9jcnRjX3ZibGFua19nZXQoY3J0 YykgIT0gMCk7DQorCQlXQVJOX09OKG10a19jcnRjLT5ldmVudCk7DQogCQltdGtfY3J0Yy0+ZXZl bnQgPSBzdGF0ZS0+YmFzZS5ldmVudDsNCiAJCXN0YXRlLT5iYXNlLmV2ZW50ID0gTlVMTDsNCiAJ fQ0KKwlzcGluX3VubG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7DQogfQ0KIA0KIHN0 YXRpYyB2b2lkIG10a19kcm1fY3J0Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRjICpjcnRj LA0KLS0gDQoyLjE4LjANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5F1FFC432C3 for ; Thu, 28 Nov 2019 02:45:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2D0AA20637 for ; Thu, 28 Nov 2019 02:45:14 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AZfdOltX"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iGsRTk0h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D0AA20637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4H8ae9EwN1ZY8iIWRBz/ucaXNa37CCuW3R5P9pWvSBs=; b=AZfdOltXoqY5P3 HOPYhz0zrC5YujPVKCeNI0nSEl6AAWecG0yAH36TRPMU1/YEszjW6ThPfKVPcjA2+XfrufefYQWRv da1pN1gzJoaiCLSr8CRKXvsIhi9I8jPKLCfFyRRc5yAoxxQuVGTnk9//k7GfCMCwGzpNsYa53jxg9 FUM9dH+GbNgnHUi5i1KVdxS//sJ2p8hTZYxumcZey3E+0+NEAnjVgFkwF0cM3k7XiiMafKE86bcBT +YnGdBm733qMKz3X1br7te/RA0PQOI6s2Agr5Io1pAuApf0NZFSnD90ud2PLO2rN7hLIW+jFJ3M/o 9z5tNR5bRnTmxerCG6Kw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia9nt-0001dM-Le; Thu, 28 Nov 2019 02:45:13 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia9nh-0001TK-OZ; Thu, 28 Nov 2019 02:45:03 +0000 X-UUID: d40fc0f01d1e4c99aecb1a8bb686bba4-20191127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=0vCTXwJv2GLquxlzgk2gQwFIoM5oJce1MlX2/bKkJNM=; b=iGsRTk0hlXIKkYRJHKjnT3BEismMYbiqiECs+a4wrWvhd6JsMftn4hdzeZirt/aTDnnffNgkza/cWiNLGPeyy7rxcsXosCYW0tMwn7q6cNJ17BGUs/86giuAEB8LfTJq/mjFXbomI9+II2zeubL7/eaQpGXjqkW7GsaMAQU9/CY=; X-UUID: d40fc0f01d1e4c99aecb1a8bb686bba4-20191127 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1456694699; Wed, 27 Nov 2019 18:45:00 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 27 Nov 2019 18:43:15 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Nov 2019 10:42:13 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 28 Nov 2019 10:42:46 +0800 From: Bibby Hsieh To: David Airlie , Matthias Brugger , Daniel Vetter , , Subject: [PATCH v1 1/6] drm/mediatek: put "event" in critical section Date: Thu, 28 Nov 2019 10:42:33 +0800 Message-ID: <20191128024238.9399-2-bibby.hsieh@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20191128024238.9399-1-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> MIME-Version: 1.0 X-TM-SNTS-SMTP: C415EC28D10D4D98CA7C3A32C93B685D07027E2639E1945941113FD2332F427D2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191127_184501_808710_A82B8B0B X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Bibby Hsieh , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, tfiga@chromium.org, CK Hu , Thierry Reding , Philipp Zabel , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The state->base.event variable would be access by thread context in mtk_drm_crtc_atomic_begin() or by interrupt context in mtk_drm_crtc_finish_page_flip(), so each part should be a critical section. Fix it. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 29d0582e90e9..71f4089a8117 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -483,12 +483,15 @@ static void mtk_drm_crtc_atomic_begin(struct drm_crtc *crtc, if (mtk_crtc->event && state->base.event) DRM_ERROR("new event while there is still a pending event\n"); + spin_lock_irq(&crtc->dev->event_lock); if (state->base.event) { state->base.event->pipe = drm_crtc_index(crtc); WARN_ON(drm_crtc_vblank_get(crtc) != 0); + WARN_ON(mtk_crtc->event); mtk_crtc->event = state->base.event; state->base.event = NULL; } + spin_unlock_irq(&crtc->dev->event_lock); } static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc, -- 2.18.0 _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33766C432C0 for ; Thu, 28 Nov 2019 02:45:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 01AC220637 for ; Thu, 28 Nov 2019 02:45:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uGdEkOMs"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mediatek.com header.i=@mediatek.com header.b="iGsRTk0h" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 01AC220637 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NVcxU+cKHz4xYkVOTD7D3mje7zJGHUX8lH0OLBQ1aGs=; b=uGdEkOMs+uAap5 lo6lVzKFsozwZM7R72VUuGIsaw1MWpqK1+/UiHdRIGh7RKNVfrBkX+Z1OuaT2TMHIRTdOoz7PGsFc EeC+cP66KifwO0aXuAdW3HwjaGAcRMcbEFU4xGuUEO8tcAaoQD7/k4KYLQmNYEtDY8cSaOEkdmWLW /HjQ5OT2Rge6GUhYJ6Ov27Pbldh0aQzERorC8H+rayxL9gobiBtTdDUzym0b2+siG9IYqMPoCHzHy 8SKD8a8WVDZ4wZlxjyJnJs7AHHBseIKGoF7AdkIj6UhKb/mqdO/5pSvUm990sW8iLck/Plz7efL/K P70ZP9V1Fe1My3ukP0pQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia9nl-0001Uv-B1; Thu, 28 Nov 2019 02:45:05 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ia9nh-0001TK-OZ; Thu, 28 Nov 2019 02:45:03 +0000 X-UUID: d40fc0f01d1e4c99aecb1a8bb686bba4-20191127 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=0vCTXwJv2GLquxlzgk2gQwFIoM5oJce1MlX2/bKkJNM=; b=iGsRTk0hlXIKkYRJHKjnT3BEismMYbiqiECs+a4wrWvhd6JsMftn4hdzeZirt/aTDnnffNgkza/cWiNLGPeyy7rxcsXosCYW0tMwn7q6cNJ17BGUs/86giuAEB8LfTJq/mjFXbomI9+II2zeubL7/eaQpGXjqkW7GsaMAQU9/CY=; X-UUID: d40fc0f01d1e4c99aecb1a8bb686bba4-20191127 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLS) with ESMTP id 1456694699; Wed, 27 Nov 2019 18:45:00 -0800 Received: from mtkmbs08n2.mediatek.inc (172.21.101.56) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 27 Nov 2019 18:43:15 -0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Nov 2019 10:42:13 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 28 Nov 2019 10:42:46 +0800 From: Bibby Hsieh To: David Airlie , Matthias Brugger , Daniel Vetter , , Subject: [PATCH v1 1/6] drm/mediatek: put "event" in critical section Date: Thu, 28 Nov 2019 10:42:33 +0800 Message-ID: <20191128024238.9399-2-bibby.hsieh@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20191128024238.9399-1-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> MIME-Version: 1.0 X-TM-SNTS-SMTP: C415EC28D10D4D98CA7C3A32C93B685D07027E2639E1945941113FD2332F427D2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191127_184501_808710_A82B8B0B X-CRM114-Status: UNSURE ( 8.85 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, Bibby Hsieh , srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, tfiga@chromium.org, CK Hu , Thierry Reding , Philipp Zabel , YT Shen , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org The state->base.event variable would be access by thread context in mtk_drm_crtc_atomic_begin() or by interrupt context in mtk_drm_crtc_finish_page_flip(), so each part should be a critical section. Fix it. Fixes: 119f5173628a ("drm/mediatek: Add DRM Driver for Mediatek SoC MT8173.") Signed-off-by: Bibby Hsieh --- drivers/gpu/drm/mediatek/mtk_drm_crtc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c index 29d0582e90e9..71f4089a8117 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_crtc.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_crtc.c @@ -483,12 +483,15 @@ static void mtk_drm_crtc_atomic_begin(struct drm_crtc *crtc, if (mtk_crtc->event && state->base.event) DRM_ERROR("new event while there is still a pending event\n"); + spin_lock_irq(&crtc->dev->event_lock); if (state->base.event) { state->base.event->pipe = drm_crtc_index(crtc); WARN_ON(drm_crtc_vblank_get(crtc) != 0); + WARN_ON(mtk_crtc->event); mtk_crtc->event = state->base.event; state->base.event = NULL; } + spin_unlock_irq(&crtc->dev->event_lock); } static void mtk_drm_crtc_atomic_flush(struct drm_crtc *crtc, -- 2.18.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bibby Hsieh Subject: [PATCH v1 1/6] drm/mediatek: put "event" in critical section Date: Thu, 28 Nov 2019 10:42:33 +0800 Message-ID: <20191128024238.9399-2-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191128024238.9399-1-bibby.hsieh@mediatek.com> Sender: linux-kernel-owner@vger.kernel.org To: David Airlie , Matthias Brugger , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org Cc: Philipp Zabel , YT Shen , Thierry Reding , CK Hu , linux-arm-kernel@lists.infradead.org, tfiga@chromium.org, drinkcat@chromium.org, linux-kernel@vger.kernel.org, srv_heupstream@mediatek.com, Bibby Hsieh List-Id: dri-devel@lists.freedesktop.org VGhlIHN0YXRlLT5iYXNlLmV2ZW50IHZhcmlhYmxlIHdvdWxkIGJlIGFjY2VzcyBieSB0aHJlYWQg Y29udGV4dA0KaW4gbXRrX2RybV9jcnRjX2F0b21pY19iZWdpbigpIG9yIGJ5IGludGVycnVwdCBj b250ZXh0IGluDQptdGtfZHJtX2NydGNfZmluaXNoX3BhZ2VfZmxpcCgpLCBzbyBlYWNoIHBhcnQg c2hvdWxkIGJlIGEgY3JpdGljYWwNCnNlY3Rpb24uIEZpeCBpdC4NCg0KRml4ZXM6IDExOWY1MTcz NjI4YSAoImRybS9tZWRpYXRlazogQWRkIERSTSBEcml2ZXIgZm9yIE1lZGlhdGVrIFNvQyBNVDgx NzMuIikNCg0KU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVr LmNvbT4NCi0tLQ0KIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyB8IDMg KysrDQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fY3J0Yy5jDQppbmRleCAyOWQwNTgyZTkwZTkuLjcxZjQwODlhODExNyAx MDA2NDQNCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQpAQCAtNDgzLDEyICs0 ODMsMTUgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2F0b21pY19iZWdpbihzdHJ1Y3QgZHJt X2NydGMgKmNydGMsDQogCWlmIChtdGtfY3J0Yy0+ZXZlbnQgJiYgc3RhdGUtPmJhc2UuZXZlbnQp DQogCQlEUk1fRVJST1IoIm5ldyBldmVudCB3aGlsZSB0aGVyZSBpcyBzdGlsbCBhIHBlbmRpbmcg ZXZlbnRcbiIpOw0KIA0KKwlzcGluX2xvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOw0K IAlpZiAoc3RhdGUtPmJhc2UuZXZlbnQpIHsNCiAJCXN0YXRlLT5iYXNlLmV2ZW50LT5waXBlID0g ZHJtX2NydGNfaW5kZXgoY3J0Yyk7DQogCQlXQVJOX09OKGRybV9jcnRjX3ZibGFua19nZXQoY3J0 YykgIT0gMCk7DQorCQlXQVJOX09OKG10a19jcnRjLT5ldmVudCk7DQogCQltdGtfY3J0Yy0+ZXZl bnQgPSBzdGF0ZS0+YmFzZS5ldmVudDsNCiAJCXN0YXRlLT5iYXNlLmV2ZW50ID0gTlVMTDsNCiAJ fQ0KKwlzcGluX3VubG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7DQogfQ0KIA0KIHN0 YXRpYyB2b2lkIG10a19kcm1fY3J0Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRjICpjcnRj LA0KLS0gDQoyLjE4LjANCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C217C43215 for ; Thu, 28 Nov 2019 02:43:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1BD4A2166E for ; Thu, 28 Nov 2019 02:43:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1BD4A2166E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 63ABB6E5F8; Thu, 28 Nov 2019 02:42:51 +0000 (UTC) Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by gabe.freedesktop.org (Postfix) with ESMTP id BD4F56E5EA for ; Thu, 28 Nov 2019 02:42:46 +0000 (UTC) X-UUID: 76abfeb4e35846eaac3301e9b8d6294c-20191128 X-UUID: 76abfeb4e35846eaac3301e9b8d6294c-20191128 Received: from mtkcas08.mediatek.inc [(172.21.101.126)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.10 Build 0809 with TLS) with ESMTP id 189081807; Thu, 28 Nov 2019 10:42:44 +0800 Received: from mtkcas07.mediatek.inc (172.21.101.84) by mtkmbs08n2.mediatek.inc (172.21.101.56) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 28 Nov 2019 10:42:13 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkcas07.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1395.4 via Frontend Transport; Thu, 28 Nov 2019 10:42:46 +0800 From: Bibby Hsieh To: David Airlie , Matthias Brugger , Daniel Vetter , , Subject: [PATCH v1 1/6] drm/mediatek: put "event" in critical section Date: Thu, 28 Nov 2019 10:42:33 +0800 Message-ID: <20191128024238.9399-2-bibby.hsieh@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20191128024238.9399-1-bibby.hsieh@mediatek.com> References: <20191128024238.9399-1-bibby.hsieh@mediatek.com> MIME-Version: 1.0 X-TM-SNTS-SMTP: C415EC28D10D4D98CA7C3A32C93B685D07027E2639E1945941113FD2332F427D2000:8 X-MTK: N X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=0vCTXwJv2GLquxlzgk2gQwFIoM5oJce1MlX2/bKkJNM=; b=iGsRTk0hlXIKkYRJHKjnT3BEismMYbiqiECs+a4wrWvhd6JsMftn4hdzeZirt/aTDnnffNgkza/cWiNLGPeyy7rxcsXosCYW0tMwn7q6cNJ17BGUs/86giuAEB8LfTJq/mjFXbomI9+II2zeubL7/eaQpGXjqkW7GsaMAQU9/CY=; X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: drinkcat@chromium.org, srv_heupstream@mediatek.com, linux-kernel@vger.kernel.org, tfiga@chromium.org, Thierry Reding , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191128024233.tRhUD06tsdsOMhET01Hg7mfdAj2sOo6GGjvRVVJT4MQ@z> VGhlIHN0YXRlLT5iYXNlLmV2ZW50IHZhcmlhYmxlIHdvdWxkIGJlIGFjY2VzcyBieSB0aHJlYWQg Y29udGV4dA0KaW4gbXRrX2RybV9jcnRjX2F0b21pY19iZWdpbigpIG9yIGJ5IGludGVycnVwdCBj b250ZXh0IGluDQptdGtfZHJtX2NydGNfZmluaXNoX3BhZ2VfZmxpcCgpLCBzbyBlYWNoIHBhcnQg c2hvdWxkIGJlIGEgY3JpdGljYWwNCnNlY3Rpb24uIEZpeCBpdC4NCg0KRml4ZXM6IDExOWY1MTcz NjI4YSAoImRybS9tZWRpYXRlazogQWRkIERSTSBEcml2ZXIgZm9yIE1lZGlhdGVrIFNvQyBNVDgx NzMuIikNCg0KU2lnbmVkLW9mZi1ieTogQmliYnkgSHNpZWggPGJpYmJ5LmhzaWVoQG1lZGlhdGVr LmNvbT4NCi0tLQ0KIGRyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYyB8IDMg KysrDQogMSBmaWxlIGNoYW5nZWQsIDMgaW5zZXJ0aW9ucygrKQ0KDQpkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jIGIvZHJpdmVycy9ncHUvZHJtL21l ZGlhdGVrL210a19kcm1fY3J0Yy5jDQppbmRleCAyOWQwNTgyZTkwZTkuLjcxZjQwODlhODExNyAx MDA2NDQNCi0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tZWRpYXRlay9tdGtfZHJtX2NydGMuYw0KKysr IGIvZHJpdmVycy9ncHUvZHJtL21lZGlhdGVrL210a19kcm1fY3J0Yy5jDQpAQCAtNDgzLDEyICs0 ODMsMTUgQEAgc3RhdGljIHZvaWQgbXRrX2RybV9jcnRjX2F0b21pY19iZWdpbihzdHJ1Y3QgZHJt X2NydGMgKmNydGMsDQogCWlmIChtdGtfY3J0Yy0+ZXZlbnQgJiYgc3RhdGUtPmJhc2UuZXZlbnQp DQogCQlEUk1fRVJST1IoIm5ldyBldmVudCB3aGlsZSB0aGVyZSBpcyBzdGlsbCBhIHBlbmRpbmcg ZXZlbnRcbiIpOw0KIA0KKwlzcGluX2xvY2tfaXJxKCZjcnRjLT5kZXYtPmV2ZW50X2xvY2spOw0K IAlpZiAoc3RhdGUtPmJhc2UuZXZlbnQpIHsNCiAJCXN0YXRlLT5iYXNlLmV2ZW50LT5waXBlID0g ZHJtX2NydGNfaW5kZXgoY3J0Yyk7DQogCQlXQVJOX09OKGRybV9jcnRjX3ZibGFua19nZXQoY3J0 YykgIT0gMCk7DQorCQlXQVJOX09OKG10a19jcnRjLT5ldmVudCk7DQogCQltdGtfY3J0Yy0+ZXZl bnQgPSBzdGF0ZS0+YmFzZS5ldmVudDsNCiAJCXN0YXRlLT5iYXNlLmV2ZW50ID0gTlVMTDsNCiAJ fQ0KKwlzcGluX3VubG9ja19pcnEoJmNydGMtPmRldi0+ZXZlbnRfbG9jayk7DQogfQ0KIA0KIHN0 YXRpYyB2b2lkIG10a19kcm1fY3J0Y19hdG9taWNfZmx1c2goc3RydWN0IGRybV9jcnRjICpjcnRj LA0KLS0gDQoyLjE4LjANCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9w Lm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1k ZXZlbA==