From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47A3CC43215 for ; Thu, 28 Nov 2019 08:10:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1D24021774 for ; Thu, 28 Nov 2019 08:10:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Jia25AtA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727460AbfK1IKA (ORCPT ); Thu, 28 Nov 2019 03:10:00 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:43838 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726448AbfK1IJ7 (ORCPT ); Thu, 28 Nov 2019 03:09:59 -0500 Received: from pendragon.ideasonboard.com (unknown [104.132.253.101]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36215729; Thu, 28 Nov 2019 09:09:55 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1574928597; bh=4275TLqavidGFPsDBkZNj9mIhffOCitIlDAiAtt5RTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jia25AtAMik5jIDCOTSO/dq60rdg6LyCZI64IGWVenk/0KEFt+8vxt//Cpd8yDmeD K1BEYSDAYIa4meJ77TzXpfkM4hRjVrsgmfHxhW21shJ8aI8mQPCeXq+dFxjJyzNIum 5bXL5WVlhN2v+Buuzo0PlfFmA5oVvU4PPKvLS+GQ= Date: Thu, 28 Nov 2019 10:09:46 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Cc: Jacopo Mondi , Kieran Bingham , Simon Horman , Ulrich Hecht , David Airlie , Daniel Vetter , Linux-Renesas , DRI Development , Linux Kernel Mailing List Subject: Re: [PATCH v7 3/7] drm: rcar-du: Add support for CMM Message-ID: <20191128080946.GF4711@pendragon.ideasonboard.com> References: <20191113100556.15616-1-jacopo+renesas@jmondi.org> <20191113100556.15616-4-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Geert, On Thu, Nov 28, 2019 at 08:56:14AM +0100, Geert Uytterhoeven wrote: > On Wed, Nov 13, 2019 at 11:04 AM Jacopo Mondi wrote: > > Add a driver for the R-Car Display Unit Color Correction Module. > > In most of Gen3 SoCs, each DU output channel is provided with a CMM unit > > to perform image enhancement and color correction. > > > > Add support for CMM through a driver that supports configuration of > > the 1-dimensional LUT table. More advanced CMM features will be > > implemented on top of this initial one. > > > > Reviewed-by: Laurent Pinchart > > Reviewed-by: Kieran Bingham > > Signed-off-by: Jacopo Mondi > > > --- a/drivers/gpu/drm/rcar-du/Kconfig > > +++ b/drivers/gpu/drm/rcar-du/Kconfig > > @@ -5,6 +5,7 @@ config DRM_RCAR_DU > > depends on ARM || ARM64 > > depends on ARCH_RENESAS || COMPILE_TEST > > imply DRM_RCAR_LVDS > > + imply DRM_RCAR_CMM > > select DRM_KMS_HELPER > > select DRM_KMS_CMA_HELPER > > select DRM_GEM_CMA_HELPER > > @@ -13,6 +14,13 @@ config DRM_RCAR_DU > > Choose this option if you have an R-Car chipset. > > If M is selected the module will be called rcar-du-drm. > > > > +config DRM_RCAR_CMM > > + tristate "R-Car DU Color Management Module (CMM) Support" > > + depends on DRM && OF > > + depends on DRM_RCAR_DU > > DRM_RCAR_DU already depends on DRM && OF, so the line above > can be removed. I've sent a pull request already. Can we address this on top ? Or is it worth a separate patch, should we wait until we have to touch this and then fix it in a "while at it" fashion ? -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BE5EC43141 for ; Thu, 28 Nov 2019 08:10:01 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E5AB21771 for ; Thu, 28 Nov 2019 08:10:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E5AB21771 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 83C806E5FC; Thu, 28 Nov 2019 08:10:00 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 514CD6E60A for ; Thu, 28 Nov 2019 08:09:59 +0000 (UTC) Received: from pendragon.ideasonboard.com (unknown [104.132.253.101]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 36215729; Thu, 28 Nov 2019 09:09:55 +0100 (CET) Date: Thu, 28 Nov 2019 10:09:46 +0200 From: Laurent Pinchart To: Geert Uytterhoeven Subject: Re: [PATCH v7 3/7] drm: rcar-du: Add support for CMM Message-ID: <20191128080946.GF4711@pendragon.ideasonboard.com> References: <20191113100556.15616-1-jacopo+renesas@jmondi.org> <20191113100556.15616-4-jacopo+renesas@jmondi.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1574928597; bh=4275TLqavidGFPsDBkZNj9mIhffOCitIlDAiAtt5RTA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jia25AtAMik5jIDCOTSO/dq60rdg6LyCZI64IGWVenk/0KEFt+8vxt//Cpd8yDmeD K1BEYSDAYIa4meJ77TzXpfkM4hRjVrsgmfHxhW21shJ8aI8mQPCeXq+dFxjJyzNIum 5bXL5WVlhN2v+Buuzo0PlfFmA5oVvU4PPKvLS+GQ= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Simon Horman , David Airlie , Linux Kernel Mailing List , DRI Development , Linux-Renesas , Kieran Bingham , Jacopo Mondi , Ulrich Hecht Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191128080946.zYSAO91Usvf4Msmjg-lfF_Hx8ynvnQ50q4yrI95LSd8@z> SGkgR2VlcnQsCgpPbiBUaHUsIE5vdiAyOCwgMjAxOSBhdCAwODo1NjoxNEFNICswMTAwLCBHZWVy dCBVeXR0ZXJob2V2ZW4gd3JvdGU6Cj4gT24gV2VkLCBOb3YgMTMsIDIwMTkgYXQgMTE6MDQgQU0g SmFjb3BvIE1vbmRpIDxqYWNvcG8rcmVuZXNhc0BqbW9uZGkub3JnPiB3cm90ZToKPiA+IEFkZCBh IGRyaXZlciBmb3IgdGhlIFItQ2FyIERpc3BsYXkgVW5pdCBDb2xvciBDb3JyZWN0aW9uIE1vZHVs ZS4KPiA+IEluIG1vc3Qgb2YgR2VuMyBTb0NzLCBlYWNoIERVIG91dHB1dCBjaGFubmVsIGlzIHBy b3ZpZGVkIHdpdGggYSBDTU0gdW5pdAo+ID4gdG8gcGVyZm9ybSBpbWFnZSBlbmhhbmNlbWVudCBh bmQgY29sb3IgY29ycmVjdGlvbi4KPiA+Cj4gPiBBZGQgc3VwcG9ydCBmb3IgQ01NIHRocm91Z2gg YSBkcml2ZXIgdGhhdCBzdXBwb3J0cyBjb25maWd1cmF0aW9uIG9mCj4gPiB0aGUgMS1kaW1lbnNp b25hbCBMVVQgdGFibGUuIE1vcmUgYWR2YW5jZWQgQ01NIGZlYXR1cmVzIHdpbGwgYmUKPiA+IGlt cGxlbWVudGVkIG9uIHRvcCBvZiB0aGlzIGluaXRpYWwgb25lLgo+ID4KPiA+IFJldmlld2VkLWJ5 OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4g PiBSZXZpZXdlZC1ieTogS2llcmFuIEJpbmdoYW0gPGtpZXJhbi5iaW5naGFtK3JlbmVzYXNAaWRl YXNvbmJvYXJkLmNvbT4KPiA+IFNpZ25lZC1vZmYtYnk6IEphY29wbyBNb25kaSA8amFjb3BvK3Jl bmVzYXNAam1vbmRpLm9yZz4KPiAKPiA+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L0tj b25maWcKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9yY2FyLWR1L0tjb25maWcKPiA+IEBAIC01 LDYgKzUsNyBAQCBjb25maWcgRFJNX1JDQVJfRFUKPiA+ICAgICAgICAgZGVwZW5kcyBvbiBBUk0g fHwgQVJNNjQKPiA+ICAgICAgICAgZGVwZW5kcyBvbiBBUkNIX1JFTkVTQVMgfHwgQ09NUElMRV9U RVNUCj4gPiAgICAgICAgIGltcGx5IERSTV9SQ0FSX0xWRFMKPiA+ICsgICAgICAgaW1wbHkgRFJN X1JDQVJfQ01NCj4gPiAgICAgICAgIHNlbGVjdCBEUk1fS01TX0hFTFBFUgo+ID4gICAgICAgICBz ZWxlY3QgRFJNX0tNU19DTUFfSEVMUEVSCj4gPiAgICAgICAgIHNlbGVjdCBEUk1fR0VNX0NNQV9I RUxQRVIKPiA+IEBAIC0xMyw2ICsxNCwxMyBAQCBjb25maWcgRFJNX1JDQVJfRFUKPiA+ICAgICAg ICAgICBDaG9vc2UgdGhpcyBvcHRpb24gaWYgeW91IGhhdmUgYW4gUi1DYXIgY2hpcHNldC4KPiA+ ICAgICAgICAgICBJZiBNIGlzIHNlbGVjdGVkIHRoZSBtb2R1bGUgd2lsbCBiZSBjYWxsZWQgcmNh ci1kdS1kcm0uCj4gPgo+ID4gK2NvbmZpZyBEUk1fUkNBUl9DTU0KPiA+ICsgICAgICAgdHJpc3Rh dGUgIlItQ2FyIERVIENvbG9yIE1hbmFnZW1lbnQgTW9kdWxlIChDTU0pIFN1cHBvcnQiCj4gPiAr ICAgICAgIGRlcGVuZHMgb24gRFJNICYmIE9GCj4gPiArICAgICAgIGRlcGVuZHMgb24gRFJNX1JD QVJfRFUKPiAKPiBEUk1fUkNBUl9EVSBhbHJlYWR5IGRlcGVuZHMgb24gRFJNICYmIE9GLCBzbyB0 aGUgbGluZSBhYm92ZQo+IGNhbiBiZSByZW1vdmVkLgoKSSd2ZSBzZW50IGEgcHVsbCByZXF1ZXN0 IGFscmVhZHkuIENhbiB3ZSBhZGRyZXNzIHRoaXMgb24gdG9wID8gT3IgaXMgaXQKd29ydGggYSBz ZXBhcmF0ZSBwYXRjaCwgc2hvdWxkIHdlIHdhaXQgdW50aWwgd2UgaGF2ZSB0byB0b3VjaCB0aGlz IGFuZAp0aGVuIGZpeCBpdCBpbiBhICJ3aGlsZSBhdCBpdCIgZmFzaGlvbiA/CgotLSAKUmVnYXJk cywKCkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v ZHJpLWRldmVs