From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Date: Fri, 29 Nov 2019 20:30:07 +0000 Subject: Re: [PATCH v2 14/14] auxdisplay: constify fb ops Message-Id: <20191129203007.GV624164@phenom.ffwll.local> List-Id: References: <94a33cf0a587e803bcadcf80e8152eac9b196f34.1575022735.git.jani.nikula@intel.com> <20191129152424.GG624164@phenom.ffwll.local> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Miguel Ojeda Cc: linux-fbdev@vger.kernel.org, Jani Nikula , Robin van der Gracht , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org On Fri, Nov 29, 2019 at 09:16:42PM +0100, Miguel Ojeda wrote: > On Fri, Nov 29, 2019 at 4:24 PM Daniel Vetter wrote: > > > > Oh, another display subsystem? Intriguing ... > > > > Reviewed-by: Daniel Vetter > > It is intended for displays that are not intended as the usual/main > display, e.g. very small LCDs :) Well we do have very small lcd display drivers in drm, and before that in fbdev. And you have a fbdev framebuffer driver in there, which looks a bit misplaced ... Afaiui you also have some even tinier lcd drivers where you don't address pixels, but just directly upload text, and those obviously don't fit into drm/fbdev world. But anything where you can address pixels very much does. -Daniel > > Reviewed-by: Miguel Ojeda > > Cheers, > Miguel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Vetter Subject: Re: [PATCH v2 14/14] auxdisplay: constify fb ops Date: Fri, 29 Nov 2019 21:30:07 +0100 Message-ID: <20191129203007.GV624164@phenom.ffwll.local> References: <94a33cf0a587e803bcadcf80e8152eac9b196f34.1575022735.git.jani.nikula@intel.com> <20191129152424.GG624164@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x342.google.com (mail-wm1-x342.google.com [IPv6:2a00:1450:4864:20::342]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCCA26E994 for ; Fri, 29 Nov 2019 20:30:11 +0000 (UTC) Received: by mail-wm1-x342.google.com with SMTP id u8so855877wmu.0 for ; Fri, 29 Nov 2019 12:30:11 -0800 (PST) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Miguel Ojeda Cc: linux-fbdev@vger.kernel.org, Jani Nikula , Robin van der Gracht , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBOb3YgMjksIDIwMTkgYXQgMDk6MTY6NDJQTSArMDEwMCwgTWlndWVsIE9qZWRhIHdy b3RlOgo+IE9uIEZyaSwgTm92IDI5LCAyMDE5IGF0IDQ6MjQgUE0gRGFuaWVsIFZldHRlciA8ZGFu aWVsQGZmd2xsLmNoPiB3cm90ZToKPiA+Cj4gPiBPaCwgYW5vdGhlciBkaXNwbGF5IHN1YnN5c3Rl bT8gSW50cmlndWluZyAuLi4KPiA+Cj4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KPiAKPiBJdCBpcyBpbnRlbmRlZCBmb3IgZGlzcGxheXMgdGhh dCBhcmUgbm90IGludGVuZGVkIGFzIHRoZSB1c3VhbC9tYWluCj4gZGlzcGxheSwgZS5nLiB2ZXJ5 IHNtYWxsIExDRHMgOikKCldlbGwgd2UgZG8gaGF2ZSB2ZXJ5IHNtYWxsIGxjZCBkaXNwbGF5IGRy aXZlcnMgaW4gZHJtLCBhbmQgYmVmb3JlIHRoYXQgaW4KZmJkZXYuIEFuZCB5b3UgaGF2ZSBhIGZi ZGV2IGZyYW1lYnVmZmVyIGRyaXZlciBpbiB0aGVyZSwgd2hpY2ggbG9va3MgYSBiaXQKbWlzcGxh Y2VkIC4uLgoKQWZhaXVpIHlvdSBhbHNvIGhhdmUgc29tZSBldmVuIHRpbmllciBsY2QgZHJpdmVy cyB3aGVyZSB5b3UgZG9uJ3QgYWRkcmVzcwpwaXhlbHMsIGJ1dCBqdXN0IGRpcmVjdGx5IHVwbG9h ZCB0ZXh0LCBhbmQgdGhvc2Ugb2J2aW91c2x5IGRvbid0IGZpdCBpbnRvCmRybS9mYmRldiB3b3Js ZC4gQnV0IGFueXRoaW5nIHdoZXJlIHlvdSBjYW4gYWRkcmVzcyBwaXhlbHMgdmVyeSBtdWNoIGRv ZXMuCi1EYW5pZWwKCj4gCj4gUmV2aWV3ZWQtYnk6IE1pZ3VlbCBPamVkYSA8bWlndWVsLm9qZWRh LnNhbmRvbmlzQGdtYWlsLmNvbT4KPiAKPiBDaGVlcnMsCj4gTWlndWVsCgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJp LWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B36C6C432C0 for ; Fri, 29 Nov 2019 20:30:13 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ED022176D for ; Fri, 29 Nov 2019 20:30:13 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ED022176D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D26566E994; Fri, 29 Nov 2019 20:30:12 +0000 (UTC) Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by gabe.freedesktop.org (Postfix) with ESMTPS id CFFF26E998 for ; Fri, 29 Nov 2019 20:30:11 +0000 (UTC) Received: by mail-wm1-x341.google.com with SMTP id b11so15295963wmj.4 for ; Fri, 29 Nov 2019 12:30:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xsYT5lMEF+x8inV5EK6Q/hgm20RbjUJUPe9EzYmEaa0=; b=Rl9uG0GRmvdq6V7EiQ+OD6LU8OvT4RpADdkEoyZ+p9f/bpIfVNLCn2stOXe2DShK5V VwURyJenm1KxpBK1+HQWNL16Q/ZOtxId2VV2GcVGugGz1jkwFxVhhDl8/NszL5+r/4tW 7uqmA6Mt8MBqdAY/79579mantl6AUdPpmiE1hgx3utbE5WtJyUkYRiBUDG2eTux1yDaW U/EFQKDMDoigye7fzn2mG7b5MwD3fo6u4LGbuNgE8HiNaxyWTT2larxfwJZn7FS19t/U s2LNAKQDp18cR7TSQe95yJSIjFYEbGzzcEUkob+qOIZoTUYZUk6sFZPRRuKaRUzTxaD6 wWVw== X-Gm-Message-State: APjAAAXwrX1DqHkj/6wEygluOrg45/2Qe6lJ1Bmkj208mP7i8HW3MPFz +uZimNVQHS3GmAUu9Iw93Wo5og== X-Google-Smtp-Source: APXvYqzJOztkRm1kwVy9FHEMusVGRjzr9oBrfa/YqQaHG3axAj84vRsSqbnDq+ajtpY9cXXMq9Ay7g== X-Received: by 2002:a7b:cc8b:: with SMTP id p11mr16709271wma.38.1575059410403; Fri, 29 Nov 2019 12:30:10 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-96.fiber7.init7.net. [212.51.149.96]) by smtp.gmail.com with ESMTPSA id s19sm10360892wmc.4.2019.11.29.12.30.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Nov 2019 12:30:09 -0800 (PST) Date: Fri, 29 Nov 2019 21:30:07 +0100 From: Daniel Vetter To: Miguel Ojeda Message-ID: <20191129203007.GV624164@phenom.ffwll.local> References: <94a33cf0a587e803bcadcf80e8152eac9b196f34.1575022735.git.jani.nikula@intel.com> <20191129152424.GG624164@phenom.ffwll.local> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Operating-System: Linux phenom 5.3.0-2-amd64 User-Agent: Mutt/1.12.2 (2019-09-21) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xsYT5lMEF+x8inV5EK6Q/hgm20RbjUJUPe9EzYmEaa0=; b=lpBVcQxlQWKQlwPnqQn+b4vO/UTKXtp4LuAdhVs1O7y9n6TPwmgND034kKipTpduKr 7EPSb7daq9j0RmY33ikvf/DWB6DVm6b9To9GctfErQ2TswXvS9imMT1y3BbUJgC4hMaK qCcYEf3t0ATUTHdniddf8RMFrzALNO4VE0ZqE= Subject: Re: [Intel-gfx] [PATCH v2 14/14] auxdisplay: constify fb ops X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-fbdev@vger.kernel.org, Jani Nikula , Robin van der Gracht , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Message-ID: <20191129203007.Fglxpy0DXnFh3TMXNKQFdVjaZp41ga-H7hYTx-HyLBs@z> T24gRnJpLCBOb3YgMjksIDIwMTkgYXQgMDk6MTY6NDJQTSArMDEwMCwgTWlndWVsIE9qZWRhIHdy b3RlOgo+IE9uIEZyaSwgTm92IDI5LCAyMDE5IGF0IDQ6MjQgUE0gRGFuaWVsIFZldHRlciA8ZGFu aWVsQGZmd2xsLmNoPiB3cm90ZToKPiA+Cj4gPiBPaCwgYW5vdGhlciBkaXNwbGF5IHN1YnN5c3Rl bT8gSW50cmlndWluZyAuLi4KPiA+Cj4gPiBSZXZpZXdlZC1ieTogRGFuaWVsIFZldHRlciA8ZGFu aWVsLnZldHRlckBmZndsbC5jaD4KPiAKPiBJdCBpcyBpbnRlbmRlZCBmb3IgZGlzcGxheXMgdGhh dCBhcmUgbm90IGludGVuZGVkIGFzIHRoZSB1c3VhbC9tYWluCj4gZGlzcGxheSwgZS5nLiB2ZXJ5 IHNtYWxsIExDRHMgOikKCldlbGwgd2UgZG8gaGF2ZSB2ZXJ5IHNtYWxsIGxjZCBkaXNwbGF5IGRy aXZlcnMgaW4gZHJtLCBhbmQgYmVmb3JlIHRoYXQgaW4KZmJkZXYuIEFuZCB5b3UgaGF2ZSBhIGZi ZGV2IGZyYW1lYnVmZmVyIGRyaXZlciBpbiB0aGVyZSwgd2hpY2ggbG9va3MgYSBiaXQKbWlzcGxh Y2VkIC4uLgoKQWZhaXVpIHlvdSBhbHNvIGhhdmUgc29tZSBldmVuIHRpbmllciBsY2QgZHJpdmVy cyB3aGVyZSB5b3UgZG9uJ3QgYWRkcmVzcwpwaXhlbHMsIGJ1dCBqdXN0IGRpcmVjdGx5IHVwbG9h ZCB0ZXh0LCBhbmQgdGhvc2Ugb2J2aW91c2x5IGRvbid0IGZpdCBpbnRvCmRybS9mYmRldiB3b3Js ZC4gQnV0IGFueXRoaW5nIHdoZXJlIHlvdSBjYW4gYWRkcmVzcyBwaXhlbHMgdmVyeSBtdWNoIGRv ZXMuCi1EYW5pZWwKCj4gCj4gUmV2aWV3ZWQtYnk6IE1pZ3VlbCBPamVkYSA8bWlndWVsLm9qZWRh LnNhbmRvbmlzQGdtYWlsLmNvbT4KPiAKPiBDaGVlcnMsCj4gTWlndWVsCgotLSAKRGFuaWVsIFZl dHRlcgpTb2Z0d2FyZSBFbmdpbmVlciwgSW50ZWwgQ29ycG9yYXRpb24KaHR0cDovL2Jsb2cuZmZ3 bGwuY2gKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50 ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBz Oi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4