All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marc-André Lureau" <marcandre.lureau@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com, ehabkost@redhat.com,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: [PATCH 04/26] qdev: move helper function to monitor/misc
Date: Sun,  1 Dec 2019 15:15:09 +0400	[thread overview]
Message-ID: <20191201111531.1136947-5-marcandre.lureau@redhat.com> (raw)
In-Reply-To: <20191201111531.1136947-1-marcandre.lureau@redhat.com>

Move the one-user function to the place it is being used.

Signed-off-by: Marc-André Lureau <marcandre.lureau@redhat.com>
---
 hw/core/qdev.c         | 26 --------------------------
 include/hw/qdev-core.h |  2 --
 monitor/misc.c         | 26 ++++++++++++++++++++++++++
 3 files changed, 26 insertions(+), 28 deletions(-)

diff --git a/hw/core/qdev.c b/hw/core/qdev.c
index c1a338bbe4..90eb01bc8e 100644
--- a/hw/core/qdev.c
+++ b/hw/core/qdev.c
@@ -760,32 +760,6 @@ void qdev_alias_all_properties(DeviceState *target, Object *source)
     } while (class != object_class_by_name(TYPE_DEVICE));
 }
 
-static int qdev_add_hotpluggable_device(Object *obj, void *opaque)
-{
-    GSList **list = opaque;
-    DeviceState *dev = (DeviceState *)object_dynamic_cast(OBJECT(obj),
-                                                          TYPE_DEVICE);
-
-    if (dev == NULL) {
-        return 0;
-    }
-
-    if (dev->realized && object_property_get_bool(obj, "hotpluggable", NULL)) {
-        *list = g_slist_append(*list, dev);
-    }
-
-    return 0;
-}
-
-GSList *qdev_build_hotpluggable_device_list(Object *peripheral)
-{
-    GSList *list = NULL;
-
-    object_child_foreach(peripheral, qdev_add_hotpluggable_device, &list);
-
-    return list;
-}
-
 static bool device_get_realized(Object *obj, Error **errp)
 {
     DeviceState *dev = DEVICE(obj);
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 1518495b1e..6b0e7b265d 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -457,8 +457,6 @@ extern bool qdev_hot_removed;
 
 char *qdev_get_dev_path(DeviceState *dev);
 
-GSList *qdev_build_hotpluggable_device_list(Object *peripheral);
-
 void qbus_set_hotplug_handler(BusState *bus, Object *handler, Error **errp);
 
 void qbus_set_bus_hotplug_handler(BusState *bus, Error **errp);
diff --git a/monitor/misc.c b/monitor/misc.c
index 3baa15f3bf..36c85cecf3 100644
--- a/monitor/misc.c
+++ b/monitor/misc.c
@@ -1956,6 +1956,32 @@ void object_add_completion(ReadLineState *rs, int nb_args, const char *str)
     g_slist_free(list);
 }
 
+static int qdev_add_hotpluggable_device(Object *obj, void *opaque)
+{
+    GSList **list = opaque;
+    DeviceState *dev = (DeviceState *)object_dynamic_cast(OBJECT(obj),
+                                                          TYPE_DEVICE);
+
+    if (dev == NULL) {
+        return 0;
+    }
+
+    if (dev->realized && object_property_get_bool(obj, "hotpluggable", NULL)) {
+        *list = g_slist_append(*list, dev);
+    }
+
+    return 0;
+}
+
+static GSList *qdev_build_hotpluggable_device_list(Object *peripheral)
+{
+    GSList *list = NULL;
+
+    object_child_foreach(peripheral, qdev_add_hotpluggable_device, &list);
+
+    return list;
+}
+
 static void peripheral_device_del_completion(ReadLineState *rs,
                                              const char *str, size_t len)
 {
-- 
2.24.0



  parent reply	other threads:[~2019-12-01 11:23 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-01 11:15 [PATCH 00/26] Make QDev use class properties Marc-André Lureau
2019-12-01 11:15 ` [PATCH 01/26] object: add extra sanity checks Marc-André Lureau
2019-12-01 19:33   ` Philippe Mathieu-Daudé
2019-12-01 11:15 ` [PATCH 02/26] qdev: remove duplicated qdev_property_add_static() doc Marc-André Lureau
2019-12-11 15:42   ` Damien Hedde
2019-12-01 11:15 ` [PATCH 03/26] qdev: remove extraneous error Marc-André Lureau
2019-12-11 16:53   ` Damien Hedde
2019-12-01 11:15 ` Marc-André Lureau [this message]
2019-12-01 19:35   ` [PATCH 04/26] qdev: move helper function to monitor/misc Philippe Mathieu-Daudé
2019-12-01 11:15 ` [PATCH 05/26] object: avoid extra class property key duplication Marc-André Lureau
2019-12-01 11:15 ` [PATCH 06/26] object: add class property initializer Marc-André Lureau
2019-12-01 11:15 ` [PATCH 07/26] object: add object_property_get_defaut() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 08/26] object: make object_class_property_add* return property Marc-André Lureau
2019-12-01 11:15 ` [PATCH 09/26] qstring: add qstring_free() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 10/26] object: add object_property_set_defaut_{bool, str, int, uint}() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 11/26] object: do not free class properties Marc-André Lureau
2019-12-01 11:15 ` [PATCH 12/26] object: check strong flag with & Marc-André Lureau
2019-12-01 11:15 ` [PATCH 13/26] object: rename link "child" to "target" Marc-André Lureau
2019-12-01 11:15 ` [PATCH 14/26] object: add direct link flag Marc-André Lureau
2019-12-01 11:15 ` [PATCH 15/26] object: express const link with link property Marc-André Lureau
2019-12-01 11:15 ` [PATCH 16/26] object: add object_class_property_add_link() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 17/26] object: release all props Marc-André Lureau
2019-12-01 11:15 ` [PATCH 18/26] object: return self in object_ref() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 19/26] qdev: set properties with device_class_set_props() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 20/26] qdev: move instance properties to class properties Marc-André Lureau
2019-12-01 11:15 ` [PATCH 21/26] qdev: register properties as " Marc-André Lureau
2019-12-01 11:15 ` [PATCH 22/26] vl: print default value in object help Marc-André Lureau
2019-12-01 11:15 ` [PATCH 23/26] qom: simplify qmp_device_list_properties() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 24/26] qom: introduce object_property_help() Marc-André Lureau
2019-12-01 11:15 ` [PATCH 25/26] qapi/qmp: add ObjectPropertyInfo.default-value Marc-André Lureau
2019-12-11 16:06   ` Eric Blake
2019-12-11 17:41     ` Marc-André Lureau
2019-12-01 11:15 ` [PATCH 26/26] qdev: use object_property_help() Marc-André Lureau
2020-01-10 15:30 [PATCH 00/26] Various qom & qdev enhancements Marc-André Lureau
2020-01-10 15:30 ` [PATCH 04/26] qdev: move helper function to monitor/misc Marc-André Lureau
2020-01-10 19:18   ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191201111531.1136947-5-marcandre.lureau@redhat.com \
    --to=marcandre.lureau@redhat.com \
    --cc=berrange@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.