* [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13
@ 2019-12-02 8:49 hongxu
2019-12-06 19:07 ` Bruce Ashfield
0 siblings, 1 reply; 2+ messages in thread
From: hongxu @ 2019-12-02 8:49 UTC (permalink / raw)
To: bruce.ashfield, meta-virtualization
Since go was upgraded to 1.13, it support for Go modules by default [1],
but for cni recipe, it uses GOPATH mode which supports offline build
[1] https://golang.org/cmd/go/#hdr-Module_support
Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
---
recipes-networking/cni/cni.inc | 1 +
1 file changed, 1 insertion(+)
diff --git a/recipes-networking/cni/cni.inc b/recipes-networking/cni/cni.inc
index 6590b27..7e5af04 100644
--- a/recipes-networking/cni/cni.inc
+++ b/recipes-networking/cni/cni.inc
@@ -45,6 +45,7 @@ do_compile() {
ln -sf ../../../../cnitool ${S}/src/import/vendor/github.com/containernetworking/cni/cnitool
ln -sf ${WORKDIR}/plugins ${S}/src/import/vendor/github.com/containernetworking/plugins
+ export GO111MODULE="off"
export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor:${STAGING_DIR_TARGET}/${prefix}/local/go"
export CGO_ENABLED="1"
--
2.21.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13
2019-12-02 8:49 [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13 hongxu
@ 2019-12-06 19:07 ` Bruce Ashfield
0 siblings, 0 replies; 2+ messages in thread
From: Bruce Ashfield @ 2019-12-06 19:07 UTC (permalink / raw)
To: Hongxu Jia; +Cc: meta-virtualization
In message: [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13
on 02/12/2019 Hongxu Jia wrote:
> Since go was upgraded to 1.13, it support for Go modules by default [1],
> but for cni recipe, it uses GOPATH mode which supports offline build
This patch doesn't look like it is against meta-virt master .. we don't
have a cni.inc file.
Can you refresh the patch and resend ?
Bruce
>
> [1] https://golang.org/cmd/go/#hdr-Module_support
>
> Signed-off-by: Hongxu Jia <hongxu.jia@windriver.com>
> ---
> recipes-networking/cni/cni.inc | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/recipes-networking/cni/cni.inc b/recipes-networking/cni/cni.inc
> index 6590b27..7e5af04 100644
> --- a/recipes-networking/cni/cni.inc
> +++ b/recipes-networking/cni/cni.inc
> @@ -45,6 +45,7 @@ do_compile() {
> ln -sf ../../../../cnitool ${S}/src/import/vendor/github.com/containernetworking/cni/cnitool
> ln -sf ${WORKDIR}/plugins ${S}/src/import/vendor/github.com/containernetworking/plugins
>
> + export GO111MODULE="off"
> export GOPATH="${S}/src/import/.gopath:${S}/src/import/vendor:${STAGING_DIR_TARGET}/${prefix}/local/go"
> export CGO_ENABLED="1"
>
> --
> 2.21.0
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-06 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-02 8:49 [meta-virtualization][PATCH] cni: never uses module support since go was upgraded to 1.13 hongxu
2019-12-06 19:07 ` Bruce Ashfield
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.