From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8918DC432C0 for ; Mon, 2 Dec 2019 14:14:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4DBFB20717 for ; Mon, 2 Dec 2019 14:14:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XGIeB6D4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4DBFB20717 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XpX7CzhM9gmwJGH66PgEAcW2RObY6vc85Z9QBtPkoYg=; b=XGIeB6D4mMizZh ysplcL+Z4qR1kwryBw5JlMmHjG4FjcGn820vKa+E9xaTzG6jVtymymO/2o91yGGtEzFErYkNQgz6m 8BMaUQPUZfmpANNI/d6NXENC7l0s+XtL+ca8a0B1+utyTpxlj0/AdxMbWmuSiRnGtW/xAmN3jQ7BI b2G1EzkpiwVALH/140liNqyTc+veqUG0thzTua40w8xD7zUyaCu5br3FwWPIfLAjjnPFF2Hjh47pM h0iI1qoAqRKaOHLB4gNgrPx/Kr/dDM6/TgHmbQOOlcpUmp/06sKZtX0e60RXIHNq5XXhr5w8ygj7E CBuOQaLLVqMqFqESQcjA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibmSx-0000LN-7w; Mon, 02 Dec 2019 14:14:19 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibmSt-0000KG-Nt for linux-arm-kernel@lists.infradead.org; Mon, 02 Dec 2019 14:14:17 +0000 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ibmSl-0006JA-AE; Mon, 02 Dec 2019 15:14:07 +0100 Received: from mfe by pty.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ibmSk-0003vt-7G; Mon, 02 Dec 2019 15:14:06 +0100 Date: Mon, 2 Dec 2019 15:14:06 +0100 From: Marco Felsch To: Stefan =?iso-8859-1?Q?Riedm=FCller?= Subject: Re: [PATCH 1/3] ARM: dts: imx6: phycore-som: fix arm and soc minimum voltage Message-ID: <20191202141406.gvzc3lnxefczd33b@pengutronix.de> References: <20191129164859.15632-1-m.felsch@pengutronix.de> <20191202124200.mvwnsne2vnszyprj@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Uptime: 15:09:59 up 17 days, 5:28, 29 users, load average: 0.00, 0.03, 0.01 User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c5 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191202_061415_780437_90734A6E X-CRM114-Status: GOOD ( 27.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: s.christ@phytec.de, chf.fritz@googlemail.com, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, c.hemp@phytec.de, shawnguo@kernel.org, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On 19-12-02 14:55, Stefan Riedm=FCller wrote: > Hi Marco, > = > On 02.12.19 13:42, Marco Felsch wrote: > > Hi Stefan, > > = > > On 19-12-02 11:09, Stefan Riedm=FCller wrote: > > > Hi Marco, > > > = > > > your proposed setting is only valid for the LDO enabled case but not = for the > > > case where the LDO's are in bypass mode. Is that intended? In bypass = mode it > > > actually needs to be 0.925 V min for ARM and 1.15 V min for SOC. > > = > > The case is that the driver doesn't support the bypass mode currently so > > yes it was intended. > = > Ok, I see. > = > > = > > > Did you experience an issue with the current settings or is this just= a > > > cosmetic change? > > = > > There is currently no issue because the internally LDO's don't try to > > apply such a low voltage value. But I think it isn't a cosmetic change > > because this value is wrong. We need to specify the valid voltage range. > = > Please correct me if I'm wrong, but isn't the regulator-min and > regulator-max values supposed to reflect the min and max values this > regulator can deliver? Nope, the constraints are hard coded within the driver e.g. da9062: 8<----------------------------------------------------------------- /* Regulator operations */ /* Current limits array (in uA) * - DA9061_ID_[BUCK1|BUCK3] * - DA9062_ID_[BUCK1|BUCK2|BUCK4] * Entry indexes corresponds to register values. */ static const unsigned int da9062_buck_a_limits[] =3D { 500000, 600000, 700000, 800000, 900000, 1000000, 1100000, 1200000, 1300000, 1400000, 1500000, 1600000, 1700000, 1800000, 1900000, 2000000 }; /* Current limits array (in uA) * - DA9061_ID_BUCK2 * - DA9062_ID_BUCK3 * Entry indexes corresponds to register values. */ static const unsigned int da9062_buck_b_limits[] =3D { 1500000, 1600000, 1700000, 1800000, 1900000, 2000000, 2100000, 2200000, 2300000, 2400000, 2500000, 2600000, 2700000, 2800000, 2900000, 3000000 }; 8<----------------------------------------------------------------- So you have to specify the min/max voltage for your design. Regards, Marco > Maybe your change is better placed in the anatop regulators. Btw they also > have a 0.725 V minimum voltage: > = > From arch/arm/boot/dts/imx6qdl.dtsi: > = > reg_arm: regulator-vddcore { > = > compatible =3D "fsl,anatop-regula= tor"; > regulator-name =3D "vddarm"; > = > regulator-min-microvolt =3D <7250= 00>; > = > regulator-max-microvolt =3D <1450= 000>; > regulator-always-on; > = > anatop-reg-offset =3D <0x140>; > = > anatop-vol-bit-shift =3D <0>; > = > anatop-vol-bit-width =3D <5>; > = > anatop-delay-reg-offset =3D <0x17= 0>; > = > anatop-delay-bit-shift =3D <24>; > = > anatop-delay-bit-width =3D <2>; > = > anatop-min-bit-val =3D <1>; > = > anatop-min-voltage =3D <725000>; > = > anatop-max-voltage =3D <1450000>; > = > }; > = > = > Regards, > Stefan > = > > = > > Regards, > > Marco > > = > > > Regards, > > > Stefan > > > = > > > = > > > On 29.11.19 17:48, Marco Felsch wrote: > > > > The current set minimum voltage of 730000mV seems to be wrong. I do= n't > > > > know the document which specifies that but the imx6qdl datasheets s= ays > > > > that the minimum voltage should be 1.05V for VDD_ARM (LDO enabled, = lowest > > > > opp) and 1.275V for VDD_SOC (LDO enabled, lowest opp). > > > > = > > > > Fixes: ddec5d1c0047 ("ARM: dts: imx6: Add initial support for phyCO= RE-i.MX 6 SOM") > > > > Signed-off-by: Marco Felsch > > > > --- > > > > arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi | 4 ++-- > > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > = > > > > diff --git a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi b/ar= ch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > > > index 6486df3e2942..46d4953c5588 100644 > > > > --- a/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > > > +++ b/arch/arm/boot/dts/imx6qdl-phytec-phycore-som.dtsi > > > > @@ -107,14 +107,14 @@ > > > > regulators { > > > > vdd_arm: buck1 { > > > > regulator-name =3D "vdd_arm"; > > > > - regulator-min-microvolt =3D <730000>; > > > > + regulator-min-microvolt =3D <1050000>; > > > > regulator-max-microvolt =3D <1380000>; > > > > regulator-always-on; > > > > }; > > > > vdd_soc: buck2 { > > > > regulator-name =3D "vdd_soc"; > > > > - regulator-min-microvolt =3D <730000>; > > > > + regulator-min-microvolt =3D <1275000>; > > > > regulator-max-microvolt =3D <1380000>; > > > > regulator-always-on; > > > > }; > > > > = > > > = > > = > = -- = Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel