From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 939C5C432C0 for ; Mon, 2 Dec 2019 16:52:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6694D20833 for ; Mon, 2 Dec 2019 16:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575305556; bh=xJBJvSL3GUEfnOnsDo3rzGZ6aEPZyboM5lRyhSJW4Eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LxRO7ahokjkX1qN2HZ+BlZ5hMdP1WaIY4kgod3gOoNsMV55fN7eT2nMMvOqXJgYAw G8cGt0kHeGk5dh2NDGZDiSeE3a7sn8y9eAUHDWzMnEXMHXch2XIalCH9P5GuNSt0lM 8r4xUqR0noQ2eY3E9Y+xx+UpYaaa3Y/ItpmNw7Ys= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727568AbfLBQwf (ORCPT ); Mon, 2 Dec 2019 11:52:35 -0500 Received: from mail.kernel.org ([198.145.29.99]:37080 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727455AbfLBQwf (ORCPT ); Mon, 2 Dec 2019 11:52:35 -0500 Received: from localhost (unknown [84.241.196.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D49942070B; Mon, 2 Dec 2019 16:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575305554; bh=xJBJvSL3GUEfnOnsDo3rzGZ6aEPZyboM5lRyhSJW4Eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a1FnBeHviNvR/pCrAAXdaUNMILZKPdQpMdlBjbr66FQ5jEKQDot4LeBle1LwAPHOD Ti3c+TqzrAj0xa1R6aFlNiPW4wMoD872WIqdF2nvHKGWQF9KQcQJjA2dZXvLCd8+99 AoIPJW9IgaIKbld8iy8k2BzFKFBhsNQwQksee+Ow= Date: Mon, 2 Dec 2019 17:52:31 +0100 From: Greg Kroah-Hartman To: Guenter Roeck Cc: devel@driverdev.osuosl.org, Julia Lawall , linux-kernel@vger.kernel.org, Wambui Karuga Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Message-ID: <20191202165231.GA728202@kroah.com> References: <20191202141836.9363-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191202141836.9363-1-linux@roeck-us.net> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > The code doesn't compile due to incompatible pointer errors such as > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type > > This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'. > > Unfortunately, one can not just revert the primary offending commit, as doing so > results in secondary errors. This is made worse by the fact that the "removed" > typedefs still exist and are used widely outside the staging directory, > making the entire set of "remove typedef" changes pointless and wrong. Ugh, sorry about that. > Reflect reality and mark the driver as BROKEN. Should I just delete this thing? No one seems to be using it and there is no move to get it out of staging at all. Will anyone actually miss it? It can always come back of someone does... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FEA8C432C3 for ; Mon, 2 Dec 2019 16:52:38 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 338AD20833 for ; Mon, 2 Dec 2019 16:52:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="a1FnBeHv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 338AD20833 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F3D3D20468; Mon, 2 Dec 2019 16:52:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id EDhB2aKBvxXR; Mon, 2 Dec 2019 16:52:36 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id CD2D220020; Mon, 2 Dec 2019 16:52:36 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id B72011BF315 for ; Mon, 2 Dec 2019 16:52:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id B32F020020 for ; Mon, 2 Dec 2019 16:52:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lM8YM2m09ykU for ; Mon, 2 Dec 2019 16:52:35 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by silver.osuosl.org (Postfix) with ESMTPS id 1D5811FEE0 for ; Mon, 2 Dec 2019 16:52:34 +0000 (UTC) Received: from localhost (unknown [84.241.196.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D49942070B; Mon, 2 Dec 2019 16:52:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575305554; bh=xJBJvSL3GUEfnOnsDo3rzGZ6aEPZyboM5lRyhSJW4Eo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=a1FnBeHviNvR/pCrAAXdaUNMILZKPdQpMdlBjbr66FQ5jEKQDot4LeBle1LwAPHOD Ti3c+TqzrAj0xa1R6aFlNiPW4wMoD872WIqdF2nvHKGWQF9KQcQJjA2dZXvLCd8+99 AoIPJW9IgaIKbld8iy8k2BzFKFBhsNQwQksee+Ow= Date: Mon, 2 Dec 2019 17:52:31 +0100 From: Greg Kroah-Hartman To: Guenter Roeck Subject: Re: [PATCH] staging/octeon: Mark Ethernet driver as BROKEN Message-ID: <20191202165231.GA728202@kroah.com> References: <20191202141836.9363-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191202141836.9363-1-linux@roeck-us.net> User-Agent: Mutt/1.12.2 (2019-09-21) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Julia Lawall , linux-kernel@vger.kernel.org, Wambui Karuga Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Mon, Dec 02, 2019 at 06:18:36AM -0800, Guenter Roeck wrote: > The code doesn't compile due to incompatible pointer errors such as > > drivers/staging/octeon/ethernet-tx.c:649:50: error: > passing argument 1 of 'cvmx_wqe_get_grp' from incompatible pointer type > > This is due to mixing, for example, cvmx_wqe_t with 'struct cvmx_wqe'. > > Unfortunately, one can not just revert the primary offending commit, as doing so > results in secondary errors. This is made worse by the fact that the "removed" > typedefs still exist and are used widely outside the staging directory, > making the entire set of "remove typedef" changes pointless and wrong. Ugh, sorry about that. > Reflect reality and mark the driver as BROKEN. Should I just delete this thing? No one seems to be using it and there is no move to get it out of staging at all. Will anyone actually miss it? It can always come back of someone does... thanks, greg k-h _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel