From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E667FC432C0 for ; Mon, 2 Dec 2019 16:58:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ADE8C20848 for ; Mon, 2 Dec 2019 16:58:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZqEi2oza" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727653AbfLBQ6s (ORCPT ); Mon, 2 Dec 2019 11:58:48 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:39902 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727477AbfLBQ6s (ORCPT ); Mon, 2 Dec 2019 11:58:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kvx6skM6KVyZP6v62kIm1BhsFXAktdiWmhoWDqy+TEc=; b=ZqEi2ozaBFH7Wa44iB6r0PCBb Rs7SdB7N4Y0ct95W25LSYY89vpmWYvZi1BNw1dzj0ysG0iVnsGmVi/WJXcHSVSV1Q8+LC5TwwIKy6 2aLZAY83lf55HTfR1UHHRNUPqc7TuWcboJmlFrlcO16k4mHPbALEp9RM8TpsRN3xMlPrWPl62pIqt Xgkn0nc70iRbSuvQ4PVIBgS2ZntcH4DDycZgo+7vxSnXT9rdcdihcFBxTElv6jJhYHTcVoG6ggQSy Pj5G2TV5B/ky+efAbARDW660Z105E3B/0HVyw4w168Xv34AQ096XHlbLhGemRPhofO83m73PhIAEF R/r2wuLEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibp27-0007sl-CK; Mon, 02 Dec 2019 16:58:47 +0000 Date: Mon, 2 Dec 2019 08:58:47 -0800 From: Christoph Hellwig To: Cong Wang Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [Patch v2 1/3] iommu: match the original algorithm Message-ID: <20191202165847.GA30032@infradead.org> References: <20191129004855.18506-1-xiyou.wangcong@gmail.com> <20191129004855.18506-2-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191129004855.18506-2-xiyou.wangcong@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org I think a subject line better describes what you change, no that it matches an original algorithm. The fact that the fix matches the original algorithm can go somewhere towards the commit log, preferably with a reference to the actual paper. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CAFC432C0 for ; Mon, 2 Dec 2019 16:58:53 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 826DC20848 for ; Mon, 2 Dec 2019 16:58:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="ZqEi2oza" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 826DC20848 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 4A1DE86812; Mon, 2 Dec 2019 16:58:53 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id d7jHLvKokyGS; Mon, 2 Dec 2019 16:58:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [140.211.9.56]) by whitealder.osuosl.org (Postfix) with ESMTP id 1F31786576; Mon, 2 Dec 2019 16:58:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id F2FD1C1797; Mon, 2 Dec 2019 16:58:51 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by lists.linuxfoundation.org (Postfix) with ESMTP id CE21BC087F for ; Mon, 2 Dec 2019 16:58:48 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id BCE59885DE for ; Mon, 2 Dec 2019 16:58:48 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rGxkRHWIovRg for ; Mon, 2 Dec 2019 16:58:48 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by hemlock.osuosl.org (Postfix) with ESMTPS id 51F1A88187 for ; Mon, 2 Dec 2019 16:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=Kvx6skM6KVyZP6v62kIm1BhsFXAktdiWmhoWDqy+TEc=; b=ZqEi2ozaBFH7Wa44iB6r0PCBb Rs7SdB7N4Y0ct95W25LSYY89vpmWYvZi1BNw1dzj0ysG0iVnsGmVi/WJXcHSVSV1Q8+LC5TwwIKy6 2aLZAY83lf55HTfR1UHHRNUPqc7TuWcboJmlFrlcO16k4mHPbALEp9RM8TpsRN3xMlPrWPl62pIqt Xgkn0nc70iRbSuvQ4PVIBgS2ZntcH4DDycZgo+7vxSnXT9rdcdihcFBxTElv6jJhYHTcVoG6ggQSy Pj5G2TV5B/ky+efAbARDW660Z105E3B/0HVyw4w168Xv34AQ096XHlbLhGemRPhofO83m73PhIAEF R/r2wuLEg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1ibp27-0007sl-CK; Mon, 02 Dec 2019 16:58:47 +0000 Date: Mon, 2 Dec 2019 08:58:47 -0800 From: Christoph Hellwig To: Cong Wang Subject: Re: [Patch v2 1/3] iommu: match the original algorithm Message-ID: <20191202165847.GA30032@infradead.org> References: <20191129004855.18506-1-xiyou.wangcong@gmail.com> <20191129004855.18506-2-xiyou.wangcong@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191129004855.18506-2-xiyou.wangcong@gmail.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" I think a subject line better describes what you change, no that it matches an original algorithm. The fact that the fix matches the original algorithm can go somewhere towards the commit log, preferably with a reference to the actual paper. _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu