From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8637DC432C0 for ; Tue, 3 Dec 2019 09:44:39 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4E50C20661 for ; Tue, 3 Dec 2019 09:44:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E50C20661 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CF2616B0359; Tue, 3 Dec 2019 04:44:38 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CA1BE6B035A; Tue, 3 Dec 2019 04:44:38 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BB6A86B035B; Tue, 3 Dec 2019 04:44:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0209.hostedemail.com [216.40.44.209]) by kanga.kvack.org (Postfix) with ESMTP id A671F6B0359 for ; Tue, 3 Dec 2019 04:44:38 -0500 (EST) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 6960C181AEF23 for ; Tue, 3 Dec 2019 09:44:38 +0000 (UTC) X-FDA: 76223345436.02.cover50_28704f360e94a X-HE-Tag: cover50_28704f360e94a X-Filterd-Recvd-Size: 4405 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Tue, 3 Dec 2019 09:44:37 +0000 (UTC) Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB39gJfK150702 for ; Tue, 3 Dec 2019 04:44:35 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0b-001b2d01.pphosted.com with ESMTP id 2wm6n03rck-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Dec 2019 04:44:35 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Dec 2019 09:44:33 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Dec 2019 09:44:30 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xB39iTJv47841338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Dec 2019 09:44:29 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 173314203F; Tue, 3 Dec 2019 09:44:29 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4EBE42045; Tue, 3 Dec 2019 09:44:26 +0000 (GMT) Received: from in.ibm.com (unknown [9.124.35.39]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 3 Dec 2019 09:44:26 +0000 (GMT) Date: Tue, 3 Dec 2019 15:14:24 +0530 From: Bharata B Rao To: Hugh Dickins Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, paulus@au1.ibm.com, aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com, cclaudio@linux.ibm.com, linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com, hch@lst.de Subject: Re: [PATCH v11 0/7] KVM: PPC: Driver to manage pages of secure guest Reply-To: bharata@linux.ibm.com References: <20191125030631.7716-1-bharata@linux.ibm.com> <20191128050411.GF23438@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-TM-AS-GCONF: 00 x-cbid: 19120309-0028-0000-0000-000003C3F85A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19120309-0029-0000-0000-0000248710E9 Message-Id: <20191203094424.GA25855@in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-03_01:2019-11-29,2019-12-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 mlxscore=0 clxscore=1015 mlxlogscore=999 spamscore=0 phishscore=0 suspectscore=0 adultscore=0 bulkscore=0 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912030079 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Dec 01, 2019 at 12:24:50PM -0800, Hugh Dickins wrote: > On Thu, 28 Nov 2019, Bharata B Rao wrote: > > On Mon, Nov 25, 2019 at 08:36:24AM +0530, Bharata B Rao wrote: > > > Hi, > > > > > > This is the next version of the patchset that adds required support > > > in the KVM hypervisor to run secure guests on PEF-enabled POWER platforms. > > > > > > > Here is a fix for the issue Hugh identified with the usage of ksm_madvise() > > in this patchset. It applies on top of this patchset. > > It looks correct to me, and I hope will not spoil your performance in any > way that matters. But I have to say, the patch would be so much clearer, > if you just named your bool "downgraded" instead of "downgrade". Thanks for confirming. Yes "downgraded" would have been more appropriate, will probably change it when we do any next change in this part of the code. Regards, Bharata. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 350F5C432C0 for ; Tue, 3 Dec 2019 09:47:16 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8A2F8206EC for ; Tue, 3 Dec 2019 09:47:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8A2F8206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 47RxwK15DtzDqVQ for ; Tue, 3 Dec 2019 20:47:13 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=linux.ibm.com (client-ip=148.163.156.1; helo=mx0a-001b2d01.pphosted.com; envelope-from=bharata@linux.ibm.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=linux.ibm.com Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 47RxsP4mnkzDqVC for ; Tue, 3 Dec 2019 20:44:40 +1100 (AEDT) Received: from pps.filterd (m0098393.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id xB39gEuN061759 for ; Tue, 3 Dec 2019 04:44:36 -0500 Received: from e06smtp07.uk.ibm.com (e06smtp07.uk.ibm.com [195.75.94.103]) by mx0a-001b2d01.pphosted.com with ESMTP id 2wm6s6ag4a-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Tue, 03 Dec 2019 04:44:36 -0500 Received: from localhost by e06smtp07.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 3 Dec 2019 09:44:33 -0000 Received: from b06cxnps4076.portsmouth.uk.ibm.com (9.149.109.198) by e06smtp07.uk.ibm.com (192.168.101.137) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Tue, 3 Dec 2019 09:44:30 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4076.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id xB39iTJv47841338 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 3 Dec 2019 09:44:29 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 173314203F; Tue, 3 Dec 2019 09:44:29 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id E4EBE42045; Tue, 3 Dec 2019 09:44:26 +0000 (GMT) Received: from in.ibm.com (unknown [9.124.35.39]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 3 Dec 2019 09:44:26 +0000 (GMT) Date: Tue, 3 Dec 2019 15:14:24 +0530 From: Bharata B Rao To: Hugh Dickins Subject: Re: [PATCH v11 0/7] KVM: PPC: Driver to manage pages of secure guest References: <20191125030631.7716-1-bharata@linux.ibm.com> <20191128050411.GF23438@in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) X-TM-AS-GCONF: 00 x-cbid: 19120309-0028-0000-0000-000003C3F85A X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19120309-0029-0000-0000-0000248710E9 Message-Id: <20191203094424.GA25855@in.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.95,18.0.572 definitions=2019-12-03_01:2019-11-29,2019-12-03 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 clxscore=1015 priorityscore=1501 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 impostorscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-1910280000 definitions=main-1912030079 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: bharata@linux.ibm.com Cc: linuxram@us.ibm.com, cclaudio@linux.ibm.com, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, jglisse@redhat.com, aneesh.kumar@linux.vnet.ibm.com, paulus@au1.ibm.com, sukadev@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org, hch@lst.de Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Sun, Dec 01, 2019 at 12:24:50PM -0800, Hugh Dickins wrote: > On Thu, 28 Nov 2019, Bharata B Rao wrote: > > On Mon, Nov 25, 2019 at 08:36:24AM +0530, Bharata B Rao wrote: > > > Hi, > > > > > > This is the next version of the patchset that adds required support > > > in the KVM hypervisor to run secure guests on PEF-enabled POWER platforms. > > > > > > > Here is a fix for the issue Hugh identified with the usage of ksm_madvise() > > in this patchset. It applies on top of this patchset. > > It looks correct to me, and I hope will not spoil your performance in any > way that matters. But I have to say, the patch would be so much clearer, > if you just named your bool "downgraded" instead of "downgrade". Thanks for confirming. Yes "downgraded" would have been more appropriate, will probably change it when we do any next change in this part of the code. Regards, Bharata. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bharata B Rao Date: Tue, 03 Dec 2019 09:56:24 +0000 Subject: Re: [PATCH v11 0/7] KVM: PPC: Driver to manage pages of secure guest Message-Id: <20191203094424.GA25855@in.ibm.com> List-Id: References: <20191125030631.7716-1-bharata@linux.ibm.com> <20191128050411.GF23438@in.ibm.com> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Hugh Dickins Cc: linuxppc-dev@lists.ozlabs.org, kvm-ppc@vger.kernel.org, linux-mm@kvack.org, paulus@au1.ibm.com, aneesh.kumar@linux.vnet.ibm.com, jglisse@redhat.com, cclaudio@linux.ibm.com, linuxram@us.ibm.com, sukadev@linux.vnet.ibm.com, hch@lst.de On Sun, Dec 01, 2019 at 12:24:50PM -0800, Hugh Dickins wrote: > On Thu, 28 Nov 2019, Bharata B Rao wrote: > > On Mon, Nov 25, 2019 at 08:36:24AM +0530, Bharata B Rao wrote: > > > Hi, > > > > > > This is the next version of the patchset that adds required support > > > in the KVM hypervisor to run secure guests on PEF-enabled POWER platforms. > > > > > > > Here is a fix for the issue Hugh identified with the usage of ksm_madvise() > > in this patchset. It applies on top of this patchset. > > It looks correct to me, and I hope will not spoil your performance in any > way that matters. But I have to say, the patch would be so much clearer, > if you just named your bool "downgraded" instead of "downgrade". Thanks for confirming. Yes "downgraded" would have been more appropriate, will probably change it when we do any next change in this part of the code. Regards, Bharata.