From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95198C432C0 for ; Tue, 3 Dec 2019 10:17:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 65EFB206DF for ; Tue, 3 Dec 2019 10:17:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="kTzLTcnG" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725774AbfLCKRj (ORCPT ); Tue, 3 Dec 2019 05:17:39 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:32948 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725773AbfLCKRj (ORCPT ); Tue, 3 Dec 2019 05:17:39 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9628309; Tue, 3 Dec 2019 11:17:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575368257; bh=oT8aVb9gFuG6LRGtXmKix4LSGzY7LvR7mDNzrD/+yns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kTzLTcnGXMWM4h61u/SIO3Yz8OFrRHkkF25jr033tOTzqQByAd2tS0T9ZNDXcyJWG Ukz5kOQbtIf8Zxx0YJoJ3wFK6rZmQegNF0huN693flPsXmRmHSGJTT/QMX7TbdC4YS D7d0nzyeLYGvTCg1VY33eEsI8KXneqlL7aHxLIx4= Date: Tue, 3 Dec 2019 12:17:30 +0200 From: Laurent Pinchart To: Boris Brezillon Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v3 18/21] drm/bridge: panel: Propage bus format/flags Message-ID: <20191203101730.GP4730@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-19-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191023154512.9762-19-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Boris, Thank you for the patch. On Wed, Oct 23, 2019 at 05:45:09PM +0200, Boris Brezillon wrote: > So that the previous bridge element in the chain knows which input > format the panel bridge expects. > > Signed-off-by: Boris Brezillon > --- > Changes in v3: > * Adjust things to match the new bus-format negotiation approach > * Use drm_atomic_helper_bridge_propagate_bus_fmt > * Don't implement ->atomic_check() (the core now takes care of bus > flags propagation) > > Changes in v2: > * Adjust things to match the new bus-format negotiation approach > --- > drivers/gpu/drm/bridge/panel.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c > index f4e293e7cf64..a70c363a2bd0 100644 > --- a/drivers/gpu/drm/bridge/panel.c > +++ b/drivers/gpu/drm/bridge/panel.c > @@ -127,6 +127,7 @@ static const struct drm_bridge_funcs panel_bridge_bridge_funcs = { > .enable = panel_bridge_enable, > .disable = panel_bridge_disable, > .post_disable = panel_bridge_post_disable, > + .atomic_get_input_bus_fmts = drm_atomic_helper_bridge_propagate_bus_fmt, Shouldn't the format be retrieved from the panel instead of from the connector ? We're moving towards removing connector creation from bridges, so I think it would be more future-proof. > }; > > /** -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79800C43215 for ; Tue, 3 Dec 2019 10:17:41 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5ABFB206E0 for ; Tue, 3 Dec 2019 10:17:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5ABFB206E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D176B6E46F; Tue, 3 Dec 2019 10:17:40 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 020876E46F for ; Tue, 3 Dec 2019 10:17:38 +0000 (UTC) Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D9628309; Tue, 3 Dec 2019 11:17:36 +0100 (CET) Date: Tue, 3 Dec 2019 12:17:30 +0200 From: Laurent Pinchart To: Boris Brezillon Subject: Re: [PATCH v3 18/21] drm/bridge: panel: Propage bus format/flags Message-ID: <20191203101730.GP4730@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-19-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191023154512.9762-19-boris.brezillon@collabora.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575368257; bh=oT8aVb9gFuG6LRGtXmKix4LSGzY7LvR7mDNzrD/+yns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kTzLTcnGXMWM4h61u/SIO3Yz8OFrRHkkF25jr033tOTzqQByAd2tS0T9ZNDXcyJWG Ukz5kOQbtIf8Zxx0YJoJ3wFK6rZmQegNF0huN693flPsXmRmHSGJTT/QMX7TbdC4YS D7d0nzyeLYGvTCg1VY33eEsI8KXneqlL7aHxLIx4= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SGkgQm9yaXMsCgpUaGFuayB5b3UgZm9yIHRoZSBwYXRjaC4KCk9uIFdlZCwgT2N0IDIzLCAyMDE5 IGF0IDA1OjQ1OjA5UE0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiBTbyB0aGF0IHRo ZSBwcmV2aW91cyBicmlkZ2UgZWxlbWVudCBpbiB0aGUgY2hhaW4ga25vd3Mgd2hpY2ggaW5wdXQK PiBmb3JtYXQgdGhlIHBhbmVsIGJyaWRnZSBleHBlY3RzLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEJv cmlzIEJyZXppbGxvbiA8Ym9yaXMuYnJlemlsbG9uQGNvbGxhYm9yYS5jb20+Cj4gLS0tCj4gQ2hh bmdlcyBpbiB2MzoKPiAqIEFkanVzdCB0aGluZ3MgdG8gbWF0Y2ggdGhlIG5ldyBidXMtZm9ybWF0 IG5lZ290aWF0aW9uIGFwcHJvYWNoCj4gKiBVc2UgZHJtX2F0b21pY19oZWxwZXJfYnJpZGdlX3By b3BhZ2F0ZV9idXNfZm10Cj4gKiBEb24ndCBpbXBsZW1lbnQgLT5hdG9taWNfY2hlY2soKSAodGhl IGNvcmUgbm93IHRha2VzIGNhcmUgb2YgYnVzCj4gICBmbGFncyBwcm9wYWdhdGlvbikKPiAKPiBD aGFuZ2VzIGluIHYyOgo+ICogQWRqdXN0IHRoaW5ncyB0byBtYXRjaCB0aGUgbmV3IGJ1cy1mb3Jt YXQgbmVnb3RpYXRpb24gYXBwcm9hY2gKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9w YW5lbC5jIHwgMSArCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKQo+IAo+IGRpZmYg LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BhbmVsLmMgYi9kcml2ZXJzL2dwdS9kcm0v YnJpZGdlL3BhbmVsLmMKPiBpbmRleCBmNGUyOTNlN2NmNjQuLmE3MGMzNjNhMmJkMCAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vYnJpZGdlL3BhbmVsLmMKPiArKysgYi9kcml2ZXJzL2dw dS9kcm0vYnJpZGdlL3BhbmVsLmMKPiBAQCAtMTI3LDYgKzEyNyw3IEBAIHN0YXRpYyBjb25zdCBz dHJ1Y3QgZHJtX2JyaWRnZV9mdW5jcyBwYW5lbF9icmlkZ2VfYnJpZGdlX2Z1bmNzID0gewo+ICAJ LmVuYWJsZSA9IHBhbmVsX2JyaWRnZV9lbmFibGUsCj4gIAkuZGlzYWJsZSA9IHBhbmVsX2JyaWRn ZV9kaXNhYmxlLAo+ICAJLnBvc3RfZGlzYWJsZSA9IHBhbmVsX2JyaWRnZV9wb3N0X2Rpc2FibGUs Cj4gKwkuYXRvbWljX2dldF9pbnB1dF9idXNfZm10cyA9IGRybV9hdG9taWNfaGVscGVyX2JyaWRn ZV9wcm9wYWdhdGVfYnVzX2ZtdCwKClNob3VsZG4ndCB0aGUgZm9ybWF0IGJlIHJldHJpZXZlZCBm cm9tIHRoZSBwYW5lbCBpbnN0ZWFkIG9mIGZyb20gdGhlCmNvbm5lY3RvciA/IFdlJ3JlIG1vdmlu ZyB0b3dhcmRzIHJlbW92aW5nIGNvbm5lY3RvciBjcmVhdGlvbiBmcm9tCmJyaWRnZXMsIHNvIEkg dGhpbmsgaXQgd291bGQgYmUgbW9yZSBmdXR1cmUtcHJvb2YuCgo+ICB9Owo+ICAKPiAgLyoqCgot LSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVs