From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25FEDC432C0 for ; Tue, 3 Dec 2019 12:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 085E120684 for ; Tue, 3 Dec 2019 12:42:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726098AbfLCMm2 (ORCPT ); Tue, 3 Dec 2019 07:42:28 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:57196 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725954AbfLCMm2 (ORCPT ); Tue, 3 Dec 2019 07:42:28 -0500 Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AA19128DB93; Tue, 3 Dec 2019 12:42:25 +0000 (GMT) Date: Tue, 3 Dec 2019 13:42:22 +0100 From: Boris Brezillon To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org Subject: Re: [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Message-ID: <20191203134222.4c20161f@collabora.com> In-Reply-To: <20191202171724.GS4929@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-20-boris.brezillon@collabora.com> <20191202171724.GS4929@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 2 Dec 2019 19:17:24 +0200 Laurent Pinchart wrote: > Hi Boris, > > Thank you for the patch. > > On Wed, Oct 23, 2019 at 05:45:10PM +0200, Boris Brezillon wrote: > > Add a new entry for the Toshiba LTA089AC29000 panel. > > > > Signed-off-by: Boris Brezillon > > --- > > Changes in v3: > > * None > > --- > > drivers/gpu/drm/panel/panel-simple.c | 36 ++++++++++++++++++++++++++++ > > 1 file changed, 36 insertions(+) > > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index 5d487686d25c..27c92b44bd95 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -2937,6 +2937,39 @@ static const struct panel_desc toshiba_lt089ac29000 = { > > .connector_type = DRM_MODE_CONNECTOR_LVDS, > > }; > > > > +static const struct drm_display_mode toshiba_lta089ac29000_mode = { > > + .clock = 79500, > > + .hdisplay = 1280, > > + .hsync_start = 1280 + 192, > > + .hsync_end = 1280 + 192 + 128, > > + .htotal = 1280 + 192 + 128 + 64, > > + .vdisplay = 768, > > + .vsync_start = 768 + 20, > > + .vsync_end = 768 + 20 + 7, > > + .vtotal = 768 + 20 + 7 + 3, > > + .vrefresh = 60, > > +}; > > + > > +static const struct panel_desc toshiba_lta089ac29000 = { > > + .modes = &toshiba_lta089ac29000_mode, > > + .num_modes = 1, > > + .size = { > > + .width = 194, > > + .height = 116, > > + }, > > + /* > > + * FIXME: > > + * The panel supports 2 bus formats: jeida-24 and jeida-18. The > > + * mode is selected through the 8b6b_SEL pin. If anyone ever needs > > + * support for jeida-18 we should probably parse the 'data-mapping' > > + * property. > > + * In the unlikely event where 8b6b_SEL is connected to a GPIO, we'd > > + * need a new infra to allow bus format negotiation at the panel level. > > + */ > > + .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_JEIDA, > > + .bus_flags = DRM_BUS_FLAG_DE_HIGH | DRM_BUS_FLAG_PIXDATA_DRIVE_POSEDGE, > > +}; > > + > > static const struct drm_display_mode tpk_f07a_0102_mode = { > > .clock = 33260, > > .hdisplay = 800, > > @@ -3392,6 +3425,9 @@ static const struct of_device_id platform_of_match[] = { > > }, { > > .compatible = "toshiba,lt089ac29000", > > .data = &toshiba_lt089ac29000, > > + }, { > > + .compatible = "toshiba,lta089ac29000", > > Is this really different than "toshiba,lt089ac29000" ? Both have the > exact same timing, the only difference is .bus_format, and according to > https://www.avnet-integrated.eu/fileadmin/user_upload/Files/Displays/Colour_TFT/LT089AC29000.pdf > the "toshiba,lt089ac29000" is an LVDS panel. I think you can select the LVDS format on the LTA variant which you can't do on the LT089AC29000. But I agree, LT089AC29000 is definitely not an DPI/RGB panel. At the same time, changing the definition is likely to break existing users :-(. > > > + .data = &toshiba_lta089ac29000, > > }, { > > .compatible = "tpk,f07a-0102", > > .data = &tpk_f07a_0102, > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61117C43215 for ; Tue, 3 Dec 2019 12:42:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 41F192080A for ; Tue, 3 Dec 2019 12:42:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 41F192080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AD43C6E4BB; Tue, 3 Dec 2019 12:42:28 +0000 (UTC) Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [46.235.227.227]) by gabe.freedesktop.org (Postfix) with ESMTPS id AB6AF6E4C7 for ; Tue, 3 Dec 2019 12:42:27 +0000 (UTC) Received: from localhost (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id AA19128DB93; Tue, 3 Dec 2019 12:42:25 +0000 (GMT) Date: Tue, 3 Dec 2019 13:42:22 +0100 From: Boris Brezillon To: Laurent Pinchart Subject: Re: [PATCH v3 19/21] drm/panel: simple: Add support for Toshiba LTA089AC29000 panel Message-ID: <20191203134222.4c20161f@collabora.com> In-Reply-To: <20191202171724.GS4929@pendragon.ideasonboard.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> <20191023154512.9762-20-boris.brezillon@collabora.com> <20191202171724.GS4929@pendragon.ideasonboard.com> Organization: Collabora X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Neil Armstrong , dri-devel@lists.freedesktop.org, Thierry Reding , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gTW9uLCAyIERlYyAyMDE5IDE5OjE3OjI0ICswMjAwCkxhdXJlbnQgUGluY2hhcnQgPGxhdXJl bnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4gd3JvdGU6Cgo+IEhpIEJvcmlzLAo+IAo+IFRo YW5rIHlvdSBmb3IgdGhlIHBhdGNoLgo+IAo+IE9uIFdlZCwgT2N0IDIzLCAyMDE5IGF0IDA1OjQ1 OjEwUE0gKzAyMDAsIEJvcmlzIEJyZXppbGxvbiB3cm90ZToKPiA+IEFkZCBhIG5ldyBlbnRyeSBm b3IgdGhlIFRvc2hpYmEgTFRBMDg5QUMyOTAwMCBwYW5lbC4KPiA+IAo+ID4gU2lnbmVkLW9mZi1i eTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AY29sbGFib3JhLmNvbT4KPiA+IC0t LQo+ID4gQ2hhbmdlcyBpbiB2MzoKPiA+ICogTm9uZQo+ID4gLS0tCj4gPiAgZHJpdmVycy9ncHUv ZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5jIHwgMzYgKysrKysrKysrKysrKysrKysrKysrKysrKysr Kwo+ID4gIDEgZmlsZSBjaGFuZ2VkLCAzNiBpbnNlcnRpb25zKCspCj4gPiAKPiA+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMgYi9kcml2ZXJzL2dwdS9k cm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+IGluZGV4IDVkNDg3Njg2ZDI1Yy4uMjdjOTJiNDRi ZDk1IDEwMDY0NAo+ID4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL3BhbmVsL3BhbmVsLXNpbXBsZS5j Cj4gPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vcGFuZWwvcGFuZWwtc2ltcGxlLmMKPiA+IEBAIC0y OTM3LDYgKzI5MzcsMzkgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBwYW5lbF9kZXNjIHRvc2hpYmFf bHQwODlhYzI5MDAwID0gewo+ID4gIAkuY29ubmVjdG9yX3R5cGUgPSBEUk1fTU9ERV9DT05ORUNU T1JfTFZEUywKPiA+ICB9Owo+ID4gIAo+ID4gK3N0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Rpc3Bs YXlfbW9kZSB0b3NoaWJhX2x0YTA4OWFjMjkwMDBfbW9kZSA9IHsKPiA+ICsJLmNsb2NrID0gNzk1 MDAsCj4gPiArCS5oZGlzcGxheSA9IDEyODAsCj4gPiArCS5oc3luY19zdGFydCA9IDEyODAgKyAx OTIsCj4gPiArCS5oc3luY19lbmQgPSAxMjgwICsgMTkyICsgMTI4LAo+ID4gKwkuaHRvdGFsID0g MTI4MCArIDE5MiArIDEyOCArIDY0LAo+ID4gKwkudmRpc3BsYXkgPSA3NjgsCj4gPiArCS52c3lu Y19zdGFydCA9IDc2OCArIDIwLAo+ID4gKwkudnN5bmNfZW5kID0gNzY4ICsgMjAgKyA3LAo+ID4g KwkudnRvdGFsID0gNzY4ICsgMjAgKyA3ICsgMywKPiA+ICsJLnZyZWZyZXNoID0gNjAsCj4gPiAr fTsKPiA+ICsKPiA+ICtzdGF0aWMgY29uc3Qgc3RydWN0IHBhbmVsX2Rlc2MgdG9zaGliYV9sdGEw ODlhYzI5MDAwID0gewo+ID4gKwkubW9kZXMgPSAmdG9zaGliYV9sdGEwODlhYzI5MDAwX21vZGUs Cj4gPiArCS5udW1fbW9kZXMgPSAxLAo+ID4gKwkuc2l6ZSA9IHsKPiA+ICsJCS53aWR0aCA9IDE5 NCwKPiA+ICsJCS5oZWlnaHQgPSAxMTYsCj4gPiArCX0sCj4gPiArCS8qCj4gPiArCSAqIEZJWE1F Ogo+ID4gKwkgKiBUaGUgcGFuZWwgc3VwcG9ydHMgMiBidXMgZm9ybWF0czogamVpZGEtMjQgYW5k IGplaWRhLTE4LiBUaGUKPiA+ICsJICogbW9kZSBpcyBzZWxlY3RlZCB0aHJvdWdoIHRoZSA4YjZi X1NFTCBwaW4uIElmIGFueW9uZSBldmVyIG5lZWRzCj4gPiArCSAqIHN1cHBvcnQgZm9yIGplaWRh LTE4IHdlIHNob3VsZCBwcm9iYWJseSBwYXJzZSB0aGUgJ2RhdGEtbWFwcGluZycKPiA+ICsJICog cHJvcGVydHkuCj4gPiArCSAqIEluIHRoZSB1bmxpa2VseSBldmVudCB3aGVyZSA4YjZiX1NFTCBp cyBjb25uZWN0ZWQgdG8gYSBHUElPLCB3ZSdkCj4gPiArCSAqIG5lZWQgYSBuZXcgaW5mcmEgdG8g YWxsb3cgYnVzIGZvcm1hdCBuZWdvdGlhdGlvbiBhdCB0aGUgcGFuZWwgbGV2ZWwuCj4gPiArCSAq Lwo+ID4gKwkuYnVzX2Zvcm1hdCA9IE1FRElBX0JVU19GTVRfUkdCODg4XzFYN1g0X0pFSURBLAo+ ID4gKwkuYnVzX2ZsYWdzID0gRFJNX0JVU19GTEFHX0RFX0hJR0ggfCBEUk1fQlVTX0ZMQUdfUElY REFUQV9EUklWRV9QT1NFREdFLAo+ID4gK307Cj4gPiArCj4gPiAgc3RhdGljIGNvbnN0IHN0cnVj dCBkcm1fZGlzcGxheV9tb2RlIHRwa19mMDdhXzAxMDJfbW9kZSA9IHsKPiA+ICAJLmNsb2NrID0g MzMyNjAsCj4gPiAgCS5oZGlzcGxheSA9IDgwMCwKPiA+IEBAIC0zMzkyLDYgKzM0MjUsOSBAQCBz dGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBwbGF0Zm9ybV9vZl9tYXRjaFtdID0gewo+ ID4gIAl9LCB7Cj4gPiAgCQkuY29tcGF0aWJsZSA9ICJ0b3NoaWJhLGx0MDg5YWMyOTAwMCIsCj4g PiAgCQkuZGF0YSA9ICZ0b3NoaWJhX2x0MDg5YWMyOTAwMCwKPiA+ICsJfSwgewo+ID4gKwkJLmNv bXBhdGlibGUgPSAidG9zaGliYSxsdGEwODlhYzI5MDAwIiwgIAo+IAo+IElzIHRoaXMgcmVhbGx5 IGRpZmZlcmVudCB0aGFuICJ0b3NoaWJhLGx0MDg5YWMyOTAwMCIgPyBCb3RoIGhhdmUgdGhlCj4g ZXhhY3Qgc2FtZSB0aW1pbmcsIHRoZSBvbmx5IGRpZmZlcmVuY2UgaXMgLmJ1c19mb3JtYXQsIGFu ZCBhY2NvcmRpbmcgdG8KPiBodHRwczovL3d3dy5hdm5ldC1pbnRlZ3JhdGVkLmV1L2ZpbGVhZG1p bi91c2VyX3VwbG9hZC9GaWxlcy9EaXNwbGF5cy9Db2xvdXJfVEZUL0xUMDg5QUMyOTAwMC5wZGYK PiB0aGUgInRvc2hpYmEsbHQwODlhYzI5MDAwIiBpcyBhbiBMVkRTIHBhbmVsLgoKSSB0aGluayB5 b3UgY2FuIHNlbGVjdCB0aGUgTFZEUyBmb3JtYXQgb24gdGhlIExUQSB2YXJpYW50IHdoaWNoIHlv dQpjYW4ndCBkbyBvbiB0aGUgTFQwODlBQzI5MDAwLiBCdXQgSSBhZ3JlZSwgTFQwODlBQzI5MDAw IGlzIGRlZmluaXRlbHkKbm90IGFuIERQSS9SR0IgcGFuZWwuIEF0IHRoZSBzYW1lIHRpbWUsIGNo YW5naW5nIHRoZSBkZWZpbml0aW9uIGlzCmxpa2VseSB0byBicmVhayBleGlzdGluZyB1c2VycyA6 LSguCgo+IAo+ID4gKwkJLmRhdGEgPSAmdG9zaGliYV9sdGEwODlhYzI5MDAwLAo+ID4gIAl9LCB7 Cj4gPiAgCQkuY29tcGF0aWJsZSA9ICJ0cGssZjA3YS0wMTAyIiwKPiA+ICAJCS5kYXRhID0gJnRw a19mMDdhXzAxMDIsICAKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNr dG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2Ry aS1kZXZlbA==