All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: virtio-fs@redhat.com
Subject: Re: [Virtio-fs] [PATCH 0/2] Convert to cap-ng
Date: Tue, 3 Dec 2019 09:17:59 -0500	[thread overview]
Message-ID: <20191203141759.GA7810@redhat.com> (raw)
In-Reply-To: <20191203131423.40962-1-dgilbert@redhat.com>

On Tue, Dec 03, 2019 at 01:14:21PM +0000, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
> 
> Hi,
>   This changes virtiofsd to use cap-ng rather than cap
> (qemu is moving in that direction).  It's a little painful
> because of an interaction with our sandboxing.
> 
> I intend to flatten the conversion into Vivek's patch that
> adds the libcap use.

It feels ugly that we store the parent process's state in a global
variable and all the threads load their state from there. At the
same time I don't have any good idea how to solve this problem given
libcap-ng relies on /proc being there. So I am fine with the patches.

Thanks
Vivek
> 
> Dave
> 
> Dr. David Alan Gilbert (2):
>   virtiofsd: cap-ng helpers
>   virtiofsd: Convert to libcap-ng
> 
>  Makefile                           |   2 +-
>  contrib/virtiofsd/Makefile.objs    |   2 -
>  contrib/virtiofsd/passthrough_ll.c | 162 +++++++++++++++++++----------
>  3 files changed, 106 insertions(+), 60 deletions(-)
> 
> -- 
> 2.23.0
> 


  parent reply	other threads:[~2019-12-03 14:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 13:14 [Virtio-fs] [PATCH 0/2] Convert to cap-ng Dr. David Alan Gilbert (git)
2019-12-03 13:14 ` [Virtio-fs] [PATCH 1/2] virtiofsd: cap-ng helpers Dr. David Alan Gilbert (git)
2019-12-04  7:20   ` misono.tomohiro
2019-12-04  9:11     ` Dr. David Alan Gilbert
2019-12-03 13:14 ` [Virtio-fs] [PATCH 2/2] virtiofsd: Convert to libcap-ng Dr. David Alan Gilbert (git)
2019-12-03 14:17 ` Vivek Goyal [this message]
2019-12-03 14:52   ` [Virtio-fs] [PATCH 0/2] Convert to cap-ng Dr. David Alan Gilbert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191203141759.GA7810@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=virtio-fs@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.