From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86BDDC43215 for ; Tue, 3 Dec 2019 22:43:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4FEDD20803 for ; Tue, 3 Dec 2019 22:43:01 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="X+aA1rBT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728744AbfLCWnA (ORCPT ); Tue, 3 Dec 2019 17:43:00 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:43421 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728707AbfLCWmv (ORCPT ); Tue, 3 Dec 2019 17:42:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575412970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+sDgbMqjO9PDnPDuImNP6HXuoqamT1anUKE/7ClETRA=; b=X+aA1rBTY+q2Jy+07ak2Fz1rKtZA7h/F/ulyQxVdO2wXNEoS/gv2WFTau2n2tlu0s4dOuK 6GUzweMwmDHRC62i64oM9BQncJzVe55dlqE+bTJwZE1IJm+WFNCJGJ2mAwtpVZO80sG8o6 N4QumWRd+pcvxp+jcCIukrDOOwjnGbQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-4k8qimMGOBeQPasm2opFyw-1; Tue, 03 Dec 2019 17:42:49 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 411EA800D54; Tue, 3 Dec 2019 22:42:47 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-90.bss.redhat.com [10.20.1.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6637F5DA32; Tue, 3 Dec 2019 22:42:43 +0000 (UTC) From: Lyude Paul To: intel-gfx@lists.freedesktop.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , Daniel Vetter , Chris Wilson , =?UTF-8?q?Ville=20Syrj=C3=A4l=C3=A4?= , Lee Shawn C , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] drm/i915: Assume 100% brightness when not in DPCD control mode Date: Tue, 3 Dec 2019 17:42:35 -0500 Message-Id: <20191203224236.230930-1-lyude@redhat.com> In-Reply-To: <87tv6hinv1.fsf@intel.com> References: <87tv6hinv1.fsf@intel.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 4k8qimMGOBeQPasm2opFyw-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed in the first place. This appears to be the case on the Lenovo ThinkPad X1 Extreme 2nd Generation, where the default value in these registers is always 0 on boot despite the fact the panel runs at max brightness by default. Getting the initial brightness value correct here is important as well, since the panel on this laptop doesn't behave well if it's ever put into DPCD control mode while the brightness level is programmed to 0. So, let's fix this by checking what the current backlight control mode is before reading the brightness level. If it's in DPCD control mode, we return the programmed brightness level. Otherwise we assume 100% brightness and return the highest possible brightness level. This also prevents us from accidentally programming a brightness level of 0. This is one of the many fixes that gets backlight controls working on the ThinkPad X1 Extreme 2nd Generation with optional 4K AMOLED screen. Changes since v1: * s/DP_EDP_DISPLAY_CONTROL_REGISTER/DP_EDP_BACKLIGHT_MODE_SET_REGISTER/ - Jani Signed-off-by: Lyude Paul --- .../drm/i915/display/intel_dp_aux_backlight.c | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c b/driver= s/gpu/drm/i915/display/intel_dp_aux_backlight.c index fad470553cf9..4d467e7d29eb 100644 --- a/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c +++ b/drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c @@ -59,8 +59,25 @@ static u32 intel_dp_aux_get_backlight(struct intel_conne= ctor *connector) { =09struct intel_dp *intel_dp =3D enc_to_intel_dp(&connector->encoder->base= ); =09u8 read_val[2] =3D { 0x0 }; +=09u8 mode_reg; =09u16 level =3D 0; =20 +=09if (drm_dp_dpcd_readb(&intel_dp->aux, +=09=09=09 DP_EDP_BACKLIGHT_MODE_SET_REGISTER, +=09=09=09 &mode_reg) !=3D 1) { +=09=09DRM_DEBUG_KMS("Failed to read the DPCD register 0x%x\n", +=09=09=09 DP_EDP_BACKLIGHT_MODE_SET_REGISTER); +=09=09return 0; +=09} + +=09/* +=09 * If we're not in DPCD control mode yet, the programmed brightness +=09 * value is meaningless and we should assume max brightness +=09 */ +=09if ((mode_reg & DP_EDP_BACKLIGHT_CONTROL_MODE_MASK) !=3D +=09 DP_EDP_BACKLIGHT_CONTROL_MODE_DPCD) +=09=09return connector->panel.backlight.max; + =09if (drm_dp_dpcd_read(&intel_dp->aux, DP_EDP_BACKLIGHT_BRIGHTNESS_MSB, =09=09=09 &read_val, sizeof(read_val)) < 0) { =09=09DRM_DEBUG_KMS("Failed to read DPCD register 0x%x\n", --=20 2.23.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D483C432C3 for ; Tue, 3 Dec 2019 22:42:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2953B206EC for ; Tue, 3 Dec 2019 22:42:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2953B206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6D7F06E9DA; Tue, 3 Dec 2019 22:42:53 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id B95A66E9DA for ; Tue, 3 Dec 2019 22:42:51 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-4k8qimMGOBeQPasm2opFyw-1; Tue, 03 Dec 2019 17:42:49 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 411EA800D54; Tue, 3 Dec 2019 22:42:47 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-90.bss.redhat.com [10.20.1.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6637F5DA32; Tue, 3 Dec 2019 22:42:43 +0000 (UTC) From: Lyude Paul To: intel-gfx@lists.freedesktop.org Subject: [PATCH v2] drm/i915: Assume 100% brightness when not in DPCD control mode Date: Tue, 3 Dec 2019 17:42:35 -0500 Message-Id: <20191203224236.230930-1-lyude@redhat.com> In-Reply-To: <87tv6hinv1.fsf@intel.com> References: <87tv6hinv1.fsf@intel.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 4k8qimMGOBeQPasm2opFyw-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575412970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+sDgbMqjO9PDnPDuImNP6HXuoqamT1anUKE/7ClETRA=; b=X+aA1rBTY+q2Jy+07ak2Fz1rKtZA7h/F/ulyQxVdO2wXNEoS/gv2WFTau2n2tlu0s4dOuK 6GUzweMwmDHRC62i64oM9BQncJzVe55dlqE+bTJwZE1IJm+WFNCJGJ2mAwtpVZO80sG8o6 N4QumWRd+pcvxp+jcCIukrDOOwjnGbQ= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rodrigo Vivi , Lee Shawn C Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Q3VycmVudGx5IHdlIGFsd2F5cyBkZXRlcm1pbmUgdGhlIGluaXRpYWwgcGFuZWwgYnJpZ2h0bmVz cyBsZXZlbCBieQpzaW1wbHkgcmVhZGluZyB0aGUgdmFsdWUgZnJvbSBEUF9FRFBfQkFDS0xJR0hU X0JSSUdIVE5FU1NfTVNCL0xTQi4gVGhpcwpzZWVtcyB3cm9uZyB0aG91Z2gsIGJlY2F1c2UgaWYg dGhlIHBhbmVsIGlzIG5vdCBjdXJyZW50bHkgaW4gRFBDRApjb250cm9sIG1vZGUgdGhlcmUncyBu b3QgcmVhbGx5IGFueSByZWFzb24gd2h5IHRoZXJlIHdvdWxkIGJlIGFueQpicmlnaHRuZXNzIHZh bHVlIHByb2dyYW1tZWQgaW4gdGhlIGZpcnN0IHBsYWNlLgoKVGhpcyBhcHBlYXJzIHRvIGJlIHRo ZSBjYXNlIG9uIHRoZSBMZW5vdm8gVGhpbmtQYWQgWDEgRXh0cmVtZSAybmQKR2VuZXJhdGlvbiwg d2hlcmUgdGhlIGRlZmF1bHQgdmFsdWUgaW4gdGhlc2UgcmVnaXN0ZXJzIGlzIGFsd2F5cyAwIG9u CmJvb3QgZGVzcGl0ZSB0aGUgZmFjdCB0aGUgcGFuZWwgcnVucyBhdCBtYXggYnJpZ2h0bmVzcyBi eSBkZWZhdWx0LgpHZXR0aW5nIHRoZSBpbml0aWFsIGJyaWdodG5lc3MgdmFsdWUgY29ycmVjdCBo ZXJlIGlzIGltcG9ydGFudCBhcyB3ZWxsLApzaW5jZSB0aGUgcGFuZWwgb24gdGhpcyBsYXB0b3Ag ZG9lc24ndCBiZWhhdmUgd2VsbCBpZiBpdCdzIGV2ZXIgcHV0IGludG8KRFBDRCBjb250cm9sIG1v ZGUgd2hpbGUgdGhlIGJyaWdodG5lc3MgbGV2ZWwgaXMgcHJvZ3JhbW1lZCB0byAwLgoKU28sIGxl dCdzIGZpeCB0aGlzIGJ5IGNoZWNraW5nIHdoYXQgdGhlIGN1cnJlbnQgYmFja2xpZ2h0IGNvbnRy b2wgbW9kZQppcyBiZWZvcmUgcmVhZGluZyB0aGUgYnJpZ2h0bmVzcyBsZXZlbC4gSWYgaXQncyBp biBEUENEIGNvbnRyb2wgbW9kZSwgd2UKcmV0dXJuIHRoZSBwcm9ncmFtbWVkIGJyaWdodG5lc3Mg bGV2ZWwuIE90aGVyd2lzZSB3ZSBhc3N1bWUgMTAwJQpicmlnaHRuZXNzIGFuZCByZXR1cm4gdGhl IGhpZ2hlc3QgcG9zc2libGUgYnJpZ2h0bmVzcyBsZXZlbC4gVGhpcyBhbHNvCnByZXZlbnRzIHVz IGZyb20gYWNjaWRlbnRhbGx5IHByb2dyYW1taW5nIGEgYnJpZ2h0bmVzcyBsZXZlbCBvZiAwLgoK VGhpcyBpcyBvbmUgb2YgdGhlIG1hbnkgZml4ZXMgdGhhdCBnZXRzIGJhY2tsaWdodCBjb250cm9s cyB3b3JraW5nIG9uCnRoZSBUaGlua1BhZCBYMSBFeHRyZW1lIDJuZCBHZW5lcmF0aW9uIHdpdGgg b3B0aW9uYWwgNEsgQU1PTEVEIHNjcmVlbi4KCkNoYW5nZXMgc2luY2UgdjE6Ciogcy9EUF9FRFBf RElTUExBWV9DT05UUk9MX1JFR0lTVEVSL0RQX0VEUF9CQUNLTElHSFRfTU9ERV9TRVRfUkVHSVNU RVIvCiAgLSBKYW5pCgpTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t PgotLS0KIC4uLi9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYyAgIHwg MTcgKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFj a2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwX2F1eF9iYWNr bGlnaHQuYwppbmRleCBmYWQ0NzA1NTNjZjkuLjRkNDY3ZTdkMjllYiAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKQEAg LTU5LDggKzU5LDI1IEBAIHN0YXRpYyB1MzIgaW50ZWxfZHBfYXV4X2dldF9iYWNrbGlnaHQoc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQogewogCXN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmNvbm5lY3Rvci0+ZW5jb2Rlci0+YmFzZSk7CiAJdTgg cmVhZF92YWxbMl0gPSB7IDB4MCB9OworCXU4IG1vZGVfcmVnOwogCXUxNiBsZXZlbCA9IDA7CiAK KwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCisJCQkgICAgICBEUF9FRFBf QkFDS0xJR0hUX01PREVfU0VUX1JFR0lTVEVSLAorCQkJICAgICAgJm1vZGVfcmVnKSAhPSAxKSB7 CisJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byByZWFkIHRoZSBEUENEIHJlZ2lzdGVyIDB4JXhc biIsCisJCQkgICAgICBEUF9FRFBfQkFDS0xJR0hUX01PREVfU0VUX1JFR0lTVEVSKTsKKwkJcmV0 dXJuIDA7CisJfQorCisJLyoKKwkgKiBJZiB3ZSdyZSBub3QgaW4gRFBDRCBjb250cm9sIG1vZGUg eWV0LCB0aGUgcHJvZ3JhbW1lZCBicmlnaHRuZXNzCisJICogdmFsdWUgaXMgbWVhbmluZ2xlc3Mg YW5kIHdlIHNob3VsZCBhc3N1bWUgbWF4IGJyaWdodG5lc3MKKwkgKi8KKwlpZiAoKG1vZGVfcmVn ICYgRFBfRURQX0JBQ0tMSUdIVF9DT05UUk9MX01PREVfTUFTSykgIT0KKwkgICAgRFBfRURQX0JB Q0tMSUdIVF9DT05UUk9MX01PREVfRFBDRCkKKwkJcmV0dXJuIGNvbm5lY3Rvci0+cGFuZWwuYmFj a2xpZ2h0Lm1heDsKKwogCWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9F RFBfQkFDS0xJR0hUX0JSSUdIVE5FU1NfTVNCLAogCQkJICAgICAmcmVhZF92YWwsIHNpemVvZihy ZWFkX3ZhbCkpIDwgMCkgewogCQlEUk1fREVCVUdfS01TKCJGYWlsZWQgdG8gcmVhZCBEUENEIHJl Z2lzdGVyIDB4JXhcbiIsCi0tIAoyLjIzLjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A787C432C0 for ; Tue, 3 Dec 2019 22:42:53 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E86FE206EC for ; Tue, 3 Dec 2019 22:42:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E86FE206EC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8BDF46E9D9; Tue, 3 Dec 2019 22:42:52 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id B8EB06E9D9 for ; Tue, 3 Dec 2019 22:42:51 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-216-4k8qimMGOBeQPasm2opFyw-1; Tue, 03 Dec 2019 17:42:49 -0500 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 411EA800D54; Tue, 3 Dec 2019 22:42:47 +0000 (UTC) Received: from malachite.bss.redhat.com (dhcp-10-20-1-90.bss.redhat.com [10.20.1.90]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6637F5DA32; Tue, 3 Dec 2019 22:42:43 +0000 (UTC) From: Lyude Paul To: intel-gfx@lists.freedesktop.org Date: Tue, 3 Dec 2019 17:42:35 -0500 Message-Id: <20191203224236.230930-1-lyude@redhat.com> In-Reply-To: <87tv6hinv1.fsf@intel.com> References: <87tv6hinv1.fsf@intel.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-MC-Unique: 4k8qimMGOBeQPasm2opFyw-1 X-Mimecast-Spam-Score: 0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575412970; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=+sDgbMqjO9PDnPDuImNP6HXuoqamT1anUKE/7ClETRA=; b=X+aA1rBTY+q2Jy+07ak2Fz1rKtZA7h/F/ulyQxVdO2wXNEoS/gv2WFTau2n2tlu0s4dOuK 6GUzweMwmDHRC62i64oM9BQncJzVe55dlqE+bTJwZE1IJm+WFNCJGJ2mAwtpVZO80sG8o6 N4QumWRd+pcvxp+jcCIukrDOOwjnGbQ= Subject: [Intel-gfx] [PATCH v2] drm/i915: Assume 100% brightness when not in DPCD control mode X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Airlie , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Q3VycmVudGx5IHdlIGFsd2F5cyBkZXRlcm1pbmUgdGhlIGluaXRpYWwgcGFuZWwgYnJpZ2h0bmVz cyBsZXZlbCBieQpzaW1wbHkgcmVhZGluZyB0aGUgdmFsdWUgZnJvbSBEUF9FRFBfQkFDS0xJR0hU X0JSSUdIVE5FU1NfTVNCL0xTQi4gVGhpcwpzZWVtcyB3cm9uZyB0aG91Z2gsIGJlY2F1c2UgaWYg dGhlIHBhbmVsIGlzIG5vdCBjdXJyZW50bHkgaW4gRFBDRApjb250cm9sIG1vZGUgdGhlcmUncyBu b3QgcmVhbGx5IGFueSByZWFzb24gd2h5IHRoZXJlIHdvdWxkIGJlIGFueQpicmlnaHRuZXNzIHZh bHVlIHByb2dyYW1tZWQgaW4gdGhlIGZpcnN0IHBsYWNlLgoKVGhpcyBhcHBlYXJzIHRvIGJlIHRo ZSBjYXNlIG9uIHRoZSBMZW5vdm8gVGhpbmtQYWQgWDEgRXh0cmVtZSAybmQKR2VuZXJhdGlvbiwg d2hlcmUgdGhlIGRlZmF1bHQgdmFsdWUgaW4gdGhlc2UgcmVnaXN0ZXJzIGlzIGFsd2F5cyAwIG9u CmJvb3QgZGVzcGl0ZSB0aGUgZmFjdCB0aGUgcGFuZWwgcnVucyBhdCBtYXggYnJpZ2h0bmVzcyBi eSBkZWZhdWx0LgpHZXR0aW5nIHRoZSBpbml0aWFsIGJyaWdodG5lc3MgdmFsdWUgY29ycmVjdCBo ZXJlIGlzIGltcG9ydGFudCBhcyB3ZWxsLApzaW5jZSB0aGUgcGFuZWwgb24gdGhpcyBsYXB0b3Ag ZG9lc24ndCBiZWhhdmUgd2VsbCBpZiBpdCdzIGV2ZXIgcHV0IGludG8KRFBDRCBjb250cm9sIG1v ZGUgd2hpbGUgdGhlIGJyaWdodG5lc3MgbGV2ZWwgaXMgcHJvZ3JhbW1lZCB0byAwLgoKU28sIGxl dCdzIGZpeCB0aGlzIGJ5IGNoZWNraW5nIHdoYXQgdGhlIGN1cnJlbnQgYmFja2xpZ2h0IGNvbnRy b2wgbW9kZQppcyBiZWZvcmUgcmVhZGluZyB0aGUgYnJpZ2h0bmVzcyBsZXZlbC4gSWYgaXQncyBp biBEUENEIGNvbnRyb2wgbW9kZSwgd2UKcmV0dXJuIHRoZSBwcm9ncmFtbWVkIGJyaWdodG5lc3Mg bGV2ZWwuIE90aGVyd2lzZSB3ZSBhc3N1bWUgMTAwJQpicmlnaHRuZXNzIGFuZCByZXR1cm4gdGhl IGhpZ2hlc3QgcG9zc2libGUgYnJpZ2h0bmVzcyBsZXZlbC4gVGhpcyBhbHNvCnByZXZlbnRzIHVz IGZyb20gYWNjaWRlbnRhbGx5IHByb2dyYW1taW5nIGEgYnJpZ2h0bmVzcyBsZXZlbCBvZiAwLgoK VGhpcyBpcyBvbmUgb2YgdGhlIG1hbnkgZml4ZXMgdGhhdCBnZXRzIGJhY2tsaWdodCBjb250cm9s cyB3b3JraW5nIG9uCnRoZSBUaGlua1BhZCBYMSBFeHRyZW1lIDJuZCBHZW5lcmF0aW9uIHdpdGgg b3B0aW9uYWwgNEsgQU1PTEVEIHNjcmVlbi4KCkNoYW5nZXMgc2luY2UgdjE6Ciogcy9EUF9FRFBf RElTUExBWV9DT05UUk9MX1JFR0lTVEVSL0RQX0VEUF9CQUNLTElHSFRfTU9ERV9TRVRfUkVHSVNU RVIvCiAgLSBKYW5pCgpTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQYXVsIDxseXVkZUByZWRoYXQuY29t PgotLS0KIC4uLi9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwX2F1eF9iYWNrbGlnaHQuYyAgIHwg MTcgKysrKysrKysrKysrKysrKysKIDEgZmlsZSBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCspCgpk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFj a2xpZ2h0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2RwX2F1eF9iYWNr bGlnaHQuYwppbmRleCBmYWQ0NzA1NTNjZjkuLjRkNDY3ZTdkMjllYiAxMDA2NDQKLS0tIGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKKysrIGIv ZHJpdmVycy9ncHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kcF9hdXhfYmFja2xpZ2h0LmMKQEAg LTU5LDggKzU5LDI1IEBAIHN0YXRpYyB1MzIgaW50ZWxfZHBfYXV4X2dldF9iYWNrbGlnaHQoc3Ry dWN0IGludGVsX2Nvbm5lY3RvciAqY29ubmVjdG9yKQogewogCXN0cnVjdCBpbnRlbF9kcCAqaW50 ZWxfZHAgPSBlbmNfdG9faW50ZWxfZHAoJmNvbm5lY3Rvci0+ZW5jb2Rlci0+YmFzZSk7CiAJdTgg cmVhZF92YWxbMl0gPSB7IDB4MCB9OworCXU4IG1vZGVfcmVnOwogCXUxNiBsZXZlbCA9IDA7CiAK KwlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCisJCQkgICAgICBEUF9FRFBf QkFDS0xJR0hUX01PREVfU0VUX1JFR0lTVEVSLAorCQkJICAgICAgJm1vZGVfcmVnKSAhPSAxKSB7 CisJCURSTV9ERUJVR19LTVMoIkZhaWxlZCB0byByZWFkIHRoZSBEUENEIHJlZ2lzdGVyIDB4JXhc biIsCisJCQkgICAgICBEUF9FRFBfQkFDS0xJR0hUX01PREVfU0VUX1JFR0lTVEVSKTsKKwkJcmV0 dXJuIDA7CisJfQorCisJLyoKKwkgKiBJZiB3ZSdyZSBub3QgaW4gRFBDRCBjb250cm9sIG1vZGUg eWV0LCB0aGUgcHJvZ3JhbW1lZCBicmlnaHRuZXNzCisJICogdmFsdWUgaXMgbWVhbmluZ2xlc3Mg YW5kIHdlIHNob3VsZCBhc3N1bWUgbWF4IGJyaWdodG5lc3MKKwkgKi8KKwlpZiAoKG1vZGVfcmVn ICYgRFBfRURQX0JBQ0tMSUdIVF9DT05UUk9MX01PREVfTUFTSykgIT0KKwkgICAgRFBfRURQX0JB Q0tMSUdIVF9DT05UUk9MX01PREVfRFBDRCkKKwkJcmV0dXJuIGNvbm5lY3Rvci0+cGFuZWwuYmFj a2xpZ2h0Lm1heDsKKwogCWlmIChkcm1fZHBfZHBjZF9yZWFkKCZpbnRlbF9kcC0+YXV4LCBEUF9F RFBfQkFDS0xJR0hUX0JSSUdIVE5FU1NfTVNCLAogCQkJICAgICAmcmVhZF92YWwsIHNpemVvZihy ZWFkX3ZhbCkpIDwgMCkgewogCQlEUk1fREVCVUdfS01TKCJGYWlsZWQgdG8gcmVhZCBEUENEIHJl Z2lzdGVyIDB4JXhcbiIsCi0tIAoyLjIzLjAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2ludGVsLWdmeA==