From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B92A6C43603 for ; Wed, 4 Dec 2019 20:37:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 963D52073B for ; Wed, 4 Dec 2019 20:37:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728282AbfLDUhU (ORCPT ); Wed, 4 Dec 2019 15:37:20 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:36328 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727911AbfLDUhT (ORCPT ); Wed, 4 Dec 2019 15:37:19 -0500 Received: from localhost (unknown [IPv6:2601:601:9f00:1c3::3d5]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id EF65414D78C45; Wed, 4 Dec 2019 12:37:18 -0800 (PST) Date: Wed, 04 Dec 2019 12:37:18 -0800 (PST) Message-Id: <20191204.123718.1152659362924451799.davem@davemloft.net> To: grygorii.strashko@ti.com Cc: netdev@vger.kernel.org, ivan.khoronzhuk@linaro.org, nsekhar@ti.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: ethernet: ti: davinci_cpdma: fix warning "device driver frees DMA memory with different size" From: David Miller In-Reply-To: <20191204165029.9264-1-grygorii.strashko@ti.com> References: <20191204165029.9264-1-grygorii.strashko@ti.com> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Wed, 04 Dec 2019 12:37:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Grygorii Strashko Date: Wed, 4 Dec 2019 18:50:29 +0200 > @@ -1018,7 +1018,7 @@ static int cpdma_chan_submit_si(struct submit_info *si) > struct cpdma_chan *chan = si->chan; > struct cpdma_ctlr *ctlr = chan->ctlr; > int len = si->len; > - int swlen = len; > + int swlen; > struct cpdma_desc __iomem *desc; > dma_addr_t buffer; > u32 mode; > @@ -1040,6 +1040,7 @@ static int cpdma_chan_submit_si(struct submit_info *si) > chan->stats.runt_transmit_buff++; > } > > + swlen = len; > mode = CPDMA_DESC_OWNER | CPDMA_DESC_SOP | CPDMA_DESC_EOP; > cpdma_desc_to_port(chan, mode, si->directed); > > -- > 2.17.1 > Now there is no reason to keep a separate swlen variable. The integral value is always consumed as the length before the descriptor bits are added to it. Therefore you can just use 'len' everywhere in this function now.