From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE437C43215 for ; Wed, 4 Dec 2019 02:39:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 87F3D2068E for ; Wed, 4 Dec 2019 02:39:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575427173; bh=gzYyVFtj2t/t6DxxRUeD141hKdVGvS4D0XfbvzUCn3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=dhooyoU1tXmsTcpiriuNmfdA/TI+VNTB4s8Rpkf7HaIlwKNJiVwsItU4SezbbVf3G UErIjSFBdqIn+HRrlhd8ERLFCc28/X4F0mG27wGpw1hm2x+viP4sgfKqqVsXXO7YbJ 34l0cW2N8iWsIg1agcwZ1jiJ+XCfEAZ104N0iMkQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726896AbfLDCjc (ORCPT ); Tue, 3 Dec 2019 21:39:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:37668 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726189AbfLDCjc (ORCPT ); Tue, 3 Dec 2019 21:39:32 -0500 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8642E20640; Wed, 4 Dec 2019 02:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575427171; bh=gzYyVFtj2t/t6DxxRUeD141hKdVGvS4D0XfbvzUCn3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yXPip5TDdP4yZuS4AAiHPCD50dWrLL1pUnMg00G06iErfCaqOK0cAzlSSkxSnfOZc 2ObTZdorEKBXOY0timyFw44f+soGrTj734MCby4EOOpzsUFgeFvPODVGLekueE8Jp1 yi8Tu1rARAUT7R6lWdPGHLSvvodk3VaBwz6DabRk= Date: Wed, 4 Dec 2019 10:39:21 +0800 From: Shawn Guo To: Anson Huang Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Linux-imx@nxp.com Subject: Re: [PATCH 3/3] ARM: dts: imx6sll: Add Rev A board support Message-ID: <20191204023920.GO9767@dragon> References: <1573033650-11848-1-git-send-email-Anson.Huang@nxp.com> <1573033650-11848-3-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1573033650-11848-3-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Nov 06, 2019 at 05:47:30PM +0800, Anson Huang wrote: > i.MX6SLL EVK Rev A board is same with latest i.MX6SLL EVK board except > eMMC can ONLY run at HS200 mode, add support for this board. > > Signed-off-by: Anson Huang > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6sll-evk-reva.dts | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6sll-evk-reva.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 71f08e7..3845bbf 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -557,6 +557,7 @@ dtb-$(CONFIG_SOC_IMX6SL) += \ > imx6sl-warp.dtb > dtb-$(CONFIG_SOC_IMX6SLL) += \ > imx6sll-evk.dtb \ > + imx6sll-evk-reva.dtb \ > imx6sll-kobo-clarahd.dtb > dtb-$(CONFIG_SOC_IMX6SX) += \ > imx6sx-nitrogen6sx.dtb \ > diff --git a/arch/arm/boot/dts/imx6sll-evk-reva.dts b/arch/arm/boot/dts/imx6sll-evk-reva.dts > new file mode 100644 > index 0000000..7ca2563 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6sll-evk-reva.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2016 Freescale Semiconductor, Inc. > + * Copyright 2017-2019 NXP. > + * > + */ > + > +#include "imx6sll-evk.dts" > + > +&usdhc2 { > + compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc"; It looks odd to me that we need to deal with a board level difference with a SoC level compatible. The USDHC compatible should be solely determined by the IP programming model, not the board level capability. Shawn > +}; > -- > 2.7.4 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4DE91C432C0 for ; Wed, 4 Dec 2019 02:39:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B52320640 for ; Wed, 4 Dec 2019 02:39:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="JjBWQESR"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="yXPip5TD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1B52320640 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wDhHBVOUp9Gud3PwUJ4aBrWQjw9BeN3mivszggmML9I=; b=JjBWQESR+ZD0sO SUL89ug6cOlmc6+IiEyZwfaotzmQH+ywlenMFJM1S0BbOz3xqc4TLakzKWrna+MZf/aZFmms1jZSg q9FEZ0LXv/MquVwHj1tQ4RsSbIYHTjJcD+w/fXViWNnVGv32iHfPlArMuEu4Q/Gno6pdBbYxi0UCu 3U+feVFqDvCsVhcXCXES2a/URjOmJt6xjY23C1A38C74FjhSirgfXPjpSnGV/XENnA3D+2kG4wIvq h84ARvMWGLiuGj6m7acsTCr9gFg1WrI2ioS7yVuDRV0HzKT3SqsSJTqpg1Qp/KHd5hX38Gvq6El1H oiqqWufCHY0ntQmKkCpw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1icKZj-0003F4-94; Wed, 04 Dec 2019 02:39:35 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1icKZf-0003Ec-TM for linux-arm-kernel@lists.infradead.org; Wed, 04 Dec 2019 02:39:34 +0000 Received: from dragon (98.142.130.235.16clouds.com [98.142.130.235]) (using TLSv1.2 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8642E20640; Wed, 4 Dec 2019 02:39:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575427171; bh=gzYyVFtj2t/t6DxxRUeD141hKdVGvS4D0XfbvzUCn3k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=yXPip5TDdP4yZuS4AAiHPCD50dWrLL1pUnMg00G06iErfCaqOK0cAzlSSkxSnfOZc 2ObTZdorEKBXOY0timyFw44f+soGrTj734MCby4EOOpzsUFgeFvPODVGLekueE8Jp1 yi8Tu1rARAUT7R6lWdPGHLSvvodk3VaBwz6DabRk= Date: Wed, 4 Dec 2019 10:39:21 +0800 From: Shawn Guo To: Anson Huang Subject: Re: [PATCH 3/3] ARM: dts: imx6sll: Add Rev A board support Message-ID: <20191204023920.GO9767@dragon> References: <1573033650-11848-1-git-send-email-Anson.Huang@nxp.com> <1573033650-11848-3-git-send-email-Anson.Huang@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1573033650-11848-3-git-send-email-Anson.Huang@nxp.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191203_183931_969005_6C1A864A X-CRM114-Status: GOOD ( 16.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, s.hauer@pengutronix.de, linux-kernel@vger.kernel.org, robh+dt@kernel.org, Linux-imx@nxp.com, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 06, 2019 at 05:47:30PM +0800, Anson Huang wrote: > i.MX6SLL EVK Rev A board is same with latest i.MX6SLL EVK board except > eMMC can ONLY run at HS200 mode, add support for this board. > > Signed-off-by: Anson Huang > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/imx6sll-evk-reva.dts | 12 ++++++++++++ > 2 files changed, 13 insertions(+) > create mode 100644 arch/arm/boot/dts/imx6sll-evk-reva.dts > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 71f08e7..3845bbf 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -557,6 +557,7 @@ dtb-$(CONFIG_SOC_IMX6SL) += \ > imx6sl-warp.dtb > dtb-$(CONFIG_SOC_IMX6SLL) += \ > imx6sll-evk.dtb \ > + imx6sll-evk-reva.dtb \ > imx6sll-kobo-clarahd.dtb > dtb-$(CONFIG_SOC_IMX6SX) += \ > imx6sx-nitrogen6sx.dtb \ > diff --git a/arch/arm/boot/dts/imx6sll-evk-reva.dts b/arch/arm/boot/dts/imx6sll-evk-reva.dts > new file mode 100644 > index 0000000..7ca2563 > --- /dev/null > +++ b/arch/arm/boot/dts/imx6sll-evk-reva.dts > @@ -0,0 +1,12 @@ > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > +/* > + * Copyright 2016 Freescale Semiconductor, Inc. > + * Copyright 2017-2019 NXP. > + * > + */ > + > +#include "imx6sll-evk.dts" > + > +&usdhc2 { > + compatible = "fsl,imx6sll-usdhc", "fsl,imx6sx-usdhc"; It looks odd to me that we need to deal with a board level difference with a SoC level compatible. The USDHC compatible should be solely determined by the IP programming model, not the board level capability. Shawn > +}; > -- > 2.7.4 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel