All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-mmc@vger.kernel.org, Ulf Hansson <ulf.hansson@linaro.org>,
	Phil Elwell <phil@raspberrypi.org>
Subject: Re: [PATCH] mmc: spi: Toggle SPI polarity, do not hardcode it
Date: Wed, 4 Dec 2019 17:20:06 +0000	[thread overview]
Message-ID: <20191204172006.GY1998@sirena.org.uk> (raw)
In-Reply-To: <20191204152749.12652-1-linus.walleij@linaro.org>

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

On Wed, Dec 04, 2019 at 04:27:49PM +0100, Linus Walleij wrote:
> The code in mmc_spi_initsequence() tries to send a burst with
> high chipselect and for this reason hardcodes the device into
> SPI_CS_HIGH.

Reviewed-by: Mark Brown <broonie@kernel.org>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2019-12-04 17:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-04 15:27 [PATCH] mmc: spi: Toggle SPI polarity, do not hardcode it Linus Walleij
2019-12-04 17:20 ` Mark Brown [this message]
2019-12-10  9:51 ` Ulf Hansson
2019-12-10 23:10   ` Linus Walleij
2019-12-16 12:09     ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191204172006.GY1998@sirena.org.uk \
    --to=broonie@kernel.org \
    --cc=linus.walleij@linaro.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=phil@raspberrypi.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.