From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B2EC2BD09 for ; Thu, 5 Dec 2019 10:38:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E2FF62464D for ; Thu, 5 Dec 2019 10:38:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E2FF62464D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=intel-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 85BD36F5FF; Thu, 5 Dec 2019 10:38:17 +0000 (UTC) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1608F6F5FF for ; Thu, 5 Dec 2019 10:38:16 +0000 (UTC) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Dec 2019 02:38:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,281,1571727600"; d="scan'208";a="219167014" Received: from stinkbox.fi.intel.com (HELO stinkbox) ([10.237.72.174]) by fmsmga001.fm.intel.com with SMTP; 05 Dec 2019 02:38:12 -0800 Received: by stinkbox (sSMTP sendmail emulation); Thu, 05 Dec 2019 12:38:12 +0200 Date: Thu, 5 Dec 2019 12:38:12 +0200 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: =?iso-8859-1?Q?Jos=E9?= Roberto de Souza Message-ID: <20191205103812.GF1208@intel.com> References: <20191204205510.119853-1-jose.souza@intel.com> <20191204205510.119853-3-jose.souza@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191204205510.119853-3-jose.souza@intel.com> User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [Intel-gfx] [PATCH v2 3/3] drm/i915/display: Refactor intel_commit_modeset_disables() X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: intel-gfx@lists.freedesktop.org, Lucas De Marchi Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" T24gV2VkLCBEZWMgMDQsIDIwMTkgYXQgMTI6NTU6MTBQTSAtMDgwMCwgSm9zw6kgUm9iZXJ0byBk ZSBTb3V6YSB3cm90ZToKPiBDb21taXQgOWM3MjJlMTdjMWI5ICgiZHJtL2k5MTU6IERpc2FibGUg cGlwZXMgaW4gcmV2ZXJzZSBvcmRlciIpCj4gcmV2ZXJ0ZWQgdGhlIG9yZGVyIHRoYXQgcGlwZXMg Z2V0cyBkaXNhYmxlZCBiZWNhdXNlIG9mIFRHTAo+IG1hc3Rlci9zbGF2ZSByZWxhdGlvbnNoaXAg YmV0d2VlbiB0cmFuc2NvZGVycyBpbiBNU1QgbW9kZS4KPiAKPiBCdXQgYXMgc3RhdGVkIGluIGEg Y29tbWVudCBpbiBza2xfY29tbWl0X21vZGVzZXRfZW5hYmxlcygpIHRoZQo+IGVuYWJsaW5nIG9y ZGVyIGlzIG5vdCBhbHdheXMgY3Jlc2NlbnQsIHBvc3NpYmx5IGNhdXNpbmcgcHJldmlvdXNseQo+ IHNlbGVjdGVkIHNsYXZlIHRyYW5zY29kZXIgYmVpbmcgZW5hYmxlZCBiZWZvcmUgbWFzdGVyIHNv IGFub3RoZXIKPiBhcHByb2FjaCB3aWxsIGJlIG5lZWRlZCB0byBzZWxlY3QgYSB0cmFuc2NvZGVy IHRvIG1hc3RlciBpbiBNU1QgbW9kZS4KPiBJdCB3aWxsIGJlIHNpbWlsYXIgdG8gdGhlIGFwcHJv YWNoIHRha2VuIGluIHBvcnQgc3luYy4KPiAKPiBCdXQgaW5zdGVhZCBvZiBpbXBsZW1lbnQgc29t ZXRoaW5nIGxpa2UKPiBpbnRlbF90cmFuc19wb3J0X3N5bmNfbW9kZXNldF9kaXNhYmxlcygpIHRv IE1TVCBsZXRzIHNpbXBseSBpdCBhbmQKPiBpdGVyYXRlIG92ZXIgYWxsIHBpcGVzIDIgdGltZXMs IHRoZSBmaXJzdCBvbmUgZGlzYWJsaW5nIGFueSBzbGF2ZSBhbmQKPiB0aGVuIGRpc2FibGluZyBl dmVyeXRoaW5nIGVsc2UuCj4gVGhlIE1TVCBiaXRzIHdpbGwgYmUgYWRkZWQgaW4gYW5vdGhlciBw YXRjaC4KPiAKPiB2MjoKPiBOb3QgdXNpbmcgY3J0Yy0+YWN0aXZlIGFzIGl0IGlzIGRlcHJlY2F0 ZWQKPiAKPiBDYzogTHVjYXMgRGUgTWFyY2hpIDxsdWNhcy5kZW1hcmNoaUBpbnRlbC5jb20+Cj4g Q2M6IE1hbmFzaSBOYXZhcmUgPG1hbmFzaS5kLm5hdmFyZUBpbnRlbC5jb20+Cj4gQ2M6IE1hdHQg Um9wZXIgPG1hdHRoZXcuZC5yb3BlckBpbnRlbC5jb20+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0 IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IFZpbGxlIFN5cmrDpGzD pCA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogSm9zw6kg Um9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMv Z3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jIHwgODYgKysrKysrKy0tLS0tLS0t LS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDMwIGluc2VydGlvbnMoKyksIDU2IGRlbGV0aW9ucygt KQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rp c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfZGlzcGxheS5jCj4g aW5kZXggNjg1NzU0NTdkNDBlLi5hOWY1YWFmOGRmOWIgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvZGlzcGxheS9pbnRlbF9kaXNwbGF5LmMKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9kaXNwbGF5L2ludGVsX2Rpc3BsYXkuYwo+IEBAIC0xNDM5Myw3NyArMTQzOTMsNTEg QEAgc3RhdGljIHZvaWQgaW50ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMoc3RydWN0IGludGVs X2F0b21pY19zdGF0ZSAqc3RhdGUsCj4gIAkJZGV2X3ByaXYtPmRpc3BsYXkuaW5pdGlhbF93YXRl cm1hcmtzKHN0YXRlLCBjcnRjKTsKPiAgfQo+ICAKPiAtc3RhdGljIHZvaWQgaW50ZWxfdHJhbnNf cG9ydF9zeW5jX21vZGVzZXRfZGlzYWJsZXMoc3RydWN0IGludGVsX2F0b21pY19zdGF0ZSAqc3Rh dGUsCj4gLQkJCQkJCSAgIHN0cnVjdCBpbnRlbF9jcnRjICpjcnRjLAo+IC0JCQkJCQkgICBzdHJ1 Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqb2xkX2NydGNfc3RhdGUsCj4gLQkJCQkJCSAgIHN0cnVjdCBp bnRlbF9jcnRjX3N0YXRlICpuZXdfY3J0Y19zdGF0ZSkKPiAtewo+IC0Jc3RydWN0IGludGVsX2Ny dGMgKnNsYXZlX2NydGMgPSBpbnRlbF9nZXRfc2xhdmVfY3J0YyhuZXdfY3J0Y19zdGF0ZSk7Cj4g LQlzdHJ1Y3QgaW50ZWxfY3J0Y19zdGF0ZSAqbmV3X3NsYXZlX2NydGNfc3RhdGUgPQo+IC0JCWlu dGVsX2F0b21pY19nZXRfbmV3X2NydGNfc3RhdGUoc3RhdGUsIHNsYXZlX2NydGMpOwo+IC0Jc3Ry dWN0IGludGVsX2NydGNfc3RhdGUgKm9sZF9zbGF2ZV9jcnRjX3N0YXRlID0KPiAtCQlpbnRlbF9h dG9taWNfZ2V0X29sZF9jcnRjX3N0YXRlKHN0YXRlLCBzbGF2ZV9jcnRjKTsKPiAtCj4gLQlXQVJO X09OKCFzbGF2ZV9jcnRjIHx8ICFuZXdfc2xhdmVfY3J0Y19zdGF0ZSB8fAo+IC0JCSFvbGRfc2xh dmVfY3J0Y19zdGF0ZSk7Cj4gLQo+IC0JLyogRGlzYWJsZSBTbGF2ZSBmaXJzdCAqLwo+IC0JaW50 ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdGF0ZSwgc2xhdmVfY3J0Yyk7Cj4gLQlpZiAob2xkX3NsYXZl X2NydGNfc3RhdGUtPmh3LmFjdGl2ZSkKPiAtCQlpbnRlbF9vbGRfY3J0Y19zdGF0ZV9kaXNhYmxl cyhzdGF0ZSwKPiAtCQkJCQkgICAgICBvbGRfc2xhdmVfY3J0Y19zdGF0ZSwKPiAtCQkJCQkgICAg ICBuZXdfc2xhdmVfY3J0Y19zdGF0ZSwKPiAtCQkJCQkgICAgICBzbGF2ZV9jcnRjKTsKPiAtCj4g LQkvKiBEaXNhYmxlIE1hc3RlciAqLwo+IC0JaW50ZWxfcHJlX3BsYW5lX3VwZGF0ZShzdGF0ZSwg Y3J0Yyk7Cj4gLQlpZiAob2xkX2NydGNfc3RhdGUtPmh3LmFjdGl2ZSkKPiAtCQlpbnRlbF9vbGRf Y3J0Y19zdGF0ZV9kaXNhYmxlcyhzdGF0ZSwKPiAtCQkJCQkgICAgICBvbGRfY3J0Y19zdGF0ZSwK PiAtCQkJCQkgICAgICBuZXdfY3J0Y19zdGF0ZSwKPiAtCQkJCQkgICAgICBjcnRjKTsKPiAtfQo+ IC0KPiAgc3RhdGljIHZvaWQgaW50ZWxfY29tbWl0X21vZGVzZXRfZGlzYWJsZXMoc3RydWN0IGlu dGVsX2F0b21pY19zdGF0ZSAqc3RhdGUpCj4gIHsKPiAgCXN0cnVjdCBpbnRlbF9jcnRjX3N0YXRl ICpuZXdfY3J0Y19zdGF0ZSwgKm9sZF9jcnRjX3N0YXRlOwo+ICAJc3RydWN0IGludGVsX2NydGMg KmNydGM7Cj4gKwl1MzIgaGFuZGxlZCA9IDA7Cj4gIAlpbnQgaTsKPiAgCj4gLQkvKgo+IC0JICog RGlzYWJsZSBDUlRDL3BpcGVzIGluIHJldmVyc2Ugb3JkZXIgYmVjYXVzZSBzb21lIGZlYXR1cmVz KE1TVCBpbgo+IC0JICogVEdMKykgcmVxdWlyZXMgbWFzdGVyIGFuZCBzbGF2ZSByZWxhdGlvbnNo aXAgYmV0d2VlbiBwaXBlcywgc28gaXQKPiAtCSAqIHNob3VsZCBhbHdheXMgcGljayB0aGUgbG93 ZXN0IHBpcGUgYXMgbWFzdGVyIGFzIGl0IHdpbGwgYmUgZW5hYmxlZAo+IC0JICogZmlyc3QgYW5k IGRpc2FibGUgaW4gdGhlIHJldmVyc2Ugb3JkZXIgc28gdGhlIG1hc3RlciB3aWxsIGJlIHRoZQo+ IC0JICogbGFzdCBvbmUgdG8gYmUgZGlzYWJsZWQuCj4gLQkgKi8KPiAtCWZvcl9lYWNoX29sZG5l d19pbnRlbF9jcnRjX2luX3N0YXRlX3JldmVyc2Uoc3RhdGUsIGNydGMsIG9sZF9jcnRjX3N0YXRl LAo+IC0JCQkJCQkgICAgbmV3X2NydGNfc3RhdGUsIGkpIHsKPiArCS8qIE9ubHkgZGlzYWJsZSBw b3J0IHN5bmMgc2xhdmVzICovCj4gKwlmb3JfZWFjaF9vbGRuZXdfaW50ZWxfY3J0Y19pbl9zdGF0 ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsCj4gKwkJCQkJICAgIG5ld19jcnRjX3N0YXRl LCBpKSB7Cj4gIAkJaWYgKCFuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRlKSkKPiAgCQkJY29u dGludWU7Cj4gIAo+ICsJCS8qIElmIGl0IHdhc24ndCBhY3RpdmUgbm8gbmVlZCB0byBjaGVjayB0 aGUgc3BlY2lhbCBjYXNlcyAqLwoKVGhpcyBjb21tZW50IHNlZW1zIGEgYml0IHJlZHVuZGFudC4K Cj4gKwkJaWYgKCFvbGRfY3J0Y19zdGF0ZS0+aHcuYWN0aXZlKQo+ICsJCQljb250aW51ZTsKPiAr Cj4gIAkJLyogSW4gY2FzZSBvZiBUcmFuc2NvZGVyIHBvcnQgU3luYyBtYXN0ZXIgc2xhdmUgQ1JU Q3MgY2FuIGJlCj4gIAkJICogYXNzaWduZWQgaW4gYW55IG9yZGVyIGFuZCB3ZSBuZWVkIHRvIG1h a2Ugc3VyZSB0aGF0Cj4gIAkJICogc2xhdmUgQ1JUQ3MgYXJlIGRpc2FibGVkIGZpcnN0IGFuZCB0 aGVuIG1hc3RlciBDUlRDIHNpbmNlCj4gIAkJICogU2xhdmUgdmJsYW5rcyBhcmUgbWFza2VkIHRp bGwgTWFzdGVyIFZibGFua3MuCj4gIAkJICovCj4gLQkJaWYgKGlzX3RyYW5zX3BvcnRfc3luY19t b2RlKG9sZF9jcnRjX3N0YXRlKSkgewo+IC0JCQlpZiAoaXNfdHJhbnNfcG9ydF9zeW5jX21hc3Rl cihvbGRfY3J0Y19zdGF0ZSkpCj4gLQkJCQlpbnRlbF90cmFuc19wb3J0X3N5bmNfbW9kZXNldF9k aXNhYmxlcyhzdGF0ZSwKPiAtCQkJCQkJCQkgICAgICAgY3J0YywKPiAtCQkJCQkJCQkgICAgICAg b2xkX2NydGNfc3RhdGUsCj4gLQkJCQkJCQkJICAgICAgIG5ld19jcnRjX3N0YXRlKTsKPiAtCQkJ ZWxzZQo+IC0JCQkJY29udGludWU7Cj4gLQkJfSBlbHNlIHsKPiAtCQkJaW50ZWxfcHJlX3BsYW5l X3VwZGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gKwkJaWYgKCFpc190cmFuc19wb3J0X3N5bmNfbW9kZShv bGRfY3J0Y19zdGF0ZSkpCj4gKwkJCWNvbnRpbnVlOwo+ICAKPiAtCQkJaWYgKG9sZF9jcnRjX3N0 YXRlLT5ody5hY3RpdmUpCj4gLQkJCQlpbnRlbF9vbGRfY3J0Y19zdGF0ZV9kaXNhYmxlcyhzdGF0 ZSwKPiAtCQkJCQkJCSAgICAgIG9sZF9jcnRjX3N0YXRlLAo+IC0JCQkJCQkJICAgICAgbmV3X2Ny dGNfc3RhdGUsCj4gLQkJCQkJCQkgICAgICBjcnRjKTsKPiAtCQl9Cj4gKwkJaWYgKGlzX3RyYW5z X3BvcnRfc3luY19tYXN0ZXIob2xkX2NydGNfc3RhdGUpKQo+ICsJCQljb250aW51ZTsKCkknZCBz dGlsbCBsaWtlIHRvIHNlZSBpc190cmFuc19wb3J0X3N5bmNfc2xhdmUoKSBzbyB3ZSBjb3VsZCBl bGltaW5hdGUKdGhlIGRvdWJsZSBjaGVjayBoZXJlLgoKPiArCj4gKwkJaW50ZWxfcHJlX3BsYW5l X3VwZGF0ZShzdGF0ZSwgY3J0Yyk7Cj4gKwkJaW50ZWxfb2xkX2NydGNfc3RhdGVfZGlzYWJsZXMo c3RhdGUsIG9sZF9jcnRjX3N0YXRlLAo+ICsJCQkJCSAgICAgIG5ld19jcnRjX3N0YXRlLCBjcnRj KTsKPiArCQloYW5kbGVkIHw9IEJJVChjcnRjLT5waXBlKTsKPiArCX0KPiArCj4gKwkvKiBEaXNh YmxlIGV2ZXJ5dGhpbmcgZWxzZSBsZWZ0IG9uICovCj4gKwlmb3JfZWFjaF9vbGRuZXdfaW50ZWxf Y3J0Y19pbl9zdGF0ZShzdGF0ZSwgY3J0Yywgb2xkX2NydGNfc3RhdGUsCj4gKwkJCQkJICAgIG5l d19jcnRjX3N0YXRlLCBpKSB7Cj4gKwkJaWYgKCFuZWVkc19tb2Rlc2V0KG5ld19jcnRjX3N0YXRl KSB8fAo+ICsJCSAgICAoaGFuZGxlZCAmIEJJVChjcnRjLT5waXBlKSkpCj4gKwkJCWNvbnRpbnVl Owo+ICsKPiArCQlpbnRlbF9wcmVfcGxhbmVfdXBkYXRlKHN0YXRlLCBjcnRjKTsKPiArCQlpZiAo b2xkX2NydGNfc3RhdGUtPmh3LmFjdGl2ZSkKPiArCQkJaW50ZWxfb2xkX2NydGNfc3RhdGVfZGlz YWJsZXMoc3RhdGUsIG9sZF9jcnRjX3N0YXRlLAo+ICsJCQkJCQkgICAgICBuZXdfY3J0Y19zdGF0 ZSwgY3J0Yyk7Cj4gIAl9CgpUaGUgb25seSBjb25jZXJuIGxlZnQgaXMgdGhlIG5ldyBvcmRlcmlu ZyB3aGVuIHdlIGhhdmUgbXVsdGlwbGUKc2V0cyBvZiBnZW5sb2NrZWQgcGlwZXMuIEFzc3VtaW5n IHRoZSBoYXJkd2FyZSBpcyBzYW5lIEkgZG9uJ3QKdGhpbmsgYW55dGhpbmcgKnNob3VsZCogYnJl YWsuIEJ1dCB3aG8ga25vd3MuCgpBcGFydCBmcm9tIHRoYXQ6ClJldmlld2VkLWJ5OiBWaWxsZSBT eXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKPiAgfQo+ICAKPiAtLSAK PiAyLjI0LjAKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1n ZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4