From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67A40C43603 for ; Thu, 5 Dec 2019 16:03:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 36C44206DB for ; Thu, 5 Dec 2019 16:03:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="NflRHuan" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726257AbfLEQDe (ORCPT ); Thu, 5 Dec 2019 11:03:34 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:55922 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726028AbfLEQDe (ORCPT ); Thu, 5 Dec 2019 11:03:34 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575561813; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHd+4w0V9iVfUn6tAMIGauQiWjLxMUn18cIdw9bXNzA=; b=NflRHuan3Ju5klAhlrEXMl70Z+Nt6vNMBsLB/ZlTnZy7JceiILsAOhCviPFhdXSSqDnFY+ znBjHD49pobspjTV2Gvy9hls09bod4y5Lpdaf+9soOLkbbzCvVeg3tJd0lrnOLIF14d1eq A8b7o2Yj78jH44rp19PDzURgGwzS3iQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-MoRTtIA4PDWwtQt6J_dX7Q-1; Thu, 05 Dec 2019 11:03:30 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E4D312A7E49; Thu, 5 Dec 2019 16:03:28 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CC4D600D1; Thu, 5 Dec 2019 16:03:26 +0000 (UTC) Date: Thu, 5 Dec 2019 11:03:24 -0500 From: Jerome Glisse To: Jason Gunthorpe Cc: Linus Torvalds , Ralph Campbell , David Airlie , "Kuehling, Felix" , "dri-devel@lists.freedesktop.org" , Christoph Hellwig , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , Andrew Morton , Dan Williams , "linux-rdma@vger.kernel.org" Subject: Re: [GIT PULL] Please pull hmm changes Message-ID: <20191205160324.GB5819@redhat.com> References: <20191125204248.GA2485@ziepe.ca> <20191203024206.GC5795@mellanox.com> MIME-Version: 1.0 In-Reply-To: <20191203024206.GC5795@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: MoRTtIA4PDWwtQt6J_dX7Q-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Tue, Dec 03, 2019 at 02:42:12AM +0000, Jason Gunthorpe wrote: > On Sat, Nov 30, 2019 at 10:23:31AM -0800, Linus Torvalds wrote: > > On Sat, Nov 30, 2019 at 10:03 AM Linus Torvalds > > wrote: > > > > > > I'll try to figure the code out, but my initial reaction was "yeah, > > > not in my VM". > >=20 > > Why is it ok to sometimes do > >=20 > > WRITE_ONCE(mni->invalidate_seq, cur_seq); > >=20 > > (to pair with the unlocked READ_ONCE), and sometimes then do > >=20 > > mni->invalidate_seq =3D mmn_mm->invalidate_seq; > >=20 > > My initial guess was that latter is only done at initialization time, > > but at least in one case it's done *after* the mni has been added to > > the mmn_mm (oh, how I despise those names - I can only repeat: WTF?). >=20 > Yes, the only occurrences are in the notifier_insert, under the > spinlock. The one case where it is out of the natural order was to > make the manipulation of seq a bit saner, but in all cases since the > spinlock is held there is no way for another thread to get the pointer > to the 'mmu_interval_notifier *' to do the unlocked read. >=20 > Regarding the ugly names.. Naming has been really hard here because > currently everything is a 'mmu notifier' and the natural abberviations > from there are crummy. Here is the basic summary: >=20 > struct mmu_notifier_mm (ie the mm->mmu_notifier_mm) > -> mmn_mm > struct mm_struct=20 > -> mm > struct mmu_notifier (ie the user subscription to the mm_struct) > -> mn > struct mmu_interval_notifier (the other kind of user subscription) > -> mni What about "interval" the context should already tell people it is related to mmu notifier and thus a notifier. I would just remove the notifier suffix, this would match the below range. > struct mmu_notifier_range (ie the args to invalidate_range) > -> range Yeah range as context should tell you it is related to mmu notifier. >=20 > I can send a patch to switch mmn_mm to mmu_notifier_mm, which is the > only pre-existing name for this value. But IIRC, it is a somewhat ugly > with long line wrapping. 'mni' is a pain, I have to reflect on that. > (honesly, I dislike mmu_notififer_mm quite a lot too) >=20 > I think it would be overall nicer with better names for the original > structs. Perhaps: >=20 > mmn_* - MMU notifier prefix > mmn_state <- struct mmu_notifier_mm > mmn_subscription (mmn_sub) <- struct mmu_notifier > mmn_range_subscription (mmn_range_sub) <- struct mmu_interval_notifier > mmn_invalidate_desc <- struct mmu_notifier_range This looks good. >=20 > At least this is how I describe them in my mind.. This is a lot of > churn, and spreads through many drivers. This is why I kept the names > as-is and we ended up with the also quite bad 'mmu_interval_notifier' >=20 > Maybe just switch mmu_notifier_mm for mmn_state and leave the drivers > alone? >=20 > Anyone on the CC list have advice? Maybe we can do a semantic patch to do convertion and then Linus can easily apply the patch by just re-running the coccinelle. Cheers, J=E9r=F4me From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03D28C43603 for ; Thu, 5 Dec 2019 16:03:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D7C32206DB for ; Thu, 5 Dec 2019 16:03:37 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D7C32206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 132D36E990; Thu, 5 Dec 2019 16:03:37 +0000 (UTC) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4D09E6E988 for ; Thu, 5 Dec 2019 16:03:35 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-MoRTtIA4PDWwtQt6J_dX7Q-1; Thu, 05 Dec 2019 11:03:30 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E4D312A7E49; Thu, 5 Dec 2019 16:03:28 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CC4D600D1; Thu, 5 Dec 2019 16:03:26 +0000 (UTC) Date: Thu, 5 Dec 2019 11:03:24 -0500 From: Jerome Glisse To: Jason Gunthorpe Subject: Re: [GIT PULL] Please pull hmm changes Message-ID: <20191205160324.GB5819@redhat.com> References: <20191125204248.GA2485@ziepe.ca> <20191203024206.GC5795@mellanox.com> MIME-Version: 1.0 In-Reply-To: <20191203024206.GC5795@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: MoRTtIA4PDWwtQt6J_dX7Q-1 X-Mimecast-Spam-Score: 0 Content-Disposition: inline X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575561814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHd+4w0V9iVfUn6tAMIGauQiWjLxMUn18cIdw9bXNzA=; b=VaSz2b/5TeIzw/CS0oNKxhi+xt/6DOgoW3/N2h9jZo8IWNBqF36g0bpDH1uDZYHYNtQ955 f0MROrh0HaLPHUv7va4uTno3RGcrTrA1r+F2HZ45iQETJPQbuxN7B73g+ezYG1nTulwHl3 ocUg8CtIIUk08irOGnwwlxBlg4aVO1I= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ralph Campbell , David Airlie , "Kuehling, Felix" , Dan Williams , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , Andrew Morton , Linus Torvalds , Christoph Hellwig , "linux-rdma@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gVHVlLCBEZWMgMDMsIDIwMTkgYXQgMDI6NDI6MTJBTSArMDAwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIFNhdCwgTm92IDMwLCAyMDE5IGF0IDEwOjIzOjMxQU0gLTA4MDAsIExpbnVz IFRvcnZhbGRzIHdyb3RlOgo+ID4gT24gU2F0LCBOb3YgMzAsIDIwMTkgYXQgMTA6MDMgQU0gTGlu dXMgVG9ydmFsZHMKPiA+IDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4g PiA+Cj4gPiA+IEknbGwgdHJ5IHRvIGZpZ3VyZSB0aGUgY29kZSBvdXQsIGJ1dCBteSBpbml0aWFs IHJlYWN0aW9uIHdhcyAieWVhaCwKPiA+ID4gbm90IGluIG15IFZNIi4KPiA+IAo+ID4gV2h5IGlz IGl0IG9rIHRvIHNvbWV0aW1lcyBkbwo+ID4gCj4gPiAgICAgV1JJVEVfT05DRShtbmktPmludmFs aWRhdGVfc2VxLCBjdXJfc2VxKTsKPiA+IAo+ID4gKHRvIHBhaXIgd2l0aCB0aGUgdW5sb2NrZWQg UkVBRF9PTkNFKSwgYW5kIHNvbWV0aW1lcyB0aGVuIGRvCj4gPiAKPiA+ICAgICBtbmktPmludmFs aWRhdGVfc2VxID0gbW1uX21tLT5pbnZhbGlkYXRlX3NlcTsKPiA+IAo+ID4gTXkgaW5pdGlhbCBn dWVzcyB3YXMgdGhhdCBsYXR0ZXIgaXMgb25seSBkb25lIGF0IGluaXRpYWxpemF0aW9uIHRpbWUs Cj4gPiBidXQgYXQgbGVhc3QgaW4gb25lIGNhc2UgaXQncyBkb25lICphZnRlciogdGhlIG1uaSBo YXMgYmVlbiBhZGRlZCB0bwo+ID4gdGhlIG1tbl9tbSAob2gsIGhvdyBJIGRlc3Bpc2UgdGhvc2Ug bmFtZXMgLSBJIGNhbiBvbmx5IHJlcGVhdDogV1RGPykuCj4gCj4gWWVzLCB0aGUgb25seSBvY2N1 cnJlbmNlcyBhcmUgaW4gdGhlIG5vdGlmaWVyX2luc2VydCwgdW5kZXIgdGhlCj4gc3BpbmxvY2su IFRoZSBvbmUgY2FzZSB3aGVyZSBpdCBpcyBvdXQgb2YgdGhlIG5hdHVyYWwgb3JkZXIgd2FzIHRv Cj4gbWFrZSB0aGUgbWFuaXB1bGF0aW9uIG9mIHNlcSBhIGJpdCBzYW5lciwgYnV0IGluIGFsbCBj YXNlcyBzaW5jZSB0aGUKPiBzcGlubG9jayBpcyBoZWxkIHRoZXJlIGlzIG5vIHdheSBmb3IgYW5v dGhlciB0aHJlYWQgdG8gZ2V0IHRoZSBwb2ludGVyCj4gdG8gdGhlICdtbXVfaW50ZXJ2YWxfbm90 aWZpZXIgKicgdG8gZG8gdGhlIHVubG9ja2VkIHJlYWQuCj4gCj4gUmVnYXJkaW5nIHRoZSB1Z2x5 IG5hbWVzLi4gTmFtaW5nIGhhcyBiZWVuIHJlYWxseSBoYXJkIGhlcmUgYmVjYXVzZQo+IGN1cnJl bnRseSBldmVyeXRoaW5nIGlzIGEgJ21tdSBub3RpZmllcicgYW5kIHRoZSBuYXR1cmFsIGFiYmVy dmlhdGlvbnMKPiBmcm9tIHRoZXJlIGFyZSBjcnVtbXkuIEhlcmUgaXMgdGhlIGJhc2ljIHN1bW1h cnk6Cj4gCj4gc3RydWN0IG1tdV9ub3RpZmllcl9tbSAoaWUgdGhlIG1tLT5tbXVfbm90aWZpZXJf bW0pCj4gICAgLT4gbW1uX21tCj4gc3RydWN0IG1tX3N0cnVjdCAKPiAgICAtPiBtbQo+IHN0cnVj dCBtbXVfbm90aWZpZXIgKGllIHRoZSB1c2VyIHN1YnNjcmlwdGlvbiB0byB0aGUgbW1fc3RydWN0 KQo+ICAgIC0+IG1uCj4gc3RydWN0IG1tdV9pbnRlcnZhbF9ub3RpZmllciAodGhlIG90aGVyIGtp bmQgb2YgdXNlciBzdWJzY3JpcHRpb24pCj4gICAgLT4gbW5pCgpXaGF0IGFib3V0ICJpbnRlcnZh bCIgdGhlIGNvbnRleHQgc2hvdWxkIGFscmVhZHkgdGVsbCBwZW9wbGUKaXQgaXMgcmVsYXRlZCB0 byBtbXUgbm90aWZpZXIgYW5kIHRodXMgYSBub3RpZmllci4gSSB3b3VsZApqdXN0IHJlbW92ZSB0 aGUgbm90aWZpZXIgc3VmZml4LCB0aGlzIHdvdWxkIG1hdGNoIHRoZSBiZWxvdwpyYW5nZS4KCj4g c3RydWN0IG1tdV9ub3RpZmllcl9yYW5nZSAoaWUgdGhlIGFyZ3MgdG8gaW52YWxpZGF0ZV9yYW5n ZSkKPiAgICAtPiByYW5nZQoKWWVhaCByYW5nZSBhcyBjb250ZXh0IHNob3VsZCB0ZWxsIHlvdSBp dCBpcyByZWxhdGVkIHRvIG1tdQpub3RpZmllci4KCj4gCj4gSSBjYW4gc2VuZCBhIHBhdGNoIHRv IHN3aXRjaCBtbW5fbW0gdG8gbW11X25vdGlmaWVyX21tLCB3aGljaCBpcyB0aGUKPiBvbmx5IHBy ZS1leGlzdGluZyBuYW1lIGZvciB0aGlzIHZhbHVlLiBCdXQgSUlSQywgaXQgaXMgYSBzb21ld2hh dCB1Z2x5Cj4gd2l0aCBsb25nIGxpbmUgd3JhcHBpbmcuICdtbmknIGlzIGEgcGFpbiwgSSBoYXZl IHRvIHJlZmxlY3Qgb24gdGhhdC4KPiAoaG9uZXNseSwgSSBkaXNsaWtlIG1tdV9ub3RpZmlmZXJf bW0gcXVpdGUgYSBsb3QgdG9vKQo+IAo+IEkgdGhpbmsgaXQgd291bGQgYmUgb3ZlcmFsbCBuaWNl ciB3aXRoIGJldHRlciBuYW1lcyBmb3IgdGhlIG9yaWdpbmFsCj4gc3RydWN0cy4gUGVyaGFwczoK PiAKPiAgbW1uXyogLSBNTVUgbm90aWZpZXIgcHJlZml4Cj4gIG1tbl9zdGF0ZSA8LSBzdHJ1Y3Qg bW11X25vdGlmaWVyX21tCj4gIG1tbl9zdWJzY3JpcHRpb24gKG1tbl9zdWIpIDwtIHN0cnVjdCBt bXVfbm90aWZpZXIKPiAgbW1uX3JhbmdlX3N1YnNjcmlwdGlvbiAobW1uX3JhbmdlX3N1YikgPC0g c3RydWN0IG1tdV9pbnRlcnZhbF9ub3RpZmllcgo+ICBtbW5faW52YWxpZGF0ZV9kZXNjIDwtIHN0 cnVjdCBtbXVfbm90aWZpZXJfcmFuZ2UKClRoaXMgbG9va3MgZ29vZC4KCj4gCj4gQXQgbGVhc3Qg dGhpcyBpcyBob3cgSSBkZXNjcmliZSB0aGVtIGluIG15IG1pbmQuLiAgVGhpcyBpcyBhIGxvdCBv Zgo+IGNodXJuLCBhbmQgc3ByZWFkcyB0aHJvdWdoIG1hbnkgZHJpdmVycy4gVGhpcyBpcyB3aHkg SSBrZXB0IHRoZSBuYW1lcwo+IGFzLWlzIGFuZCB3ZSBlbmRlZCB1cCB3aXRoIHRoZSBhbHNvIHF1 aXRlIGJhZCAnbW11X2ludGVydmFsX25vdGlmaWVyJwo+IAo+IE1heWJlIGp1c3Qgc3dpdGNoIG1t dV9ub3RpZmllcl9tbSBmb3IgbW1uX3N0YXRlIGFuZCBsZWF2ZSB0aGUgZHJpdmVycwo+IGFsb25l Pwo+IAo+IEFueW9uZSBvbiB0aGUgQ0MgbGlzdCBoYXZlIGFkdmljZT8KCk1heWJlIHdlIGNhbiBk byBhIHNlbWFudGljIHBhdGNoIHRvIGRvIGNvbnZlcnRpb24gYW5kIHRoZW4gTGludXMKY2FuIGVh c2lseSBhcHBseSB0aGUgcGF0Y2ggYnkganVzdCByZS1ydW5uaW5nIHRoZSBjb2NjaW5lbGxlLgoK Q2hlZXJzLApKw6lyw7RtZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE82C43603 for ; Thu, 5 Dec 2019 16:03:39 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2A7A0206DB for ; Thu, 5 Dec 2019 16:03:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2A7A0206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 896056E996; Thu, 5 Dec 2019 16:03:37 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by gabe.freedesktop.org (Postfix) with ESMTPS id 54F136E990 for ; Thu, 5 Dec 2019 16:03:35 +0000 (UTC) Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-MoRTtIA4PDWwtQt6J_dX7Q-1; Thu, 05 Dec 2019 11:03:30 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 4E4D312A7E49; Thu, 5 Dec 2019 16:03:28 +0000 (UTC) Received: from redhat.com (unknown [10.20.6.225]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 1CC4D600D1; Thu, 5 Dec 2019 16:03:26 +0000 (UTC) Date: Thu, 5 Dec 2019 11:03:24 -0500 From: Jerome Glisse To: Jason Gunthorpe Subject: Re: [GIT PULL] Please pull hmm changes Message-ID: <20191205160324.GB5819@redhat.com> References: <20191125204248.GA2485@ziepe.ca> <20191203024206.GC5795@mellanox.com> MIME-Version: 1.0 In-Reply-To: <20191203024206.GC5795@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-MC-Unique: MoRTtIA4PDWwtQt6J_dX7Q-1 X-Mimecast-Spam-Score: 0 Content-Disposition: inline X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575561814; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oHd+4w0V9iVfUn6tAMIGauQiWjLxMUn18cIdw9bXNzA=; b=VaSz2b/5TeIzw/CS0oNKxhi+xt/6DOgoW3/N2h9jZo8IWNBqF36g0bpDH1uDZYHYNtQ955 f0MROrh0HaLPHUv7va4uTno3RGcrTrA1r+F2HZ45iQETJPQbuxN7B73g+ezYG1nTulwHl3 ocUg8CtIIUk08irOGnwwlxBlg4aVO1I= X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ralph Campbell , David Airlie , "Kuehling, Felix" , Dan Williams , "dri-devel@lists.freedesktop.org" , "linux-mm@kvack.org" , "amd-gfx@lists.freedesktop.org" , "Deucher, Alexander" , Andrew Morton , Linus Torvalds , Christoph Hellwig , "linux-rdma@vger.kernel.org" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" T24gVHVlLCBEZWMgMDMsIDIwMTkgYXQgMDI6NDI6MTJBTSArMDAwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IE9uIFNhdCwgTm92IDMwLCAyMDE5IGF0IDEwOjIzOjMxQU0gLTA4MDAsIExpbnVz IFRvcnZhbGRzIHdyb3RlOgo+ID4gT24gU2F0LCBOb3YgMzAsIDIwMTkgYXQgMTA6MDMgQU0gTGlu dXMgVG9ydmFsZHMKPiA+IDx0b3J2YWxkc0BsaW51eC1mb3VuZGF0aW9uLm9yZz4gd3JvdGU6Cj4g PiA+Cj4gPiA+IEknbGwgdHJ5IHRvIGZpZ3VyZSB0aGUgY29kZSBvdXQsIGJ1dCBteSBpbml0aWFs IHJlYWN0aW9uIHdhcyAieWVhaCwKPiA+ID4gbm90IGluIG15IFZNIi4KPiA+IAo+ID4gV2h5IGlz IGl0IG9rIHRvIHNvbWV0aW1lcyBkbwo+ID4gCj4gPiAgICAgV1JJVEVfT05DRShtbmktPmludmFs aWRhdGVfc2VxLCBjdXJfc2VxKTsKPiA+IAo+ID4gKHRvIHBhaXIgd2l0aCB0aGUgdW5sb2NrZWQg UkVBRF9PTkNFKSwgYW5kIHNvbWV0aW1lcyB0aGVuIGRvCj4gPiAKPiA+ICAgICBtbmktPmludmFs aWRhdGVfc2VxID0gbW1uX21tLT5pbnZhbGlkYXRlX3NlcTsKPiA+IAo+ID4gTXkgaW5pdGlhbCBn dWVzcyB3YXMgdGhhdCBsYXR0ZXIgaXMgb25seSBkb25lIGF0IGluaXRpYWxpemF0aW9uIHRpbWUs Cj4gPiBidXQgYXQgbGVhc3QgaW4gb25lIGNhc2UgaXQncyBkb25lICphZnRlciogdGhlIG1uaSBo YXMgYmVlbiBhZGRlZCB0bwo+ID4gdGhlIG1tbl9tbSAob2gsIGhvdyBJIGRlc3Bpc2UgdGhvc2Ug bmFtZXMgLSBJIGNhbiBvbmx5IHJlcGVhdDogV1RGPykuCj4gCj4gWWVzLCB0aGUgb25seSBvY2N1 cnJlbmNlcyBhcmUgaW4gdGhlIG5vdGlmaWVyX2luc2VydCwgdW5kZXIgdGhlCj4gc3BpbmxvY2su IFRoZSBvbmUgY2FzZSB3aGVyZSBpdCBpcyBvdXQgb2YgdGhlIG5hdHVyYWwgb3JkZXIgd2FzIHRv Cj4gbWFrZSB0aGUgbWFuaXB1bGF0aW9uIG9mIHNlcSBhIGJpdCBzYW5lciwgYnV0IGluIGFsbCBj YXNlcyBzaW5jZSB0aGUKPiBzcGlubG9jayBpcyBoZWxkIHRoZXJlIGlzIG5vIHdheSBmb3IgYW5v dGhlciB0aHJlYWQgdG8gZ2V0IHRoZSBwb2ludGVyCj4gdG8gdGhlICdtbXVfaW50ZXJ2YWxfbm90 aWZpZXIgKicgdG8gZG8gdGhlIHVubG9ja2VkIHJlYWQuCj4gCj4gUmVnYXJkaW5nIHRoZSB1Z2x5 IG5hbWVzLi4gTmFtaW5nIGhhcyBiZWVuIHJlYWxseSBoYXJkIGhlcmUgYmVjYXVzZQo+IGN1cnJl bnRseSBldmVyeXRoaW5nIGlzIGEgJ21tdSBub3RpZmllcicgYW5kIHRoZSBuYXR1cmFsIGFiYmVy dmlhdGlvbnMKPiBmcm9tIHRoZXJlIGFyZSBjcnVtbXkuIEhlcmUgaXMgdGhlIGJhc2ljIHN1bW1h cnk6Cj4gCj4gc3RydWN0IG1tdV9ub3RpZmllcl9tbSAoaWUgdGhlIG1tLT5tbXVfbm90aWZpZXJf bW0pCj4gICAgLT4gbW1uX21tCj4gc3RydWN0IG1tX3N0cnVjdCAKPiAgICAtPiBtbQo+IHN0cnVj dCBtbXVfbm90aWZpZXIgKGllIHRoZSB1c2VyIHN1YnNjcmlwdGlvbiB0byB0aGUgbW1fc3RydWN0 KQo+ICAgIC0+IG1uCj4gc3RydWN0IG1tdV9pbnRlcnZhbF9ub3RpZmllciAodGhlIG90aGVyIGtp bmQgb2YgdXNlciBzdWJzY3JpcHRpb24pCj4gICAgLT4gbW5pCgpXaGF0IGFib3V0ICJpbnRlcnZh bCIgdGhlIGNvbnRleHQgc2hvdWxkIGFscmVhZHkgdGVsbCBwZW9wbGUKaXQgaXMgcmVsYXRlZCB0 byBtbXUgbm90aWZpZXIgYW5kIHRodXMgYSBub3RpZmllci4gSSB3b3VsZApqdXN0IHJlbW92ZSB0 aGUgbm90aWZpZXIgc3VmZml4LCB0aGlzIHdvdWxkIG1hdGNoIHRoZSBiZWxvdwpyYW5nZS4KCj4g c3RydWN0IG1tdV9ub3RpZmllcl9yYW5nZSAoaWUgdGhlIGFyZ3MgdG8gaW52YWxpZGF0ZV9yYW5n ZSkKPiAgICAtPiByYW5nZQoKWWVhaCByYW5nZSBhcyBjb250ZXh0IHNob3VsZCB0ZWxsIHlvdSBp dCBpcyByZWxhdGVkIHRvIG1tdQpub3RpZmllci4KCj4gCj4gSSBjYW4gc2VuZCBhIHBhdGNoIHRv IHN3aXRjaCBtbW5fbW0gdG8gbW11X25vdGlmaWVyX21tLCB3aGljaCBpcyB0aGUKPiBvbmx5IHBy ZS1leGlzdGluZyBuYW1lIGZvciB0aGlzIHZhbHVlLiBCdXQgSUlSQywgaXQgaXMgYSBzb21ld2hh dCB1Z2x5Cj4gd2l0aCBsb25nIGxpbmUgd3JhcHBpbmcuICdtbmknIGlzIGEgcGFpbiwgSSBoYXZl IHRvIHJlZmxlY3Qgb24gdGhhdC4KPiAoaG9uZXNseSwgSSBkaXNsaWtlIG1tdV9ub3RpZmlmZXJf bW0gcXVpdGUgYSBsb3QgdG9vKQo+IAo+IEkgdGhpbmsgaXQgd291bGQgYmUgb3ZlcmFsbCBuaWNl ciB3aXRoIGJldHRlciBuYW1lcyBmb3IgdGhlIG9yaWdpbmFsCj4gc3RydWN0cy4gUGVyaGFwczoK PiAKPiAgbW1uXyogLSBNTVUgbm90aWZpZXIgcHJlZml4Cj4gIG1tbl9zdGF0ZSA8LSBzdHJ1Y3Qg bW11X25vdGlmaWVyX21tCj4gIG1tbl9zdWJzY3JpcHRpb24gKG1tbl9zdWIpIDwtIHN0cnVjdCBt bXVfbm90aWZpZXIKPiAgbW1uX3JhbmdlX3N1YnNjcmlwdGlvbiAobW1uX3JhbmdlX3N1YikgPC0g c3RydWN0IG1tdV9pbnRlcnZhbF9ub3RpZmllcgo+ICBtbW5faW52YWxpZGF0ZV9kZXNjIDwtIHN0 cnVjdCBtbXVfbm90aWZpZXJfcmFuZ2UKClRoaXMgbG9va3MgZ29vZC4KCj4gCj4gQXQgbGVhc3Qg dGhpcyBpcyBob3cgSSBkZXNjcmliZSB0aGVtIGluIG15IG1pbmQuLiAgVGhpcyBpcyBhIGxvdCBv Zgo+IGNodXJuLCBhbmQgc3ByZWFkcyB0aHJvdWdoIG1hbnkgZHJpdmVycy4gVGhpcyBpcyB3aHkg SSBrZXB0IHRoZSBuYW1lcwo+IGFzLWlzIGFuZCB3ZSBlbmRlZCB1cCB3aXRoIHRoZSBhbHNvIHF1 aXRlIGJhZCAnbW11X2ludGVydmFsX25vdGlmaWVyJwo+IAo+IE1heWJlIGp1c3Qgc3dpdGNoIG1t dV9ub3RpZmllcl9tbSBmb3IgbW1uX3N0YXRlIGFuZCBsZWF2ZSB0aGUgZHJpdmVycwo+IGFsb25l Pwo+IAo+IEFueW9uZSBvbiB0aGUgQ0MgbGlzdCBoYXZlIGFkdmljZT8KCk1heWJlIHdlIGNhbiBk byBhIHNlbWFudGljIHBhdGNoIHRvIGRvIGNvbnZlcnRpb24gYW5kIHRoZW4gTGludXMKY2FuIGVh c2lseSBhcHBseSB0aGUgcGF0Y2ggYnkganVzdCByZS1ydW5uaW5nIHRoZSBjb2NjaW5lbGxlLgoK Q2hlZXJzLApKw6lyw7RtZQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KYW1kLWdmeCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4