* [Buildroot] [PATCH] package/python-brotli: fix build failure due to gcc bug 68485
@ 2019-12-05 11:16 Giulio Benetti
2019-12-05 20:37 ` Thomas Petazzoni
2019-12-07 11:06 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Giulio Benetti @ 2019-12-05 11:16 UTC (permalink / raw)
To: buildroot
The python-brotli package exhibits gcc bug 68485 when built for the
Microblaze architecture with optimization enabled, which causes a build
failure.
As done for other packages in Buildroot work around this gcc bug by
setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.
Fixes:
http://autobuild.buildroot.net/results/24b/24b23175ab27615fb377bb4d5f6c656dccf10a86/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/python-brotli/python-brotli.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/python-brotli/python-brotli.mk b/package/python-brotli/python-brotli.mk
index 745255f413..2ec549ed0c 100644
--- a/package/python-brotli/python-brotli.mk
+++ b/package/python-brotli/python-brotli.mk
@@ -11,6 +11,14 @@ PYTHON_BROTLI_SETUP_TYPE = setuptools
PYTHON_BROTLI_LICENSE = MIT
PYTHON_BROTLI_LICENSE_FILES = LICENSE
+PYTHON_BROTLI_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_68485),y)
+PYTHON_BROTLI_CFLAGS += -O0
+endif
+
+PYTHON_BROTLI_ENV = CFLAGS="$(PYTHON_BROTLI_CFLAGS)"
+
define PYTHON_BROTLI_EXTRACT_CMDS
$(UNZIP) -d $(@D) $(PYTHON_BROTLI_DL_DIR)/$(PYTHON_BROTLI_SOURCE)
mv $(@D)/Brotli-$(PYTHON_BROTLI_VERSION)/* $(@D)
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/python-brotli: fix build failure due to gcc bug 68485
2019-12-05 11:16 [Buildroot] [PATCH] package/python-brotli: fix build failure due to gcc bug 68485 Giulio Benetti
@ 2019-12-05 20:37 ` Thomas Petazzoni
2019-12-07 11:06 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-12-05 20:37 UTC (permalink / raw)
To: buildroot
On Thu, 5 Dec 2019 12:16:50 +0100
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> The python-brotli package exhibits gcc bug 68485 when built for the
> Microblaze architecture with optimization enabled, which causes a build
> failure.
>
> As done for other packages in Buildroot work around this gcc bug by
> setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.
>
> Fixes:
>
> http://autobuild.buildroot.net/results/24b/24b23175ab27615fb377bb4d5f6c656dccf10a86/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/python-brotli/python-brotli.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH] package/python-brotli: fix build failure due to gcc bug 68485
2019-12-05 11:16 [Buildroot] [PATCH] package/python-brotli: fix build failure due to gcc bug 68485 Giulio Benetti
2019-12-05 20:37 ` Thomas Petazzoni
@ 2019-12-07 11:06 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-12-07 11:06 UTC (permalink / raw)
To: buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> The python-brotli package exhibits gcc bug 68485 when built for the
> Microblaze architecture with optimization enabled, which causes a build
> failure.
> As done for other packages in Buildroot work around this gcc bug by
> setting optimization to -O0 if BR2_TOOLCHAIN_HAS_GCC_BUG_68485=y.
> Fixes:
> http://autobuild.buildroot.net/results/24b/24b23175ab27615fb377bb4d5f6c656dccf10a86/
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed to 2019.11.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-07 11:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-05 11:16 [Buildroot] [PATCH] package/python-brotli: fix build failure due to gcc bug 68485 Giulio Benetti
2019-12-05 20:37 ` Thomas Petazzoni
2019-12-07 11:06 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.