From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Petazzoni Date: Thu, 5 Dec 2019 22:18:07 +0100 Subject: [Buildroot] [PATCH v3 1/1] package/grpc: bump to version 1.25.0 In-Reply-To: <20191205210155.2705242-1-aduskett@gmail.com> References: <20191205210155.2705242-1-aduskett@gmail.com> Message-ID: <20191205221807.3022cc5b@windsurf> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net On Thu, 5 Dec 2019 13:01:55 -0800 aduskett at gmail.com wrote: > -GRPC_VERSION = 1.23.0 > +GRPC_VERSION = 1.25.0 > GRPC_SITE = $(call github,grpc,grpc,v$(GRPC_VERSION)) > GRPC_LICENSE = Apache-2.0 > GRPC_LICENSE_FILES = LICENSE > @@ -48,6 +48,14 @@ GRPC_CFLAGS += -O0 > GRPC_CXXFLAGS += -O0 > endif > > +# Toolchains older than gcc5 will fail to compile with -0s due to: > +# error: failure memory model cannot be stronger than success memory model for > +# '__atomic_compare_exchange' > +ifneq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),y) Could also be: ifeq ($(BR2_TOOLCHAIN_GCC_AT_LEAST_5),) > +GRPC_CFLAGS += -O0 > +GRPC_CXXFLAGS += -O0 What happens when O2 or O3 are the default optimization flags? Does it build? If it does, what you're doing is a bit brutal, as you're forcing O0 even if O2 or O3 would work. Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com