From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EB6AFC2BD09 for ; Fri, 6 Dec 2019 11:46:55 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id A622021823 for ; Fri, 6 Dec 2019 11:46:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A622021823 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5E9714AED2; Fri, 6 Dec 2019 06:46:55 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id glfpL3XLhvhV; Fri, 6 Dec 2019 06:46:54 -0500 (EST) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5E87F4AF3D; Fri, 6 Dec 2019 06:46:54 -0500 (EST) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 775724AF29 for ; Fri, 6 Dec 2019 06:46:53 -0500 (EST) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id bt9g3cPaZ8pJ for ; Fri, 6 Dec 2019 06:46:52 -0500 (EST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 107DD4AF40 for ; Fri, 6 Dec 2019 06:46:52 -0500 (EST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B23831B; Fri, 6 Dec 2019 03:46:51 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4565B3F52E; Fri, 6 Dec 2019 03:46:50 -0800 (PST) Date: Fri, 6 Dec 2019 11:46:48 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH v2] arm64: KVM: Invoke compute_layout() before alternatives are applied Message-ID: <20191206114647.GB32767@arrakis.emea.arm.com> References: <20191016165953.o6ogh4fdmsjmd2sw@linutronix.de> <20191128195805.c2pryug4ohmcoqwd@linutronix.de> <5aae0e8248df45c3f4c08a8bb5aabe06@www.loen.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5aae0e8248df45c3f4c08a8bb5aabe06@www.loen.fr> User-Agent: Mutt/1.10.1 (2018-07-13) Cc: Sebastian Andrzej Siewior , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Fri, Dec 06, 2019 at 11:22:02AM +0000, Marc Zyngier wrote: > On 2019-11-28 19:58, Sebastian Andrzej Siewior wrote: > > compute_layout() is invoked as part of an alternative fixup under > > stop_machine(). This function invokes get_random_long() which acquires a > > sleeping lock on -RT which can not be acquired in this context. > > > > Rename compute_layout() to kvm_compute_layout() and invoke it before > > stop_machine() applies the alternatives. Add a __init prefix to > > kvm_compute_layout() because the caller has it, too (and so the code can > > be > > discarded after boot). > > > > Signed-off-by: Sebastian Andrzej Siewior > > Acked-by: Marc Zyngier > > I think this should go via the arm64 tree, so I'll let Catalin > and Will pick this up (unless they think otherwise). I can pick this up. Thanks. -- Catalin _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08B38C43603 for ; Fri, 6 Dec 2019 11:47:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CB8932464E for ; Fri, 6 Dec 2019 11:47:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O2poDRC4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CB8932464E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4jVjUYTIK2pCHdNn/FZ8oMxgFHF49EszjBg/HYrKXUE=; b=O2poDRC44Cc48r mBcWMOG/LKvFYiXWiI6hTH3CzPzdn8nyiSFvBHALPIg6DHwzaMxzF2L0biYAg+7/gSk3BqNeEu1QH hFH//e7HbOQb7FRKX0LE3E5IcIMTrRZ5d53fwMXhgbKFTeWbF5yugMowyVPdI6QAZ8I416+O7cJ+g mZiBQyU6QpG/0D0qsJUWfo870n8ZZzhWdxKLIa7oR3XoTgPhAYEnYQW+gqrEID0e3XRP4vmtbZVMR IKTA/Dfl0HzFWlnHO1L2jGmHJpsUrMjD8ktK9W4+K7gKae0IPVcaKi1wSbptiAfZWLHl7HaPrh9v0 RPKQ2zNAWQVvRWNLlm0w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idC4f-0005LA-EV; Fri, 06 Dec 2019 11:47:05 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idC4S-0005AZ-DN for linux-arm-kernel@lists.infradead.org; Fri, 06 Dec 2019 11:46:55 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7B23831B; Fri, 6 Dec 2019 03:46:51 -0800 (PST) Received: from arrakis.emea.arm.com (arrakis.cambridge.arm.com [10.1.197.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4565B3F52E; Fri, 6 Dec 2019 03:46:50 -0800 (PST) Date: Fri, 6 Dec 2019 11:46:48 +0000 From: Catalin Marinas To: Marc Zyngier Subject: Re: [PATCH v2] arm64: KVM: Invoke compute_layout() before alternatives are applied Message-ID: <20191206114647.GB32767@arrakis.emea.arm.com> References: <20191016165953.o6ogh4fdmsjmd2sw@linutronix.de> <20191128195805.c2pryug4ohmcoqwd@linutronix.de> <5aae0e8248df45c3f4c08a8bb5aabe06@www.loen.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5aae0e8248df45c3f4c08a8bb5aabe06@www.loen.fr> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_034652_521097_0F7775BB X-CRM114-Status: GOOD ( 13.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Suzuki K Poulose , Sebastian Andrzej Siewior , James Morse , linux-arm-kernel@lists.infradead.org, Thomas Gleixner , Will Deacon , kvmarm@lists.cs.columbia.edu, Julien Thierry Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Dec 06, 2019 at 11:22:02AM +0000, Marc Zyngier wrote: > On 2019-11-28 19:58, Sebastian Andrzej Siewior wrote: > > compute_layout() is invoked as part of an alternative fixup under > > stop_machine(). This function invokes get_random_long() which acquires a > > sleeping lock on -RT which can not be acquired in this context. > > > > Rename compute_layout() to kvm_compute_layout() and invoke it before > > stop_machine() applies the alternatives. Add a __init prefix to > > kvm_compute_layout() because the caller has it, too (and so the code can > > be > > discarded after boot). > > > > Signed-off-by: Sebastian Andrzej Siewior > > Acked-by: Marc Zyngier > > I think this should go via the arm64 tree, so I'll let Catalin > and Will pick this up (unless they think otherwise). I can pick this up. Thanks. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel