From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: virtio-fs@redhat.com, mszeredi@redhat.com, qemu-devel@nongnu.org
Subject: Re: [Virtio-fs] [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo
Date: Fri, 6 Dec 2019 15:55:38 +0000 [thread overview]
Message-ID: <20191206155538.GH2878@work-vm> (raw)
In-Reply-To: <20191204194250.GN3325@work-vm>
* Dr. David Alan Gilbert (dgilbert@redhat.com) wrote:
> * Vivek Goyal (vgoyal@redhat.com) wrote:
> > There are some unused fields in "struct fv_QueueInfo". Get rid of these fields.
> >
> > Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
> > ---
> > contrib/virtiofsd/fuse_virtio.c | 6 ------
> > 1 file changed, 6 deletions(-)
> >
> > diff --git a/contrib/virtiofsd/fuse_virtio.c b/contrib/virtiofsd/fuse_virtio.c
> > index 31c8542b6c..2a9cd60a01 100644
> > --- a/contrib/virtiofsd/fuse_virtio.c
> > +++ b/contrib/virtiofsd/fuse_virtio.c
> > @@ -50,12 +50,6 @@ struct fv_QueueInfo {
> > int qidx;
> > int kick_fd;
> > int kill_fd; /* For killing the thread */
> > -
> > - /* The element for the command currently being processed */
> > - VuVirtqElement *qe;
> > - /* If any of the qe vec elements (towards vmm) are unmappable */
> > - unsigned int elem_bad_in;
> > - bool reply_sent;
>
> Yep, those last two got moved into FVRequest as part of the thread pool
> stuff.
>
>
> Reviewed-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
I've merged that 1/5 into my world.
> > };
> >
> > /* A FUSE request */
> > --
> > 2.20.1
> >
> --
> Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
>
> _______________________________________________
> Virtio-fs mailing list
> Virtio-fs@redhat.com
> https://www.redhat.com/mailman/listinfo/virtio-fs
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK
next prev parent reply other threads:[~2019-12-06 15:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 19:08 [PATCH v2 0/5] [RFC] virtiofsd, vhost-user-fs: Add support for notification queue Vivek Goyal
2019-12-04 19:08 ` [Virtio-fs] " Vivek Goyal
2019-12-04 19:08 ` [PATCH v2 1/5] virtiofsd: Get rid of unused fields in fv_QueueInfo Vivek Goyal
2019-12-04 19:08 ` [Virtio-fs] " Vivek Goyal
2019-12-04 19:42 ` Dr. David Alan Gilbert
2019-12-04 19:42 ` [Virtio-fs] " Dr. David Alan Gilbert
2019-12-06 15:55 ` Dr. David Alan Gilbert [this message]
2019-12-04 19:08 ` [PATCH v2 2/5] virtiofsd: Release file locks using F_UNLCK Vivek Goyal
2019-12-04 19:08 ` [Virtio-fs] " Vivek Goyal
2019-12-04 19:08 ` [PATCH v2 3/5] virtiofd: Create a notification queue Vivek Goyal
2019-12-04 19:08 ` [Virtio-fs] " Vivek Goyal
2019-12-04 19:08 ` [PATCH v2 4/5] virtiofsd: Specify size of notification buffer using config space Vivek Goyal
2019-12-04 19:08 ` [Virtio-fs] " Vivek Goyal
2019-12-04 19:08 ` [PATCH v2 5/5] virtiofsd: Implement blocking posix locks Vivek Goyal
2019-12-04 19:08 ` [Virtio-fs] " Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206155538.GH2878@work-vm \
--to=dgilbert@redhat.com \
--cc=mszeredi@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.