Re: [Intel-gfx] [PATCH] drm/i915/bios: remove extra debug messages

[Matt Roper <matthew.d.roper@intel.com>]

On Fri, Dec 06, 2019 at 11:05:52AM -0800, Lucas De Marchi wrote:
> Just like in 523e0cc89b83 ("drm/i915/tgl: allow DVI/HDMI on port A"),
> the port checks when reading the VBT can easily not match what the
> platform really exposes. However here we only have some additional debug
> messages that are not adding much value: in the previous debug message
> we already print everything we know about the VBT.
> 
> Instead of keep fixing the possible port assignments according to the
> platform, just nuke the additional messages.
> 
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>

Seems reasonable to me.  The detailed "Port X VBT info:" line gives
plenty of information for anyone trying to debug problems.

Reviewed-by: Matt Roper <matthew.d.roper@intel.com>

> ---
>  drivers/gpu/drm/i915/display/intel_bios.c | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_bios.c b/drivers/gpu/drm/i915/display/intel_bios.c
> index 1aeecdd02293..e054e87eba8e 100644
> --- a/drivers/gpu/drm/i915/display/intel_bios.c
> +++ b/drivers/gpu/drm/i915/display/intel_bios.c
> @@ -1602,22 +1602,6 @@ static void parse_ddi_port(struct drm_i915_private *dev_priv,
>  		      HAS_LSPCON(dev_priv) && child->lspcon,
>  		      info->supports_typec_usb, info->supports_tbt);
>  
> -	if (is_edp && is_dvi)
> -		DRM_DEBUG_KMS("Internal DP port %c is TMDS compatible\n",
> -			      port_name(port));
> -	if (is_crt && port != PORT_E)
> -		DRM_DEBUG_KMS("Port %c is analog\n", port_name(port));
> -	if (is_crt && (is_dvi || is_dp))
> -		DRM_DEBUG_KMS("Analog port %c is also DP or TMDS compatible\n",
> -			      port_name(port));
> -	if (is_dvi && (port == PORT_A || port == PORT_E))
> -		DRM_DEBUG_KMS("Port %c is TMDS compatible\n", port_name(port));
> -	if (!is_dvi && !is_dp && !is_crt)
> -		DRM_DEBUG_KMS("Port %c is not DP/TMDS/CRT compatible\n",
> -			      port_name(port));
> -	if (is_edp && (port == PORT_B || port == PORT_C || port == PORT_E))
> -		DRM_DEBUG_KMS("Port %c is internal DP\n", port_name(port));
> -
>  	if (is_dvi) {
>  		u8 ddc_pin;
>  
> -- 
> 2.24.0
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx