All of lore.kernel.org
 help / color / mirror / Atom feed
From: Duncan Roe <duncan_roe@optusnet.com.au>
To: Pablo Neira Ayuso <pablo@netfilter.org>
Cc: Netfilter Development <netfilter-devel@vger.kernel.org>
Subject: Re: Documentation question (verdicts)
Date: Sat, 7 Dec 2019 12:28:43 +1100	[thread overview]
Message-ID: <20191207012843.GA22674@dimstar.local.net> (raw)
In-Reply-To: <20191202102623.GA775@dimstar.local.net>

Hi Pablo,

On Mon, Dec 02, 2019 at 09:26:23PM +1100, Duncan Roe wrote:
> Hi Pablo,
>
> Queue handling [DEPRECATED] in libnetfilter_queue.c documents these 3:
>
> > 278  *   - NF_ACCEPT the packet passes, continue iterations
> > 281  *   - NF_REPEAT iterate the same cycle once more
> > 282  *   - NF_STOP accept, but don't continue iterations
>
> In my tests, NF_REPEAT works as documented - the input hook presents the packet
> a second time. But, contrary to the above, the packet does not show again
> after NF_ACCEPT.
>
> Is that expected behaviour nowadays?
>
> And if so, does that make NF_STOP redundant?
>
> BTW if you'd like to try it, my test program nfq6 is a subdirectory at
> https://github.com/duncan-roe/nfq (nfq itself is an ad blocker).
>
> Cheers ... Duncan.

Specifically I need to know whether to document NF_STOP as obsolete (same as
NF_ACCEPT).

Cheers ... Duncan.

  reply	other threads:[~2019-12-07  1:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-02 10:26 Documentation question (verdicts) Duncan Roe
2019-12-07  1:28 ` Duncan Roe [this message]
2019-12-07 11:16   ` Florian Westphal
2019-12-07 11:49     ` Duncan Roe
2019-12-07 11:52       ` Florian Westphal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207012843.GA22674@dimstar.local.net \
    --to=duncan_roe@optusnet.com.au \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=pablo@netfilter.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.