From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2CBEBC2BBE2 for ; Sat, 7 Dec 2019 13:29:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0354B24676 for ; Sat, 7 Dec 2019 13:29:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575725343; bh=h2OuwS7wr+vcyzOIsp3qmN766Q2fsuw4ieXO6+Dxin4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=1Ki+3DjBjZku8EXOocRlBjJ9OHjhzZGcgoe58XzejkskjXNAw0/TFsX2qD2tZxS2x Is5L5V3NVYsCaFHp7EfoFZypF8laFYnMM0EumeC+eNZuMWjX93ztPwD+dS620gUhTW hOLtT71CxlrCah/CcRZGwSqhu+t91r9ebOn8NCjQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726427AbfLGN3B (ORCPT ); Sat, 7 Dec 2019 08:29:01 -0500 Received: from mail-ed1-f67.google.com ([209.85.208.67]:33398 "EHLO mail-ed1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726399AbfLGN3A (ORCPT ); Sat, 7 Dec 2019 08:29:00 -0500 Received: by mail-ed1-f67.google.com with SMTP id l63so8416533ede.0; Sat, 07 Dec 2019 05:28:59 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7y0ZNBEgzv9XawrP/HXbktND1cefPtKyMWBgc9jJ2Vc=; b=JZg9BcKcMSya7UussQ+45bJwZwLg7xBRt8yTcjoJdt2IYIHPEfUmS5/RituwfZsthZ /8a6JVTY8JK/9RyuYydmlmO+PuNsMgOIqjQIejGl0F2qswcQgPysBWnFC2kyKRMGWbx+ V2gBUmRuy9y5wWdhHUXs3g/fcYgVLrUpoiCBMj4/icdBmvCEO+6xtqB+kOETzlMxw18J +higWDsgclUWirVmK9AWcfjfa73r4D8x1O5ySC8XjgzSVsja6xlo0ZaR3nTWtEH0SV4M DRlLBAwi+St/nahL9M20BumF/Of5pkWNur8jd7hAhUW+MTPEZ4GSX4GcuAaYpd6hlxvX 9RkA== X-Gm-Message-State: APjAAAVsPWImq+9pH0Q+6BZbbopf9KVNVlb273pKkdyOJvcZbGJWCWf0 ZjOz3C3rXiue+DlDeY1FMiE= X-Google-Smtp-Source: APXvYqwRuhyCcWafkNThzuWx6NKR53IU32fzXyZq05AftVy3xEUUe89MpZPIHixera5+axOlKJ1iTg== X-Received: by 2002:a17:906:2ecd:: with SMTP id s13mr14517103eji.195.1575725338853; Sat, 07 Dec 2019 05:28:58 -0800 (PST) Received: from kozik-lap ([194.230.155.234]) by smtp.googlemail.com with ESMTPSA id rl27sm191361ejb.11.2019.12.07.05.28.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Dec 2019 05:28:58 -0800 (PST) Date: Sat, 7 Dec 2019 14:28:55 +0100 From: Krzysztof Kozlowski To: Hyunki Koo Cc: linux@armlinux.org.uk, kgene@kernel.org, tglx@linutronix.de, jason@lakedaemon.net, maz@kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Hyunki Koo Subject: Re: [PATCH 1/2] irqchip: define EXYNOS_IRQ_COMBINER Message-ID: <20191207132855.GA4384@kozik-lap> References: <20191207130049.27533-1-hyunki00.koo@gmail.com> <20191207130049.27533-2-hyunki00.koo@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191207130049.27533-2-hyunki00.koo@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 07, 2019 at 10:00:48PM +0900, Hyunki Koo wrote: > From: Hyunki Koo > > Not all exynos device have IRQ_COMBINER. > Thus add the config for EXYNOS_IRQ_COMBINER. > > Signed-off-by: Hyunki Koo > --- > drivers/irqchip/Kconfig | 7 +++++++ > drivers/irqchip/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > Hi, There is no changelog and versioning of this patch so I do not understand how it differs with previous. It's a resend? v2? It brings the confusion and looks like you're ignoring previous comments. Looks the same and looks like breaking Exynos platforms in the same way. If you not want to skip combiner on ARMv8, it makes sense, then please follow the approach we did for Pinctrl drivers (PINCTRL_EXYNOS_ARM and PINCTRL_EXYNOS_ARM64). Best regards, Krzysztof > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index ba152954324b..3ed7b7f2ae26 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -499,4 +499,11 @@ config SIFIVE_PLIC > > If you don't know what to do here, say Y. > > +config EXYNOS_IRQ_COMBINER > + bool "Samsung Exynos IRQ combiner support" > + depends on ARCH_EXYNOS > + help > + Say yes here to add support for the IRQ combiner devices embedded > + in Samsung Exynos chips. > + > endmenu > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index e806dda690ea..60d7c7260fc3 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o > obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o > obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o > obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o > -obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o > +obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o > obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o > obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o > obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o > -- > 2.17.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2ECEBC43603 for ; Sat, 7 Dec 2019 13:29:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E9A6224676 for ; Sat, 7 Dec 2019 13:29:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="tvwDayzP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E9A6224676 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ycCxj1psv0lbd90F9pKupvAZ1jAO82UF5U8JvLzehVc=; b=tvwDayzPA/1ZTa PbTvXYs/3+uExsBRe0LR+s3Ee4DCyyFQBWhNwxL6L8rxMWwp6JzBEhM++N24tMtey0r3egpW2JVzL 0I+rh9X8vvm3G263feHCEQXrUY2mHTvcZAomWkz/ompuah3jltv2+4ibe5u7D10b8do14XtMyGsIK O+tEa6tthvyu4NxRXQZUqrpi940TLUfZUPVLzGmWuM2KomzQjaRBNA8MgdQn9RAvCzbQnE2DR81FI kPxTNVAOC1WAqkZOv7oqYNRZFfxQwY3RYUldtwYTinyDux5zi73os+ZfAmG5FFKsK27lORmj5xjyJ GoKU2cLzDeHJL0itODIQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ida8v-0001xm-PL; Sat, 07 Dec 2019 13:29:05 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ida8s-0001x7-LU for linux-arm-kernel@lists.infradead.org; Sat, 07 Dec 2019 13:29:03 +0000 Received: by mail-ed1-f67.google.com with SMTP id f8so8401251edv.2 for ; Sat, 07 Dec 2019 05:29:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=7y0ZNBEgzv9XawrP/HXbktND1cefPtKyMWBgc9jJ2Vc=; b=aCQKMS6OUNtY67rvjsSQkJ3ixoHMFKkAsPMelUBTanSIsYvg0SZwY4z4dnQydkWZ+b q+PXcFn4Npb6kmVvCSCjuDus6JSeN/R+RvMnMAyWx7Yk5n0oD8n7dmJO4PxdpvuNIW0y niD//SJIJG7MxEjg1bA/8lmLaCdu3dVYtTGsJ7PBbsrIyLwg95wUJIprO8ITW0rBZy8x 0Kfoej+HWRgRcaOKb9jLX6pUqcFAL5/7XDZ4mHfBcJY64gAQNcMSSherx+LcWbr+Y3bD M4f0WQllJeYBy+1zlJCIF7NGexL3WKLQtz7RkEjUW0k1CbaoToGH8ZBVS61dJx2NtA5w irjA== X-Gm-Message-State: APjAAAXPTnIwQ4iwGH4BKU4YUo+zFiFnVMOzpekIwtp9SdSqH9wUFAUU FYMoR3rRBMKZK/F5nDotQJQ= X-Google-Smtp-Source: APXvYqwRuhyCcWafkNThzuWx6NKR53IU32fzXyZq05AftVy3xEUUe89MpZPIHixera5+axOlKJ1iTg== X-Received: by 2002:a17:906:2ecd:: with SMTP id s13mr14517103eji.195.1575725338853; Sat, 07 Dec 2019 05:28:58 -0800 (PST) Received: from kozik-lap ([194.230.155.234]) by smtp.googlemail.com with ESMTPSA id rl27sm191361ejb.11.2019.12.07.05.28.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 07 Dec 2019 05:28:58 -0800 (PST) Date: Sat, 7 Dec 2019 14:28:55 +0100 From: Krzysztof Kozlowski To: Hyunki Koo Subject: Re: [PATCH 1/2] irqchip: define EXYNOS_IRQ_COMBINER Message-ID: <20191207132855.GA4384@kozik-lap> References: <20191207130049.27533-1-hyunki00.koo@gmail.com> <20191207130049.27533-2-hyunki00.koo@gmail.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191207130049.27533-2-hyunki00.koo@gmail.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191207_052902_702683_182FE3F8 X-CRM114-Status: GOOD ( 18.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, jason@lakedaemon.net, maz@kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, kgene@kernel.org, Hyunki Koo , tglx@linutronix.de, kernel-team@android.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 07, 2019 at 10:00:48PM +0900, Hyunki Koo wrote: > From: Hyunki Koo > > Not all exynos device have IRQ_COMBINER. > Thus add the config for EXYNOS_IRQ_COMBINER. > > Signed-off-by: Hyunki Koo > --- > drivers/irqchip/Kconfig | 7 +++++++ > drivers/irqchip/Makefile | 2 +- > 2 files changed, 8 insertions(+), 1 deletion(-) > Hi, There is no changelog and versioning of this patch so I do not understand how it differs with previous. It's a resend? v2? It brings the confusion and looks like you're ignoring previous comments. Looks the same and looks like breaking Exynos platforms in the same way. If you not want to skip combiner on ARMv8, it makes sense, then please follow the approach we did for Pinctrl drivers (PINCTRL_EXYNOS_ARM and PINCTRL_EXYNOS_ARM64). Best regards, Krzysztof > diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig > index ba152954324b..3ed7b7f2ae26 100644 > --- a/drivers/irqchip/Kconfig > +++ b/drivers/irqchip/Kconfig > @@ -499,4 +499,11 @@ config SIFIVE_PLIC > > If you don't know what to do here, say Y. > > +config EXYNOS_IRQ_COMBINER > + bool "Samsung Exynos IRQ combiner support" > + depends on ARCH_EXYNOS > + help > + Say yes here to add support for the IRQ combiner devices embedded > + in Samsung Exynos chips. > + > endmenu > diff --git a/drivers/irqchip/Makefile b/drivers/irqchip/Makefile > index e806dda690ea..60d7c7260fc3 100644 > --- a/drivers/irqchip/Makefile > +++ b/drivers/irqchip/Makefile > @@ -9,7 +9,7 @@ obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2835.o > obj-$(CONFIG_ARCH_BCM2835) += irq-bcm2836.o > obj-$(CONFIG_DAVINCI_AINTC) += irq-davinci-aintc.o > obj-$(CONFIG_DAVINCI_CP_INTC) += irq-davinci-cp-intc.o > -obj-$(CONFIG_ARCH_EXYNOS) += exynos-combiner.o > +obj-$(CONFIG_EXYNOS_IRQ_COMBINER) += exynos-combiner.o > obj-$(CONFIG_FARADAY_FTINTC010) += irq-ftintc010.o > obj-$(CONFIG_ARCH_HIP04) += irq-hip04.o > obj-$(CONFIG_ARCH_LPC32XX) += irq-lpc32xx.o > -- > 2.17.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel