From mboxrd@z Thu Jan 1 00:00:00 1970 From: Colin King Date: Sat, 07 Dec 2019 15:33:43 +0000 Subject: [PATCH] cpu: microcode: remove redundant check on pointer entry Message-Id: <20191207153343.112887-1-colin.king@canonical.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org From: Colin Ian King The check for a null entry is redundant as the while loop also checks for this. Remove the redundant check. Cleans up cppcheck style warning: src/cpu/microcode/microcode.c:203:14: style: Condition 'entry' is always true [knownConditionTrueFalse] if (entry && src/cpu/microcode/microcode.c:202:32: note: Assuming that condition '(entry=readdir(dir))!=NULL' is not redundant while ((entry = readdir(dir)) != NULL) { src/cpu/microcode/microcode.c:203:14: note: Condition 'entry' is always true if (entry && Signed-off-by: Colin Ian King --- src/cpu/microcode/microcode.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/cpu/microcode/microcode.c b/src/cpu/microcode/microcode.c index 974fdec9..65abe50a 100644 --- a/src/cpu/microcode/microcode.c +++ b/src/cpu/microcode/microcode.c @@ -200,8 +200,7 @@ static int microcode_test1(fwts_framework *fw) /* Scan and check */ while ((entry = readdir(dir)) != NULL) { - if (entry && - (strlen(entry->d_name) > 3) && + if ((strlen(entry->d_name) > 3) && (strncmp(entry->d_name,"cpu", 3) = 0) && (isdigit(entry->d_name[3]))) { char path[PATH_MAX]; -- 2.24.0