All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dr. David Alan Gilbert" <linux@treblig.org>
To: Guenter Roeck <linux@roeck-us.net>
Cc: jdelvare@suse.com, linux-hwmon@vger.kernel.org
Subject: Re: [PATCH 2/2] hwmon: (w83627ehf) convert to with_info interface
Date: Sat, 7 Dec 2019 16:49:36 +0000	[thread overview]
Message-ID: <20191207164936.GA25521@gallifrey> (raw)
In-Reply-To: <20191207135127.GA24852@roeck-us.net>

* Guenter Roeck (linux@roeck-us.net) wrote:
> On Sun, Nov 24, 2019 at 08:20:30PM +0000, Dr. David Alan Gilbert wrote:
> > Convert the old hwmon_device_register code to
> > devm_hwmon_device_register_with_info.
> > 
> > Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> 
> Looks good. I am sure I am missing something, given the size of the patch,

Thanks! I couldn't see an obvious way to split it and keep it working
bisectably.

> but I am going to apply this to hwmon-next.

Great.

> Side note: At some point we should drop support for nct6775 and nct6776
> from this driver.

Hehe it would have probably easier to do that first!  Oh well,
I've added it to a TODO, that means nothing about if/when I'll actually
get around to it!

Thanks again,

Dave


> Thanks,
> Guenter
-- 
 -----Open up your eyes, open up your mind, open up your code -------   
/ Dr. David Alan Gilbert    |       Running GNU/Linux       | Happy  \ 
\        dave @ treblig.org |                               | In Hex /
 \ _________________________|_____ http://www.treblig.org   |_______/

  reply	other threads:[~2019-12-07 16:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-24 20:20 [PATCH 0/2] hwmon: convert w83627ehf to new interface Dr. David Alan Gilbert
2019-11-24 20:20 ` [PATCH 1/2] hwmon: Add intrusion templates Dr. David Alan Gilbert
2019-11-29 18:39   ` Guenter Roeck
2019-11-24 20:20 ` [PATCH 2/2] hwmon: (w83627ehf) convert to with_info interface Dr. David Alan Gilbert
2019-12-07 13:51   ` Guenter Roeck
2019-12-07 16:49     ` Dr. David Alan Gilbert [this message]
2019-12-24  2:16       ` Dr. David Alan Gilbert
2019-12-24  2:21         ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191207164936.GA25521@gallifrey \
    --to=linux@treblig.org \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.