All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v2 1/1] package/pkg-golang: enable trimpath option for reproducible builds
@ 2019-12-07 19:57 Christian Stewart
  2019-12-08  7:42 ` Peter Korsgaard
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Stewart @ 2019-12-07 19:57 UTC (permalink / raw)
  To: buildroot

The -trimpath option removes absolute build paths from the target binary. This
results in more consistent / reproducible builds across different systems with
varying paths to Buildroot.

Signed-off-by: Christian Stewart <christian@paral.in>
---

v1 -> v2:

 - Fixed indentation on trimpath

 package/pkg-golang.mk | 1 +
 1 file changed, 1 insertion(+)

diff --git a/package/pkg-golang.mk b/package/pkg-golang.mk
index e47de17aba..2494ce028c 100644
--- a/package/pkg-golang.mk
+++ b/package/pkg-golang.mk
@@ -61,6 +61,7 @@ $(2)_WORKSPACE ?= _gopath
 $(2)_BUILD_OPTS += \
 	-ldflags "$$($(2)_LDFLAGS)" \
 	-tags "$$($(2)_TAGS)" \
+	-trimpath \
 	-p $(PARALLEL_JOBS)
 
 # Target packages need the Go compiler on the host.
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH v2 1/1] package/pkg-golang: enable trimpath option for reproducible builds
  2019-12-07 19:57 [Buildroot] [PATCH v2 1/1] package/pkg-golang: enable trimpath option for reproducible builds Christian Stewart
@ 2019-12-08  7:42 ` Peter Korsgaard
  0 siblings, 0 replies; 2+ messages in thread
From: Peter Korsgaard @ 2019-12-08  7:42 UTC (permalink / raw)
  To: buildroot

>>>>> "Christian" == Christian Stewart <christian@paral.in> writes:

 > The -trimpath option removes absolute build paths from the target binary. This
 > results in more consistent / reproducible builds across different systems with
 > varying paths to Buildroot.

 > Signed-off-by: Christian Stewart <christian@paral.in>
 > ---

 > v1 -> v2:
 >  - Fixed indentation on trimpath

Committed after extending the commit message to clarify that this is a
new feature in go 1.13, so we shouldn't backport this to 2019.02.x.

-- 
Bye, Peter Korsgaard

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-08  7:42 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 19:57 [Buildroot] [PATCH v2 1/1] package/pkg-golang: enable trimpath option for reproducible builds Christian Stewart
2019-12-08  7:42 ` Peter Korsgaard

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.