All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH v1] acsccid: needs locale
@ 2019-12-07 20:40 Peter Seiderer
  2019-12-08 10:15 ` Bernd Kuhls
  0 siblings, 1 reply; 4+ messages in thread
From: Peter Seiderer @ 2019-12-07 20:40 UTC (permalink / raw)
  To: buildroot

Needs locale/iconv since the bump from 1.1.4 to 1.1.7 [1]
including upstream commit [2].

Fixes:
  http://autobuild.buildroot.net/results/829b69ca27671bd4612f39733149ea278f5f6b2d

  ifdhandler.c:60:10: fatal error: iconv.h: No such file or directory
   #include <iconv.h>

[1] https://git.buildroot.net/buildroot/commit/?id=6c6a37b2901459425ebe83e30123e4c9a2e7b6cf
[2] https://github.com/acshk/acsccid/commit/5672d821ba96deb6c0c11060e4de0c9dab9b21c7

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 package/acsccid/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/package/acsccid/Config.in b/package/acsccid/Config.in
index 90624ee797..90bf63a0c4 100644
--- a/package/acsccid/Config.in
+++ b/package/acsccid/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_ACSCCID
 	bool "acsccid"
+	depends on BR2_ENABLE_LOCALE
 	depends on BR2_TOOLCHAIN_HAS_THREADS # pcsc-lite, libusb
 	depends on BR2_USE_MMU # pcsc-lite
 	depends on !BR2_STATIC_LIBS # pcsc-lite
@@ -13,7 +14,7 @@ config BR2_PACKAGE_ACSCCID
 
 	  http://acsccid.sourceforge.net/
 
-comment "acsccid needs a toolchain w/ threads, dynamic library"
+comment "acsccid needs a toolchain w/ threads, dynamic library, locale"
 	depends on BR2_USE_MMU
-	depends on !BR2_TOOLCHAIN_HAS_THREADS || \
+	depends on !BR2_ENABLE_LOCALE || !BR2_TOOLCHAIN_HAS_THREADS || \
 		BR2_STATIC_LIBS
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v1] acsccid: needs locale
  2019-12-07 20:40 [Buildroot] [PATCH v1] acsccid: needs locale Peter Seiderer
@ 2019-12-08 10:15 ` Bernd Kuhls
  2019-12-08 13:32   ` Thomas Petazzoni
  2019-12-08 18:56   ` Peter Seiderer
  0 siblings, 2 replies; 4+ messages in thread
From: Bernd Kuhls @ 2019-12-08 10:15 UTC (permalink / raw)
  To: buildroot

Am Sat, 07 Dec 2019 21:40:42 +0100 schrieb Peter Seiderer:

> Needs locale/iconv since the bump from 1.1.4 to 1.1.7 [1]
> including upstream commit [2].

Hi,

already sent patch adding libiconv as optional dependency when needed:
http://patchwork.ozlabs.org/patch/1186510/

Regards, Bernd

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v1] acsccid: needs locale
  2019-12-08 10:15 ` Bernd Kuhls
@ 2019-12-08 13:32   ` Thomas Petazzoni
  2019-12-08 18:56   ` Peter Seiderer
  1 sibling, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2019-12-08 13:32 UTC (permalink / raw)
  To: buildroot

On Sun, 08 Dec 2019 11:15:57 +0100
Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Am Sat, 07 Dec 2019 21:40:42 +0100 schrieb Peter Seiderer:
> 
> > Needs locale/iconv since the bump from 1.1.4 to 1.1.7 [1]
> > including upstream commit [2].  
> 
> Hi,
> 
> already sent patch adding libiconv as optional dependency when needed:
> http://patchwork.ozlabs.org/patch/1186510/

Agreed, so I've applied your patch.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] [PATCH v1] acsccid: needs locale
  2019-12-08 10:15 ` Bernd Kuhls
  2019-12-08 13:32   ` Thomas Petazzoni
@ 2019-12-08 18:56   ` Peter Seiderer
  1 sibling, 0 replies; 4+ messages in thread
From: Peter Seiderer @ 2019-12-08 18:56 UTC (permalink / raw)
  To: buildroot

Hello Bernd,

On Sun, 08 Dec 2019 11:15:57 +0100, Bernd Kuhls <bernd.kuhls@t-online.de> wrote:

> Am Sat, 07 Dec 2019 21:40:42 +0100 schrieb Peter Seiderer:
>
> > Needs locale/iconv since the bump from 1.1.4 to 1.1.7 [1]
> > including upstream commit [2].
>
> Hi,
>
> already sent patch adding libiconv as optional dependency when needed:
> http://patchwork.ozlabs.org/patch/1186510/

Ups, seem to missed your patch (or did not search long enough backwards)...,
sorry for the noise...
Regards,
Peter

>
> Regards, Bernd
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-12-08 18:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 20:40 [Buildroot] [PATCH v1] acsccid: needs locale Peter Seiderer
2019-12-08 10:15 ` Bernd Kuhls
2019-12-08 13:32   ` Thomas Petazzoni
2019-12-08 18:56   ` Peter Seiderer

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.