All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] objtool: silence build output from sync-check.sh
@ 2019-12-07 20:54 Olof Johansson
  2019-12-09 18:08 ` Josh Poimboeuf
  0 siblings, 1 reply; 3+ messages in thread
From: Olof Johansson @ 2019-12-07 20:54 UTC (permalink / raw)
  To: Josh Poimboeuf, Peter Zijlstra; +Cc: linux-kernel, torvalds, Olof Johansson

The sync-check.sh script prints out the path due to a "cd -" at the end
of the script, even on silent builds. This isn't needed, since the
script is never sourced (so it won't change the working directory of
the surrounding build anyway).

Just remove the cd to make the build silent.

Fixes: 2ffd84ae973b ("objtool: Update sync-check.sh from perf's check-headers.sh")
Signed-off-by: Olof Johansson <olof@lixom.net>
---
 tools/objtool/sync-check.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/objtool/sync-check.sh b/tools/objtool/sync-check.sh
index 9bd04bbed01e..2a1261bfbb62 100755
--- a/tools/objtool/sync-check.sh
+++ b/tools/objtool/sync-check.sh
@@ -48,5 +48,3 @@ check arch/x86/include/asm/inat.h     '-I "^#include [\"<]\(asm/\)*inat_types.h[
 check arch/x86/include/asm/insn.h     '-I "^#include [\"<]\(asm/\)*inat.h[\">]"'
 check arch/x86/lib/inat.c             '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"'
 check arch/x86/lib/insn.c             '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"'
-
-cd -
-- 
2.22.GIT


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] objtool: silence build output from sync-check.sh
  2019-12-07 20:54 [PATCH] objtool: silence build output from sync-check.sh Olof Johansson
@ 2019-12-09 18:08 ` Josh Poimboeuf
  2019-12-16 22:01   ` [PATCH] objtool: silence build output Olof Johansson
  0 siblings, 1 reply; 3+ messages in thread
From: Josh Poimboeuf @ 2019-12-09 18:08 UTC (permalink / raw)
  To: Olof Johansson; +Cc: Peter Zijlstra, linux-kernel, torvalds

On Sat, Dec 07, 2019 at 12:54:20PM -0800, Olof Johansson wrote:
> The sync-check.sh script prints out the path due to a "cd -" at the end
> of the script, even on silent builds. This isn't needed, since the
> script is never sourced (so it won't change the working directory of
> the surrounding build anyway).
> 
> Just remove the cd to make the build silent.
> 
> Fixes: 2ffd84ae973b ("objtool: Update sync-check.sh from perf's check-headers.sh")
> Signed-off-by: Olof Johansson <olof@lixom.net>
> ---
>  tools/objtool/sync-check.sh | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/objtool/sync-check.sh b/tools/objtool/sync-check.sh
> index 9bd04bbed01e..2a1261bfbb62 100755
> --- a/tools/objtool/sync-check.sh
> +++ b/tools/objtool/sync-check.sh
> @@ -48,5 +48,3 @@ check arch/x86/include/asm/inat.h     '-I "^#include [\"<]\(asm/\)*inat_types.h[
>  check arch/x86/include/asm/insn.h     '-I "^#include [\"<]\(asm/\)*inat.h[\">]"'
>  check arch/x86/lib/inat.c             '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"'
>  check arch/x86/lib/insn.c             '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"'
> -
> -cd -

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

If you want to send it through -tip, please resend to x86@kernel.org.

-- 
Josh


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] objtool: silence build output
  2019-12-09 18:08 ` Josh Poimboeuf
@ 2019-12-16 22:01   ` Olof Johansson
  0 siblings, 0 replies; 3+ messages in thread
From: Olof Johansson @ 2019-12-16 22:01 UTC (permalink / raw)
  To: x86; +Cc: linux-kernel, Olof Johansson, Josh Poimboeuf

The sync-check.sh script prints out the path due to a "cd -" at the end
of the script, even on silent builds. This isn't even needed, since the
script is executed in our build instead of sourced (so it won't change
the working directory of the surrounding build anyway).

Just remove the cd to make the build silent.

Fixes: 2ffd84ae973b ("objtool: Update sync-check.sh from perf's check-headers.sh")
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Olof Johansson <olof@lixom.net>
---
 tools/objtool/sync-check.sh | 2 --
 1 file changed, 2 deletions(-)

diff --git a/tools/objtool/sync-check.sh b/tools/objtool/sync-check.sh
index 9bd04bbed01e..2a1261bfbb62 100755
--- a/tools/objtool/sync-check.sh
+++ b/tools/objtool/sync-check.sh
@@ -48,5 +48,3 @@ check arch/x86/include/asm/inat.h     '-I "^#include [\"<]\(asm/\)*inat_types.h[
 check arch/x86/include/asm/insn.h     '-I "^#include [\"<]\(asm/\)*inat.h[\">]"'
 check arch/x86/lib/inat.c             '-I "^#include [\"<]\(../include/\)*asm/insn.h[\">]"'
 check arch/x86/lib/insn.c             '-I "^#include [\"<]\(../include/\)*asm/in\(at\|sn\).h[\">]" -I "^#include [\"<]\(../include/\)*asm/emulate_prefix.h[\">]"'
-
-cd -
-- 
2.22.GIT


^ permalink raw reply related	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-12-16 22:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-07 20:54 [PATCH] objtool: silence build output from sync-check.sh Olof Johansson
2019-12-09 18:08 ` Josh Poimboeuf
2019-12-16 22:01   ` [PATCH] objtool: silence build output Olof Johansson

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.