From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36DFEC43603 for ; Sun, 8 Dec 2019 03:04:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EB810206DF for ; Sun, 8 Dec 2019 03:04:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725865AbfLHDE1 (ORCPT ); Sat, 7 Dec 2019 22:04:27 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:56580 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725834AbfLHDE1 (ORCPT ); Sat, 7 Dec 2019 22:04:27 -0500 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1idmrg-00078U-Lw; Sun, 08 Dec 2019 03:04:09 +0000 Date: Sun, 8 Dec 2019 03:04:07 +0000 From: Al Viro To: Deepa Dinamani Cc: Linux Kernel Mailing List , Andrew Morton , Linux FS-devel Mailing List , Arnd Bergmann , ceph-devel , OGAWA Hirofumi , Jeff Layton , CIFS , linux-mtd , Richard Weinberger , Steve French Subject: Re: [PATCH v2 0/6] Delete timespec64_trunc() Message-ID: <20191208030407.GO4203@ZenIV.linux.org.uk> References: <20191203051945.9440-1-deepa.kernel@gmail.com> <20191207060201.GN4203@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-cifs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-cifs@vger.kernel.org On Sat, Dec 07, 2019 at 06:04:38PM -0800, Deepa Dinamani wrote: > On Fri, Dec 6, 2019 at 10:02 PM Al Viro wrote: > > > > On Thu, Dec 05, 2019 at 06:43:26PM -0800, Deepa Dinamani wrote: > > > On Mon, Dec 2, 2019 at 9:20 PM Deepa Dinamani wrote: > > > > This series aims at deleting timespec64_trunc(). > > > > There is a new api: timestamp_truncate() that is the > > > > replacement api. The api additionally does a limits > > > > check on the filesystem timestamps. > > > > > > Al/Andrew, can one of you help merge these patches? > > > > Looks sane. Could you check if #misc.timestamp looks sane to you? > > Yes, that looks sane to me. > > > One thing that leaves me scratching head is kernfs - surely we > > are _not_ limited by any external layouts there, so why do we > > need to bother with truncation? > > I think I was more pedantic then, and was explicitly truncating times > before assignment to inode timestamps. But, Arnd has since coached me > that we should not introduce things to safe guard against all > possibilities, but only what is needed currently. So this kernfs > truncate is redundant, given the limits and the granularity match vfs > timestamp representation limits. OK... I've tossed a followup removing the truncation from kernfs; the whole series looks reasonably safe, but I don't think it's urgent enough to even try getting it merged before -rc1. So here's what I'm going to do: immediately after -rc1 it gets renamed[*] to #imm.timestamp, which will be in the never-modified mode, in #for-next from the very begining and safe for other trees to pull. Current shortlog: Al Viro (1): kernfs: don't bother with timestamp truncation Amir Goldstein (1): utimes: Clamp the timestamps in notify_change() Deepa Dinamani (6): fs: fat: Eliminate timespec64_trunc() usage fs: cifs: Delete usage of timespec64_trunc fs: ceph: Delete timespec64_trunc() usage fs: ubifs: Eliminate timespec64_trunc() usage fs: Delete timespec64_trunc() fs: Do not overload update_time Diffstat: fs/attr.c | 23 +++++++++++------------ fs/ceph/mds_client.c | 4 +--- fs/cifs/inode.c | 13 +++++++------ fs/configfs/inode.c | 9 +++------ fs/f2fs/file.c | 18 ++++++------------ fs/fat/misc.c | 10 +++++++++- fs/inode.c | 33 +++------------------------------ fs/kernfs/inode.c | 6 +++--- fs/ntfs/inode.c | 18 ++++++------------ fs/ubifs/file.c | 18 ++++++------------ fs/ubifs/sb.c | 11 ++++------- fs/utimes.c | 4 ++-- include/linux/fs.h | 1 - 13 files changed, 61 insertions(+), 107 deletions(-) [*] right now it's based on v5.4; I don't see anything that would warrant rebasing it to -rc1 at the moment, but if anything of that sort shows up tomorrow, s/renamed/rebased to -rc1 and renamed/. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v2 0/6] Delete timespec64_trunc() Date: Sun, 8 Dec 2019 03:04:07 +0000 Message-ID: <20191208030407.GO4203@ZenIV.linux.org.uk> References: <20191203051945.9440-1-deepa.kernel@gmail.com> <20191207060201.GN4203@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-mtd" Errors-To: linux-mtd-bounces+gldm-linux-mtd-36=gmane.org@lists.infradead.org To: Deepa Dinamani Cc: CIFS , Arnd Bergmann , Richard Weinberger , Jeff Layton , Linux Kernel Mailing List , linux-mtd , Steve French , Linux FS-devel Mailing List , Andrew Morton , ceph-devel , OGAWA Hirofumi List-Id: ceph-devel.vger.kernel.org On Sat, Dec 07, 2019 at 06:04:38PM -0800, Deepa Dinamani wrote: > On Fri, Dec 6, 2019 at 10:02 PM Al Viro wrote: > > > > On Thu, Dec 05, 2019 at 06:43:26PM -0800, Deepa Dinamani wrote: > > > On Mon, Dec 2, 2019 at 9:20 PM Deepa Dinamani wrote: > > > > This series aims at deleting timespec64_trunc(). > > > > There is a new api: timestamp_truncate() that is the > > > > replacement api. The api additionally does a limits > > > > check on the filesystem timestamps. > > > > > > Al/Andrew, can one of you help merge these patches? > > > > Looks sane. Could you check if #misc.timestamp looks sane to you? > > Yes, that looks sane to me. > > > One thing that leaves me scratching head is kernfs - surely we > > are _not_ limited by any external layouts there, so why do we > > need to bother with truncation? > > I think I was more pedantic then, and was explicitly truncating times > before assignment to inode timestamps. But, Arnd has since coached me > that we should not introduce things to safe guard against all > possibilities, but only what is needed currently. So this kernfs > truncate is redundant, given the limits and the granularity match vfs > timestamp representation limits. OK... I've tossed a followup removing the truncation from kernfs; the whole series looks reasonably safe, but I don't think it's urgent enough to even try getting it merged before -rc1. So here's what I'm going to do: immediately after -rc1 it gets renamed[*] to #imm.timestamp, which will be in the never-modified mode, in #for-next from the very begining and safe for other trees to pull. Current shortlog: Al Viro (1): kernfs: don't bother with timestamp truncation Amir Goldstein (1): utimes: Clamp the timestamps in notify_change() Deepa Dinamani (6): fs: fat: Eliminate timespec64_trunc() usage fs: cifs: Delete usage of timespec64_trunc fs: ceph: Delete timespec64_trunc() usage fs: ubifs: Eliminate timespec64_trunc() usage fs: Delete timespec64_trunc() fs: Do not overload update_time Diffstat: fs/attr.c | 23 +++++++++++------------ fs/ceph/mds_client.c | 4 +--- fs/cifs/inode.c | 13 +++++++------ fs/configfs/inode.c | 9 +++------ fs/f2fs/file.c | 18 ++++++------------ fs/fat/misc.c | 10 +++++++++- fs/inode.c | 33 +++------------------------------ fs/kernfs/inode.c | 6 +++--- fs/ntfs/inode.c | 18 ++++++------------ fs/ubifs/file.c | 18 ++++++------------ fs/ubifs/sb.c | 11 ++++------- fs/utimes.c | 4 ++-- include/linux/fs.h | 1 - 13 files changed, 61 insertions(+), 107 deletions(-) [*] right now it's based on v5.4; I don't see anything that would warrant rebasing it to -rc1 at the moment, but if anything of that sort shows up tomorrow, s/renamed/rebased to -rc1 and renamed/. ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/