All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2, 1/1] package/alsa-utils: remove --disable-alsatest
Date: Sun, 8 Dec 2019 14:47:45 +0100	[thread overview]
Message-ID: <20191208144745.20a6ed97@windsurf.home> (raw)
In-Reply-To: <20191207091743.183814-1-fontaine.fabrice@gmail.com>

On Sat,  7 Dec 2019 10:17:43 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> atopology is needed to build alsa-utils since version 1.2.1 and
> https://github.com/alsa-project/alsa-utils/commit/c8fdd38c74de2e8b7b2b5a4576787d5e9b4ae807
> 
> However, atopology is not correctly detected if --disable-alsatest is
> passed so drop --disable-alsatest that is not needed since commit
> 2c03ec15307b567fd2250fe2a7981a89d19b87a9 (from 2002), which removed
> AC_TRY_RUN
> 
> Fixes:
>  - http://autobuild.buildroot.org/results/d0fb760669b02b813115af04adcf24530d35f4e1
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Thomas Petazzoni):
>  - Remove --disable-alsatest instead of adding --enable-alsa-topology

Applied to master, thanks.

However, while reviewing this I noticed that alsa-utils.mk contains:

# Regenerate aclocal.m4 to pick the patched
# version of alsa.m4 from alsa-lib
ALSA_UTILS_AUTORECONF = YES
ALSA_UTILS_GETTEXTIZE = YES

But, since commit e8cb594bc8ce07e22e247972a417d53fd56e10fb, we are no
longer patching alsa.m4 from alsa-lib, and a new version of alsa-utils
is used since commit 337bdb2b44c9696551a11f396dde86d3fa869426, which
perhaps has a bundled  configure script that was re-regenerated with
the new alsa.m4. Could you try if autoreconfiguring alsa-utils is still
necessary ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

      reply	other threads:[~2019-12-08 13:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07  9:17 [Buildroot] [PATCH v2, 1/1] package/alsa-utils: remove --disable-alsatest Fabrice Fontaine
2019-12-08 13:47 ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191208144745.20a6ed97@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.