All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 4/5] package/shairport-sync: add dbus option
Date: Sun, 8 Dec 2019 23:24:23 +0100	[thread overview]
Message-ID: <20191208232423.206f981a@windsurf.home> (raw)
In-Reply-To: <20191203105341.1232360-4-joerg.krause@embedded.rocks>

On Tue,  3 Dec 2019 11:53:40 +0100
J?rg Krause <joerg.krause@embedded.rocks> wrote:

> Shairport Sync added DBus support in version 3.2.
> 
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
> ---
>  package/shairport-sync/Config.in         | 11 +++++++++++
>  package/shairport-sync/shairport-sync.mk |  5 +++++
>  2 files changed, 16 insertions(+)
> 
> diff --git a/package/shairport-sync/Config.in b/package/shairport-sync/Config.in
> index 87f38a940d..6325e9d30d 100644
> --- a/package/shairport-sync/Config.in
> +++ b/package/shairport-sync/Config.in
> @@ -26,6 +26,17 @@ config BR2_PACKAGE_SHAIRPORT_SYNC_CONVOLUTION
>  	help
>  	  Enable audio DSP convolution support.
>  
> +config BR2_PACKAGE_SHAIRPORT_SYNC_DBUS
> +	bool "dbus support"
> +	depends on BR2_USE_WCHAR # libglib2 -> gettext

No need to repeat the full comment, just "# libglib2" is sufficient.

However, you forgot the other dependencies from libglib2: yes the
thread dependency was already implied by the dependency of
shairport-sync on NPTL, but the BR2_USE_MMU dependency was missing. So
I've replicated both, to keep things simple.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-12-08 22:24 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-03 10:53 [Buildroot] [PATCH 1/5] package/shairport-sync: bump to version 3.3.5 Jörg Krause
2019-12-03 10:53 ` [Buildroot] [PATCH 2/5] package/shairport-sync: make libdaemon an optional dependency Jörg Krause
2019-12-08 22:23   ` Thomas Petazzoni
2019-12-03 10:53 ` [Buildroot] [PATCH 3/5] package/shairport-sync: add audio DSP convolution option Jörg Krause
2019-12-08 22:23   ` Thomas Petazzoni
2019-12-03 10:53 ` [Buildroot] [PATCH 4/5] package/shairport-sync: add dbus option Jörg Krause
2019-12-08 22:24   ` Thomas Petazzoni [this message]
2019-12-03 10:53 ` [Buildroot] [PATCH 5/5] package/shairport-sync: add mqtt option Jörg Krause
2019-12-08 22:24   ` Thomas Petazzoni
2019-12-08 22:22 ` [Buildroot] [PATCH 1/5] package/shairport-sync: bump to version 3.3.5 Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191208232423.206f981a@windsurf.home \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.