[Intel-gfx] [PATCH] drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling

[Intel-gfx] [PATCH] drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling

[Chris Wilson]

Despite taking the intel_gt wakeref, and asserting that we do indeed
hold the runtime-pm wakeref for the device, our mmio debug insists that
the irq enabling is not being recognised:

[   19.342117] Unclaimed write to register 0x220a8
[   19.342185] WARNING: CPU: 2 PID: 619 at __unclaimed_reg_debug+0x4f/0x60 [i915]
[   19.342192] Modules linked in: nls_ascii nls_cp437 vfat i915 crct10dif_pclmul fat crc32_pclmul crc32c_intel aesni_intel glue_helper crypto_simd cryptd intel_cstate ahci intel_gtt libahci intel_uncore drm_kms_helper intel_rapl_perf i2c_i801 efivars video button efivarfs
[   19.342224] CPU: 2 PID: 619 Comm: gem_exec_parse_ Tainted: G     U            5.4.0-rc8+ #389
[   19.342230] Hardware name: Intel Corporation NUC7i5BNK/NUC7i5BNB, BIOS BNKBL357.86A.0052.2017.0918.1346 09/18/2017
[   19.342283] RIP: 0010:__unclaimed_reg_debug+0x4f/0x60 [i915]
[   19.342291] Code: 06 5b 5d 41 5c c3 c3 45 84 e4 48 c7 c0 15 af 2c a0 48 c7 c6 0b af 2c a0 89 ea 48 0f 44 f0 48 c7 c7 1e af 2c a0 e8 c7 56 e9 e0 <0f> 0b 83 2d e8 03 18 00 01 5b 5d 41 5c c3 0f 1f 00 23 b7 a4 00 00
[   19.342301] RSP: 0018:ffffc90000553a28 EFLAGS: 00010092
[   19.342309] RAX: 0000000000000023 RBX: 0000000000000000 RCX: 0000000000000006
[   19.342316] RDX: 0000000000000007 RSI: 0000000000000086 RDI: ffff88885eb163a0
[   19.342322] RBP: 00000000000220a8 R08: 000000000000028c R09: ffff88885a4c47c0
[   19.342328] R10: 0000000000000000 R11: 000000085488de02 R12: 0000000000000000
[   19.342334] R13: ffff8888548407c8 R14: 0000000000000006 R15: ffffc90000553b7c
[   19.342341] FS:  00007f0e8a2879c0(0000) GS:ffff88885eb00000(0000) knlGS:0000000000000000
[   19.342349] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[   19.342355] CR2: 00007f0e8c235e12 CR3: 0000000858ef7001 CR4: 00000000001606e0
[   19.342361] Call Trace:
[   19.342413]  fwtable_write32+0x1a0/0x1e0 [i915]
[   19.342476]  gen8_logical_ring_enable_irq+0x2d/0x40 [i915]
[   19.342541]  irq_enable.part.14+0x1d/0x30 [i915]
[   19.342598]  i915_request_enable_breadcrumb+0x16a/0x1a0 [i915]
[   19.342611]  ? sync_file_alloc+0x80/0x80
[   19.342620]  __dma_fence_enable_signaling+0x2c/0x50
[   19.342629]  dma_fence_add_callback+0x34/0x90
[   19.342638]  sync_file_poll+0x7b/0xa0

Just silence the critics :(

References: 045d1fb79616 ("drm/i915/gt: Acquire a GT wakeref for the breadcrumb interrupt")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
---
 drivers/gpu/drm/i915/gt/intel_lrc.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index fcd9bb771223..0bfafc29a3dc 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -3338,14 +3338,16 @@ static int gen9_emit_bb_start(struct i915_request *rq,
 
 static void gen8_logical_ring_enable_irq(struct intel_engine_cs *engine)
 {
-	ENGINE_WRITE(engine, RING_IMR,
-		     ~(engine->irq_enable_mask | engine->irq_keep_mask));
+	GEM_BUG_ON(!intel_gt_pm_is_awake(engine->gt));
+
+	ENGINE_WRITE_FW(engine, RING_IMR,
+			~(engine->irq_enable_mask | engine->irq_keep_mask));
 	ENGINE_POSTING_READ(engine, RING_IMR);
 }
 
 static void gen8_logical_ring_disable_irq(struct intel_engine_cs *engine)
 {
-	ENGINE_WRITE(engine, RING_IMR, ~engine->irq_keep_mask);
+	ENGINE_WRITE_FW(engine, RING_IMR, ~engine->irq_keep_mask);
 }
 
 static int gen8_emit_flush(struct i915_request *request, u32 mode)
-- 
2.24.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling

[Patchwork]

== Series Details ==

Series: drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling
URL   : https://patchwork.freedesktop.org/series/70603/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
5626a524b60b drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling
-:39: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#39: 
References: 045d1fb79616 ("drm/i915/gt: Acquire a GT wakeref for the breadcrumb interrupt")

-:39: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 045d1fb79616 ("drm/i915/gt: Acquire a GT wakeref for the breadcrumb interrupt")'
#39: 
References: 045d1fb79616 ("drm/i915/gt: Acquire a GT wakeref for the breadcrumb interrupt")

total: 1 errors, 1 warnings, 0 checks, 19 lines checked

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling

[Patchwork]

== Series Details ==

Series: drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling
URL   : https://patchwork.freedesktop.org/series/70603/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_7511 -> Patchwork_15649
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_15649 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_15649, please notify your bug team to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/index.html

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_15649:

### IGT changes ###

#### Possible regressions ####

  * igt@debugfs_test@read_all_entries:
    - fi-hsw-peppy:       NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-hsw-peppy/igt@debugfs_test@read_all_entries.html

  * igt@gem_close_race@basic-threads:
    - fi-ivb-3770:        NOTRUN -> [INCOMPLETE][2]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-ivb-3770/igt@gem_close_race@basic-threads.html

  * igt@gem_ctx_create@basic-files:
    - fi-bdw-5557u:       NOTRUN -> [INCOMPLETE][3]
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-bdw-5557u/igt@gem_ctx_create@basic-files.html

  * igt@gem_exec_fence@nb-await-default:
    - fi-bxt-dsi:         [PASS][4] -> [TIMEOUT][5]
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-bxt-dsi/igt@gem_exec_fence@nb-await-default.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-bxt-dsi/igt@gem_exec_fence@nb-await-default.html

  * igt@gem_ringfill@basic-default-forked:
    - fi-kbl-guc:         [PASS][6] -> [TIMEOUT][7] +4 similar issues
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-kbl-guc/igt@gem_ringfill@basic-default-forked.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-kbl-guc/igt@gem_ringfill@basic-default-forked.html

  * igt@gem_ringfill@basic-default-interruptible:
    - fi-glk-dsi:         [PASS][8] -> [TIMEOUT][9] +4 similar issues
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-glk-dsi/igt@gem_ringfill@basic-default-interruptible.html
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-glk-dsi/igt@gem_ringfill@basic-default-interruptible.html
    - fi-kbl-8809g:       NOTRUN -> [TIMEOUT][10] +2 similar issues
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-kbl-8809g/igt@gem_ringfill@basic-default-interruptible.html

  
Known issues
------------

  Here are the changes found in Patchwork_15649 that come from known issues:

### IGT changes ###

#### Possible fixes ####

  * igt@core_auth@basic-auth:
    - fi-pnv-d510:        [INCOMPLETE][11] ([i915#299]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-pnv-d510/igt@core_auth@basic-auth.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-pnv-d510/igt@core_auth@basic-auth.html

  * igt@debugfs_test@read_all_entries:
    - fi-apl-guc:         [INCOMPLETE][13] ([fdo#103927]) -> [PASS][14]
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7511/fi-apl-guc/igt@debugfs_test@read_all_entries.html
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/fi-apl-guc/igt@debugfs_test@read_all_entries.html

  
  [fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
  [i915#299]: https://gitlab.freedesktop.org/drm/intel/issues/299


Participating hosts (26 -> 24)
------------------------------

  Additional (5): fi-byt-j1900 fi-hsw-peppy fi-gdg-551 fi-kbl-8809g fi-blb-e6850 
  Missing    (7): fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-n2820 fi-byt-clapper fi-bdw-samus 


Build changes
-------------

  * CI: CI-20190529 -> None
  * Linux: CI_DRM_7511 -> Patchwork_15649

  CI-20190529: 20190529
  CI_DRM_7511: 04ca2c0fb47c3d394a364f5f71943ca9f440dda7 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_5339: d45e11f8e10a4c5775372002ec89974ce3d97b27 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
  Patchwork_15649: 5626a524b60bbdce30d1eebabc6eb51858176136 @ git://anongit.freedesktop.org/gfx-ci/linux


== Linux commits ==

5626a524b60b drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15649/index.html
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915/gt: Suppress unclaimed mmio warnings for irq enabling

[Chris Wilson]

Quoting Chris Wilson (2019-12-08 23:34:56)
> Despite taking the intel_gt wakeref, and asserting that we do indeed
> hold the runtime-pm wakeref for the device, our mmio debug insists that
> the irq enabling is not being recognised:

Scratch the dropping of fw, we miss interrupts.
-Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx