From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback Date: Mon, 9 Dec 2019 02:50:18 +0200 Message-ID: <20191209005018.GJ14311@pendragon.ideasonboard.com> References: <20191207140353.23967-1-sam@ravnborg.org> <20191207140353.23967-2-sam@ravnborg.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191207140353.23967-2-sam@ravnborg.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Sam Ravnborg Cc: Neil Armstrong , David Airlie , dri-devel@lists.freedesktop.org, Thierry Reding , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon List-Id: linux-tegra@vger.kernel.org SGkgU2FtLAoKVGhhbmsgeW91IGZvciB0aGUgcGF0Y2guCgpPbiBTYXQsIERlYyAwNywgMjAxOSBh dCAwMzowMzoyOVBNICswMTAwLCBTYW0gUmF2bmJvcmcgd3JvdGU6Cj4gVGhlIGNhbGxiYWNrcyBp biBkcm1fcGFuZWxfZnVuY3MgYXJlIG9wdGlvbmFsLCBzbyBkbyBub3QKPiByZXR1cm4gYW4gZXJy b3IganVzdCBiZWNhdXNlIG5vIGNhbGxiYWNrIGlzIGFzc2lnbmVkLgo+IAo+IHYyOgo+IC0gRG9j dW1lbnQgd2hhdCBmdW5jdGlvbnMgaW4gZHJtX3BhbmVsX2Z1bmNzIGFyZSBvcHRpb25hbCAoTGF1 cmVudCkKPiAtIFJldHVybiAtRU9QTk9UU1VQUCBpZiBnZXRfbW9kZXMoKSBpcyBub3QgYXNzaWdu ZWQgKExhdXJlbnQpCj4gICAoU2FtOiAtRU9QTk9UU1VQUCBzZWVtcyB0byBiZXN0IGVycm9yIGNv ZGUgaW4gdGhpcyBzaXR1YXRpb24pCj4gCj4gU2lnbmVkLW9mZi1ieTogU2FtIFJhdm5ib3JnIDxz YW1AcmF2bmJvcmcub3JnPgo+IFJldmlld2VkLWJ5OiBMYXVyZW50IFBpbmNoYXJ0IDxsYXVyZW50 LnBpbmNoYXJ0QGlkZWFzb25ib2FyZC5jb20+Cj4gQ2M6IE1hYXJ0ZW4gTGFua2hvcnN0IDxtYWFy dGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IE1heGltZSBSaXBhcmQgPG1yaXBh cmRAa2VybmVsLm9yZz4KPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVkaW5nQGdtYWls LmNvbT4KPiBDYzogU2FtIFJhdm5ib3JnIDxzYW1AcmF2bmJvcmcub3JnPgo+IENjOiBEYXZpZCBB aXJsaWUgPGFpcmxpZWRAbGludXguaWU+Cj4gQ2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbEBmZnds bC5jaD4KPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL2RybV9wYW5lbC5jIHwgMzUgKysrKysrKysr KysrKysrKysrKysrKysrKy0tLS0tLS0tLS0KPiAgaW5jbHVkZS9kcm0vZHJtX3BhbmVsLmggICAg IHwgMTggKysrKysrKysrKysrKysrKy0tCj4gIDIgZmlsZXMgY2hhbmdlZCwgNDEgaW5zZXJ0aW9u cygrKSwgMTIgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fcGFuZWwuYyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGFuZWwuYwo+IGluZGV4IGVkNzk4NWMw NTM1YS4uNGFiNzIyOWZiMjJiIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGFu ZWwuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fcGFuZWwuYwo+IEBAIC0xNTEsMTAgKzE1 MSwxMyBAQCBFWFBPUlRfU1lNQk9MKGRybV9wYW5lbF9kZXRhY2gpOwo+ICAgKi8KPiAgaW50IGRy bV9wYW5lbF9wcmVwYXJlKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKQo+ICB7Cj4gLQlpZiAocGFu ZWwgJiYgcGFuZWwtPmZ1bmNzICYmIHBhbmVsLT5mdW5jcy0+cHJlcGFyZSkKPiArCWlmICghcGFu ZWwpCj4gKwkJcmV0dXJuIC1FSU5WQUw7Cj4gKwo+ICsJaWYgKHBhbmVsLT5mdW5jcyAmJiBwYW5l bC0+ZnVuY3MtPnByZXBhcmUpCj4gIAkJcmV0dXJuIHBhbmVsLT5mdW5jcy0+cHJlcGFyZShwYW5l bCk7Cj4gIAo+IC0JcmV0dXJuIHBhbmVsID8gLUVOT1NZUyA6IC1FSU5WQUw7Cj4gKwlyZXR1cm4g MDsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9wYW5lbF9wcmVwYXJlKTsKPiAgCj4gQEAgLTE3 MSwxMCArMTc0LDEzIEBAIEVYUE9SVF9TWU1CT0woZHJtX3BhbmVsX3ByZXBhcmUpOwo+ICAgKi8K PiAgaW50IGRybV9wYW5lbF91bnByZXBhcmUoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gIHsK PiAtCWlmIChwYW5lbCAmJiBwYW5lbC0+ZnVuY3MgJiYgcGFuZWwtPmZ1bmNzLT51bnByZXBhcmUp Cj4gKwlpZiAoIXBhbmVsKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsKPiArCWlmIChwYW5lbC0+ ZnVuY3MgJiYgcGFuZWwtPmZ1bmNzLT51bnByZXBhcmUpCj4gIAkJcmV0dXJuIHBhbmVsLT5mdW5j cy0+dW5wcmVwYXJlKHBhbmVsKTsKPiAgCj4gLQlyZXR1cm4gcGFuZWwgPyAtRU5PU1lTIDogLUVJ TlZBTDsKPiArCXJldHVybiAwOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX3BhbmVsX3VucHJl cGFyZSk7Cj4gIAo+IEBAIC0xOTAsMTAgKzE5NiwxMyBAQCBFWFBPUlRfU1lNQk9MKGRybV9wYW5l bF91bnByZXBhcmUpOwo+ICAgKi8KPiAgaW50IGRybV9wYW5lbF9lbmFibGUoc3RydWN0IGRybV9w YW5lbCAqcGFuZWwpCj4gIHsKPiAtCWlmIChwYW5lbCAmJiBwYW5lbC0+ZnVuY3MgJiYgcGFuZWwt PmZ1bmNzLT5lbmFibGUpCj4gKwlpZiAoIXBhbmVsKQo+ICsJCXJldHVybiAtRUlOVkFMOwo+ICsK PiArCWlmIChwYW5lbC0+ZnVuY3MgJiYgcGFuZWwtPmZ1bmNzLT5lbmFibGUpCj4gIAkJcmV0dXJu IHBhbmVsLT5mdW5jcy0+ZW5hYmxlKHBhbmVsKTsKPiAgCj4gLQlyZXR1cm4gcGFuZWwgPyAtRU5P U1lTIDogLUVJTlZBTDsKPiArCXJldHVybiAwOwo+ICB9Cj4gIEVYUE9SVF9TWU1CT0woZHJtX3Bh bmVsX2VuYWJsZSk7Cj4gIAo+IEBAIC0yMDksMTAgKzIxOCwxMyBAQCBFWFBPUlRfU1lNQk9MKGRy bV9wYW5lbF9lbmFibGUpOwo+ICAgKi8KPiAgaW50IGRybV9wYW5lbF9kaXNhYmxlKHN0cnVjdCBk cm1fcGFuZWwgKnBhbmVsKQo+ICB7Cj4gLQlpZiAocGFuZWwgJiYgcGFuZWwtPmZ1bmNzICYmIHBh bmVsLT5mdW5jcy0+ZGlzYWJsZSkKPiArCWlmICghcGFuZWwpCj4gKwkJcmV0dXJuIC1FSU5WQUw7 Cj4gKwo+ICsJaWYgKHBhbmVsLT5mdW5jcyAmJiBwYW5lbC0+ZnVuY3MtPmRpc2FibGUpCj4gIAkJ cmV0dXJuIHBhbmVsLT5mdW5jcy0+ZGlzYWJsZShwYW5lbCk7Cj4gIAo+IC0JcmV0dXJuIHBhbmVs ID8gLUVOT1NZUyA6IC1FSU5WQUw7Cj4gKwlyZXR1cm4gMDsKPiAgfQo+ICBFWFBPUlRfU1lNQk9M KGRybV9wYW5lbF9kaXNhYmxlKTsKPiAgCj4gQEAgLTIyOCwxMCArMjQwLDEzIEBAIEVYUE9SVF9T WU1CT0woZHJtX3BhbmVsX2Rpc2FibGUpOwo+ICAgKi8KPiAgaW50IGRybV9wYW5lbF9nZXRfbW9k ZXMoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpCj4gIHsKPiAtCWlmIChwYW5lbCAmJiBwYW5lbC0+ ZnVuY3MgJiYgcGFuZWwtPmZ1bmNzLT5nZXRfbW9kZXMpCj4gKwlpZiAoIXBhbmVsKQo+ICsJCXJl dHVybiAtRUlOVkFMOwo+ICsKPiArCWlmIChwYW5lbC0+ZnVuY3MgJiYgcGFuZWwtPmZ1bmNzLT5n ZXRfbW9kZXMpCj4gIAkJcmV0dXJuIHBhbmVsLT5mdW5jcy0+Z2V0X21vZGVzKHBhbmVsKTsKPiAg Cj4gLQlyZXR1cm4gcGFuZWwgPyAtRU5PU1lTIDogLUVJTlZBTDsKPiArCXJldHVybiAtRU9QTk9U U1VQUDsKPiAgfQo+ICBFWFBPUlRfU1lNQk9MKGRybV9wYW5lbF9nZXRfbW9kZXMpOwo+ICAKPiBk aWZmIC0tZ2l0IGEvaW5jbHVkZS9kcm0vZHJtX3BhbmVsLmggYi9pbmNsdWRlL2RybS9kcm1fcGFu ZWwuaAo+IGluZGV4IGNlOGRhNjQwMjJiNC4uZDcxNjU1YjI2MzRjIDEwMDY0NAo+IC0tLSBhL2lu Y2x1ZGUvZHJtL2RybV9wYW5lbC5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX3BhbmVsLmgKPiBA QCAtNjUsNiArNjUsOCBAQCBzdHJ1Y3QgZHJtX3BhbmVsX2Z1bmNzIHsKPiAgCSAqIEBwcmVwYXJl Ogo+ICAJICoKPiAgCSAqIFR1cm4gb24gcGFuZWwgYW5kIHBlcmZvcm0gc2V0IHVwLgo+ICsJICoK PiArCSAqIFRoaXMgZnVuY3Rpb24gaXMgb3B0aW9uYWwuCj4gIAkgKi8KPiAgCWludCAoKnByZXBh cmUpKHN0cnVjdCBkcm1fcGFuZWwgKnBhbmVsKTsKPiAgCj4gQEAgLTcyLDYgKzc0LDggQEAgc3Ry dWN0IGRybV9wYW5lbF9mdW5jcyB7Cj4gIAkgKiBAZW5hYmxlOgo+ICAJICoKPiAgCSAqIEVuYWJs ZSBwYW5lbCAodHVybiBvbiBiYWNrIGxpZ2h0LCBldGMuKS4KPiArCSAqCj4gKwkgKiBUaGlzIGZ1 bmN0aW9uIGlzIG9wdGlvbmFsLgo+ICAJICovCj4gIAlpbnQgKCplbmFibGUpKHN0cnVjdCBkcm1f cGFuZWwgKnBhbmVsKTsKPiAgCj4gQEAgLTc5LDYgKzgzLDggQEAgc3RydWN0IGRybV9wYW5lbF9m dW5jcyB7Cj4gIAkgKiBAZGlzYWJsZToKPiAgCSAqCj4gIAkgKiBEaXNhYmxlIHBhbmVsICh0dXJu IG9mZiBiYWNrIGxpZ2h0LCBldGMuKS4KPiArCSAqCj4gKwkgKiBUaGlzIGZ1bmN0aW9uIGlzIG9w dGlvbmFsLgo+ICAJICovCj4gIAlpbnQgKCpkaXNhYmxlKShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5l bCk7Cj4gIAo+IEBAIC04NiwxNCArOTIsMjAgQEAgc3RydWN0IGRybV9wYW5lbF9mdW5jcyB7Cj4g IAkgKiBAdW5wcmVwYXJlOgo+ICAJICoKPiAgCSAqIFR1cm4gb2ZmIHBhbmVsLgo+ICsJICoKPiAr CSAqIFRoaXMgZnVuY3Rpb24gaXMgb3B0aW9uYWwuCj4gIAkgKi8KPiAgCWludCAoKnVucHJlcGFy ZSkoc3RydWN0IGRybV9wYW5lbCAqcGFuZWwpOwo+ICAKPiAgCS8qKgo+ICAJICogQGdldF9tb2Rl czoKPiAgCSAqCj4gLQkgKiBBZGQgbW9kZXMgdG8gdGhlIGNvbm5lY3RvciB0aGF0IHRoZSBwYW5l bCBpcyBhdHRhY2hlZCB0byBhbmQKPiAtCSAqIHJldHVybiB0aGUgbnVtYmVyIG9mIG1vZGVzIGFk ZGVkLgo+ICsJICogQWRkIG1vZGVzIHRvIHRoZSBjb25uZWN0b3IgdGhhdCB0aGUgcGFuZWwgaXMg YXR0YWNoZWQgdG8uCj4gKwkgKgo+ICsJICogVGhpcyBmdW5jdGlvbiBpcyBtYW5kYXRvcnkuCj4g KwkgKgo+ICsJICogUmV0dXJucyB0aGUgbnVtYmVyIG9mIG1vZGVzIGFkZGVkLCAtRU9QTk9UU1VQ UCBpZiBjYWxsYmFjawo+ICsJICogaXMgbWlzc2luZywgLUVJTlZBTCBpZiBwYW5lbCBpcyBOVUxM LgoKVGhpcyBhcHBsaWVzIHRvIGRybV9wYW5lbF9nZXRfbW9kZXMsIG5vdCAmZHJtX3BhbmVsX2Z1 bmNzLmdldF9tb2Rlcy4KSGVyZSB5b3Ugc2hvdWxkIGp1c3QgaGF2ZQoKIAkgKgogCSAqIEFkZCBt b2RlcyB0byB0aGUgY29ubmVjdG9yIHRoYXQgdGhlIHBhbmVsIGlzIGF0dGFjaGVkIHRvIGFuZAog CSAqIHJldHVybiB0aGUgbnVtYmVyIG9mIG1vZGVzIGFkZGVkLgorCSAqCisJICogVGhpcyBmdW5j dGlvbiBpcyBtYW5kYXRvcnkuCiAJICovCiAJaW50ICgqZ2V0X21vZGVzKShzdHJ1Y3QgZHJtX3Bh bmVsICpwYW5lbCk7CiAKPiAgCSAqLwo+ICAJaW50ICgqZ2V0X21vZGVzKShzdHJ1Y3QgZHJtX3Bh bmVsICpwYW5lbCk7Cj4gIAo+IEBAIC0xMDIsNiArMTE0LDggQEAgc3RydWN0IGRybV9wYW5lbF9m dW5jcyB7Cj4gIAkgKgo+ICAJICogQ29weSBkaXNwbGF5IHRpbWluZ3MgaW50byB0aGUgcHJvdmlk ZWQgYXJyYXkgYW5kIHJldHVybgo+ICAJICogdGhlIG51bWJlciBvZiBkaXNwbGF5IHRpbWluZ3Mg YXZhaWxhYmxlLgo+ICsJICoKPiArCSAqIFRoaXMgZnVuY3Rpb24gaXMgb3B0aW9uYWwuCj4gIAkg Ki8KPiAgCWludCAoKmdldF90aW1pbmdzKShzdHJ1Y3QgZHJtX3BhbmVsICpwYW5lbCwgdW5zaWdu ZWQgaW50IG51bV90aW1pbmdzLAo+ICAJCQkgICBzdHJ1Y3QgZGlzcGxheV90aW1pbmcgKnRpbWlu Z3MpOwoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRl dmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9t YWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C0397C43603 for ; Mon, 9 Dec 2019 00:50:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7E79A206F4 for ; Mon, 9 Dec 2019 00:50:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aPM7SCEV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726659AbfLIAu3 (ORCPT ); Sun, 8 Dec 2019 19:50:29 -0500 Received: from perceval.ideasonboard.com ([213.167.242.64]:49774 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726621AbfLIAu2 (ORCPT ); Sun, 8 Dec 2019 19:50:28 -0500 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CE90A52B; Mon, 9 Dec 2019 01:50:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575852625; bh=05qu6A8LjmvyF+V1mQN3igr/hkyti8yhAOb0TcMEjBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aPM7SCEVSQZJXE7EyZ2dRxMJ+M1xpN1dnPsbeDQZ7R6amo1/qxXroZt3KnEHlq8aF jp/X4dSfBpcS6P7eA+PLl37xwevqOUhRe3+jf+WOPqMAhk7GVf0kN7+T4oqhk3Konp TpKjRjJSuaJsGi2it/bEbmeLOBvSCx989iQjdPdY= Date: Mon, 9 Dec 2019 02:50:18 +0200 From: Laurent Pinchart To: Sam Ravnborg Cc: dri-devel@lists.freedesktop.org, Thierry Reding , Linus Walleij , Abhinav Kumar , Andrzej Hajda , Benjamin Gaignard , Boris Brezillon , Daniel Vetter , David Airlie , Jagan Teki , Jitao Shi , linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-renesas-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org, Maarten Lankhorst , Maxime Ripard , Neil Armstrong , NXP Linux Team , Pengutronix Kernel Team , Purism Kernel Team , Sean Paul , Stefan Agner , Tomi Valkeinen Subject: Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback Message-ID: <20191209005018.GJ14311@pendragon.ideasonboard.com> References: <20191207140353.23967-1-sam@ravnborg.org> <20191207140353.23967-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191207140353.23967-2-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-renesas-soc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-renesas-soc@vger.kernel.org Hi Sam, Thank you for the patch. On Sat, Dec 07, 2019 at 03:03:29PM +0100, Sam Ravnborg wrote: > The callbacks in drm_panel_funcs are optional, so do not > return an error just because no callback is assigned. > > v2: > - Document what functions in drm_panel_funcs are optional (Laurent) > - Return -EOPNOTSUPP if get_modes() is not assigned (Laurent) > (Sam: -EOPNOTSUPP seems to best error code in this situation) > > Signed-off-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/drm_panel.c | 35 +++++++++++++++++++++++++---------- > include/drm/drm_panel.h | 18 ++++++++++++++++-- > 2 files changed, 41 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index ed7985c0535a..4ab7229fb22b 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -151,10 +151,13 @@ EXPORT_SYMBOL(drm_panel_detach); > */ > int drm_panel_prepare(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->prepare) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->prepare) > return panel->funcs->prepare(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_prepare); > > @@ -171,10 +174,13 @@ EXPORT_SYMBOL(drm_panel_prepare); > */ > int drm_panel_unprepare(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->unprepare) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->unprepare) > return panel->funcs->unprepare(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_unprepare); > > @@ -190,10 +196,13 @@ EXPORT_SYMBOL(drm_panel_unprepare); > */ > int drm_panel_enable(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->enable) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->enable) > return panel->funcs->enable(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_enable); > > @@ -209,10 +218,13 @@ EXPORT_SYMBOL(drm_panel_enable); > */ > int drm_panel_disable(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->disable) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->disable) > return panel->funcs->disable(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_disable); > > @@ -228,10 +240,13 @@ EXPORT_SYMBOL(drm_panel_disable); > */ > int drm_panel_get_modes(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->get_modes) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->get_modes) > return panel->funcs->get_modes(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return -EOPNOTSUPP; > } > EXPORT_SYMBOL(drm_panel_get_modes); > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index ce8da64022b4..d71655b2634c 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -65,6 +65,8 @@ struct drm_panel_funcs { > * @prepare: > * > * Turn on panel and perform set up. > + * > + * This function is optional. > */ > int (*prepare)(struct drm_panel *panel); > > @@ -72,6 +74,8 @@ struct drm_panel_funcs { > * @enable: > * > * Enable panel (turn on back light, etc.). > + * > + * This function is optional. > */ > int (*enable)(struct drm_panel *panel); > > @@ -79,6 +83,8 @@ struct drm_panel_funcs { > * @disable: > * > * Disable panel (turn off back light, etc.). > + * > + * This function is optional. > */ > int (*disable)(struct drm_panel *panel); > > @@ -86,14 +92,20 @@ struct drm_panel_funcs { > * @unprepare: > * > * Turn off panel. > + * > + * This function is optional. > */ > int (*unprepare)(struct drm_panel *panel); > > /** > * @get_modes: > * > - * Add modes to the connector that the panel is attached to and > - * return the number of modes added. > + * Add modes to the connector that the panel is attached to. > + * > + * This function is mandatory. > + * > + * Returns the number of modes added, -EOPNOTSUPP if callback > + * is missing, -EINVAL if panel is NULL. This applies to drm_panel_get_modes, not &drm_panel_funcs.get_modes. Here you should just have * * Add modes to the connector that the panel is attached to and * return the number of modes added. + * + * This function is mandatory. */ int (*get_modes)(struct drm_panel *panel); > */ > int (*get_modes)(struct drm_panel *panel); > > @@ -102,6 +114,8 @@ struct drm_panel_funcs { > * > * Copy display timings into the provided array and return > * the number of display timings available. > + * > + * This function is optional. > */ > int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > struct display_timing *timings); -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9403FC43603 for ; Mon, 9 Dec 2019 00:56:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5BDF2206DB for ; Mon, 9 Dec 2019 00:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="n09Sj+Ex"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aPM7SCEV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5BDF2206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ZSXbZJMhf6dULjQ/lQ39QLZxR6MuZZvqpGAiHCDQjz4=; b=n09Sj+ExuApq60 Bya7TQ7KO2o19BbPbD2Aw0AdcMRsNJWZzjh3xnceyI6e/nZGHPaHneWaXAkD3iOddGY58bSE5vbW7 B/szcCjCMown1yuBuElc6VlgdIKWCljPg6c2JGIt6+yefZiWorVKC0T3iTMbbQPntUwPAQichTzf3 NRmUh8UhUKXv5SxcPdBeQY8PfnancUA+KmMzXf/JTBG8broqDPnEQJpIw9be97DBc8ZLV0CuuiqC0 R+Z/IuvBiGXScJgkY7/h+LtUtBGREFzo0QG4UVH3QSlqcgzYsr4rwKSDkWbhdy8QqJIUSv7Rt/WDc QhnY/Y1lx1deCZC5fzlA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ie7LL-0007D2-LO; Mon, 09 Dec 2019 00:56:07 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ie7LB-00075M-DG; Mon, 09 Dec 2019 00:55:59 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CE90A52B; Mon, 9 Dec 2019 01:50:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575852625; bh=05qu6A8LjmvyF+V1mQN3igr/hkyti8yhAOb0TcMEjBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aPM7SCEVSQZJXE7EyZ2dRxMJ+M1xpN1dnPsbeDQZ7R6amo1/qxXroZt3KnEHlq8aF jp/X4dSfBpcS6P7eA+PLl37xwevqOUhRe3+jf+WOPqMAhk7GVf0kN7+T4oqhk3Konp TpKjRjJSuaJsGi2it/bEbmeLOBvSCx989iQjdPdY= Date: Mon, 9 Dec 2019 02:50:18 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback Message-ID: <20191209005018.GJ14311@pendragon.ideasonboard.com> References: <20191207140353.23967-1-sam@ravnborg.org> <20191207140353.23967-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191207140353.23967-2-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191208_165557_887364_F72ED4E9 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Sat, Dec 07, 2019 at 03:03:29PM +0100, Sam Ravnborg wrote: > The callbacks in drm_panel_funcs are optional, so do not > return an error just because no callback is assigned. > > v2: > - Document what functions in drm_panel_funcs are optional (Laurent) > - Return -EOPNOTSUPP if get_modes() is not assigned (Laurent) > (Sam: -EOPNOTSUPP seems to best error code in this situation) > > Signed-off-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/drm_panel.c | 35 +++++++++++++++++++++++++---------- > include/drm/drm_panel.h | 18 ++++++++++++++++-- > 2 files changed, 41 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index ed7985c0535a..4ab7229fb22b 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -151,10 +151,13 @@ EXPORT_SYMBOL(drm_panel_detach); > */ > int drm_panel_prepare(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->prepare) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->prepare) > return panel->funcs->prepare(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_prepare); > > @@ -171,10 +174,13 @@ EXPORT_SYMBOL(drm_panel_prepare); > */ > int drm_panel_unprepare(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->unprepare) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->unprepare) > return panel->funcs->unprepare(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_unprepare); > > @@ -190,10 +196,13 @@ EXPORT_SYMBOL(drm_panel_unprepare); > */ > int drm_panel_enable(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->enable) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->enable) > return panel->funcs->enable(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_enable); > > @@ -209,10 +218,13 @@ EXPORT_SYMBOL(drm_panel_enable); > */ > int drm_panel_disable(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->disable) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->disable) > return panel->funcs->disable(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_disable); > > @@ -228,10 +240,13 @@ EXPORT_SYMBOL(drm_panel_disable); > */ > int drm_panel_get_modes(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->get_modes) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->get_modes) > return panel->funcs->get_modes(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return -EOPNOTSUPP; > } > EXPORT_SYMBOL(drm_panel_get_modes); > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index ce8da64022b4..d71655b2634c 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -65,6 +65,8 @@ struct drm_panel_funcs { > * @prepare: > * > * Turn on panel and perform set up. > + * > + * This function is optional. > */ > int (*prepare)(struct drm_panel *panel); > > @@ -72,6 +74,8 @@ struct drm_panel_funcs { > * @enable: > * > * Enable panel (turn on back light, etc.). > + * > + * This function is optional. > */ > int (*enable)(struct drm_panel *panel); > > @@ -79,6 +83,8 @@ struct drm_panel_funcs { > * @disable: > * > * Disable panel (turn off back light, etc.). > + * > + * This function is optional. > */ > int (*disable)(struct drm_panel *panel); > > @@ -86,14 +92,20 @@ struct drm_panel_funcs { > * @unprepare: > * > * Turn off panel. > + * > + * This function is optional. > */ > int (*unprepare)(struct drm_panel *panel); > > /** > * @get_modes: > * > - * Add modes to the connector that the panel is attached to and > - * return the number of modes added. > + * Add modes to the connector that the panel is attached to. > + * > + * This function is mandatory. > + * > + * Returns the number of modes added, -EOPNOTSUPP if callback > + * is missing, -EINVAL if panel is NULL. This applies to drm_panel_get_modes, not &drm_panel_funcs.get_modes. Here you should just have * * Add modes to the connector that the panel is attached to and * return the number of modes added. + * + * This function is mandatory. */ int (*get_modes)(struct drm_panel *panel); > */ > int (*get_modes)(struct drm_panel *panel); > > @@ -102,6 +114,8 @@ struct drm_panel_funcs { > * > * Copy display timings into the provided array and return > * the number of display timings available. > + * > + * This function is optional. > */ > int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > struct display_timing *timings); -- Regards, Laurent Pinchart _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30929C2D0C0 for ; Mon, 9 Dec 2019 00:56:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06792206DB for ; Mon, 9 Dec 2019 00:56:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XrXeGO/w"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="aPM7SCEV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06792206DB Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=XARYVwY9bHuhtOCgJ26ULIx2k9iwDCakVj1S0Wlp9KA=; b=XrXeGO/w/x9I+y ajRMUTv4jjPgz3kTEm1c85iN5FooPU6IDsyz6pU6X7ol8HpMhjSbCaKe61gcJO0pKfAx7OW/Hr+HX Y8UC407kORf/zwnX/9bYt5csj7IEZS3pCmT01cdiJ+45qrCB9vT1vzcFbbPJThm9CEo7JBPvfQqaL 5SGJl8lWmsiK5TDPRKNkFqaQghbVFoDspCA3dkrH8r/Vwzt8SfbWdbNrZ7Di2pvipX+ph9KndAoE+ Dvo4cp0UKPqM3tRW1SY5MTP+LwEtCeNUjScipN18EVlzjk2TRfgS+69vJ2dUIyVDIssiN8NdUQ13Q 9vvRT61J9yREFZSRJvsw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ie7LF-000764-A2; Mon, 09 Dec 2019 00:56:01 +0000 Received: from perceval.ideasonboard.com ([2001:4b98:dc2:55:216:3eff:fef7:d647]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ie7LB-00075M-DG; Mon, 09 Dec 2019 00:55:59 +0000 Received: from pendragon.ideasonboard.com (81-175-216-236.bb.dnainternet.fi [81.175.216.236]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id CE90A52B; Mon, 9 Dec 2019 01:50:24 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1575852625; bh=05qu6A8LjmvyF+V1mQN3igr/hkyti8yhAOb0TcMEjBA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=aPM7SCEVSQZJXE7EyZ2dRxMJ+M1xpN1dnPsbeDQZ7R6amo1/qxXroZt3KnEHlq8aF jp/X4dSfBpcS6P7eA+PLl37xwevqOUhRe3+jf+WOPqMAhk7GVf0kN7+T4oqhk3Konp TpKjRjJSuaJsGi2it/bEbmeLOBvSCx989iQjdPdY= Date: Mon, 9 Dec 2019 02:50:18 +0200 From: Laurent Pinchart To: Sam Ravnborg Subject: Re: [PATCH v2 01/25] drm/drm_panel: no error when no callback Message-ID: <20191209005018.GJ14311@pendragon.ideasonboard.com> References: <20191207140353.23967-1-sam@ravnborg.org> <20191207140353.23967-2-sam@ravnborg.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191207140353.23967-2-sam@ravnborg.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191208_165557_887364_F72ED4E9 X-CRM114-Status: GOOD ( 19.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , David Airlie , Linus Walleij , dri-devel@lists.freedesktop.org, Andrzej Hajda , Thierry Reding , Benjamin Gaignard , Stefan Agner , linux-samsung-soc@vger.kernel.org, linux-rockchip@lists.infradead.org, Tomi Valkeinen , NXP Linux Team , Jagan Teki , Jitao Shi , Pengutronix Kernel Team , Maarten Lankhorst , Maxime Ripard , linux-mediatek@lists.infradead.org, Abhinav Kumar , linux-tegra@vger.kernel.org, Sean Paul , linux-arm-kernel@lists.infradead.org, Purism Kernel Team , linux-renesas-soc@vger.kernel.org, Boris Brezillon , Daniel Vetter Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Sam, Thank you for the patch. On Sat, Dec 07, 2019 at 03:03:29PM +0100, Sam Ravnborg wrote: > The callbacks in drm_panel_funcs are optional, so do not > return an error just because no callback is assigned. > > v2: > - Document what functions in drm_panel_funcs are optional (Laurent) > - Return -EOPNOTSUPP if get_modes() is not assigned (Laurent) > (Sam: -EOPNOTSUPP seems to best error code in this situation) > > Signed-off-by: Sam Ravnborg > Reviewed-by: Laurent Pinchart > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Thierry Reding > Cc: Sam Ravnborg > Cc: David Airlie > Cc: Daniel Vetter > --- > drivers/gpu/drm/drm_panel.c | 35 +++++++++++++++++++++++++---------- > include/drm/drm_panel.h | 18 ++++++++++++++++-- > 2 files changed, 41 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c > index ed7985c0535a..4ab7229fb22b 100644 > --- a/drivers/gpu/drm/drm_panel.c > +++ b/drivers/gpu/drm/drm_panel.c > @@ -151,10 +151,13 @@ EXPORT_SYMBOL(drm_panel_detach); > */ > int drm_panel_prepare(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->prepare) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->prepare) > return panel->funcs->prepare(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_prepare); > > @@ -171,10 +174,13 @@ EXPORT_SYMBOL(drm_panel_prepare); > */ > int drm_panel_unprepare(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->unprepare) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->unprepare) > return panel->funcs->unprepare(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_unprepare); > > @@ -190,10 +196,13 @@ EXPORT_SYMBOL(drm_panel_unprepare); > */ > int drm_panel_enable(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->enable) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->enable) > return panel->funcs->enable(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_enable); > > @@ -209,10 +218,13 @@ EXPORT_SYMBOL(drm_panel_enable); > */ > int drm_panel_disable(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->disable) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->disable) > return panel->funcs->disable(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return 0; > } > EXPORT_SYMBOL(drm_panel_disable); > > @@ -228,10 +240,13 @@ EXPORT_SYMBOL(drm_panel_disable); > */ > int drm_panel_get_modes(struct drm_panel *panel) > { > - if (panel && panel->funcs && panel->funcs->get_modes) > + if (!panel) > + return -EINVAL; > + > + if (panel->funcs && panel->funcs->get_modes) > return panel->funcs->get_modes(panel); > > - return panel ? -ENOSYS : -EINVAL; > + return -EOPNOTSUPP; > } > EXPORT_SYMBOL(drm_panel_get_modes); > > diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h > index ce8da64022b4..d71655b2634c 100644 > --- a/include/drm/drm_panel.h > +++ b/include/drm/drm_panel.h > @@ -65,6 +65,8 @@ struct drm_panel_funcs { > * @prepare: > * > * Turn on panel and perform set up. > + * > + * This function is optional. > */ > int (*prepare)(struct drm_panel *panel); > > @@ -72,6 +74,8 @@ struct drm_panel_funcs { > * @enable: > * > * Enable panel (turn on back light, etc.). > + * > + * This function is optional. > */ > int (*enable)(struct drm_panel *panel); > > @@ -79,6 +83,8 @@ struct drm_panel_funcs { > * @disable: > * > * Disable panel (turn off back light, etc.). > + * > + * This function is optional. > */ > int (*disable)(struct drm_panel *panel); > > @@ -86,14 +92,20 @@ struct drm_panel_funcs { > * @unprepare: > * > * Turn off panel. > + * > + * This function is optional. > */ > int (*unprepare)(struct drm_panel *panel); > > /** > * @get_modes: > * > - * Add modes to the connector that the panel is attached to and > - * return the number of modes added. > + * Add modes to the connector that the panel is attached to. > + * > + * This function is mandatory. > + * > + * Returns the number of modes added, -EOPNOTSUPP if callback > + * is missing, -EINVAL if panel is NULL. This applies to drm_panel_get_modes, not &drm_panel_funcs.get_modes. Here you should just have * * Add modes to the connector that the panel is attached to and * return the number of modes added. + * + * This function is mandatory. */ int (*get_modes)(struct drm_panel *panel); > */ > int (*get_modes)(struct drm_panel *panel); > > @@ -102,6 +114,8 @@ struct drm_panel_funcs { > * > * Copy display timings into the provided array and return > * the number of display timings available. > + * > + * This function is optional. > */ > int (*get_timings)(struct drm_panel *panel, unsigned int num_timings, > struct display_timing *timings); -- Regards, Laurent Pinchart _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel