From: "Roger Pau Monné" <roger.pau@citrix.com>
To: Jan Beulich <jbeulich@suse.com>
Cc: xen-devel@lists.xenproject.org, Wei Liu <wl@xen.org>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [Xen-devel] [PATCH v3 3/4] x86/smp: check APIC ID on AP bringup
Date: Mon, 9 Dec 2019 11:27:24 +0100 [thread overview]
Message-ID: <20191209102724.GP980@Air-de-Roger> (raw)
In-Reply-To: <02ce4cc5-6da9-3383-df9e-39890f622177@suse.com>
On Thu, Dec 05, 2019 at 10:33:44AM +0100, Jan Beulich wrote:
> On 04.12.2019 17:20, Roger Pau Monne wrote:
> > Check that the processor to be woken up APIC ID is addressable in the
> > current APIC mode.
> >
> > Note that in practice systems with APIC IDs > 255 should already have
> > x2APIC enabled by the firmware, and hence this is mostly a safety
> > belt.
> >
> > Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
>
> Reviewed-by: Jan Beulich <jbeulich@suse.com>
> with ...
>
> > --- a/xen/arch/x86/smpboot.c
> > +++ b/xen/arch/x86/smpboot.c
> > @@ -1317,6 +1317,13 @@ int __cpu_up(unsigned int cpu)
> > if ( (apicid = x86_cpu_to_apicid[cpu]) == BAD_APICID )
> > return -ENODEV;
> >
> > + if ( (!x2apic_enabled || !iommu_intremap) && (apicid >> 8) )
> > + {
> > + printk("Unsupported: APIC ID %#x in xAPIC mode w/o interrupt remapping",
> > + apicid);
>
> ... the lost newline added back (can be done while commiting).
Sorry for dropping it, please add it at commit.
Thanks, Roger.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
next prev parent reply other threads:[~2019-12-09 10:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-04 16:20 [Xen-devel] [PATCH v3 0/4] x86: enable x2APIC mode regardless of interrupt remapping support Roger Pau Monne
2019-12-04 16:20 ` [Xen-devel] [PATCH v3 1/4] x86/ioapic: only use dest32 with x2apic and interrupt remapping enabled Roger Pau Monne
2019-12-05 9:26 ` Jan Beulich
2019-12-04 16:20 ` [Xen-devel] [PATCH v3 2/4] x86/apic: force phys mode if interrupt remapping is disabled Roger Pau Monne
2019-12-05 9:32 ` Jan Beulich
2019-12-09 10:25 ` Roger Pau Monné
2019-12-09 14:30 ` Jan Beulich
2019-12-09 14:50 ` Roger Pau Monné
2019-12-04 16:20 ` [Xen-devel] [PATCH v3 3/4] x86/smp: check APIC ID on AP bringup Roger Pau Monne
2019-12-05 9:33 ` Jan Beulich
2019-12-09 10:27 ` Roger Pau Monné [this message]
2019-12-20 15:17 ` Jan Beulich
2019-12-20 15:23 ` Andrew Cooper
2019-12-04 16:20 ` [Xen-devel] [PATCH v3 4/4] x86/apic: allow enabling x2APIC mode regardless of interrupt remapping Roger Pau Monne
2019-12-05 9:45 ` Jan Beulich
2019-12-09 10:56 ` Roger Pau Monné
2019-12-09 14:36 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191209102724.GP980@Air-de-Roger \
--to=roger.pau@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.