All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Johannes Thumshirn <jthumshirn@suse.de>
Cc: Sebastian <sebastian.scherbel@fau.de>,
	clm@fb.com, josef@toxicpanda.com, dsterba@suse.com,
	linux-btrfs@vger.kernel.org, linux-kernel@i4.cs.fau.de
Subject: Re: [PATCH 0/2] btrfs: Move dereference behind null checks
Date: Mon, 9 Dec 2019 17:11:44 +0100	[thread overview]
Message-ID: <20191209161144.GJ2734@twin.jikos.cz> (raw)
In-Reply-To: <ba7c4979-3f5b-4efc-49aa-9e1f130a5876@suse.de>

On Mon, Dec 09, 2019 at 10:30:06AM +0100, Johannes Thumshirn wrote:
> On 07/12/2019 23:18, Sebastian wrote:
> > From: Sebastian Scherbel <sebastian.scherbel@fau.de>
> > 
> > Regarding Bug 205003, points 1 and 2
> > This patch series moves two dereferences after the null check to avoid
> > a possible null pointer dereference.
> > 
> > Sebastian Scherbel (2):
> >   btrfs: Move dereference behind null check in check integrity
> >   btrfs: Move dereference behind null check in check volumes
> > 
> >  fs/btrfs/check-integrity.c | 4 +++-
> >  fs/btrfs/volumes.c         | 4 +++-
> >  2 files changed, 6 insertions(+), 2 deletions(-)
> > 
> 
> I've already submitted a series addressing these and David merged it:
> https://lore.kernel.org/linux-btrfs/20191205131959.19184-1-jth@kernel.org/

Yes, that's been in misc-next since ~friday, I'm not sure when I pushed
the branch.

Sebastian, thanks for the patches, this sometimes happens that the work
is duplicated. Johannes removed the BUG_ON and WARN_ON completely though
your change is also correct assuming that the two are not redundant.

      reply	other threads:[~2019-12-09 16:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-07 22:18 [PATCH 0/2] btrfs: Move dereference behind null checks Sebastian
2019-12-07 22:18 ` [PATCH 1/2] btrfs: Move dereference behind null check in check integrity Sebastian
2019-12-07 22:18 ` [PATCH 2/2] btrfs: Move dereference behind null check in check volumes Sebastian
2019-12-09  9:30 ` [PATCH 0/2] btrfs: Move dereference behind null checks Johannes Thumshirn
2019-12-09 16:11   ` David Sterba [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209161144.GJ2734@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=clm@fb.com \
    --cc=dsterba@suse.com \
    --cc=josef@toxicpanda.com \
    --cc=jthumshirn@suse.de \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=linux-kernel@i4.cs.fau.de \
    --cc=sebastian.scherbel@fau.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.