All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: "Martin K . Petersen" <martin.petersen@oracle.com>,
	"James E . J . Bottomley" <jejb@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
	Quinn Tran <qutran@marvell.com>, Martin Wilck <mwilck@suse.com>,
	Daniel Wagner <dwagner@suse.de>,
	Roman Bolshakov <r.bolshakov@yadro.com>
Subject: [PATCH 1/4] qla2xxx: Check locking assumptions at runtime in qla2x00_abort_srb()
Date: Mon,  9 Dec 2019 10:02:20 -0800	[thread overview]
Message-ID: <20191209180223.194959-2-bvanassche@acm.org> (raw)
In-Reply-To: <20191209180223.194959-1-bvanassche@acm.org>

Document the locking assumptions this function relies on and also verify these
locking assumptions at runtime.

Cc: Quinn Tran <qutran@marvell.com>
Cc: Martin Wilck <mwilck@suse.com>
Cc: Daniel Wagner <dwagner@suse.de>
Cc: Roman Bolshakov <r.bolshakov@yadro.com>
Signed-off-by: Bart Van Assche <bvanassche@acm.org>
---
 drivers/scsi/qla2xxx/qla_os.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
index 8b84bc4a6ac8..145ea93206f0 100644
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -1700,6 +1700,8 @@ static void qla2x00_abort_srb(struct qla_qpair *qp, srb_t *sp, const int res,
 	bool ret_cmd;
 	uint32_t ratov_j;
 
+	lockdep_assert_held(qp->qp_lock_ptr);
+
 	if (qla2x00_chip_is_down(vha)) {
 		sp->done(sp, res);
 		return;

  reply	other threads:[~2019-12-09 18:02 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 18:02 [PATCH 0/4] qla2xxx patches for kernel v5.6 Bart Van Assche
2019-12-09 18:02 ` Bart Van Assche [this message]
2019-12-10 11:06   ` [PATCH 1/4] qla2xxx: Check locking assumptions at runtime in qla2x00_abort_srb() Martin Wilck
2019-12-10 19:39   ` Himanshu Madhani
2019-12-11 19:03   ` Roman Bolshakov
2019-12-09 18:02 ` [PATCH 2/4] qla2xxx: Simplify the code for aborting SCSI commands Bart Van Assche
2019-12-10 11:47   ` Martin Wilck
2019-12-10 17:57     ` Bart Van Assche
2019-12-10 20:29       ` Martin Wilck
2019-12-10 20:45         ` Bart Van Assche
2019-12-11 10:26           ` Martin Wilck
2019-12-12 16:01     ` Roman Bolshakov
2019-12-10 19:41   ` Himanshu Madhani
2019-12-12 16:04   ` Roman Bolshakov
2019-12-09 18:02 ` [PATCH 3/4] qla2xxx: Fix point-to-point mode for qla25xx and older Bart Van Assche
2019-12-10 10:52   ` Martin Wilck
2019-12-10 18:00     ` Bart Van Assche
2019-12-10 19:44       ` Martin Wilck
2019-12-12 20:07     ` Roman Bolshakov
2019-12-14  1:04       ` Roman Bolshakov
2019-12-15  0:09         ` Bart Van Assche
2019-12-16 11:45           ` Roman Bolshakov
2019-12-16 20:08             ` Roman Bolshakov
2019-12-16  8:37         ` Daniel Wagner
2019-12-10 19:40   ` Himanshu Madhani
2019-12-09 18:02 ` [PATCH 4/4] qla2xxx: Micro-optimize qla2x00_configure_local_loop() Bart Van Assche
2019-12-10 10:46   ` Martin Wilck
2019-12-14 12:30     ` Roman Bolshakov
2019-12-15  0:12     ` Bart Van Assche
2019-12-14 12:33   ` Roman Bolshakov
2019-12-15  0:14     ` Bart Van Assche
2020-02-06 13:23 ` [PATCH 0/4] qla2xxx patches for kernel v5.6 Martin Wilck
2020-02-06 20:49   ` Bart Van Assche
2020-02-06 20:52     ` Martin Wilck
2020-02-06 21:01       ` Bart Van Assche
2020-02-07  9:09         ` Martin Wilck
2020-02-08  3:17           ` Bart Van Assche

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209180223.194959-2-bvanassche@acm.org \
    --to=bvanassche@acm.org \
    --cc=dwagner@suse.de \
    --cc=jejb@linux.vnet.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=mwilck@suse.com \
    --cc=qutran@marvell.com \
    --cc=r.bolshakov@yadro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.