From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0F90C43603 for ; Tue, 10 Dec 2019 17:12:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A5B3C2073B for ; Tue, 10 Dec 2019 17:12:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=netronome-com.20150623.gappssmtp.com header.i=@netronome-com.20150623.gappssmtp.com header.b="BZ92BIwW" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727719AbfLJRMr (ORCPT ); Tue, 10 Dec 2019 12:12:47 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:37116 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727553AbfLJRMr (ORCPT ); Tue, 10 Dec 2019 12:12:47 -0500 Received: by mail-pl1-f195.google.com with SMTP id c23so127271plz.4 for ; Tue, 10 Dec 2019 09:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=netronome-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :organization:mime-version:content-transfer-encoding; bh=ZD+wd55MbpiKBwOs4hW8gl6L+aU37IccOqDX3dd5NyE=; b=BZ92BIwWtDXhF4F+dgkNcGmqzQ0hi5vM6sId4W+ibp5wp0KptxFiuPyTYn3qC6NsbD alWP4GdCyylPdtkSfbJuR0i22bYHwBQHZCG9lK0ow+LTh9KrD6/L1olF8qp//GZlkd6T DVK9+HLGig4PTtTS0hXmThBTpl5A0aJrxentxtFoSBu3Mvmjyc5+6yBmg9UsUo6WKplh Gat1l7XuudmE6JYj0QuQPj3mmeWtKrm1CNB4n4/evBMIWnhBW+qgHm4LsFe6B2L30lG0 HSn3noJi+HSib2xpP7rz1RwD4Q80gMjHHPmaCnOvyZbWs7r2mDlSr0q75PGkpXnYbj4j lMyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:organization:mime-version:content-transfer-encoding; bh=ZD+wd55MbpiKBwOs4hW8gl6L+aU37IccOqDX3dd5NyE=; b=t0u0cb6w8+kpN+uHkSNaj3NdQY8ihrAOtCNL1vBQO/riaD1/HNy6Ijl42gz+U8Nmrw sSv6xXOgRUFlbWAp5ZM+cHoW+J1r0GS30IlFNEbaA0HKnqe4vIIVMIwMhzx5HGvZ+YSI MNXUXgo0yzfLRSGIi9TJkWrFFHuzsEyghi2ioYQYXrJyOomc1aGwrYfksYuAVidKooCE 35vZbEx1syjD0+F8zDOn2vTcl4ygwHeDym/tGg8qILqynFs6uoxgNA30do8YFfJP7neJ MgjKn4qbl+8ePJkPH1ACeM9EXwHb5F1fYHUGGFHNEfbDJUZ9B4kTqLYsl9KNCtA+kPYz jNig== X-Gm-Message-State: APjAAAXdTp8mxsYH20aOPUf0OMjf9RAntF1hx24pDuHeH/FREbb4Fj9t b/dSTGk5KaSjLEYLg/33iSYjew== X-Google-Smtp-Source: APXvYqyF6W66BMTxnAytzEXlBaKoQ91qch57tqY3e1dFG1KP9NPaSBofk8zYXzxZZf4hUrHOYFO4NQ== X-Received: by 2002:a17:90a:a416:: with SMTP id y22mr6670085pjp.114.1575997966443; Tue, 10 Dec 2019 09:12:46 -0800 (PST) Received: from cakuba.netronome.com ([2601:646:8e00:e18::3]) by smtp.gmail.com with ESMTPSA id z4sm4077112pfn.42.2019.12.10.09.12.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Dec 2019 09:12:46 -0800 (PST) Date: Tue, 10 Dec 2019 09:12:41 -0800 From: Jakub Kicinski To: subashab@codeaurora.org Cc: Maciej =?UTF-8?B?xbtlbmN6eWtvd3NraQ==?= , "David S . Miller" , Linux Network Development Mailing List , Marcelo Ricardo Leitner , Sean Tranchetti , Eric Dumazet , Linux SCTP Subject: Re: [PATCH v2] net: introduce ip_local_unbindable_ports sysctl Message-ID: <20191210091241.0c6df09e@cakuba.netronome.com> In-Reply-To: <0101016eee9bf9b5-f5615781-f0a6-41c4-8e9d-ed694eccf07c-000000@us-west-2.amazonses.com> References: <20191209224530.156283-1-zenczykowski@gmail.com> <20191209154216.7e19e0c0@cakuba.netronome.com> <20191209161835.7c455fc0@cakuba.netronome.com> <0101016eee9bf9b5-f5615781-f0a6-41c4-8e9d-ed694eccf07c-000000@us-west-2.amazonses.com> Organization: Netronome Systems, Ltd. MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, 10 Dec 2019 07:00:29 +0000, subashab@codeaurora.org wrote: > > Okay, that's what I was suspecting. It'd be great if the real > > motivation for a patch was spelled out in the commit message :/ > > > > So some SoCs which run non-vanilla kernels require hacks to steal > > ports from the networking stack for use by proprietary firmware. > > > > I don't see how merging this patch benefits the community. > > This is just a transparent proxy scenario though. > We block the specific ports so that there is no unrelated traffic > belonging to host proxied here incorrectly. It's a form of one, agreed, although let's be honest - someone reading the transparent proxy use case in the commit message will not think of a complex AP scenario, but rather of a locally configured transparent proxy with IPtables or sockets or such. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jakub Kicinski Date: Tue, 10 Dec 2019 17:12:41 +0000 Subject: Re: [PATCH v2] net: introduce ip_local_unbindable_ports sysctl Message-Id: <20191210091241.0c6df09e@cakuba.netronome.com> List-Id: References: <20191209224530.156283-1-zenczykowski@gmail.com> <20191209154216.7e19e0c0@cakuba.netronome.com> <20191209161835.7c455fc0@cakuba.netronome.com> <0101016eee9bf9b5-f5615781-f0a6-41c4-8e9d-ed694eccf07c-000000@us-west-2.amazonses.com> In-Reply-To: <0101016eee9bf9b5-f5615781-f0a6-41c4-8e9d-ed694eccf07c-000000@us-west-2.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: subashab@codeaurora.org Cc: Maciej =?UTF-8?B?xbtlbmN6eWtvd3NraQ==?= , "David S . Miller" , Linux Network Development Mailing List , Marcelo Ricardo Leitner , Sean Tranchetti , Eric Dumazet , Linux SCTP On Tue, 10 Dec 2019 07:00:29 +0000, subashab@codeaurora.org wrote: > > Okay, that's what I was suspecting. It'd be great if the real > > motivation for a patch was spelled out in the commit message :/ > > > > So some SoCs which run non-vanilla kernels require hacks to steal > > ports from the networking stack for use by proprietary firmware. > > > > I don't see how merging this patch benefits the community. > > This is just a transparent proxy scenario though. > We block the specific ports so that there is no unrelated traffic > belonging to host proxied here incorrectly. It's a form of one, agreed, although let's be honest - someone reading the transparent proxy use case in the commit message will not think of a complex AP scenario, but rather of a locally configured transparent proxy with IPtables or sockets or such.