From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Date: Tue, 10 Dec 2019 10:24:44 +0000 Subject: [PATCH v2] pwm: sun4i: Narrow scope of local variable Message-Id: <20191210102444.26594-1-u.kleine-koenig@pengutronix.de> List-Id: References: <20191210101229.rvqelc2hanisd2cp@pengutronix.de> In-Reply-To: <20191210101229.rvqelc2hanisd2cp@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: Colin King , Thierry Reding , Walter Harms Cc: linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Dan Carpenter The variable pval is only used in a single block in the function sun4i_pwm_calculate(). So declare it in a more local scope to simplify the function for humans and compilers. While at it also simplify assignment to pval. While the diffstat for this patch is negative for this patch I still thing the advantage of having a narrower scope is beneficial. In my compiler / .config setup (gcc 8.2.1, arm/imx_v6_v7_defconfig + COMPILE_TEST + PWM_SUN4I) this change doesn't result in any binary changes. Signed-off-by: Uwe Kleine-K=C3=B6nig --- Hello, changes since (implicit) v1: - also simplify assignment to pval as suggested by Walter - verify the patch doesn't introduce binary changes Best regards Uwe drivers/pwm/pwm-sun4i.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c index 1fa2057419fb..4f77ebc8ae69 100644 --- a/drivers/pwm/pwm-sun4i.c +++ b/drivers/pwm/pwm-sun4i.c @@ -152,7 +152,7 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *s= un4i_pwm, u32 *dty, u32 *prd, unsigned int *prsclr) { u64 clk_rate, div =3D 0; - unsigned int pval, prescaler =3D 0; + unsigned int prescaler =3D 0; =20 clk_rate =3D clk_get_rate(sun4i_pwm->clk); =20 @@ -173,9 +173,11 @@ static int sun4i_pwm_calculate(struct sun4i_pwm_chip *= sun4i_pwm, if (prescaler =3D 0) { /* Go up from the first divider */ for (prescaler =3D 0; prescaler < PWM_PRESCAL_MASK; prescaler++) { + unsigned int pval =3D prescaler_table[prescaler]; + - if (!prescaler_table[prescaler]) + if (!pval) continue; - pval =3D prescaler_table[prescaler]; + div =3D clk_rate; do_div(div, pval); div =3D div * state->period; --=20 2.24.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?q?Uwe=20Kleine-K=C3=B6nig?= Subject: [PATCH v2] pwm: sun4i: Narrow scope of local variable Date: Tue, 10 Dec 2019 11:24:44 +0100 Message-ID: <20191210102444.26594-1-u.kleine-koenig@pengutronix.de> References: <20191210101229.rvqelc2hanisd2cp@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191210101229.rvqelc2hanisd2cp@pengutronix.de> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Colin King , Thierry Reding , Walter Harms Cc: linux-pwm@vger.kernel.org, kernel-janitors@vger.kernel.org, =?UTF-8?q?Cl=C3=A9ment=20P=C3=A9ron?= , linux-arm-kernel@lists.infradead.org, kernel@pengutronix.de, Dan Carpenter List-Id: linux-pwm@vger.kernel.org VGhlIHZhcmlhYmxlIHB2YWwgaXMgb25seSB1c2VkIGluIGEgc2luZ2xlIGJsb2NrIGluIHRoZSBm dW5jdGlvbgpzdW40aV9wd21fY2FsY3VsYXRlKCkuIFNvIGRlY2xhcmUgaXQgaW4gYSBtb3JlIGxv Y2FsIHNjb3BlIHRvIHNpbXBsaWZ5CnRoZSBmdW5jdGlvbiBmb3IgaHVtYW5zIGFuZCBjb21waWxl cnMuCgpXaGlsZSBhdCBpdCBhbHNvIHNpbXBsaWZ5IGFzc2lnbm1lbnQgdG8gcHZhbC4KCldoaWxl IHRoZSBkaWZmc3RhdCBmb3IgdGhpcyBwYXRjaCBpcyBuZWdhdGl2ZSBmb3IgdGhpcyBwYXRjaCBJ IHN0aWxsCnRoaW5nIHRoZSBhZHZhbnRhZ2Ugb2YgaGF2aW5nIGEgbmFycm93ZXIgc2NvcGUgaXMg YmVuZWZpY2lhbC4KCkluIG15IGNvbXBpbGVyIC8gLmNvbmZpZyBzZXR1cCAoZ2NjIDguMi4xLCBh cm0vaW14X3Y2X3Y3X2RlZmNvbmZpZyArCkNPTVBJTEVfVEVTVCArIFBXTV9TVU40SSkgdGhpcyBj aGFuZ2UgZG9lc24ndCByZXN1bHQgaW4gYW55IGJpbmFyeQpjaGFuZ2VzLgoKU2lnbmVkLW9mZi1i eTogVXdlIEtsZWluZS1Lw7ZuaWcgPHUua2xlaW5lLWtvZW5pZ0BwZW5ndXRyb25peC5kZT4KLS0t CkhlbGxvLAoKY2hhbmdlcyBzaW5jZSAoaW1wbGljaXQpIHYxOgoKIC0gYWxzbyBzaW1wbGlmeSBh c3NpZ25tZW50IHRvIHB2YWwgYXMgc3VnZ2VzdGVkIGJ5IFdhbHRlcgogLSB2ZXJpZnkgdGhlIHBh dGNoIGRvZXNuJ3QgaW50cm9kdWNlIGJpbmFyeSBjaGFuZ2VzCgpCZXN0IHJlZ2FyZHMKVXdlCgog ZHJpdmVycy9wd20vcHdtLXN1bjRpLmMgfCA4ICsrKysrLS0tCiAxIGZpbGUgY2hhbmdlZCwgNSBp bnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvcHdtL3B3 bS1zdW40aS5jIGIvZHJpdmVycy9wd20vcHdtLXN1bjRpLmMKaW5kZXggMWZhMjA1NzQxOWZiLi40 Zjc3ZWJjOGFlNjkgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvcHdtL3B3bS1zdW40aS5jCisrKyBiL2Ry aXZlcnMvcHdtL3B3bS1zdW40aS5jCkBAIC0xNTIsNyArMTUyLDcgQEAgc3RhdGljIGludCBzdW40 aV9wd21fY2FsY3VsYXRlKHN0cnVjdCBzdW40aV9wd21fY2hpcCAqc3VuNGlfcHdtLAogCQkJICAg ICAgIHUzMiAqZHR5LCB1MzIgKnByZCwgdW5zaWduZWQgaW50ICpwcnNjbHIpCiB7CiAJdTY0IGNs a19yYXRlLCBkaXYgPSAwOwotCXVuc2lnbmVkIGludCBwdmFsLCBwcmVzY2FsZXIgPSAwOworCXVu c2lnbmVkIGludCBwcmVzY2FsZXIgPSAwOwogCiAJY2xrX3JhdGUgPSBjbGtfZ2V0X3JhdGUoc3Vu NGlfcHdtLT5jbGspOwogCkBAIC0xNzMsOSArMTczLDExIEBAIHN0YXRpYyBpbnQgc3VuNGlfcHdt X2NhbGN1bGF0ZShzdHJ1Y3Qgc3VuNGlfcHdtX2NoaXAgKnN1bjRpX3B3bSwKIAlpZiAocHJlc2Nh bGVyID09IDApIHsKIAkJLyogR28gdXAgZnJvbSB0aGUgZmlyc3QgZGl2aWRlciAqLwogCQlmb3Ig KHByZXNjYWxlciA9IDA7IHByZXNjYWxlciA8IFBXTV9QUkVTQ0FMX01BU0s7IHByZXNjYWxlcisr KSB7CisJCQl1bnNpZ25lZCBpbnQgcHZhbCA9IHByZXNjYWxlcl90YWJsZVtwcmVzY2FsZXJdOwor Ci0JCQlpZiAoIXByZXNjYWxlcl90YWJsZVtwcmVzY2FsZXJdKQorCQkJaWYgKCFwdmFsKQogCQkJ CWNvbnRpbnVlOwotCQkJcHZhbCA9IHByZXNjYWxlcl90YWJsZVtwcmVzY2FsZXJdOworCiAJCQlk aXYgPSBjbGtfcmF0ZTsKIAkJCWRvX2RpdihkaXYsIHB2YWwpOwogCQkJZGl2ID0gZGl2ICogc3Rh dGUtPnBlcmlvZDsKLS0gCjIuMjQuMAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1r ZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK