From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 16F1AC43603 for ; Tue, 10 Dec 2019 14:47:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC95E2077B for ; Tue, 10 Dec 2019 14:47:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575989261; bh=t9mW6I2dr+Dg2/7uKgcBKKAq/tKRT4xQ0h18PE3NDVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=sqZmNPFHkNR7kBuwU/aBdUALstn6JdmO213hudiQwM7cUMrEDYwq0ggwx/Ch0IK5w N3Bc3QAMT15iiyIkuFBPP2LfKU5S9GLEbM/8RNXJXWHnLXID+dFkwX1uCniEJJVJu3 4itAPshMrfh+7zp2hC5xaKJAdgujbCdrD+dwd+kI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727535AbfLJOrk (ORCPT ); Tue, 10 Dec 2019 09:47:40 -0500 Received: from mail.kernel.org ([198.145.29.99]:56676 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727145AbfLJOrk (ORCPT ); Tue, 10 Dec 2019 09:47:40 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3581120637; Tue, 10 Dec 2019 14:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575989259; bh=t9mW6I2dr+Dg2/7uKgcBKKAq/tKRT4xQ0h18PE3NDVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kb15QnBe5+/0sGZPyfGV8xt6u5BKJLLdRfMUCmYQcSGRu4ORb3O4vWwvAc/HQNWMy c13OUy+ybJRy5GsVg1p/JFFwTSvpcNhidAzGa0Nbd8uHjkaH89Td880BBGrk8Vj1j3 E5rdW5bkfTd3idM8bNpf5rTqvLYbpcqxcWg68C3s= Date: Tue, 10 Dec 2019 15:47:37 +0100 From: Greg KH To: Thomas Renninger Cc: Will Deacon , Felix Schnizlein , linux-kernel@vger.kernel.org, Felix Schnizlein , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, will.deacon@arm.com, x86@kernel.org Subject: Re: [PATCH 3/3] arm64 cpuinfo: implement sysfs nodes for arm64 Message-ID: <20191210144737.GB3975980@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <25032400.G9DUGnJgnc@skinner.arch.suse.de> <20191209173804.GD7489@willie-the-truck> <11195456.EmMzWPVPDU@skinner.arch.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <11195456.EmMzWPVPDU@skinner.arch.suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2019 at 02:33:07PM +0100, Thomas Renninger wrote: > On Monday, December 9, 2019 6:38:05 PM CET Will Deacon wrote: > > On Mon, Dec 09, 2019 at 12:28:44PM +0100, Thomas Renninger wrote: > > > On Monday, December 9, 2019 11:31:11 AM CET Will Deacon wrote: > > > > On Fri, Dec 06, 2019 at 05:24:21PM +0100, Thomas Renninger wrote: > > > > > From: Felix Schnizlein > > > > > > > > > > Export all information from /proc/cpuinfo to sysfs: > > > > > implementer, architecture, variant, part, revision, > > > > > bogomips and flags are exported. > > > > > > > > > > Example: > > > > > /sys/devices/system/cpu/cpu1/info/:[0]# head * > > > > > > ... > > > > > > > > ==> flags <== > > > > > fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid asimdrdm > > > > > > ... > > > > > > > I don't understand why we need this on arm64 > > Again: proc is moving to sys. No. New stuff is to be added to /sys/, don't add new things to /proc unless it deals with processes. There is no mass-migration of existing /proc files to sysfs for no good reason. > You probably export feature flags in /proc/cpuinfo for a good reason. > So where in sysfs should this show up? Why does it have to live in sysfs if it is already in /proc and parsed properly by tools? thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41860C43603 for ; Tue, 10 Dec 2019 14:47:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0765B20836 for ; Tue, 10 Dec 2019 14:47:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="uUkltvZL"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="kb15QnBe" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0765B20836 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TJYs/4KT/junH2M64eDoscxiZfW3T7xE8MX/sMphZtU=; b=uUkltvZLI1g6Ki qYZSBNPikrlRgCqtDMp87p+o4fWoLQiHA1xqG75a/bCt+Ut31pcPvB0J8JKka2X0Eumte9qEe1WjY npkmQP10kBjlSd04eLbJIce3GuqawJRcQ/YhglOBydRyk7cN76Ox3EABfCQoe5yOmoiH8XwuXK+O2 QUpHBbXQEJ7J8zy+FEDMvYoFOxFkrNaGAFPS4+rqWr/kPnoX4Yvg+1qUuUB5Z0wJgtQk0DLCOyBhj x3ay6zLmsjq/DnNTpUgJZHPlNwX3L//nxt/WvXZs/UBHg578/tRaTVlqsUuM00xwMEQBlS0ZJsCjh Vlp8JI6/mK5cDNu5y7sg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iegnf-0002PK-9U; Tue, 10 Dec 2019 14:47:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iegnc-0002Om-Au for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 14:47:41 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3581120637; Tue, 10 Dec 2019 14:47:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575989259; bh=t9mW6I2dr+Dg2/7uKgcBKKAq/tKRT4xQ0h18PE3NDVU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=kb15QnBe5+/0sGZPyfGV8xt6u5BKJLLdRfMUCmYQcSGRu4ORb3O4vWwvAc/HQNWMy c13OUy+ybJRy5GsVg1p/JFFwTSvpcNhidAzGa0Nbd8uHjkaH89Td880BBGrk8Vj1j3 E5rdW5bkfTd3idM8bNpf5rTqvLYbpcqxcWg68C3s= Date: Tue, 10 Dec 2019 15:47:37 +0100 From: Greg KH To: Thomas Renninger Subject: Re: [PATCH 3/3] arm64 cpuinfo: implement sysfs nodes for arm64 Message-ID: <20191210144737.GB3975980@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <25032400.G9DUGnJgnc@skinner.arch.suse.de> <20191209173804.GD7489@willie-the-truck> <11195456.EmMzWPVPDU@skinner.arch.suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <11195456.EmMzWPVPDU@skinner.arch.suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_064740_397120_1E91C6BC X-CRM114-Status: GOOD ( 11.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Felix Schnizlein , Felix Schnizlein , x86@kernel.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, Will Deacon , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Dec 10, 2019 at 02:33:07PM +0100, Thomas Renninger wrote: > On Monday, December 9, 2019 6:38:05 PM CET Will Deacon wrote: > > On Mon, Dec 09, 2019 at 12:28:44PM +0100, Thomas Renninger wrote: > > > On Monday, December 9, 2019 11:31:11 AM CET Will Deacon wrote: > > > > On Fri, Dec 06, 2019 at 05:24:21PM +0100, Thomas Renninger wrote: > > > > > From: Felix Schnizlein > > > > > > > > > > Export all information from /proc/cpuinfo to sysfs: > > > > > implementer, architecture, variant, part, revision, > > > > > bogomips and flags are exported. > > > > > > > > > > Example: > > > > > /sys/devices/system/cpu/cpu1/info/:[0]# head * > > > > > > ... > > > > > > > > ==> flags <== > > > > > fp asimd evtstrm aes pmull sha1 sha2 crc32 cpuid asimdrdm > > > > > > ... > > > > > > > I don't understand why we need this on arm64 > > Again: proc is moving to sys. No. New stuff is to be added to /sys/, don't add new things to /proc unless it deals with processes. There is no mass-migration of existing /proc files to sysfs for no good reason. > You probably export feature flags in /proc/cpuinfo for a good reason. > So where in sysfs should this show up? Why does it have to live in sysfs if it is already in /proc and parsed properly by tools? thanks, greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel