From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C6B9C00454 for ; Tue, 10 Dec 2019 16:39:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C1AF2073D for ; Tue, 10 Dec 2019 16:39:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727603AbfLJQju (ORCPT ); Tue, 10 Dec 2019 11:39:50 -0500 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:56727 "EHLO relay3-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727177AbfLJQju (ORCPT ); Tue, 10 Dec 2019 11:39:50 -0500 X-Originating-IP: 90.182.112.136 Received: from localhost (136.112.broadband15.iol.cz [90.182.112.136]) (Authenticated sender: alexandre.belloni@bootlin.com) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 2F5696000D; Tue, 10 Dec 2019 16:39:46 +0000 (UTC) Date: Tue, 10 Dec 2019 17:39:44 +0100 From: Alexandre Belloni To: Biwen Li Cc: a.zummo@towertech.it, robh+dt@kernel.org, mark.rutland@arm.com, leoyang.li@nxp.com, linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Martin Fuzzey Subject: Re: [v5,1/2] dt-bindings: rtc: pcf85263/pcf85363: add some properties Message-ID: <20191210163944.GS1463890@piout.net> References: <20190919014520.15500-1-biwen.li@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190919014520.15500-1-biwen.li@nxp.com> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 19/09/2019 09:45:19+0800, Biwen Li wrote: > Add some properties for pcf85263/pcf85363 as follows: > - nxp,rtc-interrupt-type: integer type > - nxp,rtc-interrupt-output-pin: string type > - quartz-load-femtofarads: integer type > - quartz-drive-strength-ohms: integer type > - nxp,quartz-low-jitter: bool type > - wakeup-source: bool type > > Signed-off-by: Martin Fuzzey > Signed-off-by: Biwen Li > --- > Change in v5: > - Replace nxp,quartz-drive-strength with > quartz-drive-strength-ohms > - Select ohm unit for quartz drive strength > > Change in v4: > - Drop robust defines in include/dt-bindings/rtc/pcf85363.h > - Add nxp,rtc-interrupt-type property > - Replace interrupt-output-pin with nxp,rtc-interrupt-output-pin > > Change in v3: > - None > > Change in v2: > - Replace properties name > quartz-load-capacitance -> quartz-load-femtofarads > quartz-drive-strength -> nxp,quartz-drive-strength > quartz-low-jitter -> nxp,quartz-low-jitter > - Replace drive strength name > PCF85263_QUARTZDRIVE_NORMAL -> PCF85263_QUARTZDRIVE_100ko > PCF85263_QUARTZDRIVE_LOW -> PCF85263_QUARTZDRIVE_60ko > PCF85263_QUARTZDRIVE_HIGH -> PCF85263_QUARTZDRIVE_500ko > - Set default interrupt-output-pin as "INTA" > > .../devicetree/bindings/rtc/pcf85363.txt | 44 ++++++++++++++++++- > include/dt-bindings/rtc/pcf85363.h | 14 ++++++ > 2 files changed, 57 insertions(+), 1 deletion(-) > create mode 100644 include/dt-bindings/rtc/pcf85363.h > > diff --git a/Documentation/devicetree/bindings/rtc/pcf85363.txt b/Documentation/devicetree/bindings/rtc/pcf85363.txt > index 94adc1cf93d9..7f907581d5db 100644 > --- a/Documentation/devicetree/bindings/rtc/pcf85363.txt > +++ b/Documentation/devicetree/bindings/rtc/pcf85363.txt > @@ -8,10 +8,52 @@ Required properties: > Optional properties: > - interrupts: IRQ line for the RTC (not implemented). > > +- nxp,rtc-interrupt-type: integer property, represent the interrupt's > + type. Valid values are > + INT_PIE(periodic interrupt enable), > + INT_OIE(offset correction interrupt enable), > + INT_A1IE(alarm1 interrupt enable), > + INT_A2IE(alarm2 interrupt enable), > + INT_TSRIE(timestamp register interrupt enable) > + INT_BSIE(battery switch interrupt enable), > + INT_WDIE(WatchDog interrupt enable,and > + compose these values such as: INT_A1IE | INT_A2IE, > + but currently only support INT_A1IE, default value is INT_A1IE. > + The property and property nxp,rtc-interrupt-output-pin > + work together to generate some interrupts on some pins. > + > +- nxp,rtc-interrupt-output-pin: The interrupt output pin must be > + "INTA" or "INTB", default value is "INTA". The property and property > + nxp,rtc-interrupt-type work together to generate some interrupts on > + some pins. > + This binding is still not working. What if you need INT_A1 on INTA and INT_WD on INTB? > +- quartz-load-femtofarads: The internal capacitor to select for the quartz, > + expressed in femto Farad (fF). Valid values are 6000, 7000 and 12500. > + Default value is 12500fF. > + > +- quartz-drive-strength-ohms: Drive strength for the quartz, > + expressed in ohm, Valid values are 60000, 100000 and 500000. > + Default value is 100000 ohm. > + > +- nxp,quartz-low-jitter: Boolean property, if present enables low jitter mode > + which reduces jitter at the cost of increased power consumption. > + > +- wakeup-source: Boolean property, Please refer to > + Documentation/devicetree/bindings/power/wakeup-source.txt > + > Example: > > pcf85363: pcf85363@51 { > compatible = "nxp,pcf85363"; > reg = <0x51>; > -}; > > + interrupt-parent = <&gpio1>; > + interrupts = <18 IRQ_TYPE_EDGE_FALLING>; > + > + wakeup-source; > + nxp,rtc-interrupt-output-pin = "INTA"; > + nxp,rtc-interrupt-type = ; > + quartz-load-femtofarads = <12500>; > + quartz-drive-strength-ohms = <60000>; > + nxp,quartz-low-jitter; > +}; > diff --git a/include/dt-bindings/rtc/pcf85363.h b/include/dt-bindings/rtc/pcf85363.h > new file mode 100644 > index 000000000000..6340bf2da8f5 > --- /dev/null > +++ b/include/dt-bindings/rtc/pcf85363.h > @@ -0,0 +1,14 @@ > +/* SPDX-License-Identifier: GPL-2.0 */ > +#ifndef _DT_BINDINGS_RTC_PCF85363_H > +#define _DT_BINDINGS_RTC_PCF85363_H > + > +/* Interrupt type */ > +#define INT_WDIE (1 << 0) > +#define INT_BSIE (1 << 1) > +#define INT_TSRIE (1 << 2) > +#define INT_A2IE (1 << 3) > +#define INT_A1IE (1 << 4) > +#define INT_OIE (1 << 5) > +#define INT_PIE (1 << 6) Please remove IE from the define names. i.e INT_WDIE is a bit enabling INT_WD, you don't get an interrupt when the watchdog is enabled but rather when it expires. -- Alexandre Belloni, Bootlin Embedded Linux and Kernel engineering https://bootlin.com