From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA35EC43603 for ; Tue, 10 Dec 2019 20:53:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 93FD920828 for ; Tue, 10 Dec 2019 20:53:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576011232; bh=fkev4MRGf9Lhg8tjRG4U3dQfBAMe6/SLbFZByzfr46g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=NGVMBjrs5t4tEtERUBIi21AB5fh0kBks5CpoIn+j3xMJY3+Bv5FIXPFj+07H2mxd5 tQQyvqNrEKOkTf6Vowr4vuz/HXZ5VRwu8KUdwWnM6bJZQBpRi+qUQaAyioqSFz/hXz AHQ+WKeNw7QlUjZXK6bR1IOHC2Xz3nte3RrvQhws= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726901AbfLJUxv (ORCPT ); Tue, 10 Dec 2019 15:53:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:35496 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725999AbfLJUxv (ORCPT ); Tue, 10 Dec 2019 15:53:51 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29D62206EC; Tue, 10 Dec 2019 20:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576011230; bh=fkev4MRGf9Lhg8tjRG4U3dQfBAMe6/SLbFZByzfr46g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJ+yXHaw9iREFbIOuodzq9CaRUiVqEoOvWrbIbVYlqase9BSf1E/o1d2VepJuxPi7 HpJGb0VaGyHQqtvI3TkQSv9hCyYi13p0TSkCuatWGyaC+Em5K+XQyZQTbrlDOSL+by yWHyMPXWVUIXKnQdNnauCUuUp64VlKwmpHHt09r4= Date: Tue, 10 Dec 2019 21:53:48 +0100 From: Greg KH To: Thomas Gleixner Cc: Thomas Renninger , linux-kernel@vger.kernel.org, Felix Schnizlein , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, will.deacon@arm.com, x86@kernel.org, fschnitzlein@suse.de, Felix Schnizlein , Thomas Renninger Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 Message-ID: <20191210205348.GA4080658@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-3-trenn@suse.de> <20191206163656.GC86904@kroah.com> <87sglroqix.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87sglroqix.fsf@nanos.tec.linutronix.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 10, 2019 at 09:48:54PM +0100, Thomas Gleixner wrote: > Greg KH writes: > > On Fri, Dec 06, 2019 at 05:24:20PM +0100, Thomas Renninger wrote: > >> From: Felix Schnizlein > >> ==> flags <== > >> fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid tsc_known_freq pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 x2apic movbe popcnt tsc_deadline_timer aes xsave avx f16c rdrand hypervisor lahf_lm abm cpuid_fault invpcid_single pti ssbd ibrs ibpb fsgsbase tsc_adjust bmi1 avx2 smep bmi2 erms invpcid xsaveopt arat umip > > > > One file with all of that? We are going to run into problems > > eventually, that should be split up. > > > > Just like bugs, that's going to just grow over time and eventually > > overflow PAGE_SIZE :( > > > > Make this: > > ├── flags > > │   ├── fpu > > │   ├── vme > > ... > > > > Much simpler to parse, right? > > Well, I'm not really sure whether 100+ files are simpler to parse. > > Aside of that I really don't see the value for 100+ files per CPU which > are just returning 1 or True or whatever as long as you are not > suggesting to provide real feature files which have 0/1 or True/False > content. > > But I still don't get the whole thing. The only "argument" I've seen so > far is the 'proc moves to sys' mantra, but that does not make it any > better. That is not a valid mantra, as I tried to explain later in this thread. I don't understand the need for this patchset either, all I was trying to do was to at least make it sane from a sysfs-point-of-view if people really wanted to do this type of thing. > We won't get rid of /proc/cpuinfo for a very long time simply because > too much userspace uses it. Introducing a mess in /sys/ in parallel just > for following the mantra does not help much. Again, invalid mantra, not a valid reason :) I think this is a patchset in search of a problem, which is why it was dropped all those years ago... thanks, greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BC4AC43603 for ; Tue, 10 Dec 2019 20:53:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0838C20828 for ; Tue, 10 Dec 2019 20:53:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="G0CQfigx"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="MJ+yXHaw" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0838C20828 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tLRHK9RZ191tf9BHizQSBOWtnTzCgoTrjPR5iVRCAWo=; b=G0CQfigxcsKixq MAmAJSxrk+HptYbRfENEzKk82nWb+UgoqnKQyqHZUJfF6TC+MIOgpxpdR8dXQdUcjsJliEKIzDbjN tR1A55WgEtd8edfObbceeYZgdrKqijB5d9bX8tvTE7oF5w93XPMQtujV696Olq+MWJ7Ghd1hnIwFG S7opRxtF2Jx5G48cGo25bYAwIC+rrDw1lclKvcJkYP0ngCWb+Nx1+mz88kWkKGGBu9NkdxajWZD4F iydvBWBU2NegYU12cylP7h8RDZCwwSdsI0YM3IPVE0waXj4ghLWt+PwBETKYfE4IypjtEvyes5vT/ cA7/e8EAVewLCEq5gJUg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iemW1-0002wU-Pa; Tue, 10 Dec 2019 20:53:53 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iemVz-0002w1-0y for linux-arm-kernel@lists.infradead.org; Tue, 10 Dec 2019 20:53:52 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 29D62206EC; Tue, 10 Dec 2019 20:53:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576011230; bh=fkev4MRGf9Lhg8tjRG4U3dQfBAMe6/SLbFZByzfr46g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=MJ+yXHaw9iREFbIOuodzq9CaRUiVqEoOvWrbIbVYlqase9BSf1E/o1d2VepJuxPi7 HpJGb0VaGyHQqtvI3TkQSv9hCyYi13p0TSkCuatWGyaC+Em5K+XQyZQTbrlDOSL+by yWHyMPXWVUIXKnQdNnauCUuUp64VlKwmpHHt09r4= Date: Tue, 10 Dec 2019 21:53:48 +0100 From: Greg KH To: Thomas Gleixner Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 Message-ID: <20191210205348.GA4080658@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206162421.15050-3-trenn@suse.de> <20191206163656.GC86904@kroah.com> <87sglroqix.fsf@nanos.tec.linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87sglroqix.fsf@nanos.tec.linutronix.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191210_125351_092845_1BD457F1 X-CRM114-Status: GOOD ( 16.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Felix Schnizlein , Felix Schnizlein , x86@kernel.org, will.deacon@arm.com, linux@armlinux.org.uk, Thomas Renninger , linux-kernel@vger.kernel.org, fschnitzlein@suse.de, Thomas Renninger , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCBEZWMgMTAsIDIwMTkgYXQgMDk6NDg6NTRQTSArMDEwMCwgVGhvbWFzIEdsZWl4bmVy IHdyb3RlOgo+IEdyZWcgS0ggPGdyZWdraEBsaW51eGZvdW5kYXRpb24ub3JnPiB3cml0ZXM6Cj4g PiBPbiBGcmksIERlYyAwNiwgMjAxOSBhdCAwNToyNDoyMFBNICswMTAwLCBUaG9tYXMgUmVubmlu Z2VyIHdyb3RlOgo+ID4+IEZyb206IEZlbGl4IFNjaG5pemxlaW4gPGZzY2huaXpsZWluQHN1c2Uu ZGU+Cj4gPj4gPT0+IGZsYWdzIDw9PQo+ID4+IGZwdSB2bWUgZGUgcHNlIHRzYyBtc3IgcGFlIG1j ZSBjeDggYXBpYyBzZXAgbXRyciBwZ2UgbWNhIGNtb3YgcGF0IHBzZTM2IGNsZmx1c2ggbW14IGZ4 c3Igc3NlIHNzZTIgc3Mgc3lzY2FsbCBueCBwZHBlMWdiIHJkdHNjcCBsbSBjb25zdGFudF90c2Mg cmVwX2dvb2Qgbm9wbCB4dG9wb2xvZ3kgY3B1aWQgdHNjX2tub3duX2ZyZXEgcG5pIHBjbG11bHFk cSBzc3NlMyBmbWEgY3gxNiBwY2lkIHNzZTRfMSBzc2U0XzIgeDJhcGljIG1vdmJlIHBvcGNudCB0 c2NfZGVhZGxpbmVfdGltZXIgYWVzIHhzYXZlIGF2eCBmMTZjIHJkcmFuZCBoeXBlcnZpc29yIGxh aGZfbG0gYWJtIGNwdWlkX2ZhdWx0IGludnBjaWRfc2luZ2xlIHB0aSBzc2JkIGlicnMgaWJwYiBm c2dzYmFzZSB0c2NfYWRqdXN0IGJtaTEgYXZ4MiBzbWVwIGJtaTIgZXJtcyBpbnZwY2lkIHhzYXZl b3B0IGFyYXQgdW1pcAo+ID4KPiA+IE9uZSBmaWxlIHdpdGggYWxsIG9mIHRoYXQ/ICBXZSBhcmUg Z29pbmcgdG8gcnVuIGludG8gcHJvYmxlbXMKPiA+IGV2ZW50dWFsbHksIHRoYXQgc2hvdWxkIGJl IHNwbGl0IHVwLgo+ID4KPiA+IEp1c3QgbGlrZSBidWdzLCB0aGF0J3MgZ29pbmcgdG8ganVzdCBn cm93IG92ZXIgdGltZSBhbmQgZXZlbnR1YWxseQo+ID4gb3ZlcmZsb3cgUEFHRV9TSVpFIDooCj4g Pgo+ID4gTWFrZSB0aGlzOgo+ID4gICDilJzilIDilIAgZmxhZ3MKPiA+ICAg4pSCwqDCoCDilJzi lIDilIAgZnB1Cj4gPiAgIOKUgsKgwqAg4pSc4pSA4pSAIHZtZQo+ID4gLi4uCj4gPgo+ID4gTXVj aCBzaW1wbGVyIHRvIHBhcnNlLCByaWdodD8KPiAKPiBXZWxsLCBJJ20gbm90IHJlYWxseSBzdXJl IHdoZXRoZXIgMTAwKyBmaWxlcyBhcmUgc2ltcGxlciB0byBwYXJzZS4KPiAKPiBBc2lkZSBvZiB0 aGF0IEkgcmVhbGx5IGRvbid0IHNlZSB0aGUgdmFsdWUgZm9yIDEwMCsgZmlsZXMgcGVyIENQVSB3 aGljaAo+IGFyZSBqdXN0IHJldHVybmluZyAxIG9yIFRydWUgb3Igd2hhdGV2ZXIgYXMgbG9uZyBh cyB5b3UgYXJlIG5vdAo+IHN1Z2dlc3RpbmcgdG8gcHJvdmlkZSByZWFsIGZlYXR1cmUgZmlsZXMg d2hpY2ggaGF2ZSAwLzEgb3IgVHJ1ZS9GYWxzZQo+IGNvbnRlbnQuCj4gCj4gQnV0IEkgc3RpbGwg ZG9uJ3QgZ2V0IHRoZSB3aG9sZSB0aGluZy4gVGhlIG9ubHkgImFyZ3VtZW50IiBJJ3ZlIHNlZW4g c28KPiBmYXIgaXMgdGhlICdwcm9jIG1vdmVzIHRvIHN5cycgbWFudHJhLCBidXQgdGhhdCBkb2Vz IG5vdCBtYWtlIGl0IGFueQo+IGJldHRlci4KClRoYXQgaXMgbm90IGEgdmFsaWQgbWFudHJhLCBh cyBJIHRyaWVkIHRvIGV4cGxhaW4gbGF0ZXIgaW4gdGhpcyB0aHJlYWQuCgpJIGRvbid0IHVuZGVy c3RhbmQgdGhlIG5lZWQgZm9yIHRoaXMgcGF0Y2hzZXQgZWl0aGVyLCBhbGwgSSB3YXMgdHJ5aW5n CnRvIGRvIHdhcyB0byBhdCBsZWFzdCBtYWtlIGl0IHNhbmUgZnJvbSBhIHN5c2ZzLXBvaW50LW9m LXZpZXcgaWYgcGVvcGxlCnJlYWxseSB3YW50ZWQgdG8gZG8gdGhpcyB0eXBlIG9mIHRoaW5nLgoK PiBXZSB3b24ndCBnZXQgcmlkIG9mIC9wcm9jL2NwdWluZm8gZm9yIGEgdmVyeSBsb25nIHRpbWUg c2ltcGx5IGJlY2F1c2UKPiB0b28gbXVjaCB1c2Vyc3BhY2UgdXNlcyBpdC4gSW50cm9kdWNpbmcg YSBtZXNzIGluIC9zeXMvIGluIHBhcmFsbGVsIGp1c3QKPiBmb3IgZm9sbG93aW5nIHRoZSBtYW50 cmEgZG9lcyBub3QgaGVscCBtdWNoLgoKQWdhaW4sIGludmFsaWQgbWFudHJhLCBub3QgYSB2YWxp ZCByZWFzb24gOikKCkkgdGhpbmsgdGhpcyBpcyBhIHBhdGNoc2V0IGluIHNlYXJjaCBvZiBhIHBy b2JsZW0sIHdoaWNoIGlzIHdoeSBpdCB3YXMKZHJvcHBlZCBhbGwgdGhvc2UgeWVhcnMgYWdvLi4u Cgp0aGFua3MsCgpncmVnIGstaAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=