All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: "Daniel Walker (danielwa)" <danielwa@cisco.com>
Cc: "Aviraj Cj (acj)" <acj@cisco.com>,
	"peppe.cavallaro@st.com" <peppe.cavallaro@st.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"xe-linux-external(mailer list)" <xe-linux-external@cisco.com>
Subject: Re: [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor
Date: Wed, 11 Dec 2019 08:38:10 +0100	[thread overview]
Message-ID: <20191211073810.GA398293@kroah.com> (raw)
In-Reply-To: <20191210214014.GV20426@zorba>

On Tue, Dec 10, 2019 at 09:40:17PM +0000, Daniel Walker (danielwa) wrote:
> On Tue, Dec 10, 2019 at 09:55:42PM +0100, Greg KH wrote:
> > On Tue, Dec 10, 2019 at 09:06:58AM -0800, Aviraj CJ wrote:
> > > We always program the maximum DMA buffer size into the receive descriptor,
> > > although the allocated size may be less. E.g. with the default MTU size
> > > we allocate only 1536 bytes. If somebody sends us a bigger frame, then
> > > memory may get corrupted.
> > > 
> > > Program DMA using exact buffer sizes.
> > > 
> > > [Adopted based on upstream commit c13a936f46e3321ad2426443296571fab2feda44
> > > ("net: stmmac: use correct DMA buffer size in the RX descriptor")
> > > by Aaro Koskinen <aaro.koskinen@nokia.com> ]
> > 
> > Adopted to what?
> > 
> > What is this patch for, it looks just like the commit you reference
> > here.
> > 
> > totally confused,
> 
> 
> We're using the patches on the v4.4 -stable branch. It doesn't have these patches and
> the backport had rejects.

Ok, but commit "c13a936f46e3321ad2426443296571fab2feda44" is not in
Linus's tree, and so I think you really mean 583e63614149 ("net: stmmac:
use correct DMA buffer size in the RX descriptor") which is only
included in 4.19 and newer kernels.

So why would this need to go to 4.4.y?

And if so, it needs to be explicitly stated as such, you all have read
the stable kernel rules file, right?

Please fix up and resend properly, as well as providing a version for
newer kernels also if you really want this in a 4.4.y release.

As David said, to not do so just causes a total waste of developer time
trying to figure out what you all are wanting to do here...

thanks,

greg k-h

      parent reply	other threads:[~2019-12-11  7:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-10 17:06 [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor Aviraj CJ
2019-12-10 17:06 ` [PATCH 2/2] net: stmmac: don't stop NAPI processing when dropping a packet Aviraj CJ
2019-12-10 20:55 ` [PATCH 1/2] net: stmmac: use correct DMA buffer size in the RX descriptor Greg KH
2019-12-10 21:40   ` Daniel Walker (danielwa)
2019-12-11  1:06     ` David Miller
2019-12-11  7:38     ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191211073810.GA398293@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=acj@cisco.com \
    --cc=danielwa@cisco.com \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    --cc=xe-linux-external@cisco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.