All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Add support for Solidrun CEX7 platforms
@ 2019-12-09 12:00 ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-09 12:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: devicetree, linux-arm-kernel, Li Yang, Mark Rutland, Rob Herring,
	Jon Nettleton, Rabeeh Khoury

Hi,

This series adds support for the Solidrun Clearfog CX and Honeycomb
platforms that various developers have access to.

 arch/arm64/boot/dts/freescale/Makefile             |   2 +
 .../arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi | 123 +++++++++++++++++++++
 .../boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../dts/freescale/fsl-lx2160a-clearfog-itx.dtsi    |  57 ++++++++++
 .../boot/dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi     |  20 ++++
 6 files changed, 232 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts


-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [PATCH 0/2] Add support for Solidrun CEX7 platforms
@ 2019-12-09 12:00 ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-09 12:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

Hi,

This series adds support for the Solidrun Clearfog CX and Honeycomb
platforms that various developers have access to.

 arch/arm64/boot/dts/freescale/Makefile             |   2 +
 .../arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi | 123 +++++++++++++++++++++
 .../boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../dts/freescale/fsl-lx2160a-clearfog-itx.dtsi    |  57 ++++++++++
 .../boot/dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi     |  20 ++++
 6 files changed, 232 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts


-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
  2019-12-09 12:00 ` Russell King - ARM Linux admin
@ 2019-12-09 12:00   ` Russell King
  -1 siblings, 0 replies; 22+ messages in thread
From: Russell King @ 2019-12-09 12:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Jon Nettleton, Rabeeh Khoury, Li Yang, Rob Herring, Mark Rutland,
	linux-arm-kernel, devicetree

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
the SolidRun Clearfog CX platform.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index 0bd98f179bfa..617e1f1a2339 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
 		fsl_mc: fsl-mc@80c000000 {
 			compatible = "fsl,qoriq-mc";
 			reg = <0x00000008 0x0c000000 0 0x40>,
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
@ 2019-12-09 12:00   ` Russell King
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King @ 2019-12-09 12:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
the SolidRun Clearfog CX platform.

Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
 1 file changed, 20 insertions(+)

diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
index 0bd98f179bfa..617e1f1a2339 100644
--- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
@@ -863,6 +863,26 @@
 			fsl,extts-fifo;
 		};
 
+		emdio1: mdio@8b96000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b96000 0x00 0x1000>;
+			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
+		emdio2: mdio@8b97000 {
+			compatible = "fsl,fman-memac-mdio";
+			reg = <0x00 0x8b97000 0x00 0x1000>;
+			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
+			little-endian;
+			#address-cells = <0x01>;
+			#size-cells = <0x00>;
+			status = "disabled";
+		};
+
 		fsl_mc: fsl-mc@80c000000 {
 			compatible = "fsl,qoriq-mc";
 			reg = <0x00000008 0x0c000000 0 0x40>,
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
  2019-12-09 12:00 ` Russell King - ARM Linux admin
@ 2019-12-09 12:00   ` Russell King
  -1 siblings, 0 replies; 22+ messages in thread
From: Russell King @ 2019-12-09 12:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Jon Nettleton, Rabeeh Khoury, Rob Herring, Mark Rutland, Li Yang,
	devicetree, linux-arm-kernel

From: Rabeeh Khoury <rabeeh@solid-run.com>

The device tree enables the following features -
1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
2. 2x MDIO busses
3. 2x USB 3.0 controllers
4. 4x SATA ports
5. MT35X 512Mb SPI flash
6. Temperature sensor on i2c0 channel 3
7. AMC6821 temperature and PWM fan controller (not fitted)

The module supports AMC6821 PWM controller which is not currently
assembled on currently available Com Express 7 hardware.

This commit adds support for the Clearfog CX and Honeycomb variants,
which are indentical in this patch, but once QSFP support is finished,
only the Clearfog CX will have a QSFP description.

Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
[Add Makefile patch, split into clearfog-cx and honeycomb variants,
reworded commit -- rmk]
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/arm64/boot/dts/freescale/Makefile        |   2 +
 .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
 .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
 .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 5 files changed, 212 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 93fce8f0c66d..b4d696e64625 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
new file mode 100644
index 000000000000..4761737e62e2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
@@ -0,0 +1,123 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A-CEx7
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a.dtsi"
+
+/ {
+	model = "SolidRun LX2160A COM Express Type 7 module";
+	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";
+
+	aliases {
+		crypto = &crypto;
+	};
+
+	sb_3v3: regulator-sb3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "RT7290";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+};
+
+&crypto {
+	status = "okay";
+};
+
+&esdhc1 {
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+	bus-width = <8>;
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+
+	i2c-switch@77 {
+		compatible = "nxp,pca9547";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x77>;
+
+		i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+			fan-temperature-ctrlr@18 {
+				compatible = "ti,amc6821";
+				reg = <0x18>;
+				cooling-min-state = <0>;
+				cooling-max-state = <9>;
+				#cooling-cells = <2>;
+			};
+		};
+		i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+
+			temperature-sensor@48 {
+				compatible = "nxp,sa56004";
+				reg = <0x48>;
+				vcc-supply = <&sb_3v3>;
+			};
+		};
+	};
+};
+
+&i2c2 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+
+	rtc@51 {
+		compatible = "nxp,pcf2129";
+		reg = <0x51>;
+		// IRQ10_B
+		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
+	};
+};
+
+&fspi {
+	status = "okay";
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "micron,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>;
+		spi-tx-bus-width = <1>;
+	};
+};
+
+&usb0 {
+	status = "okay";
+};
+
+&usb1 {
+	status = "okay";
+};
+
+&emdio1 {
+	status = "okay";
+	rgmii_phy1: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
+&dpmac17 {
+	phy-handle = <&rgmii_phy1>;
+	phy-connection-type = "rgmii-id";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
new file mode 100644
index 000000000000..86a9b771428d
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog CX board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Clearfog CX";
+	compatible = "solidrun,clearfog-cx",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
new file mode 100644
index 000000000000..10541f1345bf
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog ITX board; this contains the
+// common parts shared between the Clearfog CX and Honeycomb builds.
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-cex7.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&esdhc0 {
+	sd-uhs-sdr104;
+	sd-uhs-sdr50;
+	sd-uhs-sdr25;
+	sd-uhs-sdr12;
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&emdio2 {
+	status = "okay";
+};
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
new file mode 100644
index 000000000000..fe19f3009ea5
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Honeycomb board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Honeycomb";
+	compatible = "solidrun,honeycomb",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 22+ messages in thread
* [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
@ 2019-12-09 12:00   ` Russell King
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King @ 2019-12-09 12:00 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

From: Rabeeh Khoury <rabeeh@solid-run.com>

The device tree enables the following features -
1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
2. 2x MDIO busses
3. 2x USB 3.0 controllers
4. 4x SATA ports
5. MT35X 512Mb SPI flash
6. Temperature sensor on i2c0 channel 3
7. AMC6821 temperature and PWM fan controller (not fitted)

The module supports AMC6821 PWM controller which is not currently
assembled on currently available Com Express 7 hardware.

This commit adds support for the Clearfog CX and Honeycomb variants,
which are indentical in this patch, but once QSFP support is finished,
only the Clearfog CX will have a QSFP description.

Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
[Add Makefile patch, split into clearfog-cx and honeycomb variants,
reworded commit -- rmk]
Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
---
 arch/arm64/boot/dts/freescale/Makefile        |   2 +
 .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
 .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
 .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
 .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
 5 files changed, 212 insertions(+)
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
 create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts

diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
index 93fce8f0c66d..b4d696e64625 100644
--- a/arch/arm64/boot/dts/freescale/Makefile
+++ b/arch/arm64/boot/dts/freescale/Makefile
@@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
+dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
 dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
 
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
new file mode 100644
index 000000000000..4761737e62e2
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
@@ -0,0 +1,123 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A-CEx7
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a.dtsi"
+
+/ {
+	model = "SolidRun LX2160A COM Express Type 7 module";
+	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";
+
+	aliases {
+		crypto = &crypto;
+	};
+
+	sb_3v3: regulator-sb3v3 {
+		compatible = "regulator-fixed";
+		regulator-name = "RT7290";
+		regulator-min-microvolt = <3300000>;
+		regulator-max-microvolt = <3300000>;
+		regulator-boot-on;
+		regulator-always-on;
+	};
+};
+
+&crypto {
+	status = "okay";
+};
+
+&esdhc1 {
+	mmc-hs200-1_8v;
+	mmc-hs400-1_8v;
+	bus-width = <8>;
+	status = "okay";
+};
+
+&i2c0 {
+	status = "okay";
+
+	i2c-switch@77 {
+		compatible = "nxp,pca9547";
+		#address-cells = <1>;
+		#size-cells = <0>;
+		reg = <0x77>;
+
+		i2c@1 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <1>;
+			fan-temperature-ctrlr@18 {
+				compatible = "ti,amc6821";
+				reg = <0x18>;
+				cooling-min-state = <0>;
+				cooling-max-state = <9>;
+				#cooling-cells = <2>;
+			};
+		};
+		i2c@3 {
+			#address-cells = <1>;
+			#size-cells = <0>;
+			reg = <3>;
+
+			temperature-sensor@48 {
+				compatible = "nxp,sa56004";
+				reg = <0x48>;
+				vcc-supply = <&sb_3v3>;
+			};
+		};
+	};
+};
+
+&i2c2 {
+	status = "okay";
+};
+
+&i2c4 {
+	status = "okay";
+
+	rtc@51 {
+		compatible = "nxp,pcf2129";
+		reg = <0x51>;
+		// IRQ10_B
+		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
+	};
+};
+
+&fspi {
+	status = "okay";
+	flash@0 {
+		#address-cells = <1>;
+		#size-cells = <1>;
+		compatible = "micron,m25p80";
+		m25p,fast-read;
+		spi-max-frequency = <50000000>;
+		reg = <0>;
+		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
+		spi-rx-bus-width = <8>;
+		spi-tx-bus-width = <1>;
+	};
+};
+
+&usb0 {
+	status = "okay";
+};
+
+&usb1 {
+	status = "okay";
+};
+
+&emdio1 {
+	status = "okay";
+	rgmii_phy1: ethernet-phy@1 {
+		reg = <1>;
+	};
+};
+
+&dpmac17 {
+	phy-handle = <&rgmii_phy1>;
+	phy-connection-type = "rgmii-id";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
new file mode 100644
index 000000000000..86a9b771428d
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog CX board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Clearfog CX";
+	compatible = "solidrun,clearfog-cx",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
new file mode 100644
index 000000000000..10541f1345bf
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
@@ -0,0 +1,57 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Clearfog ITX board; this contains the
+// common parts shared between the Clearfog CX and Honeycomb builds.
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-cex7.dtsi"
+
+/ {
+	aliases {
+		serial0 = &uart0;
+		serial1 = &uart1;
+	};
+
+	chosen {
+		stdout-path = "serial0:115200n8";
+	};
+};
+
+&esdhc0 {
+	sd-uhs-sdr104;
+	sd-uhs-sdr50;
+	sd-uhs-sdr25;
+	sd-uhs-sdr12;
+	status = "okay";
+};
+
+&uart0 {
+	status = "okay";
+};
+
+&uart1 {
+	status = "okay";
+};
+
+&emdio2 {
+	status = "okay";
+};
+
+&sata0 {
+	status = "okay";
+};
+
+&sata1 {
+	status = "okay";
+};
+
+&sata2 {
+	status = "okay";
+};
+
+&sata3 {
+	status = "okay";
+};
diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
new file mode 100644
index 000000000000..fe19f3009ea5
--- /dev/null
+++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
@@ -0,0 +1,15 @@
+// SPDX-License-Identifier: (GPL-2.0 OR MIT)
+//
+// Device Tree file for LX2160A Honeycomb board
+//
+// Copyright 2019 SolidRun Ltd.
+
+/dts-v1/;
+
+#include "fsl-lx2160a-clearfog-itx.dtsi"
+
+/ {
+	model = "SolidRun LX2160A Honeycomb";
+	compatible = "solidrun,honeycomb",
+		"solidrun,lx2160a-cex7", "fsl,lx2160a";
+};
-- 
2.20.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply related	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
  2019-12-09 12:00   ` Russell King
@ 2019-12-11  7:33     ` Shawn Guo
  -1 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-11  7:33 UTC (permalink / raw)
  To: Russell King
  Cc: Jon Nettleton, Rabeeh Khoury, Li Yang, Rob Herring, Mark Rutland,
	linux-arm-kernel, devicetree

On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> the SolidRun Clearfog CX platform.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 0bd98f179bfa..617e1f1a2339 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -863,6 +863,26 @@
>  			fsl,extts-fifo;
>  		};
>  
> +		emdio1: mdio@8b96000 {
> +			compatible = "fsl,fman-memac-mdio";
> +			reg = <0x00 0x8b96000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> +			little-endian;
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "disabled";
> +		};
> +
> +		emdio2: mdio@8b97000 {
> +			compatible = "fsl,fman-memac-mdio";
> +			reg = <0x00 0x8b97000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> +			little-endian;
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "disabled";
> +		};
> +

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
emdio2 was missing from there.

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

>  		fsl_mc: fsl-mc@80c000000 {
>  			compatible = "fsl,qoriq-mc";
>  			reg = <0x00000008 0x0c000000 0 0x40>,
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
@ 2019-12-11  7:33     ` Shawn Guo
  0 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-11  7:33 UTC (permalink / raw)
  To: Russell King
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> the SolidRun Clearfog CX platform.
> 
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
>  1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> index 0bd98f179bfa..617e1f1a2339 100644
> --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> @@ -863,6 +863,26 @@
>  			fsl,extts-fifo;
>  		};
>  
> +		emdio1: mdio@8b96000 {
> +			compatible = "fsl,fman-memac-mdio";
> +			reg = <0x00 0x8b96000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> +			little-endian;
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "disabled";
> +		};
> +
> +		emdio2: mdio@8b97000 {
> +			compatible = "fsl,fman-memac-mdio";
> +			reg = <0x00 0x8b97000 0x00 0x1000>;
> +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> +			little-endian;
> +			#address-cells = <0x01>;
> +			#size-cells = <0x00>;
> +			status = "disabled";
> +		};
> +

Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
emdio2 was missing from there.

Shawn

[1] https://lkml.org/lkml/2019/12/4/675

>  		fsl_mc: fsl-mc@80c000000 {
>  			compatible = "fsl,qoriq-mc";
>  			reg = <0x00000008 0x0c000000 0 0x40>,
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
  2019-12-09 12:00   ` Russell King
@ 2019-12-11  7:40     ` Shawn Guo
  -1 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-11  7:40 UTC (permalink / raw)
  To: Russell King
  Cc: Jon Nettleton, Rabeeh Khoury, Rob Herring, Mark Rutland, Li Yang,
	devicetree, linux-arm-kernel

On Mon, Dec 09, 2019 at 12:00:42PM +0000, Russell King wrote:
> From: Rabeeh Khoury <rabeeh@solid-run.com>
> 
> The device tree enables the following features -
> 1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
> 2. 2x MDIO busses
> 3. 2x USB 3.0 controllers
> 4. 4x SATA ports
> 5. MT35X 512Mb SPI flash
> 6. Temperature sensor on i2c0 channel 3
> 7. AMC6821 temperature and PWM fan controller (not fitted)
> 
> The module supports AMC6821 PWM controller which is not currently
> assembled on currently available Com Express 7 hardware.
> 
> This commit adds support for the Clearfog CX and Honeycomb variants,
> which are indentical in this patch, but once QSFP support is finished,
> only the Clearfog CX will have a QSFP description.
> 
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> [Add Makefile patch, split into clearfog-cx and honeycomb variants,
> reworded commit -- rmk]
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  arch/arm64/boot/dts/freescale/Makefile        |   2 +
>  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
>  .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
>  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
>  .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
>  5 files changed, 212 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 93fce8f0c66d..b4d696e64625 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
>  
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> new file mode 100644
> index 000000000000..4761737e62e2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> @@ -0,0 +1,123 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A-CEx7
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +
> +/ {
> +	model = "SolidRun LX2160A COM Express Type 7 module";
> +	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";

Any new compatible needs to be documented.

> +
> +	aliases {
> +		crypto = &crypto;
> +	};
> +
> +	sb_3v3: regulator-sb3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "RT7290";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +};
> +
> +&crypto {
> +	status = "okay";
> +};
> +
> +&esdhc1 {
> +	mmc-hs200-1_8v;
> +	mmc-hs400-1_8v;
> +	bus-width = <8>;
> +	status = "okay";
> +};
> +
> +&i2c0 {
> +	status = "okay";
> +
> +	i2c-switch@77 {
> +		compatible = "nxp,pca9547";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x77>;
> +
> +		i2c@1 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <1>;

As an idiomatic practice, we have a newline between properties and child
node ...

> +			fan-temperature-ctrlr@18 {
> +				compatible = "ti,amc6821";
> +				reg = <0x18>;
> +				cooling-min-state = <0>;
> +				cooling-max-state = <9>;
> +				#cooling-cells = <2>;
> +			};
> +		};

... and in between nodes.

> +		i2c@3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <3>;
> +
> +			temperature-sensor@48 {
> +				compatible = "nxp,sa56004";
> +				reg = <0x48>;
> +				vcc-supply = <&sb_3v3>;
> +			};
> +		};
> +	};
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +};
> +
> +&i2c4 {
> +	status = "okay";
> +
> +	rtc@51 {
> +		compatible = "nxp,pcf2129";
> +		reg = <0x51>;
> +		// IRQ10_B
> +		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +};
> +
> +&fspi {
> +	status = "okay";

Ditto

> +	flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "micron,m25p80";
> +		m25p,fast-read;
> +		spi-max-frequency = <50000000>;
> +		reg = <0>;
> +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> +		spi-rx-bus-width = <8>;
> +		spi-tx-bus-width = <1>;
> +	};
> +};
> +
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
> +&emdio1 {
> +	status = "okay";

Ditto

> +	rgmii_phy1: ethernet-phy@1 {
> +		reg = <1>;
> +	};
> +};
> +
> +&dpmac17 {

Instead of putting labeled nodes arbitrarily, we want to keep them
sorted alphabetically.

Shawn

> +	phy-handle = <&rgmii_phy1>;
> +	phy-connection-type = "rgmii-id";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> new file mode 100644
> index 000000000000..86a9b771428d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A Clearfog CX board
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a-clearfog-itx.dtsi"
> +
> +/ {
> +	model = "SolidRun LX2160A Clearfog CX";
> +	compatible = "solidrun,clearfog-cx",
> +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> new file mode 100644
> index 000000000000..10541f1345bf
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A Clearfog ITX board; this contains the
> +// common parts shared between the Clearfog CX and Honeycomb builds.
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a-cex7.dtsi"
> +
> +/ {
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&esdhc0 {
> +	sd-uhs-sdr104;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr12;
> +	status = "okay";
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&emdio2 {
> +	status = "okay";
> +};
> +
> +&sata0 {
> +	status = "okay";
> +};
> +
> +&sata1 {
> +	status = "okay";
> +};
> +
> +&sata2 {
> +	status = "okay";
> +};
> +
> +&sata3 {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> new file mode 100644
> index 000000000000..fe19f3009ea5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A Honeycomb board
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a-clearfog-itx.dtsi"
> +
> +/ {
> +	model = "SolidRun LX2160A Honeycomb";
> +	compatible = "solidrun,honeycomb",
> +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> +};
> -- 
> 2.20.1
> 

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
@ 2019-12-11  7:40     ` Shawn Guo
  0 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-11  7:40 UTC (permalink / raw)
  To: Russell King
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Mon, Dec 09, 2019 at 12:00:42PM +0000, Russell King wrote:
> From: Rabeeh Khoury <rabeeh@solid-run.com>
> 
> The device tree enables the following features -
> 1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
> 2. 2x MDIO busses
> 3. 2x USB 3.0 controllers
> 4. 4x SATA ports
> 5. MT35X 512Mb SPI flash
> 6. Temperature sensor on i2c0 channel 3
> 7. AMC6821 temperature and PWM fan controller (not fitted)
> 
> The module supports AMC6821 PWM controller which is not currently
> assembled on currently available Com Express 7 hardware.
> 
> This commit adds support for the Clearfog CX and Honeycomb variants,
> which are indentical in this patch, but once QSFP support is finished,
> only the Clearfog CX will have a QSFP description.
> 
> Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> [Add Makefile patch, split into clearfog-cx and honeycomb variants,
> reworded commit -- rmk]
> Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> ---
>  arch/arm64/boot/dts/freescale/Makefile        |   2 +
>  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
>  .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
>  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
>  .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
>  5 files changed, 212 insertions(+)
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
>  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> 
> diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> index 93fce8f0c66d..b4d696e64625 100644
> --- a/arch/arm64/boot/dts/freescale/Makefile
> +++ b/arch/arm64/boot/dts/freescale/Makefile
> @@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
> +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
>  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
>  
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> new file mode 100644
> index 000000000000..4761737e62e2
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> @@ -0,0 +1,123 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A-CEx7
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a.dtsi"
> +
> +/ {
> +	model = "SolidRun LX2160A COM Express Type 7 module";
> +	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";

Any new compatible needs to be documented.

> +
> +	aliases {
> +		crypto = &crypto;
> +	};
> +
> +	sb_3v3: regulator-sb3v3 {
> +		compatible = "regulator-fixed";
> +		regulator-name = "RT7290";
> +		regulator-min-microvolt = <3300000>;
> +		regulator-max-microvolt = <3300000>;
> +		regulator-boot-on;
> +		regulator-always-on;
> +	};
> +};
> +
> +&crypto {
> +	status = "okay";
> +};
> +
> +&esdhc1 {
> +	mmc-hs200-1_8v;
> +	mmc-hs400-1_8v;
> +	bus-width = <8>;
> +	status = "okay";
> +};
> +
> +&i2c0 {
> +	status = "okay";
> +
> +	i2c-switch@77 {
> +		compatible = "nxp,pca9547";
> +		#address-cells = <1>;
> +		#size-cells = <0>;
> +		reg = <0x77>;
> +
> +		i2c@1 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <1>;

As an idiomatic practice, we have a newline between properties and child
node ...

> +			fan-temperature-ctrlr@18 {
> +				compatible = "ti,amc6821";
> +				reg = <0x18>;
> +				cooling-min-state = <0>;
> +				cooling-max-state = <9>;
> +				#cooling-cells = <2>;
> +			};
> +		};

... and in between nodes.

> +		i2c@3 {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +			reg = <3>;
> +
> +			temperature-sensor@48 {
> +				compatible = "nxp,sa56004";
> +				reg = <0x48>;
> +				vcc-supply = <&sb_3v3>;
> +			};
> +		};
> +	};
> +};
> +
> +&i2c2 {
> +	status = "okay";
> +};
> +
> +&i2c4 {
> +	status = "okay";
> +
> +	rtc@51 {
> +		compatible = "nxp,pcf2129";
> +		reg = <0x51>;
> +		// IRQ10_B
> +		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
> +	};
> +};
> +
> +&fspi {
> +	status = "okay";

Ditto

> +	flash@0 {
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		compatible = "micron,m25p80";
> +		m25p,fast-read;
> +		spi-max-frequency = <50000000>;
> +		reg = <0>;
> +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> +		spi-rx-bus-width = <8>;
> +		spi-tx-bus-width = <1>;
> +	};
> +};
> +
> +&usb0 {
> +	status = "okay";
> +};
> +
> +&usb1 {
> +	status = "okay";
> +};
> +
> +&emdio1 {
> +	status = "okay";

Ditto

> +	rgmii_phy1: ethernet-phy@1 {
> +		reg = <1>;
> +	};
> +};
> +
> +&dpmac17 {

Instead of putting labeled nodes arbitrarily, we want to keep them
sorted alphabetically.

Shawn

> +	phy-handle = <&rgmii_phy1>;
> +	phy-connection-type = "rgmii-id";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> new file mode 100644
> index 000000000000..86a9b771428d
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A Clearfog CX board
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a-clearfog-itx.dtsi"
> +
> +/ {
> +	model = "SolidRun LX2160A Clearfog CX";
> +	compatible = "solidrun,clearfog-cx",
> +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> new file mode 100644
> index 000000000000..10541f1345bf
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> @@ -0,0 +1,57 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A Clearfog ITX board; this contains the
> +// common parts shared between the Clearfog CX and Honeycomb builds.
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a-cex7.dtsi"
> +
> +/ {
> +	aliases {
> +		serial0 = &uart0;
> +		serial1 = &uart1;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +};
> +
> +&esdhc0 {
> +	sd-uhs-sdr104;
> +	sd-uhs-sdr50;
> +	sd-uhs-sdr25;
> +	sd-uhs-sdr12;
> +	status = "okay";
> +};
> +
> +&uart0 {
> +	status = "okay";
> +};
> +
> +&uart1 {
> +	status = "okay";
> +};
> +
> +&emdio2 {
> +	status = "okay";
> +};
> +
> +&sata0 {
> +	status = "okay";
> +};
> +
> +&sata1 {
> +	status = "okay";
> +};
> +
> +&sata2 {
> +	status = "okay";
> +};
> +
> +&sata3 {
> +	status = "okay";
> +};
> diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> new file mode 100644
> index 000000000000..fe19f3009ea5
> --- /dev/null
> +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> @@ -0,0 +1,15 @@
> +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> +//
> +// Device Tree file for LX2160A Honeycomb board
> +//
> +// Copyright 2019 SolidRun Ltd.
> +
> +/dts-v1/;
> +
> +#include "fsl-lx2160a-clearfog-itx.dtsi"
> +
> +/ {
> +	model = "SolidRun LX2160A Honeycomb";
> +	compatible = "solidrun,honeycomb",
> +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> +};
> -- 
> 2.20.1
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
  2019-12-11  7:40     ` Shawn Guo
@ 2019-12-16 11:01       ` Russell King - ARM Linux admin
  -1 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 11:01 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Jon Nettleton, Rabeeh Khoury, Rob Herring, Mark Rutland, Li Yang,
	devicetree, linux-arm-kernel

On Wed, Dec 11, 2019 at 03:40:07PM +0800, Shawn Guo wrote:
> On Mon, Dec 09, 2019 at 12:00:42PM +0000, Russell King wrote:
> > From: Rabeeh Khoury <rabeeh@solid-run.com>
> > 
> > The device tree enables the following features -
> > 1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
> > 2. 2x MDIO busses
> > 3. 2x USB 3.0 controllers
> > 4. 4x SATA ports
> > 5. MT35X 512Mb SPI flash
> > 6. Temperature sensor on i2c0 channel 3
> > 7. AMC6821 temperature and PWM fan controller (not fitted)
> > 
> > The module supports AMC6821 PWM controller which is not currently
> > assembled on currently available Com Express 7 hardware.
> > 
> > This commit adds support for the Clearfog CX and Honeycomb variants,
> > which are indentical in this patch, but once QSFP support is finished,
> > only the Clearfog CX will have a QSFP description.
> > 
> > Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> > [Add Makefile patch, split into clearfog-cx and honeycomb variants,
> > reworded commit -- rmk]
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> >  arch/arm64/boot/dts/freescale/Makefile        |   2 +
> >  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
> >  .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
> >  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
> >  .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
> >  5 files changed, 212 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 93fce8f0c66d..b4d696e64625 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
> > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> >  
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > new file mode 100644
> > index 000000000000..4761737e62e2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > @@ -0,0 +1,123 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A-CEx7
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a.dtsi"
> > +
> > +/ {
> > +	model = "SolidRun LX2160A COM Express Type 7 module";
> > +	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";
> 
> Any new compatible needs to be documented.

Grepping for "lx2160a-qds" and "lx2160a-rdb" in that tree shows no
matches.  Maybe all lx2160a boards should be documented together
when a place for such documentation is decided upon.  (In other
words, no, I'm not going to do as you requested until the existing
boards are given the same treatment you're requesting - otherwise
it's unfair.)

> > +
> > +	aliases {
> > +		crypto = &crypto;
> > +	};
> > +
> > +	sb_3v3: regulator-sb3v3 {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "RT7290";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> > +};
> > +
> > +&crypto {
> > +	status = "okay";
> > +};
> > +
> > +&esdhc1 {
> > +	mmc-hs200-1_8v;
> > +	mmc-hs400-1_8v;
> > +	bus-width = <8>;
> > +	status = "okay";
> > +};
> > +
> > +&i2c0 {
> > +	status = "okay";
> > +
> > +	i2c-switch@77 {
> > +		compatible = "nxp,pca9547";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		reg = <0x77>;
> > +
> > +		i2c@1 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <1>;
> 
> As an idiomatic practice, we have a newline between properties and child
> node ...
> 
> > +			fan-temperature-ctrlr@18 {
> > +				compatible = "ti,amc6821";
> > +				reg = <0x18>;
> > +				cooling-min-state = <0>;
> > +				cooling-max-state = <9>;
> > +				#cooling-cells = <2>;
> > +			};
> > +		};
> 
> ... and in between nodes.
> 
> > +		i2c@3 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <3>;
> > +
> > +			temperature-sensor@48 {
> > +				compatible = "nxp,sa56004";
> > +				reg = <0x48>;
> > +				vcc-supply = <&sb_3v3>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&i2c2 {
> > +	status = "okay";
> > +};
> > +
> > +&i2c4 {
> > +	status = "okay";
> > +
> > +	rtc@51 {
> > +		compatible = "nxp,pcf2129";
> > +		reg = <0x51>;
> > +		// IRQ10_B
> > +		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
> > +	};
> > +};
> > +
> > +&fspi {
> > +	status = "okay";
> 
> Ditto
> 
> > +	flash@0 {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		compatible = "micron,m25p80";
> > +		m25p,fast-read;
> > +		spi-max-frequency = <50000000>;
> > +		reg = <0>;
> > +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> > +		spi-rx-bus-width = <8>;
> > +		spi-tx-bus-width = <1>;
> > +	};
> > +};
> > +
> > +&usb0 {
> > +	status = "okay";
> > +};
> > +
> > +&usb1 {
> > +	status = "okay";
> > +};
> > +
> > +&emdio1 {
> > +	status = "okay";
> 
> Ditto
> 
> > +	rgmii_phy1: ethernet-phy@1 {
> > +		reg = <1>;
> > +	};
> > +};
> > +
> > +&dpmac17 {
> 
> Instead of putting labeled nodes arbitrarily, we want to keep them
> sorted alphabetically.
> 
> Shawn
> 
> > +	phy-handle = <&rgmii_phy1>;
> > +	phy-connection-type = "rgmii-id";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> > new file mode 100644
> > index 000000000000..86a9b771428d
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A Clearfog CX board
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a-clearfog-itx.dtsi"
> > +
> > +/ {
> > +	model = "SolidRun LX2160A Clearfog CX";
> > +	compatible = "solidrun,clearfog-cx",
> > +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> > new file mode 100644
> > index 000000000000..10541f1345bf
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A Clearfog ITX board; this contains the
> > +// common parts shared between the Clearfog CX and Honeycomb builds.
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a-cex7.dtsi"
> > +
> > +/ {
> > +	aliases {
> > +		serial0 = &uart0;
> > +		serial1 = &uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> > +};
> > +
> > +&esdhc0 {
> > +	sd-uhs-sdr104;
> > +	sd-uhs-sdr50;
> > +	sd-uhs-sdr25;
> > +	sd-uhs-sdr12;
> > +	status = "okay";
> > +};
> > +
> > +&uart0 {
> > +	status = "okay";
> > +};
> > +
> > +&uart1 {
> > +	status = "okay";
> > +};
> > +
> > +&emdio2 {
> > +	status = "okay";
> > +};
> > +
> > +&sata0 {
> > +	status = "okay";
> > +};
> > +
> > +&sata1 {
> > +	status = "okay";
> > +};
> > +
> > +&sata2 {
> > +	status = "okay";
> > +};
> > +
> > +&sata3 {
> > +	status = "okay";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> > new file mode 100644
> > index 000000000000..fe19f3009ea5
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A Honeycomb board
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a-clearfog-itx.dtsi"
> > +
> > +/ {
> > +	model = "SolidRun LX2160A Honeycomb";
> > +	compatible = "solidrun,honeycomb",
> > +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> > +};
> > -- 
> > 2.20.1
> > 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
@ 2019-12-16 11:01       ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 11:01 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Wed, Dec 11, 2019 at 03:40:07PM +0800, Shawn Guo wrote:
> On Mon, Dec 09, 2019 at 12:00:42PM +0000, Russell King wrote:
> > From: Rabeeh Khoury <rabeeh@solid-run.com>
> > 
> > The device tree enables the following features -
> > 1. dpmac17 RGMII MAC connected to Atheros AR8035 phy
> > 2. 2x MDIO busses
> > 3. 2x USB 3.0 controllers
> > 4. 4x SATA ports
> > 5. MT35X 512Mb SPI flash
> > 6. Temperature sensor on i2c0 channel 3
> > 7. AMC6821 temperature and PWM fan controller (not fitted)
> > 
> > The module supports AMC6821 PWM controller which is not currently
> > assembled on currently available Com Express 7 hardware.
> > 
> > This commit adds support for the Clearfog CX and Honeycomb variants,
> > which are indentical in this patch, but once QSFP support is finished,
> > only the Clearfog CX will have a QSFP description.
> > 
> > Signed-off-by: Rabeeh Khoury <rabeeh@solid-run.com>
> > [Add Makefile patch, split into clearfog-cx and honeycomb variants,
> > reworded commit -- rmk]
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> >  arch/arm64/boot/dts/freescale/Makefile        |   2 +
> >  .../boot/dts/freescale/fsl-lx2160a-cex7.dtsi  | 123 ++++++++++++++++++
> >  .../dts/freescale/fsl-lx2160a-clearfog-cx.dts |  15 +++
> >  .../freescale/fsl-lx2160a-clearfog-itx.dtsi   |  57 ++++++++
> >  .../dts/freescale/fsl-lx2160a-honeycomb.dts   |  15 +++
> >  5 files changed, 212 insertions(+)
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> >  create mode 100644 arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot/dts/freescale/Makefile
> > index 93fce8f0c66d..b4d696e64625 100644
> > --- a/arch/arm64/boot/dts/freescale/Makefile
> > +++ b/arch/arm64/boot/dts/freescale/Makefile
> > @@ -18,6 +18,8 @@ dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-rdb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2080a-simu.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-qds.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-ls2088a-rdb.dtb
> > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-clearfog-cx.dtb
> > +dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-honeycomb.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-qds.dtb
> >  dtb-$(CONFIG_ARCH_LAYERSCAPE) += fsl-lx2160a-rdb.dtb
> >  
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > new file mode 100644
> > index 000000000000..4761737e62e2
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > @@ -0,0 +1,123 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A-CEx7
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a.dtsi"
> > +
> > +/ {
> > +	model = "SolidRun LX2160A COM Express Type 7 module";
> > +	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";
> 
> Any new compatible needs to be documented.

Grepping for "lx2160a-qds" and "lx2160a-rdb" in that tree shows no
matches.  Maybe all lx2160a boards should be documented together
when a place for such documentation is decided upon.  (In other
words, no, I'm not going to do as you requested until the existing
boards are given the same treatment you're requesting - otherwise
it's unfair.)

> > +
> > +	aliases {
> > +		crypto = &crypto;
> > +	};
> > +
> > +	sb_3v3: regulator-sb3v3 {
> > +		compatible = "regulator-fixed";
> > +		regulator-name = "RT7290";
> > +		regulator-min-microvolt = <3300000>;
> > +		regulator-max-microvolt = <3300000>;
> > +		regulator-boot-on;
> > +		regulator-always-on;
> > +	};
> > +};
> > +
> > +&crypto {
> > +	status = "okay";
> > +};
> > +
> > +&esdhc1 {
> > +	mmc-hs200-1_8v;
> > +	mmc-hs400-1_8v;
> > +	bus-width = <8>;
> > +	status = "okay";
> > +};
> > +
> > +&i2c0 {
> > +	status = "okay";
> > +
> > +	i2c-switch@77 {
> > +		compatible = "nxp,pca9547";
> > +		#address-cells = <1>;
> > +		#size-cells = <0>;
> > +		reg = <0x77>;
> > +
> > +		i2c@1 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <1>;
> 
> As an idiomatic practice, we have a newline between properties and child
> node ...
> 
> > +			fan-temperature-ctrlr@18 {
> > +				compatible = "ti,amc6821";
> > +				reg = <0x18>;
> > +				cooling-min-state = <0>;
> > +				cooling-max-state = <9>;
> > +				#cooling-cells = <2>;
> > +			};
> > +		};
> 
> ... and in between nodes.
> 
> > +		i2c@3 {
> > +			#address-cells = <1>;
> > +			#size-cells = <0>;
> > +			reg = <3>;
> > +
> > +			temperature-sensor@48 {
> > +				compatible = "nxp,sa56004";
> > +				reg = <0x48>;
> > +				vcc-supply = <&sb_3v3>;
> > +			};
> > +		};
> > +	};
> > +};
> > +
> > +&i2c2 {
> > +	status = "okay";
> > +};
> > +
> > +&i2c4 {
> > +	status = "okay";
> > +
> > +	rtc@51 {
> > +		compatible = "nxp,pcf2129";
> > +		reg = <0x51>;
> > +		// IRQ10_B
> > +		interrupts = <GIC_SPI 150 IRQ_TYPE_LEVEL_HIGH>;
> > +	};
> > +};
> > +
> > +&fspi {
> > +	status = "okay";
> 
> Ditto
> 
> > +	flash@0 {
> > +		#address-cells = <1>;
> > +		#size-cells = <1>;
> > +		compatible = "micron,m25p80";
> > +		m25p,fast-read;
> > +		spi-max-frequency = <50000000>;
> > +		reg = <0>;
> > +		/* The following setting enables 1-1-8 (CMD-ADDR-DATA) mode */
> > +		spi-rx-bus-width = <8>;
> > +		spi-tx-bus-width = <1>;
> > +	};
> > +};
> > +
> > +&usb0 {
> > +	status = "okay";
> > +};
> > +
> > +&usb1 {
> > +	status = "okay";
> > +};
> > +
> > +&emdio1 {
> > +	status = "okay";
> 
> Ditto
> 
> > +	rgmii_phy1: ethernet-phy@1 {
> > +		reg = <1>;
> > +	};
> > +};
> > +
> > +&dpmac17 {
> 
> Instead of putting labeled nodes arbitrarily, we want to keep them
> sorted alphabetically.
> 
> Shawn
> 
> > +	phy-handle = <&rgmii_phy1>;
> > +	phy-connection-type = "rgmii-id";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> > new file mode 100644
> > index 000000000000..86a9b771428d
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-cx.dts
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A Clearfog CX board
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a-clearfog-itx.dtsi"
> > +
> > +/ {
> > +	model = "SolidRun LX2160A Clearfog CX";
> > +	compatible = "solidrun,clearfog-cx",
> > +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> > new file mode 100644
> > index 000000000000..10541f1345bf
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-clearfog-itx.dtsi
> > @@ -0,0 +1,57 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A Clearfog ITX board; this contains the
> > +// common parts shared between the Clearfog CX and Honeycomb builds.
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a-cex7.dtsi"
> > +
> > +/ {
> > +	aliases {
> > +		serial0 = &uart0;
> > +		serial1 = &uart1;
> > +	};
> > +
> > +	chosen {
> > +		stdout-path = "serial0:115200n8";
> > +	};
> > +};
> > +
> > +&esdhc0 {
> > +	sd-uhs-sdr104;
> > +	sd-uhs-sdr50;
> > +	sd-uhs-sdr25;
> > +	sd-uhs-sdr12;
> > +	status = "okay";
> > +};
> > +
> > +&uart0 {
> > +	status = "okay";
> > +};
> > +
> > +&uart1 {
> > +	status = "okay";
> > +};
> > +
> > +&emdio2 {
> > +	status = "okay";
> > +};
> > +
> > +&sata0 {
> > +	status = "okay";
> > +};
> > +
> > +&sata1 {
> > +	status = "okay";
> > +};
> > +
> > +&sata2 {
> > +	status = "okay";
> > +};
> > +
> > +&sata3 {
> > +	status = "okay";
> > +};
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> > new file mode 100644
> > index 000000000000..fe19f3009ea5
> > --- /dev/null
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-honeycomb.dts
> > @@ -0,0 +1,15 @@
> > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > +//
> > +// Device Tree file for LX2160A Honeycomb board
> > +//
> > +// Copyright 2019 SolidRun Ltd.
> > +
> > +/dts-v1/;
> > +
> > +#include "fsl-lx2160a-clearfog-itx.dtsi"
> > +
> > +/ {
> > +	model = "SolidRun LX2160A Honeycomb";
> > +	compatible = "solidrun,honeycomb",
> > +		"solidrun,lx2160a-cex7", "fsl,lx2160a";
> > +};
> > -- 
> > 2.20.1
> > 
> 

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
  2019-12-11  7:33     ` Shawn Guo
@ 2019-12-16 11:02       ` Russell King - ARM Linux admin
  -1 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 11:02 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Jon Nettleton, Rabeeh Khoury, Li Yang, Rob Herring, Mark Rutland,
	linux-arm-kernel, devicetree

On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > the SolidRun Clearfog CX platform.
> > 
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > index 0bd98f179bfa..617e1f1a2339 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -863,6 +863,26 @@
> >  			fsl,extts-fifo;
> >  		};
> >  
> > +		emdio1: mdio@8b96000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +			#address-cells = <0x01>;
> > +			#size-cells = <0x00>;
> > +			status = "disabled";
> > +		};
> > +
> > +		emdio2: mdio@8b97000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +			#address-cells = <0x01>;
> > +			#size-cells = <0x00>;
> > +			status = "disabled";
> > +		};
> > +
> 
> Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> emdio2 was missing from there.
> 
> Shawn
> 
> [1] https://lkml.org/lkml/2019/12/4/675

Okay, I'll wait until after the next merge window before resubmitting.
Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
@ 2019-12-16 11:02       ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 11:02 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > the SolidRun Clearfog CX platform.
> > 
> > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > ---
> >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > index 0bd98f179bfa..617e1f1a2339 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > @@ -863,6 +863,26 @@
> >  			fsl,extts-fifo;
> >  		};
> >  
> > +		emdio1: mdio@8b96000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +			#address-cells = <0x01>;
> > +			#size-cells = <0x00>;
> > +			status = "disabled";
> > +		};
> > +
> > +		emdio2: mdio@8b97000 {
> > +			compatible = "fsl,fman-memac-mdio";
> > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > +			little-endian;
> > +			#address-cells = <0x01>;
> > +			#size-cells = <0x00>;
> > +			status = "disabled";
> > +		};
> > +
> 
> Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> emdio2 was missing from there.
> 
> Shawn
> 
> [1] https://lkml.org/lkml/2019/12/4/675

Okay, I'll wait until after the next merge window before resubmitting.
Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
  2019-12-16 11:02       ` Russell King - ARM Linux admin
@ 2019-12-16 11:34         ` Russell King - ARM Linux admin
  -1 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 11:34 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Mon, Dec 16, 2019 at 11:02:53AM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> > On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > > the SolidRun Clearfog CX platform.
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > ---
> > >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > index 0bd98f179bfa..617e1f1a2339 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > @@ -863,6 +863,26 @@
> > >  			fsl,extts-fifo;
> > >  		};
> > >  
> > > +		emdio1: mdio@8b96000 {
> > > +			compatible = "fsl,fman-memac-mdio";
> > > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > > +			little-endian;
> > > +			#address-cells = <0x01>;
> > > +			#size-cells = <0x00>;
> > > +			status = "disabled";
> > > +		};
> > > +
> > > +		emdio2: mdio@8b97000 {
> > > +			compatible = "fsl,fman-memac-mdio";
> > > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > > +			little-endian;
> > > +			#address-cells = <0x01>;
> > > +			#size-cells = <0x00>;
> > > +			status = "disabled";
> > > +		};
> > > +
> > 
> > Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> > emdio2 was missing from there.
> > 
> > Shawn
> > 
> > [1] https://lkml.org/lkml/2019/12/4/675
> 
> Okay, I'll wait until after the next merge window before resubmitting.
> Thanks.

Just to be clear: the reasons are:
1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have
   been.
2) I can't download the patch off lkml.org to sanely rebase on top of it
3) I'm not hunting around to try and find it on another archive site
4) I'm not digging about in random git trees trying to find it.

This makes it unnecessarily difficult to progress these patches.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
@ 2019-12-16 11:34         ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 11:34 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Rabeeh Khoury,
	Rob Herring, Li Yang, linux-arm-kernel

On Mon, Dec 16, 2019 at 11:02:53AM +0000, Russell King - ARM Linux admin wrote:
> On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> > On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > > the SolidRun Clearfog CX platform.
> > > 
> > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > ---
> > >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> > >  1 file changed, 20 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > index 0bd98f179bfa..617e1f1a2339 100644
> > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > @@ -863,6 +863,26 @@
> > >  			fsl,extts-fifo;
> > >  		};
> > >  
> > > +		emdio1: mdio@8b96000 {
> > > +			compatible = "fsl,fman-memac-mdio";
> > > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > > +			little-endian;
> > > +			#address-cells = <0x01>;
> > > +			#size-cells = <0x00>;
> > > +			status = "disabled";
> > > +		};
> > > +
> > > +		emdio2: mdio@8b97000 {
> > > +			compatible = "fsl,fman-memac-mdio";
> > > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > > +			little-endian;
> > > +			#address-cells = <0x01>;
> > > +			#size-cells = <0x00>;
> > > +			status = "disabled";
> > > +		};
> > > +
> > 
> > Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> > emdio2 was missing from there.
> > 
> > Shawn
> > 
> > [1] https://lkml.org/lkml/2019/12/4/675
> 
> Okay, I'll wait until after the next merge window before resubmitting.
> Thanks.

Just to be clear: the reasons are:
1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have
   been.
2) I can't download the patch off lkml.org to sanely rebase on top of it
3) I'm not hunting around to try and find it on another archive site
4) I'm not digging about in random git trees trying to find it.

This makes it unnecessarily difficult to progress these patches.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
  2019-12-16 11:34         ` Russell King - ARM Linux admin
@ 2019-12-16 12:34           ` Russell King - ARM Linux admin
  -1 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 12:34 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Rabeeh Khoury,
	Rob Herring, Li Yang, linux-arm-kernel

On Mon, Dec 16, 2019 at 11:34:56AM +0000, Russell King - ARM Linux admin wrote:
> On Mon, Dec 16, 2019 at 11:02:53AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> > > On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > > > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > > > the SolidRun Clearfog CX platform.
> > > > 
> > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > > ---
> > > >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> > > >  1 file changed, 20 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > index 0bd98f179bfa..617e1f1a2339 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > @@ -863,6 +863,26 @@
> > > >  			fsl,extts-fifo;
> > > >  		};
> > > >  
> > > > +		emdio1: mdio@8b96000 {
> > > > +			compatible = "fsl,fman-memac-mdio";
> > > > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > > > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			little-endian;
> > > > +			#address-cells = <0x01>;
> > > > +			#size-cells = <0x00>;
> > > > +			status = "disabled";
> > > > +		};
> > > > +
> > > > +		emdio2: mdio@8b97000 {
> > > > +			compatible = "fsl,fman-memac-mdio";
> > > > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > > > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			little-endian;
> > > > +			#address-cells = <0x01>;
> > > > +			#size-cells = <0x00>;
> > > > +			status = "disabled";
> > > > +		};
> > > > +
> > > 
> > > Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> > > emdio2 was missing from there.
> > > 
> > > Shawn
> > > 
> > > [1] https://lkml.org/lkml/2019/12/4/675
> > 
> > Okay, I'll wait until after the next merge window before resubmitting.
> > Thanks.
> 
> Just to be clear: the reasons are:
> 1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have
>    been.
> 2) I can't download the patch off lkml.org to sanely rebase on top of it
> 3) I'm not hunting around to try and find it on another archive site
> 4) I'm not digging about in random git trees trying to find it.
> 
> This makes it unnecessarily difficult to progress these patches.

Okay, I finally found it at:

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a

Note that that was unnecessarily difficult - google was unable to find
it.  Ioana's patch should have been copied to linux-arm-kernel as per
MAINTAINERS, but wasn't.  Is copying the appropriate mailing lists for
a patch now optional?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
@ 2019-12-16 12:34           ` Russell King - ARM Linux admin
  0 siblings, 0 replies; 22+ messages in thread
From: Russell King - ARM Linux admin @ 2019-12-16 12:34 UTC (permalink / raw)
  To: Shawn Guo
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Mon, Dec 16, 2019 at 11:34:56AM +0000, Russell King - ARM Linux admin wrote:
> On Mon, Dec 16, 2019 at 11:02:53AM +0000, Russell King - ARM Linux admin wrote:
> > On Wed, Dec 11, 2019 at 03:33:31PM +0800, Shawn Guo wrote:
> > > On Mon, Dec 09, 2019 at 12:00:37PM +0000, Russell King wrote:
> > > > Add MDIO descriptions to the lx2160a dtsi file, so we can use them in
> > > > the SolidRun Clearfog CX platform.
> > > > 
> > > > Signed-off-by: Russell King <rmk+kernel@armlinux.org.uk>
> > > > ---
> > > >  .../arm64/boot/dts/freescale/fsl-lx2160a.dtsi | 20 +++++++++++++++++++
> > > >  1 file changed, 20 insertions(+)
> > > > 
> > > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > index 0bd98f179bfa..617e1f1a2339 100644
> > > > --- a/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a.dtsi
> > > > @@ -863,6 +863,26 @@
> > > >  			fsl,extts-fifo;
> > > >  		};
> > > >  
> > > > +		emdio1: mdio@8b96000 {
> > > > +			compatible = "fsl,fman-memac-mdio";
> > > > +			reg = <0x00 0x8b96000 0x00 0x1000>;
> > > > +			interrupts = <GIC_SPI 90 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			little-endian;
> > > > +			#address-cells = <0x01>;
> > > > +			#size-cells = <0x00>;
> > > > +			status = "disabled";
> > > > +		};
> > > > +
> > > > +		emdio2: mdio@8b97000 {
> > > > +			compatible = "fsl,fman-memac-mdio";
> > > > +			reg = <0x00 0x8b97000 0x00 0x1000>;
> > > > +			interrupts = <GIC_SPI 91 IRQ_TYPE_LEVEL_HIGH>;
> > > > +			little-endian;
> > > > +			#address-cells = <0x01>;
> > > > +			#size-cells = <0x00>;
> > > > +			status = "disabled";
> > > > +		};
> > > > +
> > > 
> > > Ioana Ciornei already had a patch [1] adding emdio1, but unfortunately,
> > > emdio2 was missing from there.
> > > 
> > > Shawn
> > > 
> > > [1] https://lkml.org/lkml/2019/12/4/675
> > 
> > Okay, I'll wait until after the next merge window before resubmitting.
> > Thanks.
> 
> Just to be clear: the reasons are:
> 1) Ioana's patch was _not_ copied to linux-arm-kernel as it should have
>    been.
> 2) I can't download the patch off lkml.org to sanely rebase on top of it
> 3) I'm not hunting around to try and find it on another archive site
> 4) I'm not digging about in random git trees trying to find it.
> 
> This makes it unnecessarily difficult to progress these patches.

Okay, I finally found it at:

https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a

Note that that was unnecessarily difficult - google was unable to find
it.  Ioana's patch should have been copied to linux-arm-kernel as per
MAINTAINERS, but wasn't.  Is copying the appropriate mailing lists for
a patch now optional?

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
  2019-12-16 12:34           ` Russell King - ARM Linux admin
@ 2019-12-23  1:41             ` Shawn Guo
  -1 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-23  1:41 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Mark Rutland, devicetree, Jon Nettleton, Rabeeh Khoury,
	Rob Herring, Li Yang, linux-arm-kernel

On Mon, Dec 16, 2019 at 12:34:42PM +0000, Russell King - ARM Linux admin wrote:
> Okay, I finally found it at:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a
> 
> Note that that was unnecessarily difficult - google was unable to find
> it.  Ioana's patch should have been copied to linux-arm-kernel as per
> MAINTAINERS, but wasn't.  Is copying the appropriate mailing lists for
> a patch now optional?

Absolutely no.  I will remind people to copy appropriate mailing lists
when sending patches.  Sorry.

Shawn

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions
@ 2019-12-23  1:41             ` Shawn Guo
  0 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-23  1:41 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Mon, Dec 16, 2019 at 12:34:42PM +0000, Russell King - ARM Linux admin wrote:
> Okay, I finally found it at:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/linux.git/patch/?id=6e1b8fae892daa7ffb48570264b8e43b3f807e9a
> 
> Note that that was unnecessarily difficult - google was unable to find
> it.  Ioana's patch should have been copied to linux-arm-kernel as per
> MAINTAINERS, but wasn't.  Is copying the appropriate mailing lists for
> a patch now optional?

Absolutely no.  I will remind people to copy appropriate mailing lists
when sending patches.  Sorry.

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
  2019-12-16 11:01       ` Russell King - ARM Linux admin
@ 2019-12-23  2:19         ` Shawn Guo
  -1 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-23  2:19 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Jon Nettleton, Rabeeh Khoury, Rob Herring, Mark Rutland, Li Yang,
	devicetree, linux-arm-kernel

On Mon, Dec 16, 2019 at 11:01:37AM +0000, Russell King - ARM Linux admin wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > > new file mode 100644
> > > index 000000000000..4761737e62e2
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > > @@ -0,0 +1,123 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > +//
> > > +// Device Tree file for LX2160A-CEx7
> > > +//
> > > +// Copyright 2019 SolidRun Ltd.
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "fsl-lx2160a.dtsi"
> > > +
> > > +/ {
> > > +	model = "SolidRun LX2160A COM Express Type 7 module";
> > > +	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";
> > 
> > Any new compatible needs to be documented.
> 
> Grepping for "lx2160a-qds" and "lx2160a-rdb" in that tree shows no
> matches.  Maybe all lx2160a boards should be documented together
> when a place for such documentation is decided upon.  (In other
> words, no, I'm not going to do as you requested until the existing
> boards are given the same treatment you're requesting - otherwise
> it's unfair.)

Okay, I will create a patch to document "lx2160a-qds" and "lx2160a-rdb".

Shawn

^ permalink raw reply	[flat|nested] 22+ messages in thread
* Re: [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms
@ 2019-12-23  2:19         ` Shawn Guo
  0 siblings, 0 replies; 22+ messages in thread
From: Shawn Guo @ 2019-12-23  2:19 UTC (permalink / raw)
  To: Russell King - ARM Linux admin
  Cc: Mark Rutland, devicetree, Jon Nettleton, Li Yang, Rob Herring,
	Rabeeh Khoury, linux-arm-kernel

On Mon, Dec 16, 2019 at 11:01:37AM +0000, Russell King - ARM Linux admin wrote:
> > > diff --git a/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > > new file mode 100644
> > > index 000000000000..4761737e62e2
> > > --- /dev/null
> > > +++ b/arch/arm64/boot/dts/freescale/fsl-lx2160a-cex7.dtsi
> > > @@ -0,0 +1,123 @@
> > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
> > > +//
> > > +// Device Tree file for LX2160A-CEx7
> > > +//
> > > +// Copyright 2019 SolidRun Ltd.
> > > +
> > > +/dts-v1/;
> > > +
> > > +#include "fsl-lx2160a.dtsi"
> > > +
> > > +/ {
> > > +	model = "SolidRun LX2160A COM Express Type 7 module";
> > > +	compatible = "solidrun,lx2160a-cex7", "fsl,lx2160a";
> > 
> > Any new compatible needs to be documented.
> 
> Grepping for "lx2160a-qds" and "lx2160a-rdb" in that tree shows no
> matches.  Maybe all lx2160a boards should be documented together
> when a place for such documentation is decided upon.  (In other
> words, no, I'm not going to do as you requested until the existing
> boards are given the same treatment you're requesting - otherwise
> it's unfair.)

Okay, I will create a patch to document "lx2160a-qds" and "lx2160a-rdb".

Shawn

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 22+ messages in thread
end of thread, other threads:[~2019-12-23  2:19 UTC | newest]

Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09 12:00 [PATCH 0/2] Add support for Solidrun CEX7 platforms Russell King - ARM Linux admin
2019-12-09 12:00 ` Russell King - ARM Linux admin
2019-12-09 12:00 ` [PATCH 1/2] arm64: dts: lx2160a: add MDIO descriptions Russell King
2019-12-09 12:00   ` Russell King
2019-12-11  7:33   ` Shawn Guo
2019-12-11  7:33     ` Shawn Guo
2019-12-16 11:02     ` Russell King - ARM Linux admin
2019-12-16 11:02       ` Russell King - ARM Linux admin
2019-12-16 11:34       ` Russell King - ARM Linux admin
2019-12-16 11:34         ` Russell King - ARM Linux admin
2019-12-16 12:34         ` Russell King - ARM Linux admin
2019-12-16 12:34           ` Russell King - ARM Linux admin
2019-12-23  1:41           ` Shawn Guo
2019-12-23  1:41             ` Shawn Guo
2019-12-09 12:00 ` [PATCH 2/2] arm64: dts: lx2160a: add dts for CEX7 platforms Russell King
2019-12-09 12:00   ` Russell King
2019-12-11  7:40   ` Shawn Guo
2019-12-11  7:40     ` Shawn Guo
2019-12-16 11:01     ` Russell King - ARM Linux admin
2019-12-16 11:01       ` Russell King - ARM Linux admin
2019-12-23  2:19       ` Shawn Guo
2019-12-23  2:19         ` Shawn Guo

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.