From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D45DFC2D0C5 for ; Wed, 11 Dec 2019 09:50:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF40A205C9 for ; Wed, 11 Dec 2019 09:50:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728578AbfLKJuA (ORCPT ); Wed, 11 Dec 2019 04:50:00 -0500 Received: from metis.ext.pengutronix.de ([85.220.165.71]:41637 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728447AbfLKJuA (ORCPT ); Wed, 11 Dec 2019 04:50:00 -0500 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ieyd1-00020i-Hb; Wed, 11 Dec 2019 10:49:55 +0100 Received: from ukl by ptx.hi.pengutronix.de with local (Exim 4.89) (envelope-from ) id 1ieyd0-0004je-Pc; Wed, 11 Dec 2019 10:49:54 +0100 Date: Wed, 11 Dec 2019 10:49:54 +0100 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= To: Bartosz Golaszewski Cc: Peng Fan , "rjui@broadcom.com" , "linus.walleij@linaro.org" , "f.fainelli@gmail.com" , "sbranden@broadcom.com" , "thierry.reding@gmail.com" , "robh@kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , dl-linux-imx , "linux-gpio@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 2/2] gpio: bcm-kona: use platform_irq_count Message-ID: <20191211094954.qk44xv3uh33rgz7z@pengutronix.de> References: <1575451330-11112-1-git-send-email-peng.fan@nxp.com> <1575451330-11112-2-git-send-email-peng.fan@nxp.com> <20191204100925.sjp6cztozlm5qm6y@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Dec 11, 2019 at 10:30:33AM +0100, Bartosz Golaszewski wrote: > śr., 4 gru 2019 o 11:09 Uwe Kleine-König > napisał(a): > > > > On Wed, Dec 04, 2019 at 09:24:39AM +0000, Peng Fan wrote: > > > From: Peng Fan > > > > > > platform_irq_count() is the more generic way (independent of > > > device trees) to determine the count of available interrupts. So > > > use this instead. > > > > > > As platform_irq_count() might return an error code (which > > > of_irq_count doesn't) some additional handling is necessary. > > > > > > Signed-off-by: Peng Fan > > > --- > > > > > > V3: > > > Use %pe > > > > Great. Note that with %pe there is a dependency on commit 57f5677e535b > > ("printf: add support for printing symbolic error names") which was > > applied during the current merge window. > > > > Why would %pe be better in this case? The function returned an int - > why convert it to a pointer? The conversion to a pointer is (currently still) needed, because there is no printk facility (yet) that consumes an int error pointer and results in the respecting code. Somewhere on my todo-list is an item to fix that, but we're not there yet and so the best option is to use %pe. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ | From mboxrd@z Thu Jan 1 00:00:00 1970 From: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Subject: Re: [PATCH v3 2/2] gpio: bcm-kona: use platform_irq_count Date: Wed, 11 Dec 2019 10:49:54 +0100 Message-ID: <20191211094954.qk44xv3uh33rgz7z@pengutronix.de> References: <1575451330-11112-1-git-send-email-peng.fan@nxp.com> <1575451330-11112-2-git-send-email-peng.fan@nxp.com> <20191204100925.sjp6cztozlm5qm6y@pengutronix.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Bartosz Golaszewski Cc: Peng Fan , "rjui@broadcom.com" , "linus.walleij@linaro.org" , "f.fainelli@gmail.com" , "sbranden@broadcom.com" , "thierry.reding@gmail.com" , "robh@kernel.org" , "bcm-kernel-feedback-list@broadcom.com" , dl-linux-imx , "linux-gpio@vger.kernel.org" , "linux-pwm@vger.kernel.org" , "linux-kernel@vger.kernel.org" List-Id: linux-pwm@vger.kernel.org On Wed, Dec 11, 2019 at 10:30:33AM +0100, Bartosz Golaszewski wrote: > śr., 4 gru 2019 o 11:09 Uwe Kleine-König > napisał(a): > > > > On Wed, Dec 04, 2019 at 09:24:39AM +0000, Peng Fan wrote: > > > From: Peng Fan > > > > > > platform_irq_count() is the more generic way (independent of > > > device trees) to determine the count of available interrupts. So > > > use this instead. > > > > > > As platform_irq_count() might return an error code (which > > > of_irq_count doesn't) some additional handling is necessary. > > > > > > Signed-off-by: Peng Fan > > > --- > > > > > > V3: > > > Use %pe > > > > Great. Note that with %pe there is a dependency on commit 57f5677e535b > > ("printf: add support for printing symbolic error names") which was > > applied during the current merge window. > > > > Why would %pe be better in this case? The function returned an int - > why convert it to a pointer? The conversion to a pointer is (currently still) needed, because there is no printk facility (yet) that consumes an int error pointer and results in the respecting code. Somewhere on my todo-list is an item to fix that, but we're not there yet and so the best option is to use %pe. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | https://www.pengutronix.de/ |