From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A7C0C00454 for ; Wed, 11 Dec 2019 13:34:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBE1C214AF for ; Wed, 11 Dec 2019 13:34:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="E5sw+O0i" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729627AbfLKNeY (ORCPT ); Wed, 11 Dec 2019 08:34:24 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:47388 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729370AbfLKNeX (ORCPT ); Wed, 11 Dec 2019 08:34:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5mrH73H8IK9PCLoNbfAeyMajTAOWJOgXGTCwDhw8YRM=; b=E5sw+O0i+JbR6CuiQPBxKMAPbL BfsuNXhPVsOpKRXRHp/0ZjPlOTgBZZ7CPjSzBQjiPPpVpSPY6DdsSJbj8Ep26qr38wXK4Aq4xi7fn PCXgH50sYMZVLD+23kGaqTjLNxI/GsB/5LybwUHMIsSDvH5YDkau6KMx6cx/3YRE+2YQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1if280-0004Ma-Du; Wed, 11 Dec 2019 14:34:08 +0100 Date: Wed, 11 Dec 2019 14:34:08 +0100 From: Andrew Lunn To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , Andrew Hendry , linux-x25@vger.kernel.org, Kevin Curtis , "R.J.Dunlop" , Zhao Qiang , syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com, syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com Subject: Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Message-ID: <20191211133408.GL16369@lunn.ch> References: <20191209151256.2497534-1-arnd@arndb.de> <20191209151256.2497534-4-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 08:10:34AM +0100, Krzysztof Hałasa wrote: > Arnd, > > Arnd Bergmann writes: > > > - Most other supported HDLC hardware that we supoprt is for the ISA or > > PCI buses. > > I would be surprised if there is anybody left with ISA sync serial > stuff, but the PCI hardware still has some users - these machines don't > need to be upgraded yearly. Most people have migrated away, though. Hi Krzysztof, Arnd I have a use case for hdlc_cisco and hdlc_raw_eth. But it uses a lot of out of tree code, the DAHDI driver framework for E1 cards, and an E1 card which is not part of DAHDI. Given how much of this is out of tree, i would understand if you eventually decide to remove this HDLC code. Andrew From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68079C43603 for ; Wed, 11 Dec 2019 13:34:24 +0000 (UTC) Received: from silver.osuosl.org (smtp3.osuosl.org [140.211.166.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 35792214AF for ; Wed, 11 Dec 2019 13:34:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="E5sw+O0i" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 35792214AF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lunn.ch Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by silver.osuosl.org (Postfix) with ESMTP id F416123039; Wed, 11 Dec 2019 13:34:23 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from silver.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id F7jJ3VLkTQqd; Wed, 11 Dec 2019 13:34:22 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by silver.osuosl.org (Postfix) with ESMTP id 2FABA23018; Wed, 11 Dec 2019 13:34:22 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 5A05D1BF32B for ; Wed, 11 Dec 2019 13:34:21 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 555DA879A6 for ; Wed, 11 Dec 2019 13:34:21 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ec21OmFEy2-y for ; Wed, 11 Dec 2019 13:34:20 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from vps0.lunn.ch (vps0.lunn.ch [185.16.172.187]) by hemlock.osuosl.org (Postfix) with ESMTPS id 5F6B987939 for ; Wed, 11 Dec 2019 13:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5mrH73H8IK9PCLoNbfAeyMajTAOWJOgXGTCwDhw8YRM=; b=E5sw+O0i+JbR6CuiQPBxKMAPbL BfsuNXhPVsOpKRXRHp/0ZjPlOTgBZZ7CPjSzBQjiPPpVpSPY6DdsSJbj8Ep26qr38wXK4Aq4xi7fn PCXgH50sYMZVLD+23kGaqTjLNxI/GsB/5LybwUHMIsSDvH5YDkau6KMx6cx/3YRE+2YQ=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1if280-0004Ma-Du; Wed, 11 Dec 2019 14:34:08 +0100 Date: Wed, 11 Dec 2019 14:34:08 +0100 From: Andrew Lunn To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Subject: Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Message-ID: <20191211133408.GL16369@lunn.ch> References: <20191209151256.2497534-1-arnd@arndb.de> <20191209151256.2497534-4-arnd@arndb.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, linux-x25@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , "R.J.Dunlop" , linux-kernel@vger.kernel.org, Kevin Curtis , Eric Biggers , syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com, netdev@vger.kernel.org, syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com, Andrew Hendry , "David S. Miller" , Zhao Qiang Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" T24gV2VkLCBEZWMgMTEsIDIwMTkgYXQgMDg6MTA6MzRBTSArMDEwMCwgS3J6eXN6dG9mIEhhxYJh c2Egd3JvdGU6Cj4gQXJuZCwKPiAKPiBBcm5kIEJlcmdtYW5uIDxhcm5kQGFybmRiLmRlPiB3cml0 ZXM6Cj4gCj4gPiAtIE1vc3Qgb3RoZXIgc3VwcG9ydGVkIEhETEMgaGFyZHdhcmUgdGhhdCB3ZSBz dXBvcHJ0IGlzIGZvciB0aGUgSVNBIG9yCj4gPiAgIFBDSSBidXNlcy4KPiAKPiBJIHdvdWxkIGJl IHN1cnByaXNlZCBpZiB0aGVyZSBpcyBhbnlib2R5IGxlZnQgd2l0aCBJU0Egc3luYyBzZXJpYWwK PiBzdHVmZiwgYnV0IHRoZSBQQ0kgaGFyZHdhcmUgc3RpbGwgaGFzIHNvbWUgdXNlcnMgLSB0aGVz ZSBtYWNoaW5lcyBkb24ndAo+IG5lZWQgdG8gYmUgdXBncmFkZWQgeWVhcmx5LiBNb3N0IHBlb3Bs ZSBoYXZlIG1pZ3JhdGVkIGF3YXksIHRob3VnaC4KCkhpIEtyenlzenRvZiwgQXJuZAoKSSBoYXZl IGEgdXNlIGNhc2UgZm9yIGhkbGNfY2lzY28gYW5kIGhkbGNfcmF3X2V0aC4gQnV0IGl0IHVzZXMg YSBsb3QKb2Ygb3V0IG9mIHRyZWUgY29kZSwgdGhlIERBSERJIGRyaXZlciBmcmFtZXdvcmsgZm9y IEUxIGNhcmRzLCBhbmQgYW4KRTEgY2FyZCB3aGljaCBpcyBub3QgcGFydCBvZiBEQUhESS4KCkdp dmVuIGhvdyBtdWNoIG9mIHRoaXMgaXMgb3V0IG9mIHRyZWUsIGkgd291bGQgdW5kZXJzdGFuZCBp ZiB5b3UKZXZlbnR1YWxseSBkZWNpZGUgdG8gcmVtb3ZlIHRoaXMgSERMQyBjb2RlLgoKCSAgIEFu ZHJldwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkZXZl bCBtYWlsaW5nIGxpc3QKZGV2ZWxAbGludXhkcml2ZXJwcm9qZWN0Lm9yZwpodHRwOi8vZHJpdmVy ZGV2LmxpbnV4ZHJpdmVycHJvamVjdC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcml2ZXJkZXYtZGV2 ZWwK From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Lunn Subject: Re: [PATCH 4/4] [RFC] staging/net: move AF_X25 into drivers/staging Date: Wed, 11 Dec 2019 14:34:08 +0100 Message-ID: <20191211133408.GL16369@lunn.ch> References: <20191209151256.2497534-1-arnd@arndb.de> <20191209151256.2497534-4-arnd@arndb.de> Mime-Version: 1.0 Content-Transfer-Encoding: quoted-printable Return-path: DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Transfer-Encoding:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=5mrH73H8IK9PCLoNbfAeyMajTAOWJOgXGTCwDhw8YRM=; b=E5sw+O0i+JbR6CuiQPBxKMAPbL BfsuNXhPVsOpKRXRHp/0ZjPlOTgBZZ7CPjSzBQjiPPpVpSPY6DdsSJbj8Ep26qr38wXK4Aq4xi7fn PCXgH50sYMZVLD+23kGaqTjLNxI/GsB/5LybwUHMIsSDvH5YDkau6KMx6cx/3YRE+2YQ=; Content-Disposition: inline In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-ID: Content-Type: text/plain; charset="windows-1252" To: Krzysztof =?utf-8?Q?Ha=C5=82asa?= Cc: Arnd Bergmann , "David S. Miller" , Greg Kroah-Hartman , devel@driverdev.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Eric Biggers , Andrew Hendry , linux-x25@vger.kernel.org, Kevin Curtis , "R.J.Dunlop" , Zhao Qiang , syzbot+429c200ffc8772bfe070@syzkaller.appspotmail.com, syzbot+eec0c87f31a7c3b66f7b@syzkaller.appspotmail.com On Wed, Dec 11, 2019 at 08:10:34AM +0100, Krzysztof Ha=C5=82asa wrote: > Arnd, >=20 > Arnd Bergmann writes: >=20 > > - Most other supported HDLC hardware that we supoprt is for the ISA or > > PCI buses. >=20 > I would be surprised if there is anybody left with ISA sync serial > stuff, but the PCI hardware still has some users - these machines don't > need to be upgraded yearly. Most people have migrated away, though. Hi Krzysztof, Arnd I have a use case for hdlc_cisco and hdlc_raw_eth. But it uses a lot of out of tree code, the DAHDI driver framework for E1 cards, and an E1 card which is not part of DAHDI. Given how much of this is out of tree, i would understand if you eventually decide to remove this HDLC code. Andrew