From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7A54C00454 for ; Wed, 11 Dec 2019 13:56:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B5B4E222C4 for ; Wed, 11 Dec 2019 13:56:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576072589; bh=dWkqILqfAhjEvyhCKPXISYgfOfSC3OtngOei9pUlZ5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=LRmUYPbBRm99X/2l74TgmhVKvBzEgZ21DVE0deM54jZtNqSY3ujwNYeTEkKVGU7pD qLkbvUVxzAS3zyG+DsfL31OhVILIbICrf/gDamMk2eqi56bC0xP8u9Z/U9WjeaSoir /NL6SgSsTmi9zUq5M0smlyRFFzaBSf0i8cNBDpVM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729708AbfLKN43 (ORCPT ); Wed, 11 Dec 2019 08:56:29 -0500 Received: from mail.kernel.org ([198.145.29.99]:46808 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729278AbfLKN42 (ORCPT ); Wed, 11 Dec 2019 08:56:28 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC557214D8; Wed, 11 Dec 2019 13:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576072588; bh=dWkqILqfAhjEvyhCKPXISYgfOfSC3OtngOei9pUlZ5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=enaEjm3qhz+GbI1C7GZdbjUVp+Li+O9XxQqiaGueU8xTWyFJi3xOAs08wqOcxr99A TjmdjHoIohXmbLhvAqKCb708/vwcxCf5WQ+UYx2BMRwMzocjhZQpyBHCi1+hTg2dJV 4lSTU4jvrB9a4wmcTqpHvJGg5DZ7YKEwkIIzpHRU= Date: Wed, 11 Dec 2019 14:56:19 +0100 From: Greg KH To: Thomas Renninger Cc: Thomas Gleixner , Felix Schnizlein , linux-kernel@vger.kernel.org, Felix Schnizlein , linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux@armlinux.org.uk, will.deacon@arm.com, x86@kernel.org Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 Message-ID: <20191211135619.GA538980@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206163656.GC86904@kroah.com> <87sglroqix.fsf@nanos.tec.linutronix.de> <4737004.4U1sY2OxSp@skinner.arch.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4737004.4U1sY2OxSp@skinner.arch.suse.de> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 11, 2019 at 11:42:35AM +0100, Thomas Renninger wrote: > If Greg (and others) are ok, I would add "page size exceeding" handling. > Hm, quick searching for an example I realize that debugfs can exceed page > size. Is it that hard to expose a sysfs file larger than page size? No, there is a simple way to do it, but I'm not going to show you how as it is NOT how to use sysfs at all :) Why are you wanting to dump this whole mess into one file and then parse it, it's no different from having 100+ different sysfs files and then doing a readdir(3) on the thing, right? greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5660C43603 for ; Wed, 11 Dec 2019 13:56:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A75712173E for ; Wed, 11 Dec 2019 13:56:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RjSb0+vY"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="enaEjm3q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A75712173E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6gGuwB7mPKDWMFaB426jMQs4JLvzSA2sa3jN2R2n5BM=; b=RjSb0+vYWn7mMw bD1P7i1blacaWHgeagTFuAGi2//9Bne1KviIX1dTn9OowJwInzgyIpXiiAqxqc1bawimOE7XIcytx Cm87mAte0SKUVjzaz6R62ziMOINRmDDS3GUCR9QQFt+55T1DnZdx2vdB2mJm6TyjULRmVqvXXipr0 TPg2V5LAeoeH3mK5rt1QPZGof77O5HI23uYmu69HmU+xZcyhhBk0RDFGpsELz6g2wu3DaZSvUcH+b uVkpEw4hWEmvnimTUJ7E36UaQ+wWU9TImKOPxpDFS/QhAuJabkUP+t16KQjDgg4UsBSxDNm2ZoDzd B2HclXc2Grc8ahfuwfPw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if2Tl-0005C4-8a; Wed, 11 Dec 2019 13:56:37 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if2Tc-00053J-Qd for linux-arm-kernel@lists.infradead.org; Wed, 11 Dec 2019 13:56:30 +0000 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AC557214D8; Wed, 11 Dec 2019 13:56:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1576072588; bh=dWkqILqfAhjEvyhCKPXISYgfOfSC3OtngOei9pUlZ5w=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=enaEjm3qhz+GbI1C7GZdbjUVp+Li+O9XxQqiaGueU8xTWyFJi3xOAs08wqOcxr99A TjmdjHoIohXmbLhvAqKCb708/vwcxCf5WQ+UYx2BMRwMzocjhZQpyBHCi1+hTg2dJV 4lSTU4jvrB9a4wmcTqpHvJGg5DZ7YKEwkIIzpHRU= Date: Wed, 11 Dec 2019 14:56:19 +0100 From: Greg KH To: Thomas Renninger Subject: Re: [PATCH 2/3] x86 cpuinfo: implement sysfs nodes for x86 Message-ID: <20191211135619.GA538980@kroah.com> References: <20191206162421.15050-1-trenn@suse.de> <20191206163656.GC86904@kroah.com> <87sglroqix.fsf@nanos.tec.linutronix.de> <4737004.4U1sY2OxSp@skinner.arch.suse.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <4737004.4U1sY2OxSp@skinner.arch.suse.de> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_055628_913119_8BFE121D X-CRM114-Status: GOOD ( 10.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arch@vger.kernel.org, Felix Schnizlein , Felix Schnizlein , x86@kernel.org, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux@armlinux.org.uk, Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 11, 2019 at 11:42:35AM +0100, Thomas Renninger wrote: > If Greg (and others) are ok, I would add "page size exceeding" handling. > Hm, quick searching for an example I realize that debugfs can exceed page > size. Is it that hard to expose a sysfs file larger than page size? No, there is a simple way to do it, but I'm not going to show you how as it is NOT how to use sysfs at all :) Why are you wanting to dump this whole mess into one file and then parse it, it's no different from having 100+ different sysfs files and then doing a readdir(3) on the thing, right? greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel